Vulnerabilities

105 via 457 paths

Dependencies

1212

Source

GitHub

Commit

b812ec14

Find, fix and prevent vulnerabilities in your code.

Severity
  • 4
  • 48
  • 48
  • 5
Status
  • 105
  • 0
  • 0

critical severity

Predictable Value Range from Previous Values

  • Vulnerable module: form-data
  • Introduced through: gcloud@0.24.1 and gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2 form-data@2.3.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 form-data@1.0.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 form-data@1.0.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 form-data@1.0.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 form-data@2.1.4

Overview

Affected versions of this package are vulnerable to Predictable Value Range from Previous Values via the boundary value, which uses Math.random(). An attacker can manipulate HTTP request boundaries by exploiting predictable values, potentially leading to HTTP parameter pollution.

Remediation

Upgrade form-data to version 2.5.4, 3.0.4, 4.0.4 or higher.

References

critical severity

Incomplete List of Disallowed Inputs

  • Vulnerable module: babel-traverse
  • Introduced through: babel-preset-es2015@6.24.1 and babelify@7.3.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-block-scoping@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-parameters@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-block-scoping@6.26.0 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-computed-properties@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-commonjs@6.26.2 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-amd@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-systemjs@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-umd@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-parameters@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-helper-function-name@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-function-name@6.24.1 babel-helper-function-name@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-helper-replace-supers@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-object-super@6.24.1 babel-helper-replace-supers@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-parameters@6.24.1 babel-helper-call-delegate@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-helper-function-name@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-function-name@6.24.1 babel-helper-function-name@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-helper-replace-supers@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-object-super@6.24.1 babel-helper-replace-supers@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-amd@6.24.1 babel-plugin-transform-es2015-modules-commonjs@6.26.2 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-umd@6.24.1 babel-plugin-transform-es2015-modules-amd@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-helpers@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-helper-define-map@6.26.0 babel-helper-function-name@6.24.1 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-register@6.26.0 babel-core@6.26.3 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-classes@6.24.1 babel-helper-define-map@6.26.0 babel-helper-function-name@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babel-preset-es2015@6.24.1 babel-plugin-transform-es2015-modules-umd@6.24.1 babel-plugin-transform-es2015-modules-amd@6.24.1 babel-plugin-transform-es2015-modules-commonjs@6.26.2 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-register@6.26.0 babel-core@6.26.3 babel-template@6.26.0 babel-traverse@6.26.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-register@6.26.0 babel-core@6.26.3 babel-helpers@6.24.1 babel-template@6.26.0 babel-traverse@6.26.0

Overview

Affected versions of this package are vulnerable to Incomplete List of Disallowed Inputs when using plugins that rely on the path.evaluate() or path.evaluateTruthy() internal Babel methods.

Note:

This is only exploitable if the attacker uses known affected plugins such as @babel/plugin-transform-runtime, @babel/preset-env when using its useBuiltIns option, and any "polyfill provider" plugin that depends on @babel/helper-define-polyfill-provider. No other plugins under the @babel/ namespace are impacted, but third-party plugins might be.

Users that only compile trusted code are not impacted.

Workaround

Users who are unable to upgrade the library can upgrade the affected plugins instead, to avoid triggering the vulnerable code path in affected @babel/traverse.

Remediation

There is no fixed version for babel-traverse.

References

critical severity

Improper Verification of Cryptographic Signature

  • Vulnerable module: elliptic
  • Introduced through: browserify@11.2.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 crypto-browserify@3.12.1 browserify-sign@4.2.3 elliptic@6.6.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 crypto-browserify@3.12.1 create-ecdh@4.0.4 elliptic@6.6.1

Overview

elliptic is a fast elliptic-curve cryptography implementation in plain javascript.

Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to an anomaly in the _truncateToN function. An attacker can cause legitimate transactions or communications to be incorrectly flagged as invalid by exploiting the signature verification process when the hash contains at least four leading 0 bytes, and the order of the elliptic curve's base point is smaller than the hash.

In some situations, a private key exposure is possible. This can happen when an attacker knows a faulty and the corresponding correct signature for the same message.

Note: Although the vector for exploitation of this vulnerability was restricted with the release of versions 6.6.0 and 6.6.1, it remains possible to generate invalid signatures in some cases in those releases as well.

PoC

var elliptic = require('elliptic'); // tested with version 6.5.7
var hash = require('hash.js');
var BN = require('bn.js');
var toArray = elliptic.utils.toArray;

var ec = new elliptic.ec('p192');
var msg = '343236343739373234';
var sig = '303502186f20676c0d04fc40ea55d5702f798355787363a91e97a7e50219009d1c8c171b2b02e7d791c204c17cea4cf556a2034288885b';
// Same public key just in different formats
var pk = '04cd35a0b18eeb8fcd87ff019780012828745f046e785deba28150de1be6cb4376523006beff30ff09b4049125ced29723';
var pkPem = '-----BEGIN PUBLIC KEY-----\nMEkwEwYHKoZIzj0CAQYIKoZIzj0DAQEDMgAEzTWgsY7rj82H/wGXgAEoKHRfBG54\nXeuigVDeG+bLQ3ZSMAa+/zD/CbQEkSXO0pcj\n-----END PUBLIC KEY-----\n';

// Create hash
var hashArray = hash.sha256().update(toArray(msg, 'hex')).digest();
// Convert array to string (just for showcase of the leading zeros)
var hashStr = Array.from(hashArray, function(byte) {
  return ('0' + (byte & 0xFF).toString(16)).slice(-2);
}).join('');
var hMsg = new BN(hashArray, 'hex');
// Hashed message contains 4 leading zeros bytes
console.log('sha256 hash(str): ' + hashStr);
// Due to using BN bitLength lib it does not calculate the bit length correctly (should be 32 since it is a sha256 hash)
console.log('Byte len of sha256 hash: ' + hMsg.byteLength());
console.log('sha256 hash(BN): ' + hMsg.toString(16));

// Due to the shift of the message to be within the order of the curve the delta computation is invalid
var pubKey = ec.keyFromPublic(toArray(pk, 'hex'));
console.log('Valid signature: ' + pubKey.verify(hashStr, sig));

// You can check that this hash should validate by consolidating openssl
const fs = require('fs');
fs.writeFile('msg.bin', new BN(msg, 16).toBuffer(), (err) => {
  if (err) throw err;
});
fs.writeFile('sig.bin', new BN(sig, 16).toBuffer(), (err) => {
  if (err) throw err;
});
fs.writeFile('cert.pem', pkPem, (err) => {
  if (err) throw err;
});

// To verify the correctness of the message signature and key one can run:
// openssl dgst -sha256 -verify cert.pem -signature sig.bin msg.bin
// Or run this python script
/*
from cryptography.hazmat.primitives import hashes
from cryptography.hazmat.primitives.asymmetric import ec


msg = '343236343739373234'
sig = '303502186f20676c0d04fc40ea55d5702f798355787363a91e97a7e50219009d1c8c171b2b02e7d791c204c17cea4cf556a2034288885b'
pk = '04cd35a0b18eeb8fcd87ff019780012828745f046e785deba28150de1be6cb4376523006beff30ff09b4049125ced29723'

p192 = ec.SECP192R1()
pk = ec.EllipticCurvePublicKey.from_encoded_point(p192, bytes.fromhex(pk))
pk.verify(bytes.fromhex(sig), bytes.fromhex(msg), ec.ECDSA(hashes.SHA256()))
*/

Remediation

There is no fixed version for elliptic.

References

critical severity

Authentication Bypass

  • Vulnerable module: hawk
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 hawk@3.1.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3

Overview

hawk is a library for the HTTP Hawk Authentication Scheme.

Affected versions of this package are vulnerable to Authentication Bypass. The incoming (client supplied) hash of the payload is trusted by the server and not verified before the signature is calculated.

A malicious actor in the middle can alter the payload and the server side will not identify the modification occurred because it simply uses the client provided value instead of verify the hash provided against the modified payload.

According to the maintainers this issue is to be considered out of scope as "payload hash validation is optional and up to developer to implement".

Remediation

There is no fixed version for hawk.

References

high severity

NULL Pointer Dereference

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to NULL Pointer Dereference in the function Sass::Functions::selector_append which could be leveraged by an attacker to cause a denial of service (application crash) or possibly have unspecified other impact. node-sass is affected by this vulnerability due to its bundled usage of libsass.

Remediation

There is no fixed version for node-sass.

References

high severity

NULL Pointer Dereference

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to NULL Pointer Dereference. An issue was discovered in LibSass through 3.5.4. A NULL pointer dereference was found in the function Sass::Inspect::operator which could be leveraged by an attacker to cause a denial of service (application crash) or possibly have unspecified other impact.

Remediation

Upgrade node-sass to version 4.11.0 or higher.

References

high severity

NULL Pointer Dereference

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to NULL Pointer Dereference via the function Sass::Expand::operator which could be leveraged by an attacker to cause a denial of service (application crash) or possibly have unspecified other impact. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.9.0 or higher.

References

high severity

Use After Free

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Use After Free via the SharedPtr class in SharedPtr.cpp (or SharedPtr.hpp) that may cause a denial of service (application crash) or possibly have unspecified other impact. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

There is no fixed version for node-sass.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: cross-spawn
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 cross-spawn@3.0.1
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to improper input sanitization. An attacker can increase the CPU usage and crash the program by crafting a very large and well crafted string.

PoC

const { argument } = require('cross-spawn/lib/util/escape');
var str = "";
for (var i = 0; i < 1000000; i++) {
  str += "\\";
}
str += "◎";

console.log("start")
argument(str)
console.log("end")

// run `npm install cross-spawn` and `node attack.js` 
// then the program will stuck forever with high CPU usage

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade cross-spawn to version 6.0.6, 7.0.5 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: whet.extend
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-svgo@4.2.1 svgo@0.6.6 whet.extend@0.9.9

Overview

whet.extend is an A sharped version of port of jQuery.extend that actually works on node.js

Affected versions of this package are vulnerable to Prototype Pollution due to improper user input sanitization when using the extend and _findValue functions.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

There is no fixed version for whet.extend.

References

high severity

Arbitrary File Write

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.

This logic was insufficient when extracting tar files that contained both a directory and a symlink with the same name as the directory, where the symlink and directory names in the archive entry used backslashes as a path separator on posix systems. The cache checking logic used both \ and / characters as path separators. However, \ is a valid filename character on posix systems.

By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location. This can lead to extracting arbitrary files into that location, thus allowing arbitrary file creation and overwrite.

Additionally, a similar confusion could arise on case-insensitive filesystems. If a tar archive contained a directory at FOO, followed by a symbolic link named foo, then on case-insensitive file systems, the creation of the symbolic link would remove the directory from the filesystem, but not from the internal directory cache, as it would not be treated as a cache hit. A subsequent file entry within the FOO directory would then be placed in the target of the symbolic link, thinking that the directory had already been created.

Remediation

Upgrade tar to version 6.1.7, 5.0.8, 4.4.16 or higher.

References

high severity

Arbitrary File Write

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.

This logic is insufficient when extracting tar files that contain two directories and a symlink with names containing unicode values that normalized to the same value. Additionally, on Windows systems, long path portions would resolve to the same file system entities as their 8.3 "short path" counterparts. A specially crafted tar archive can include directories with two forms of the path that resolve to the same file system entity, followed by a symbolic link with a name in the first form, lastly followed by a file using the second form. This leads to bypassing node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and extracting arbitrary files into that location.

Remediation

Upgrade tar to version 6.1.9, 5.0.10, 4.4.18 or higher.

References

high severity

Arbitrary File Write

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be outside of the extraction target directory is not extracted. This is, in part, accomplished by sanitizing absolute paths of entries within the archive, skipping archive entries that contain .. path portions, and resolving the sanitized paths against the extraction target directory.

This logic is insufficient on Windows systems when extracting tar files that contain a path that is not an absolute path, but specify a drive letter different from the extraction target, such as C:some\path. If the drive letter does not match the extraction target, for example D:\extraction\dir, then the result of path.resolve(extractionDirectory, entryPath) resolves against the current working directory on the C: drive, rather than the extraction target directory.

Additionally, a .. portion of the path can occur immediately after the drive letter, such as C:../foo, and is not properly sanitized by the logic that checks for .. within the normalized and split portions of the path.

Note: This only affects users of node-tar on Windows systems.

Remediation

Upgrade tar to version 6.1.9, 5.0.10, 4.4.18 or higher.

References

high severity

Command Injection

  • Vulnerable module: shell-quote
  • Introduced through: browserify@11.2.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 shell-quote@0.0.1
    Remediation: Upgrade to browserify@12.0.0.

Overview

shell-quote is a package used to quote and parse shell commands.

Affected versions of this package are vulnerable to Command Injection. The quote function does not properly escape the following special characters <, >, ;, {, } , and as a result can be used by an attacker to inject malicious shell commands or leak sensitive information.

Proof of Concept

Consider the following poc.js application

var quote = require('shell-quote').quote;
var exec = require('child_process').exec;

var userInput = process.argv[2];

var safeCommand = quote(['echo', userInput]);

exec(safeCommand, function (err, stdout, stderr) {
  console.log(stdout);
});

Running the following command will not only print the character a as expected, but will also run the another command, i.e touch malicious.sh

$ node poc.js 'a;{touch,malicious.sh}'

Remediation

Upgrade shell-quote to version 1.6.1 or higher.

References

high severity

Arbitrary File Overwrite

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient symlink protection. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.

This logic is insufficient when extracting tar files that contain both a directory and a symlink with the same name as the directory. This order of operations results in the directory being created and added to the node-tar directory cache. When a directory is present in the directory cache, subsequent calls to mkdir for that directory are skipped. However, this is also where node-tar checks for symlinks occur. By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and subsequently extracting arbitrary files into that location.

Remediation

Upgrade tar to version 3.2.3, 4.4.15, 5.0.7, 6.1.2 or higher.

References

high severity

Arbitrary File Overwrite

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient absolute path sanitization.

node-tar aims to prevent extraction of absolute file paths by turning absolute paths into relative paths when the preservePaths flag is not set to true. This is achieved by stripping the absolute path root from any absolute file paths contained in a tar file. For example, the path /home/user/.bashrc would turn into home/user/.bashrc.

This logic is insufficient when file paths contain repeated path roots such as ////home/user/.bashrc. node-tar only strips a single path root from such paths. When given an absolute file path with repeating path roots, the resulting path (e.g. ///home/user/.bashrc) still resolves to an absolute path.

Remediation

Upgrade tar to version 3.2.2, 4.4.14, 5.0.6, 6.1.1 or higher.

References

high severity

Arbitrary Code Execution

  • Vulnerable module: js-yaml
  • Introduced through: gulp-eslint@1.1.1 and gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 js-yaml@3.4.5
    Remediation: Upgrade to gulp-eslint@2.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-svgo@4.2.1 svgo@0.6.6 js-yaml@3.6.1
    Remediation: Upgrade to gulp-imagemin@3.0.0.

Overview

js-yaml is a human-friendly data serialization language.

Affected versions of this package are vulnerable to Arbitrary Code Execution. When an object with an executable toString() property used as a map key, it will execute that function. This happens only for load(), which should not be used with untrusted data anyway. safeLoad() is not affected because it can't parse functions.

Remediation

Upgrade js-yaml to version 3.13.1 or higher.

References

high severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read. An issue was discovered in LibSass through 3.5.4. An out-of-bounds read of a memory region was found in the function Sass::Prelexer::skip_over_scopes which could be leveraged by an attacker to disclose information or manipulated to read from unmapped memory causing a denial of service. node-sass is affected by this vulnerability due to its bundled usage of libsass.

Remediation

Upgrade node-sass to version 4.11.0 or higher.

References

high severity

Remote Code Execution (RCE)

  • Vulnerable module: shell-quote
  • Introduced through: browserify@11.2.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 shell-quote@0.0.1
    Remediation: Upgrade to browserify@12.0.0.

Overview

shell-quote is a package used to quote and parse shell commands.

Affected versions of this package are vulnerable to Remote Code Execution (RCE). An attacker can inject unescaped shell metacharacters through a regex designed to support Windows drive letters. If the output of this package is passed to a real shell as a quoted argument to a command with exec(), an attacker can inject arbitrary commands. This is because the Windows drive letter regex character class is {A-z] instead of the correct {A-Za-z]. Several shell metacharacters exist in the space between capital letter Z and lower case letter a, such as the backtick character.

Remediation

Upgrade shell-quote to version 1.7.3 or higher.

References

high severity

Uninitialized Memory Exposure

  • Vulnerable module: bl
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 bl@1.1.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 bl@1.1.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 bl@1.1.2
    Remediation: Upgrade to gcloud@0.36.0.

Overview

bl is a library that allows you to collect buffers and access with a standard readable buffer interface.

Affected versions of this package are vulnerable to Uninitialized Memory Exposure. If user input ends up in consume() argument and can become negative, BufferList state can be corrupted, tricking it into exposing uninitialized memory via regular .slice() calls.

PoC by chalker

const { BufferList } = require('bl')
const secret = require('crypto').randomBytes(256)
for (let i = 0; i < 1e6; i++) {
  const clone = Buffer.from(secret)
  const bl = new BufferList()
  bl.append(Buffer.from('a'))
  bl.consume(-1024)
  const buf = bl.slice(1)
  if (buf.indexOf(clone) !== -1) {
    console.error(`Match (at ${i})`, buf)
  }
}

Remediation

Upgrade bl to version 2.2.1, 3.0.1, 4.0.3, 1.2.3 or higher.

References

high severity

Excessive Platform Resource Consumption within a Loop

  • Vulnerable module: braces
  • Introduced through: gulp@3.9.1, gulp-nodemon@2.5.0 and others

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10 braces@2.3.2
    Remediation: Upgrade to gulp@4.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10 braces@2.3.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5

Overview

braces is a Bash-like brace expansion, implemented in JavaScript.

Affected versions of this package are vulnerable to Excessive Platform Resource Consumption within a Loop due improper limitation of the number of characters it can handle, through the parse function. An attacker can cause the application to allocate excessive memory and potentially crash by sending imbalanced braces as input.

PoC

const { braces } = require('micromatch');

console.log("Executing payloads...");

const maxRepeats = 10;

for (let repeats = 1; repeats <= maxRepeats; repeats += 1) {
  const payload = '{'.repeat(repeats*90000);

  console.log(`Testing with ${repeats} repeats...`);
  const startTime = Date.now();
  braces(payload);
  const endTime = Date.now();
  const executionTime = endTime - startTime;
  console.log(`Regex executed in ${executionTime / 1000}s.\n`);
} 

Remediation

Upgrade braces to version 3.0.3 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution through the zipObjectDeep function due to improper user input sanitization in the baseZipObject function.

PoC

lodash.zipobjectdeep:

const zipObjectDeep = require("lodash.zipobjectdeep");

let emptyObject = {};


console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined

zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function

console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true

lodash:

const test = require("lodash");

let emptyObject = {};


console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined

test.zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function

console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.17 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: minimatch
  • Introduced through: browserify@11.2.0 and gulp@3.9.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to browserify@12.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 minimatch@2.0.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to gulp@4.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 minimatch@0.2.14
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 glob@3.1.21 minimatch@0.2.14

Overview

minimatch is a minimal matching utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via complicated and illegal regexes.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade minimatch to version 3.0.2 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: minimatch
  • Introduced through: browserify@11.2.0 and gulp@3.9.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to browserify@12.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 minimatch@2.0.10
    Remediation: Open PR to patch minimatch@2.0.10.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to gulp@4.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 minimatch@0.2.14
    Remediation: Open PR to patch minimatch@0.2.14.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 glob@3.1.21 minimatch@0.2.14
    Remediation: Open PR to patch minimatch@0.2.14.

Overview

minimatch is a minimal matching utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS).

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade minimatch to version 3.0.2 or higher.

References

high severity

Denial of Service (DoS)

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Denial of Service (DoS). There are memory leaks triggered by deeply nested code, such as code with a long sequence of open parenthesis characters, leading to a remote denial of service attack. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Improper Input Validation

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Improper Input Validation. There is an illegal address access in the Eval::operator function in eval.cpp. A crafted input will lead to a remote denial of service. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Improper Input Validation

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Improper Input Validation. There is an illegal address access in ast.cpp. A crafted input will lead to a remote denial of service attack. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read via lexer.hpp. A crafted input will lead to a remote denial of service attack. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read. There is an illegal address access in Sass::Eval::operator() in eval.cpp, leading to a remote denial of service attack. NOTE: this is similar to CVE-2017-11555 but remains exploitable after the vendor's CVE-2017-11555 fix (available from GitHub after 2017-07-24). Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read. A heap-based buffer over-read exists in the function json_mkstream() in sass_context.cpp. A crafted input will lead to a remote denial of service attack. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Uncontrolled Recursion

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Uncontrolled Recursion. There is a stack consumption vulnerability in the Parser::advanceToNextToken function in parser.cpp in LibSass 3.4.5. A crafted input may lead to remote denial of service. node-sass is affected by this vulnerability due to its bundled usage of libsass.

Remediation

Upgrade node-sass to version 4.8.0 or higher.

References

high severity

Uncontrolled Recursion

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Uncontrolled Recursion via the function Sass::Eval::operator() in eval.cpp. It will lead to a remote denial of service attack. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Uncontrolled Recursion

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Uncontrolled Recursion. There is a stack consumption vulnerability in the lex function in parser.hpp (as used in sassc). A crafted input will lead to a remote denial of service. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.4.0 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver
  • Introduced through: gulp@3.9.1, gulp-imagemin@2.4.0 and others

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 semver@4.3.6
    Remediation: Upgrade to gulp@4.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 semver@4.3.6
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-version-check@2.1.0 semver@4.3.6
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 semver@4.3.6
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 nodemon@2.0.22 simple-update-notifier@1.1.0 semver@7.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 semver@5.3.0
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

semver is a semantic version parser used by npm.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

PoC


const semver = require('semver')
const lengths_2 = [2000, 4000, 8000, 16000, 32000, 64000, 128000]

console.log("n[+] Valid range - Test payloads")
for (let i = 0; i =1.2.3' + ' '.repeat(lengths_2[i]) + '<1.3.0';
const start = Date.now()
semver.validRange(value)
// semver.minVersion(value)
// semver.maxSatisfying(["1.2.3"], value)
// semver.minSatisfying(["1.2.3"], value)
// new semver.Range(value, {})

const end = Date.now();
console.log('length=%d, time=%d ms', value.length, end - start);
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver to version 5.7.2, 6.3.1, 7.5.2 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver-regex
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0

Overview

semver-regex is a Regular expression for matching semver versions

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). This can occur when running the regex on untrusted user input in a server context.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver-regex to version 4.0.1, 3.1.3 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver-regex
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0

Overview

semver-regex is a Regular expression for matching semver versions

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). semverRegex function contains a regex that allows exponential backtracking.

PoC

import semverRegex from 'semver-regex';

// The following payload would take excessive CPU cycles
var payload = '0.0.0-0' + '.-------'.repeat(100000) + '@';
semverRegex().test(payload);

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver-regex to version 3.1.3 or higher.

References

high severity

Denial of Service (DoS)

  • Vulnerable module: trim-newlines
  • Introduced through: sw-precache@2.3.0, gulp-imagemin@2.4.0 and others

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e sw-precache@2.3.0 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 pretty-bytes@2.0.1 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e sw-precache@2.3.0 pretty-bytes@2.0.1 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 meow@3.7.0 trim-newlines@1.0.0
    Remediation: Upgrade to gulp-sass@5.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-bump@1.0.0 plugin-log@0.1.0 dateformat@1.0.12 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-check@2.0.0 executable@1.1.0 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-check@2.0.0 executable@1.1.0 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-check@2.0.0 executable@1.1.0 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 logalot@2.1.0 squeak@1.3.0 lpad-align@1.1.2 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 logalot@2.1.0 squeak@1.3.0 lpad-align@1.1.2 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 logalot@2.1.0 squeak@1.3.0 lpad-align@1.1.2 meow@3.7.0 trim-newlines@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 meow@3.7.0 trim-newlines@1.0.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 meow@3.7.0 trim-newlines@1.0.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 meow@3.7.0 trim-newlines@1.0.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.

Overview

trim-newlines is a Trim newlines from the start and/or end of a string

Affected versions of this package are vulnerable to Denial of Service (DoS) via the end() method.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.

Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.

One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.

When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.

Two common types of DoS vulnerabilities:

  • High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.

  • Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm ws package

Remediation

Upgrade trim-newlines to version 3.0.1, 4.0.1 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: unset-value
  • Introduced through: gulp@3.9.1 and gulp-nodemon@2.5.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0

Overview

Affected versions of this package are vulnerable to Prototype Pollution via the unset function in index.js, because it allows access to object prototype properties.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade unset-value to version 2.0.1 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: url-regex
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 url-regex@3.2.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 url-regex@3.2.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 url-regex@3.2.0

Overview

url-regex is a package with regular expression for matching URLs

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). An attacker providing a very long string in String.test can cause a Denial of Service.

PoC by Nick Baugh

For url-regex package:

 require('url-regex')({ strict: false }).test('018137.113.215.4074.138.129.172220.179.206.94180.213.144.175250.45.147.1364868726sgdm6nohQ')

For urlregex package:

require('urlregex')({ strict: false }).test('018137.113.215.4074.138.129.172220.179.206.94180.213.144.175250.45.147.1364868726sgdm6nohQ')

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

There is no fixed version for url-regex.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: hawk
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 hawk@3.1.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3
    Remediation: Upgrade to gcloud@0.36.0.

Overview

hawk is a library for the HTTP Hawk Authentication Scheme.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in header parsing where each added character in the attacker's input increases the computation time exponentially.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade hawk to version 9.0.1 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The function defaultsDeep could be tricked into adding or modifying properties of Object.prototype using a constructor payload.

PoC by Snyk

const mergeFn = require('lodash').defaultsDeep;
const payload = '{"constructor": {"prototype": {"a0": true}}}'

function check() {
    mergeFn({}, JSON.parse(payload));
    if (({})[`a0`] === true) {
        console.log(`Vulnerable to Prototype Pollution via ${payload}`);
    }
  }

check();

For more information, check out our blog post

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.12 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution via the set and setwith functions due to improper user input sanitization.

PoC

lod = require('lodash')
lod.set({}, "__proto__[test2]", "456")
console.log(Object.prototype)

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.17 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The functions merge, mergeWith, and defaultsDeep could be tricked into adding or modifying properties of Object.prototype. This is due to an incomplete fix to CVE-2018-3721.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.11 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash.merge
  • Introduced through: gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 lodash.merge@3.3.2
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash.merge is a Lodash method _.merge exported as a Node.js module.

Affected versions of this package are vulnerable to Prototype Pollution. The functions merge, mergeWith, and defaultsDeep could be tricked into adding or modifying properties of Object.prototype. This is due to an incomplete fix to CVE-2018-3721.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash.merge to version 4.6.2 or higher.

References

high severity

Improper Verification of Cryptographic Signature

  • Vulnerable module: node-forge
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6

Overview

node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.

Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSA's PKCS#1 v1.5 signature verification code which does not check for tailing garbage bytes after decoding a DigestInfo ASN.1 structure. This can allow padding bytes to be removed and garbage data added to forge a signature when a low public exponent is being used.

Remediation

Upgrade node-forge to version 1.3.0 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: node-forge
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6

Overview

node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.

Affected versions of this package are vulnerable to Prototype Pollution via the util.setPath function.

Note: version 0.10.0 is a breaking change removing the vulnerable functions.

POC:

const nodeforge = require('node-forge');
var obj = {};
nodeforge.util.setPath(obj, ['__proto__', 'polluted'], true);
console.log(polluted);

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade node-forge to version 0.10.0 or higher.

References

high severity

Code Injection

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Code Injection via template.

PoC

var _ = require('lodash');

_.template('', { variable: '){console.log(process.env)}; with(obj' })()

Remediation

Upgrade lodash to version 4.17.21 or higher.

References

high severity

Code Injection

  • Vulnerable module: lodash.template
  • Introduced through: gulp-util@3.0.8, sw-precache@2.3.0 and others

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e sw-precache@2.3.0 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-autoprefixer@3.1.1 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-minify-css@1.2.4 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-minify-html@1.0.6 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-uglify@1.5.4 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e run-sequence@1.2.2 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 gulp-util@3.0.8 lodash.template@3.6.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 gulp-util@3.0.8 lodash.template@3.6.2

Overview

lodash.template is a The Lodash method _.template exported as a Node.js module.

Affected versions of this package are vulnerable to Code Injection via template.

PoC

var _ = require('lodash');

_.template('', { variable: '){console.log(process.env)}; with(obj' })()

Remediation

There is no fixed version for lodash.template.

References

high severity

Uninitialized Memory Exposure

  • Vulnerable module: base64url
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 jws@3.0.0 base64url@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 jws@3.0.0 base64url@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 jws@3.0.0 base64url@1.0.6
    Remediation: Upgrade to gcloud@0.36.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 jws@3.0.0 jwa@1.0.2 base64url@0.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 jws@3.0.0 jwa@1.0.2 base64url@0.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 jws@3.0.0 jwa@1.0.2 base64url@0.0.6
    Remediation: Upgrade to gcloud@0.36.0.

Overview

base64url Converting to, and from, base64url.

Affected versions of this package are vulnerable to Uninitialized Memory Exposure. An attacker could extract sensitive data from uninitialized memory or may cause a Denial of Service (DoS) by passing in a large number, in setups where typed user input can be passed (e.g. from JSON).

Details

The Buffer class on Node.js is a mutable array of binary data, and can be initialized with a string, array or number.

const buf1 = new Buffer([1,2,3]);
// creates a buffer containing [01, 02, 03]
const buf2 = new Buffer('test');
// creates a buffer containing ASCII bytes [74, 65, 73, 74]
const buf3 = new Buffer(10);
// creates a buffer of length 10

The first two variants simply create a binary representation of the value it received. The last one, however, pre-allocates a buffer of the specified size, making it a useful buffer, especially when reading data from a stream. When using the number constructor of Buffer, it will allocate the memory, but will not fill it with zeros. Instead, the allocated buffer will hold whatever was in memory at the time. If the buffer is not zeroed by using buf.fill(0), it may leak sensitive information like keys, source code, and system info.

Remediation

Upgrade base64url to version 3.0.0 or higher. Note This is vulnerable only for Node <=4

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: protobufjs
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 protobufjs@4.1.3
    Remediation: Upgrade to gcloud@0.28.0.

Overview

protobufjs is a Protocol Buffers for JavaScript (& TypeScript).

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks. This can cause an impact of about 10 seconds matching time for data 45 characters long.

Disclosure Timeline

  • Feb 12th, 2018 - Initial Disclosure to package owner
  • Feb 22th, 2018 - Initial Response from package owner
  • Feb 26th, 2018 - Fix issued
  • Mar 5th, 2018 - Vulnerability published

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade protobufjs to version 5.0.3, 6.8.6 or higher.

References

high severity

Improper Privilege Management

  • Vulnerable module: shelljs
  • Introduced through: gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 shelljs@0.5.3
    Remediation: Upgrade to gulp-eslint@4.0.0.

Overview

shelljs is a wrapper for the Unix shell commands for Node.js.

Affected versions of this package are vulnerable to Improper Privilege Management. When ShellJS is used to create shell scripts which may be running as root, users with low-level privileges on the system can leak sensitive information such as passwords (depending on implementation) from the standard output of the privileged process OR shutdown privileged ShellJS processes via the exec function when triggering EACCESS errors.

Note: Thi only impacts the synchronous version of shell.exec().

Remediation

Upgrade shelljs to version 0.8.5 or higher.

References

high severity

Remote Code Execution (RCE)

  • Vulnerable module: handlebars
  • Introduced through: express-handlebars@2.0.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8
    Remediation: Upgrade to express-handlebars@3.0.0.

Overview

handlebars is an extension to the Mustache templating language.

Affected versions of this package are vulnerable to Remote Code Execution (RCE) when selecting certain compiling options to compile templates coming from an untrusted source.

POC

<script src="https://cdn.jsdelivr.net/npm/handlebars@latest/dist/handlebars.js"></script> 
<script> 
// compile the template 
var s = ` 
{{#with (__lookupGetter__ "__proto__")}} 
{{#with (./constructor.getOwnPropertyDescriptor . "valueOf")}} 
{{#with ../constructor.prototype}} 
{{../../constructor.defineProperty . "hasOwnProperty" ..}} 
{{/with}} 
{{/with}} 
{{/with}} 
{{#with "constructor"}} 
{{#with split}} 
{{pop (push "alert('Vulnerable Handlebars JS when compiling in strict mode');")}} 
{{#with .}} 
{{#with (concat (lookup join (slice 0 1)))}} 
{{#each (slice 2 3)}} 
{{#with (apply 0 ../..)}} 
{{.}} 
{{/with}} 
{{/each}} 
{{/with}} 
{{/with}} 
{{/with}} 
{{/with}} 
`;
var template = Handlebars.compile(s, { 
strict: true 
}); 
// execute the compiled template and print the output to the console console.log(template({})); 
</script>

Remediation

Upgrade handlebars to version 4.7.7 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: handlebars
  • Introduced through: express-handlebars@2.0.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8
    Remediation: Upgrade to express-handlebars@3.0.0.

Overview

handlebars is an extension to the Mustache templating language.

Affected versions of this package are vulnerable to Prototype Pollution. Prototype access to the template engine allows for potential code execution.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade handlebars to version 4.6.0 or higher.

References

medium severity

Denial of Service (DoS)

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Denial of Service (DoS). Uncontrolled recursion is possible in Sass::Complex_Selector::perform in ast.hpp and Sass::Inspect::operator in inspect.cpp. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

There is no fixed version for node-sass.

References

medium severity

Denial of Service (DoS)

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Denial of Service (DoS). Functions inside ast.cpp for IMPLEMENT_AST_OPERATORS expansion allow attackers to cause a denial-of-service resulting from stack consumption via a crafted sass file, as demonstrated by recursive calls involving clone(), cloneChildren(), and copy(). Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade node-sass to version 4.11.0 or higher.

References

medium severity

Out-of-Bounds

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-Bounds. A heap-based buffer over-read exists in Sass::Prelexer::parenthese_scope in prelexer.hpp. node-sass is affected by this vulnerability due to its bundled usage of libsass.

Remediation

There is no fixed version for node-sass.

References

medium severity

Out-of-Bounds

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-Bounds via Sass::Prelexer::alternatives in prelexer.hpp. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

There is no fixed version for node-sass.

References

medium severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read. ]There is a heap-based buffer over-read in the Sass::Prelexer::re_linebreak function in lexer.cpp in LibSass 3.4.5. A crafted input will lead to a remote denial of service attack.

Remediation

Upgrade node-sass to version 4.2.0 or higher.

References

medium severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read related to address 0xb4803ea1. A crafted input will lead to a remote denial of service attack. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade node-sass to version 4.3.0 or higher.

References

medium severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read. The function handle_error in sass_context.cpp allows attackers to cause a denial-of-service resulting from a heap-based buffer over-read via a crafted sass file. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

There is no fixed version for node-sass.

References

medium severity

Resource Exhaustion

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Resource Exhaustion. In LibSass prior to 3.5.5, Sass::Eval::operator()(Sass::Binary_Expression*) inside eval.cpp allows attackers to cause a denial-of-service resulting from stack consumption via a crafted sass file, because of certain incorrect parsing of '%' as a modulo operator in parser.cpp.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade node-sass to version 4.11.0 or higher.

References

medium severity

Server-side Request Forgery (SSRF)

  • Vulnerable module: request
  • Introduced through: gcloud@0.24.1 and gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0

Overview

request is a simplified http request client.

Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) due to insufficient checks in the lib/redirect.js file by allowing insecure redirects in the default configuration, via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).

NOTE: request package has been deprecated, so a fix is not expected. See https://github.com/request/request/issues/3142.

Remediation

A fix was pushed into the master branch but not yet published.

References

medium severity

Uncontrolled Resource Consumption ('Resource Exhaustion')

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Uncontrolled Resource Consumption ('Resource Exhaustion') due to the lack of folders count validation during the folder creation process. An attacker who generates a large number of sub-folders can consume memory on the system running the software and even crash the client within few seconds of running it using a path with too many sub-folders inside.

Remediation

Upgrade tar to version 6.2.1 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: tough-cookie
  • Introduced through: gcloud@0.24.1 and gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 tough-cookie@2.3.4
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 tough-cookie@2.3.4
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 tough-cookie@2.3.4
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 tough-cookie@2.3.4

Overview

tough-cookie is a RFC6265 Cookies and CookieJar module for Node.js.

Affected versions of this package are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. Due to an issue with the manner in which the objects are initialized, an attacker can expose or modify a limited amount of property information on those objects. There is no impact to availability.

PoC

// PoC.js
async function main(){
var tough = require("tough-cookie");
var cookiejar = new tough.CookieJar(undefined,{rejectPublicSuffixes:false});
// Exploit cookie
await cookiejar.setCookie(
  "Slonser=polluted; Domain=__proto__; Path=/notauth",
  "https://__proto__/admin"
);
// normal cookie
var cookie = await cookiejar.setCookie(
  "Auth=Lol; Domain=google.com; Path=/notauth",
  "https://google.com/"
);

//Exploit cookie
var a = {};
console.log(a["/notauth"]["Slonser"])
}
main();

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade tough-cookie to version 4.1.3 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: json5
  • Introduced through: babelify@7.3.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 json5@0.5.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e babelify@7.3.0 babel-core@6.26.3 babel-register@6.26.0 babel-core@6.26.3 json5@0.5.1

Overview

Affected versions of this package are vulnerable to Prototype Pollution via the parse method , which does not restrict parsing of keys named __proto__, allowing specially crafted strings to pollute the prototype of the resulting object. This pollutes the prototype of the object returned by JSON5.parse and not the global Object prototype (which is the commonly understood definition of Prototype Pollution). Therefore, the actual impact will depend on how applications utilize the returned object and how they filter unwanted keys.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade json5 to version 1.0.2, 2.2.2 or higher.

References

medium severity

Arbitrary File Write via Archive Extraction (Zip Slip)

  • Vulnerable module: decompress
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0

Overview

decompress is a package that can be used for extracting archives.

Affected versions of this package are vulnerable to Arbitrary File Write via Archive Extraction (Zip Slip). It is possible to bypass the security measures provided by decompress and conduct ZIP path traversal through symlinks.

PoC

const decompress = require('decompress');

decompress('slip.tar.gz', 'dist').then(files => {
    console.log('done!');
});

Details

It is exploited using a specially crafted zip archive, that holds path traversal filenames. When exploited, a filename in a malicious archive is concatenated to the target extraction directory, which results in the final path ending up outside of the target folder. For instance, a zip may hold a file with a "../../file.exe" location and thus break out of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicous file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:


+2018-04-15 22:04:29 ..... 19 19 good.txt

+2018-04-15 22:04:42 ..... 20 20 ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade decompress to version 4.2.1 or higher.

References

medium severity

Arbitrary File Write via Archive Extraction (Zip Slip)

  • Vulnerable module: decompress-tar
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 decompress-tar@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 decompress-tar@3.1.0

Overview

decompress-tar is a tar plugin for decompress.

Affected versions of this package are vulnerable to Arbitrary File Write via Archive Extraction (Zip Slip). It is possible to bypass the security measures provided by decompress and conduct ZIP path traversal through symlinks.

PoC

const decompress = require('decompress');

decompress('slip.tar.gz', 'dist').then(files => {
    console.log('done!');
});

Details

It is exploited using a specially crafted zip archive, that holds path traversal filenames. When exploited, a filename in a malicious archive is concatenated to the target extraction directory, which results in the final path ending up outside of the target folder. For instance, a zip may hold a file with a "../../file.exe" location and thus break out of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicous file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:


+2018-04-15 22:04:29 ..... 19 19 good.txt

+2018-04-15 22:04:42 ..... 20 20 ../../../../../../root/.ssh/authorized_keys

Remediation

There is no fixed version for decompress-tar.

References

medium severity

Prototype Pollution

  • Vulnerable module: dot-object
  • Introduced through: gulp-bump@1.0.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-bump@1.0.0 dot-object@1.9.0
    Remediation: Upgrade to gulp-bump@2.0.0.

Overview

dot-object is a module that makes it possible to transform javascript objects using dot notation.

Affected versions of this package are vulnerable to Prototype Pollution. The set function could be tricked into adding or modifying properties of Object.prototype using a __proto__ payload.

PoC by JHU System Security Lab

var a = require("dot-object")
var path = "__proto__";
var val = {toString:"JHU"}
a.set(path,val,{},true);
console.log({}.toString);

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade dot-object to version 2.1.3 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: hoek
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Upgrade to gcloud@0.36.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to gcloud@0.36.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Upgrade to gcloud@0.36.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Open PR to patch hoek@2.16.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to gcloud@0.36.0.

Overview

hoek is an Utility methods for the hapi ecosystem.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var Hoek = require('hoek');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
Hoek.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade hoek to version 4.2.1, 5.0.3 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var _= require('lodash');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
_.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.5 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: lodash.merge
  • Introduced through: gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 lodash.merge@3.3.2
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash.merge is a Lodash method _.merge exported as a Node.js module.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var _= require('lodash');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
_.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash.merge to version 4.6.2 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: node-forge
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6

Overview

node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.

Affected versions of this package are vulnerable to Prototype Pollution via the forge.debug API if called with untrusted input.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade node-forge to version 1.0.0 or higher.

References

medium severity

Missing Release of Resource after Effective Lifetime

  • Vulnerable module: inflight
  • Introduced through: glob@5.0.15, browserify@11.2.0 and others

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 glob@4.5.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e sw-precache@2.3.0 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e del@2.2.2 globby@5.0.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e del@2.2.2 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-bump@1.0.0 dot-object@1.9.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 protobufjs@4.1.3 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 glob@4.5.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 sass-graph@2.2.6 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 vinyl-fs@3.0.3 glob-stream@6.1.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 gaze@1.1.3 globule@1.3.4 glob@7.1.7 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 exec-buffer@2.0.1 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 file-entry-cache@1.3.1 flat-cache@1.3.4 rimraf@2.6.3 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob@5.0.15 inflight@1.0.6

Overview

Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.

Exploiting this vulnerability results in crashing the node process or in the application crash.

Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.

To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.

PoC

const inflight = require('inflight');

function testInflight() {
  let i = 0;
  function scheduleNext() {
    let key = `key-${i++}`;
    const callback = () => {
    };
    for (let j = 0; j < 1000000; j++) {
      inflight(key, callback);
    }

    setImmediate(scheduleNext);
  }


  if (i % 100 === 0) {
    console.log(process.memoryUsage());
  }

  scheduleNext();
}

testInflight();

Remediation

There is no fixed version for inflight.

References

medium severity

Denial of Service (DoS)

  • Vulnerable module: js-yaml
  • Introduced through: gulp-eslint@1.1.1 and gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 js-yaml@3.4.5
    Remediation: Upgrade to gulp-eslint@2.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-svgo@4.2.1 svgo@0.6.6 js-yaml@3.6.1
    Remediation: Upgrade to gulp-imagemin@3.0.0.

Overview

js-yaml is a human-friendly data serialization language.

Affected versions of this package are vulnerable to Denial of Service (DoS). The parsing of a specially crafted YAML file may exhaust the system resources.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade js-yaml to version 3.13.0 or higher.

References

medium severity

Denial of Service (DoS)

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@3.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Denial of Service (DoS). Crafted objects passed to the renderSync function may trigger C++ assertions in CustomImporterBridge::get_importer_entry and CustomImporterBridge::post_process_return_value that crash the Node process. This may allow attackers to crash the system's running Node process and lead to Denial of Service.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade node-sass to version 4.13.1 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: handlebars
  • Introduced through: express-handlebars@2.0.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8
    Remediation: Upgrade to express-handlebars@3.0.0.

Overview

handlebars is an extension to the Mustache templating language.

Affected versions of this package are vulnerable to Prototype Pollution when selecting certain compiling options to compile templates coming from an untrusted source.

POC

<script src="https://cdn.jsdelivr.net/npm/handlebars@latest/dist/handlebars.js"></script> 
<script> 
// compile the template 

var s2 = `{{'a/.") || alert("Vulnerable Handlebars JS when compiling in compat mode'}}`; 
var template = Handlebars.compile(s2, { 
compat: true 
}); 
// execute the compiled template and print the output to the console console.log(template({})); 
</script>

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade handlebars to version 4.7.7 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: minimist
  • Introduced through: express-handlebars@2.0.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8 optimist@0.6.1 minimist@0.0.10

Overview

minimist is a parse argument options module.

Affected versions of this package are vulnerable to Prototype Pollution. The library could be tricked into adding or modifying properties of Object.prototype using a constructor or __proto__ payload.

PoC by Snyk

require('minimist')('--__proto__.injected0 value0'.split(' '));
console.log(({}).injected0 === 'value0'); // true

require('minimist')('--constructor.prototype.injected1 value1'.split(' '));
console.log(({}).injected1 === 'value1'); // true

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade minimist to version 0.2.1, 1.2.3 or higher.

References

medium severity

Improper Verification of Cryptographic Signature

  • Vulnerable module: node-forge
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6

Overview

node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.

Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSA's PKCS#1 v1.5 signature verification code which does not properly check DigestInfo for a proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.

Remediation

Upgrade node-forge to version 1.3.0 or higher.

References

medium severity

Improper Verification of Cryptographic Signature

  • Vulnerable module: node-forge
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6

Overview

node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.

Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSAs PKCS#1` v1.5 signature verification code which is lenient in checking the digest algorithm structure. This can allow a crafted structure that steals padding bytes and uses unchecked portion of the PKCS#1 encoded message to forge a signature when a low public exponent is being used.

Remediation

Upgrade node-forge to version 1.3.0 or higher.

References

medium severity

Open Redirect

  • Vulnerable module: got
  • Introduced through: gcloud@0.24.1 and gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 got@4.2.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 got@5.7.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 got@5.7.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 got@5.7.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 got@5.7.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 got@5.7.1
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 got@5.7.1

Overview

Affected versions of this package are vulnerable to Open Redirect due to missing verification of requested URLs. It allowed a victim to be redirected to a UNIX socket.

Remediation

Upgrade got to version 11.8.5, 12.1.0 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: browserslist
  • Introduced through: gulp-autoprefixer@3.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-autoprefixer@3.1.1 autoprefixer@6.7.7 browserslist@1.7.7
    Remediation: Upgrade to gulp-autoprefixer@6.0.0.

Overview

browserslist is a Share target browsers between different front-end tools, like Autoprefixer, Stylelint and babel-env-preset

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) during parsing of queries.

PoC by Yeting Li

var browserslist = require("browserslist")
function build_attack(n) {
    var ret = "> "
    for (var i = 0; i < n; i++) {
        ret += "1"
    }
    return ret + "!";
}

// browserslist('> 1%')

//browserslist(build_attack(500000))
for(var i = 1; i <= 500000; i++) {
    if (i % 1000 == 0) {
        var time = Date.now();
        var attack_str = build_attack(i)
        try{
            browserslist(attack_str);
            var time_cost = Date.now() - time;
            console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms");
            }
        catch(e){
        var time_cost = Date.now() - time;
        console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms");
        }
    }
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade browserslist to version 4.16.5 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: color-string
  • Introduced through: gulp-minify-html@1.0.6

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-minify-html@1.0.6 minimize@1.8.1 diagnostics@1.0.1 colorspace@1.0.1 color@0.8.0 color-string@0.3.0

Overview

color-string is a Parser and generator for CSS color strings

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the hwb regular expression in the cs.get.hwb function in index.js. The affected regular expression exhibits quadratic worst-case time complexity.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade color-string to version 1.5.5 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: glob-parent
  • Introduced through: gulp-imagemin@2.4.0 and gulp-nodemon@2.5.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 vinyl-fs@3.0.3 glob-stream@6.1.0 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 glob-parent@3.1.0

Overview

glob-parent is a package that helps extracting the non-magic parent path from a glob string.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The enclosure regex used to check for strings ending in enclosure containing path separator.

PoC by Yeting Li

var globParent = require("glob-parent")
function build_attack(n) {
var ret = "{"
for (var i = 0; i < n; i++) {
ret += "/"
}

return ret;
}

globParent(build_attack(5000));

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade glob-parent to version 5.1.2 or higher.

References

medium severity

Cross-site Scripting (XSS)

  • Vulnerable module: handlebars
  • Introduced through: express-handlebars@2.0.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8
    Remediation: Upgrade to express-handlebars@3.0.0.

Overview

handlebars provides the power necessary to let you build semantic templates.

When using attributes without quotes in a handlebars template, an attacker can manipulate the input to introduce additional attributes, potentially executing code. This may lead to a Cross-site Scripting (XSS) vulnerability, assuming an attacker can influence the value entered into the template. If the handlebars template is used to render user-generated content, this vulnerability may escalate to a persistent XSS vulnerability.

Details

Cross-Site Scripting (XSS) attacks occur when an attacker tricks a user’s browser to execute malicious JavaScript code in the context of a victim’s domain. Such scripts can steal the user’s session cookies for the domain, scrape or modify its content, and perform or modify actions on the user’s behalf, actions typically blocked by the browser’s Same Origin Policy.

These attacks are possible by escaping the context of the web application and injecting malicious scripts in an otherwise trusted website. These scripts can introduce additional attributes (say, a "new" option in a dropdown list or a new link to a malicious site) and can potentially execute code on the clients side, unbeknown to the victim. This occurs when characters like < > " ' are not escaped properly.

There are a few types of XSS:

  • Persistent XSS is an attack in which the malicious code persists into the web app’s database.
  • Reflected XSS is an which the website echoes back a portion of the request. The attacker needs to trick the user into clicking a malicious link (for instance through a phishing email or malicious JS on another page), which triggers the XSS attack.
  • DOM-based XSS is an that occurs purely in the browser when client-side JavaScript echoes back a portion of the URL onto the page. DOM-Based XSS is notoriously hard to detect, as the server never gets a chance to see the attack taking place.

Example:

Assume handlebars was used to display user comments and avatar, using the following template: <img src={{avatarUrl}}><pre>{{comment}}</pre>

If an attacker spoofed their avatar URL and provided the following value: http://evil.org/avatar.png onload=alert(document.cookie)

The resulting HTML would be the following, triggering the script once the image loads: <img src=http://evil.org/avatar.png onload=alert(document.cookie)><pre>Gotcha!</pre>

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the toNumber, trim and trimEnd functions.

POC

var lo = require('lodash');

function build_blank (n) {
var ret = "1"
for (var i = 0; i < n; i++) {
ret += " "
}

return ret + "1";
}

var s = build_blank(50000)
var time0 = Date.now();
lo.trim(s)
var time_cost0 = Date.now() - time0;
console.log("time_cost0: " + time_cost0)

var time1 = Date.now();
lo.toNumber(s)
var time_cost1 = Date.now() - time1;
console.log("time_cost1: " + time_cost1)

var time2 = Date.now();
lo.trimEnd(s)
var time_cost2 = Date.now() - time2;
console.log("time_cost2: " + time_cost2)

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade lodash to version 4.17.21 or higher.

References

medium severity

Inefficient Regular Expression Complexity

  • Vulnerable module: micromatch
  • Introduced through: gulp@3.9.1, gulp-nodemon@2.5.0 and others

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 liftoff@2.5.0 findup-sync@2.0.0 micromatch@3.1.10
    Remediation: Upgrade to gulp@4.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 anymatch@2.0.0 micromatch@3.1.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 micromatch@3.1.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 matchdep@2.0.0 findup-sync@2.0.0 micromatch@3.1.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 anymatch@2.0.0 micromatch@3.1.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 glob-watcher@5.0.5 chokidar@2.1.8 readdirp@2.2.1 micromatch@3.1.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-nodemon@2.5.0 gulp@4.0.2 gulp-cli@2.3.0 liftoff@3.1.0 findup-sync@3.0.0 micromatch@3.1.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11

Overview

Affected versions of this package are vulnerable to Inefficient Regular Expression Complexity due to the use of unsafe pattern configurations that allow greedy matching through the micromatch.braces() function. An attacker can cause the application to hang or slow down by passing a malicious payload that triggers extensive backtracking in regular expression processing.

Remediation

Upgrade micromatch to version 4.0.8 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: minimatch
  • Introduced through: browserify@11.2.0 and gulp@3.9.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e browserify@11.2.0 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to browserify@12.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 minimatch@2.0.10
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-stream@3.1.18 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to gulp@4.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 minimatch@0.2.14
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 glob@3.1.21 minimatch@0.2.14

Overview

minimatch is a minimal matching utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the braceExpand function in minimatch.js.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade minimatch to version 3.0.5 or higher.

References

medium severity

Open Redirect

  • Vulnerable module: node-forge
  • Introduced through: gcloud@0.24.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 gtoken@1.2.3 google-p12-pem@0.1.2 node-forge@0.7.6

Overview

node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.

Affected versions of this package are vulnerable to Open Redirect via parseUrl function when it mishandles certain uses of backslash such as https:/\/\/\ and interprets the URI as a relative path.

PoC:


// poc.js
var forge = require("node-forge");
var url = forge.util.parseUrl("https:/\/\/\www.github.com/foo/bar");
console.log(url);

// Output of node poc.js:

{
  full: 'https://',
  scheme: 'https',
  host: '',
  port: 443,
  path: '/www.github.com/foo/bar',                        <<<---- path  should be "/foo/bar"
  fullHost: ''
}

Remediation

Upgrade node-forge to version 1.0.0 or higher.

References

medium severity

Improper Certificate Validation

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Improper Certificate Validation. Certificate validation is disabled by default when requesting binaries, even if the user is not specifying an alternative download path.

Remediation

Upgrade node-sass to version 7.0.0 or higher.

References

medium severity

Improper Input Validation

  • Vulnerable module: postcss
  • Introduced through: gulp-autoprefixer@3.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-autoprefixer@3.1.1 postcss@5.2.18
    Remediation: Upgrade to gulp-autoprefixer@8.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-autoprefixer@3.1.1 autoprefixer@6.7.7 postcss@5.2.18

Overview

postcss is a PostCSS is a tool for transforming styles with JS plugins.

Affected versions of this package are vulnerable to Improper Input Validation when parsing external Cascading Style Sheets (CSS) with linters using PostCSS. An attacker can cause discrepancies by injecting malicious CSS rules, such as @font-face{ font:(\r/*);}. This vulnerability is because of an insecure regular expression usage in the RE_BAD_BRACKET variable.

Remediation

Upgrade postcss to version 8.4.31 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: postcss
  • Introduced through: gulp-autoprefixer@3.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-autoprefixer@3.1.1 postcss@5.2.18
    Remediation: Upgrade to gulp-autoprefixer@6.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-autoprefixer@3.1.1 autoprefixer@6.7.7 postcss@5.2.18
    Remediation: Upgrade to gulp-autoprefixer@6.0.0.

Overview

postcss is a PostCSS is a tool for transforming styles with JS plugins.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via getAnnotationURL() and loadAnnotation() in lib/previous-map.js. The vulnerable regexes are caused mainly by the sub-pattern \/\*\s*# sourceMappingURL=(.*).

PoC

var postcss = require("postcss")
function build_attack(n) {
    var ret = "a{}"
    for (var i = 0; i < n; i++) {
        ret += "/*# sourceMappingURL="
    }
    return ret + "!";
}

// postcss.parse('a{}/*# sourceMappingURL=a.css.map */')
for(var i = 1; i <= 500000; i++) {
    if (i % 1000 == 0) {
        var time = Date.now();
        var attack_str = build_attack(i)
        try{
            postcss.parse(attack_str)
            var time_cost = Date.now() - time;
            console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms");
            }
        catch(e){
        var time_cost = Date.now() - time;
        console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms");
        }
    }
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade postcss to version 8.2.13, 7.0.36 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: scss-tokenizer
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 sass-graph@2.2.6 scss-tokenizer@0.2.3
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the loadAnnotation() function, due to the usage of insecure regex.

PoC

var scss = require("scss-tokenizer")
function build_attack(n) {
    var ret = "a{}"
    for (var i = 0; i < n; i++) {
        ret += "/*# sourceMappingURL="
    }
    return ret + "!";
}

// postcss.parse('a{}/*# sourceMappingURL=a.css.map */')
for(var i = 1; i <= 500000; i++) {
    if (i % 1000 == 0) {
        var time = Date.now();
        var attack_str = build_attack(i)
        try{
            scss.tokenize(attack_str)
            var time_cost = Date.now() - time;
            console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms");
            }
        catch(e){
        var time_cost = Date.now() - time;
        console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms");
        }
    }
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade scss-tokenizer to version 0.4.3 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver-regex
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0

Overview

semver-regex is a Regular expression for matching semver versions

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to improper usage of regex in the semverRegex() function.

PoC

'0.0.1-' + '-.--'.repeat(i) + ' '

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver-regex to version 3.1.4, 4.0.3 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: uglify-js
  • Introduced through: express-handlebars@2.0.1 and gulp-uglify@1.5.4

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8 uglify-js@2.8.29
    Remediation: Upgrade to express-handlebars@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-uglify@1.5.4 uglify-js@2.6.4
    Remediation: Upgrade to gulp-uglify@3.0.0.

Overview

uglify-js is a JavaScript parser, minifier, compressor and beautifier toolkit.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the string_template and the decode_template functions.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade uglify-js to version 3.14.3 or higher.

References

medium severity

Uninitialized Memory Exposure

  • Vulnerable module: tunnel-agent
  • Introduced through: gcloud@0.24.1 and gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 retry-request@1.3.2 request@2.76.0 tunnel-agent@0.4.3
    Remediation: Open PR to patch tunnel-agent@0.4.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 tunnel-agent@0.4.3
    Remediation: Open PR to patch tunnel-agent@0.4.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gce-images@0.2.3 google-auto-auth@0.1.1 google-auth-library@0.9.10 request@2.74.0 tunnel-agent@0.4.3
    Remediation: Open PR to patch tunnel-agent@0.4.3.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gcloud@0.24.1 gcs-resumable-upload@0.2.2 google-auto-auth@0.2.4 google-auth-library@0.9.10 request@2.74.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gcloud@0.36.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 caw@1.2.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 caw@1.2.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 caw@1.2.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 caw@1.2.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 caw@1.2.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gulp-imagemin@3.0.0.
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 caw@1.2.0 tunnel-agent@0.4.3
    Remediation: Upgrade to gulp-imagemin@3.0.0.

Overview

tunnel-agent is HTTP proxy tunneling agent. Affected versions of the package are vulnerable to Uninitialized Memory Exposure.

A possible memory disclosure vulnerability exists when a value of type number is used to set the proxy.auth option of a request request and results in a possible uninitialized memory exposures in the request body.

This is a result of unobstructed use of the Buffer constructor, whose insecure default constructor increases the odds of memory leakage.

Details

Constructing a Buffer class with integer N creates a Buffer of length N with raw (not "zero-ed") memory.

In the following example, the first call would allocate 100 bytes of memory, while the second example will allocate the memory needed for the string "100":

// uninitialized Buffer of length 100
x = new Buffer(100);
// initialized Buffer with value of '100'
x = new Buffer('100');

tunnel-agent's request construction uses the default Buffer constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw server side memory, potentially holding secrets, private data and code. This is a similar vulnerability to the infamous Heartbleed flaw in OpenSSL.

Proof of concept by ChALkeR

require('request')({
  method: 'GET',
  uri: 'http://www.example.com',
  tunnel: true,
  proxy:{
      protocol: 'http:',
      host:"127.0.0.1",
      port:8080,
      auth:80
  }
});

You can read more about the insecure Buffer behavior on our blog.

Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.

Remediation

Upgrade tunnel-agent to version 0.6.0 or higher. Note This is vulnerable only for Node <=4

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: lodash
  • Introduced through: gulp@3.9.1 and gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp@3.9.1 vinyl-fs@0.3.14 glob-watcher@0.0.6 gaze@0.5.2 globule@0.1.0 lodash@1.0.2
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3 inquirer@0.11.4 lodash@3.10.1
    Remediation: Upgrade to gulp-eslint@2.0.0.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It parses dates using regex strings, which may cause a slowdown of 2 seconds per 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade lodash to version 4.17.11 or higher.

References

medium severity

NULL Pointer Dereference

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to NULL Pointer Dereference via Sass::Parser::parseCompoundSelectorin parser_selectors.cpp. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Remediation

There is no fixed version for node-sass.

References

medium severity

Out-of-bounds Read

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Out-of-bounds Read via Sass::weaveParents in ast_sel_weave.cpp. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

There is no fixed version for node-sass.

References

medium severity

Uncontrolled Recursion

  • Vulnerable module: node-sass
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1

Overview

node-sass is a Node.js bindings package for libsass.

Affected versions of this package are vulnerable to Uncontrolled Recursion via Sass::Eval::operator()(Sass::Binary_Expression*) in eval.cpp. Note: node-sass is affected by this vulnerability due to its bundled usage of the libsass package.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

There is no fixed version for node-sass.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver-regex
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 bin-version-check@2.1.0 bin-version@1.0.4 find-versions@1.2.1 semver-regex@1.0.0

Overview

semver-regex is a Regular expression for matching semver versions

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS).

PoC


// import of the vulnerable library
const semverRegex = require('semver-regex');
// import of measurement tools
const { PerformanceObserver, performance } = require('perf_hooks');

// config of measurements tools
const obs = new PerformanceObserver((items) => {
 console.log(items.getEntries()[0].duration);
 performance.clearMarks();
});
obs.observe({ entryTypes: ['measure'] });

// base version string
let version = "v1.1.3-0a"

// Adding the evil code, resulting in string
// v1.1.3-0aa.aa.aa.aa.aa.aa.a…a.a"
for(let i=0; i < 20; i++) {
   version += "a.a"
}

// produce a good version
// Parses well for the regex in milliseconds
let goodVersion = version + "2"

// good version proof
performance.mark("good before")
const goodresult = semverRegex().test(goodVersion);
performance.mark("good after")


console.log(`Good result: ${goodresult}`)
performance.measure('Good', 'good before', 'good after');

// create a bad/exploit version that is invalid due to the last $ sign
// will cause the nodejs engine to hang, if not, increase the a.a
// additions above a bit.
badVersion = version + "aaaaaaa$"

// exploit proof
performance.mark("bad before")
const badresult = semverRegex().test(badVersion);
performance.mark("bad after")

console.log(`Bad result: ${badresult}`)
performance.measure('Bad', 'bad before', 'bad after');

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver-regex to version 3.1.2 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: braces
  • Introduced through: gulp-imagemin@2.4.0

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-build@2.2.0 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-gifsicle@4.2.0 gifsicle@3.0.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-jpegtran@4.3.2 jpegtran-bin@3.2.0 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5
  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-imagemin@2.4.0 imagemin@4.0.0 imagemin-optipng@4.3.0 optipng-bin@3.1.4 bin-wrapper@3.0.2 download@4.4.3 gulp-decompress@1.2.0 decompress@3.0.0 vinyl-fs@2.4.4 glob-stream@5.3.5 micromatch@2.3.11 braces@1.8.5

Overview

braces is a Bash-like brace expansion, implemented in JavaScript.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It used a regular expression (^\{(,+(?:(\{,+\})*),*|,*(?:(\{,+\})*),+)\}) in order to detects empty braces. This can cause an impact of about 10 seconds matching time for data 50K characters long.

Disclosure Timeline

  • Feb 15th, 2018 - Initial Disclosure to package owner
  • Feb 16th, 2018 - Initial Response from package owner
  • Feb 18th, 2018 - Fix issued
  • Feb 19th, 2018 - Vulnerability published

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade braces to version 2.3.1 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: clean-css
  • Introduced through: gulp-minify-css@1.2.4

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-minify-css@1.2.4 clean-css@3.4.28

Overview

clean-css is a fast and efficient CSS optimizer for Node.js platform and any modern browser.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). attacks. This can cause an impact of about 10 seconds matching time for data 70k characters long.

Disclosure Timeline

  • Feb 15th, 2018 - Initial Disclosure to package owner
  • Feb 20th, 2018 - Initial Response from package owner
  • Mar 6th, 2018 - Fix issued
  • Mar 7th, 2018 - Vulnerability published

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade clean-css to version 4.1.11 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: eslint
  • Introduced through: gulp-eslint@1.1.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-eslint@1.1.1 eslint@1.10.3
    Remediation: Upgrade to gulp-eslint@4.0.0.

Overview

eslint is a pluggable linting utility for JavaScript and JSX

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). This can cause an impact of about 10 seconds matching time for data 100k characters long.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade eslint to version 4.18.2 or higher.

References

low severity

Prototype Pollution

  • Vulnerable module: minimist
  • Introduced through: express-handlebars@2.0.1

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e express-handlebars@2.0.1 handlebars@3.0.8 optimist@0.6.1 minimist@0.0.10

Overview

minimist is a parse argument options module.

Affected versions of this package are vulnerable to Prototype Pollution due to a missing handler to Function.prototype.

Notes:

  • This vulnerability is a bypass to CVE-2020-7598

  • The reason for the different CVSS between CVE-2021-44906 to CVE-2020-7598, is that CVE-2020-7598 can pollute objects, while CVE-2021-44906 can pollute only function.

PoC by Snyk

require('minimist')('--_.constructor.constructor.prototype.foo bar'.split(' '));
console.log((function(){}).foo); // bar

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade minimist to version 0.2.4, 1.2.6 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: tar
  • Introduced through: gulp-sass@2.3.2

Detailed paths

  • Introduced through: app-shell@googlechrome/application-shell#b812ec14f7ec356dc9b10b80d0bea5c97146284e gulp-sass@2.3.2 node-sass@3.13.1 node-gyp@3.8.0 tar@2.2.2
    Remediation: Upgrade to gulp-sass@5.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). When stripping the trailing slash from files arguments, the f.replace(/\/+$/, '') performance of this function can exponentially degrade when f contains many / characters resulting in ReDoS.

This vulnerability is not likely to be exploitable as it requires that the untrusted input is being passed into the tar.extract() or tar.list() array of entries to parse/extract, which would be unusual.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade tar to version 6.1.4, 5.0.8, 4.4.16 or higher.

References