tnocs/csweb-sim
Ready to fix your vulnerabilities? Automatically find, fix, and monitor vulnerabilities for free with Snyk.
Find, fix and prevent vulnerabilities in your code.
critical severity
- Vulnerable module: socket.io-parser
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-parser@2.3.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-adapter@0.5.0 › socket.io-parser@2.3.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › socket.io-parser@2.3.1
Overview
socket.io-parser is a socket.io protocol parser
Affected versions of this package are vulnerable to Improper Input Validation.
when parsing attachments containing untrusted user input. Attackers can overwrite the _placeholder
object to place references to functions in query objects.
PoC
const decoder = new Decoder();
decoder.on("decoded", (packet) => {
console.log(packet.data); // prints [ 'hello', [Function: splice] ]
})
decoder.add('51-["hello",{"_placeholder":true,"num":"splice"}]');
decoder.add(Buffer.from("world"));
Remediation
Upgrade socket.io-parser
to version 3.3.3, 3.4.2, 4.0.5, 4.2.1 or higher.
References
high severity
- Vulnerable module: simple-get
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › simple-get@1.4.3
Overview
Affected versions of this package are vulnerable to Information Exposure. When getting Location response
header after fetching a remote url with Cookie, it will follow that url and fetch it with the provided cookie which will be then leaked to the attacker .
Remediation
Upgrade simple-get
to version 2.8.2, 3.1.1, 4.0.1 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Write. node-tar
aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.
This logic was insufficient when extracting tar
files that contained both a directory and a symlink with the same name as the directory, where the symlink and directory names in the archive entry used backslashes as a path separator on posix systems. The cache checking logic used both \
and /
characters as path separators. However, \
is a valid filename character on posix systems.
By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar
symlink checks on directories, essentially allowing an untrusted tar
file to symlink into an arbitrary location. This can lead to extracting arbitrary files into that location, thus allowing arbitrary file creation and overwrite.
Additionally, a similar confusion could arise on case-insensitive filesystems. If a tar
archive contained a directory at FOO
, followed by a symbolic link named foo
, then on case-insensitive file systems, the creation of the symbolic link would remove the directory from the filesystem, but not from the internal directory cache, as it would not be treated as a cache hit. A subsequent file entry within the FOO
directory would then be placed in the target of the symbolic link, thinking that the directory had already been created.
Remediation
Upgrade tar
to version 6.1.7, 5.0.8, 4.4.16 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Write. node-tar
aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.
This logic is insufficient when extracting tar
files that contain two directories and a symlink with names containing unicode values that normalized to the same value. Additionally, on Windows systems, long path portions would resolve to the same file system entities as their 8.3 "short path" counterparts.
A specially crafted tar
archive can include directories with two forms of the path that resolve to the same file system entity, followed by a symbolic link with a name in the first form, lastly followed by a file using the second form. This leads to bypassing node-tar
symlink checks on directories, essentially allowing an untrusted tar
file to symlink into an arbitrary location and extracting arbitrary files into that location.
Remediation
Upgrade tar
to version 6.1.9, 5.0.10, 4.4.18 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Write. node-tar
aims to guarantee that any file whose location would be outside of the extraction target directory is not extracted. This is, in part, accomplished by sanitizing absolute paths of entries within the archive, skipping archive entries that contain ..
path portions, and resolving the sanitized paths against the extraction target directory.
This logic is insufficient on Windows systems when extracting tar
files that contain a path that is not an absolute path, but specify a drive letter different from the extraction target, such as C:some\path
. If the drive letter does not match the extraction target, for example D:\extraction\dir
, then the result of path.resolve(extractionDirectory, entryPath)
resolves against the current working directory on the C:
drive, rather than the extraction target directory.
Additionally, a ..
portion of the path can occur immediately after the drive letter, such as C:../foo
, and is not properly sanitized by the logic that checks for ..
within the normalized and split portions of the path.
Note: This only affects users of node-tar
on Windows systems.
Remediation
Upgrade tar
to version 6.1.9, 5.0.10, 4.4.18 or higher.
References
high severity
- Vulnerable module: kerberos
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kerberos@0.0.24
Overview
Affected versions of this package are vulnerable to DLL Injection. An attacker can execute arbitrary code by creating a file with the same name in a folder that precedes the intended file in the DLL path search.
Remediation
Upgrade kerberos
to version 1.0.0 or higher.
References
high severity
- Vulnerable module: body-parser
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › body-parser@1.14.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › body-parser@1.14.1
Overview
Affected versions of this package are vulnerable to Asymmetric Resource Consumption (Amplification) via the extendedparser
and urlencoded
functions when the URL encoding process is enabled. An attacker can flood the server with a large number of specially crafted requests.
Remediation
Upgrade body-parser
to version 1.20.3 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient symlink protection.
node-tar
aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat
calls to determine whether a given path is a directory, paths are cached when directories are created.
This logic is insufficient when extracting tar files that contain both a directory and a symlink with the same name as the directory. This order of operations results in the directory being created and added to the node-tar
directory cache. When a directory is present in the directory cache, subsequent calls to mkdir
for that directory are skipped.
However, this is also where node-tar
checks for symlinks occur. By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar
symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and subsequently extracting arbitrary files into that location.
Remediation
Upgrade tar
to version 3.2.3, 4.4.15, 5.0.7, 6.1.2 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient absolute path sanitization.
node-tar
aims to prevent extraction of absolute file paths by turning absolute paths into relative paths when the preservePaths
flag is not set to true
. This is achieved by stripping the absolute path root from any absolute file paths contained in a tar file. For example, the path /home/user/.bashrc
would turn into home/user/.bashrc
.
This logic is insufficient when file paths contain repeated path roots such as ////home/user/.bashrc
. node-tar
only strips a single path root from such paths. When given an absolute file path with repeating path roots, the resulting path (e.g. ///home/user/.bashrc
) still resolves to an absolute path.
Remediation
Upgrade tar
to version 3.2.2, 4.4.14, 5.0.6, 6.1.1 or higher.
References
high severity
- Vulnerable module: bson
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › mongodb@2.2.36 › mongodb-core@2.1.20 › bson@1.0.9
Overview
bson is a BSON Parser for node and browser.
Affected versions of this package are vulnerable to Internal Property Tampering. The package will ignore an unknown value for an object's _bsotype
, leading to cases where an object is serialized as a document rather than the intended BSON type.
NOTE: This vulnerability has also been identified as: CVE-2019-2391
Remediation
Upgrade bson
to version 1.1.4 or higher.
References
high severity
- Vulnerable module: bson
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › mongodb@2.2.36 › mongodb-core@2.1.20 › bson@1.0.9
Overview
bson is a BSON Parser for node and browser.
Affected versions of this package are vulnerable to Internal Property Tampering. The package will ignore an unknown value for an object's _bsotype
, leading to cases where an object is serialized as a document rather than the intended BSON type.
NOTE: This vulnerability has also been identified as: CVE-2020-7610
Remediation
Upgrade bson
to version 1.1.4 or higher.
References
high severity
- Vulnerable module: bl
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › level-sublevel@6.6.5 › levelup@0.19.1 › bl@0.8.2
Overview
bl is a library that allows you to collect buffers and access with a standard readable buffer interface.
Affected versions of this package are vulnerable to Uninitialized Memory Exposure. If user input ends up in consume()
argument and can become negative, BufferList state can be corrupted, tricking it into exposing uninitialized memory via regular .slice()
calls.
PoC by chalker
const { BufferList } = require('bl')
const secret = require('crypto').randomBytes(256)
for (let i = 0; i < 1e6; i++) {
const clone = Buffer.from(secret)
const bl = new BufferList()
bl.append(Buffer.from('a'))
bl.consume(-1024)
const buf = bl.slice(1)
if (buf.indexOf(clone) !== -1) {
console.error(`Match (at ${i})`, buf)
}
}
Remediation
Upgrade bl
to version 2.2.1, 3.0.1, 4.0.3, 1.2.3 or higher.
References
high severity
- Vulnerable module: ansi-regex
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › pino@2.16.0 › chalk@1.1.3 › strip-ansi@3.0.1 › ansi-regex@2.1.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › pino@2.16.0 › chalk@1.1.3 › has-ansi@2.0.0 › ansi-regex@2.1.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › npmlog@4.1.2 › gauge@2.7.4 › strip-ansi@3.0.1 › ansi-regex@2.1.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › npmlog@4.1.2 › gauge@2.7.4 › string-width@1.0.2 › strip-ansi@3.0.1 › ansi-regex@2.1.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › npmlog@3.1.2 › gauge@2.6.0 › strip-ansi@3.0.1 › ansi-regex@2.1.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › npmlog@3.1.2 › gauge@2.6.0 › string-width@1.0.2 › strip-ansi@3.0.1 › ansi-regex@2.1.1
…and 3 more
Overview
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to the sub-patterns [[\\]()#;?]*
and (?:;[-a-zA-Z\\d\\/#&.:=?%@~_]*)*
.
PoC
import ansiRegex from 'ansi-regex';
for(var i = 1; i <= 50000; i++) {
var time = Date.now();
var attack_str = "\u001B["+";".repeat(i*10000);
ansiRegex().test(attack_str)
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ansi-regex
to version 3.0.1, 4.1.1, 5.0.1, 6.0.1 or higher.
References
high severity
- Vulnerable module: engine.io
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › engine.io@1.8.5
Overview
engine.io is a realtime engine behind Socket.IO. It provides the foundation of a bidirectional connection between client and server
Affected versions of this package are vulnerable to Denial of Service (DoS) via a POST request to the long polling transport.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade engine.io
to version 3.6.0 or higher.
References
high severity
- Vulnerable module: engine.io
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › engine.io@1.8.5
Overview
engine.io is a realtime engine behind Socket.IO. It provides the foundation of a bidirectional connection between client and server
Affected versions of this package are vulnerable to Denial of Service (DoS). A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js
process.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade engine.io
to version 3.6.1, 6.2.1 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution through the zipObjectDeep
function due to improper user input sanitization in the baseZipObject
function.
PoC
lodash.zipobjectdeep:
const zipObjectDeep = require("lodash.zipobjectdeep");
let emptyObject = {};
console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined
zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function
console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true
lodash:
const test = require("lodash");
let emptyObject = {};
console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined
test.zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function
console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.17 or higher.
References
high severity
- Vulnerable module: mongodb
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › mongodb@2.2.36
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › mongodb@2.1.21
Overview
mongodb is an official MongoDB driver for Node.js.
Affected versions of this package are vulnerable to Denial of Service (DoS). The package fails to properly catch an exception when a collection name is invalid and the DB does not exist, crashing the application.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade mongodb
to version 3.1.13 or higher.
References
high severity
- Vulnerable module: mqtt
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › mqtt-router@0.5.0 › mqtt@0.3.13
Overview
'mqtt' is a library implementing the MQTT protocol. Versions earlier than 1.0.0
allow a remote attacker to cause Denial of Service (DoS) by sending a specifically crafted packet, crashing the application.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade mqtt
to version 1.0.0 or later
References
high severity
- Vulnerable module: parsejson
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › engine.io-client@1.8.6 › parsejson@0.0.3
Overview
parsejson is a method that parses a JSON string and returns a JSON object.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks. An attacker may pass a specially crafted JSON data, causing the server to hang.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
There is no fixed version for parsejson
.
References
high severity
- Vulnerable module: qs
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › body-parser@1.14.1 › qs@5.1.0Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › body-parser@1.14.1 › qs@5.1.0
Overview
qs is a querystring parser that supports nesting and arrays, with a depth limit.
Affected versions of this package are vulnerable to Prototype Override Protection Bypass. By default qs
protects against attacks that attempt to overwrite an object's existing prototype properties, such as toString()
, hasOwnProperty()
,etc.
From qs
documentation:
By default parameters that would overwrite properties on the object prototype are ignored, if you wish to keep the data from those fields either use plainObjects as mentioned above, or set allowPrototypes to true which will allow user input to overwrite those properties. WARNING It is generally a bad idea to enable this option as it can cause problems when attempting to use the properties that have been overwritten. Always be careful with this option.
Overwriting these properties can impact application logic, potentially allowing attackers to work around security controls, modify data, make the application unstable and more.
In versions of the package affected by this vulnerability, it is possible to circumvent this protection and overwrite prototype properties and functions by prefixing the name of the parameter with [
or ]
. e.g. qs.parse("]=toString")
will return {toString = true}
, as a result, calling toString()
on the object will throw an exception.
Example:
qs.parse('toString=foo', { allowPrototypes: false })
// {}
qs.parse("]=toString", { allowPrototypes: false })
// {toString = true} <== prototype overwritten
For more information, you can check out our blog.
Disclosure Timeline
- February 13th, 2017 - Reported the issue to package owner.
- February 13th, 2017 - Issue acknowledged by package owner.
- February 16th, 2017 - Partial fix released in versions
6.0.3
,6.1.1
,6.2.2
,6.3.1
. - March 6th, 2017 - Final fix released in versions
6.4.0
,6.3.2
,6.2.3
,6.1.2
and6.0.4
Remediation
Upgrade qs
to version 6.0.4, 6.1.2, 6.2.3, 6.3.2 or higher.
References
high severity
- Vulnerable module: qs
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › body-parser@1.14.1 › qs@5.1.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › body-parser@1.14.1 › qs@5.1.0
Overview
qs is a querystring parser that supports nesting and arrays, with a depth limit.
Affected versions of this package are vulnerable to Prototype Poisoning which allows attackers to cause a Node process to hang, processing an Array object whose prototype has been replaced by one with an excessive length value.
Note: In many typical Express use cases, an unauthenticated remote attacker can place the attack payload in the query string of the URL that is used to visit the application, such as a[__proto__]=b&a[__proto__]&a[length]=100000000
.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade qs
to version 6.2.4, 6.3.3, 6.4.1, 6.5.3, 6.6.1, 6.7.3, 6.8.3, 6.9.7, 6.10.3 or higher.
References
high severity
- Vulnerable module: semver
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › level-sublevel@6.6.5 › levelup@0.19.1 › semver@5.1.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › semver@5.3.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › levelup@1.3.9 › semver@5.4.1
Overview
semver is a semantic version parser used by npm.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range
, when untrusted user data is provided as a range.
PoC
const semver = require('semver')
const lengths_2 = [2000, 4000, 8000, 16000, 32000, 64000, 128000]
console.log("n[+] Valid range - Test payloads")
for (let i = 0; i =1.2.3' + ' '.repeat(lengths_2[i]) + '<1.3.0';
const start = Date.now()
semver.validRange(value)
// semver.minVersion(value)
// semver.maxSatisfying(["1.2.3"], value)
// semver.minSatisfying(["1.2.3"], value)
// new semver.Range(value, {})
const end = Date.now();
console.log('length=%d, time=%d ms', value.length, end - start);
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade semver
to version 5.7.2, 6.3.1, 7.5.2 or higher.
References
high severity
- Vulnerable module: socket.io-parser
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-parser@2.3.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-adapter@0.5.0 › socket.io-parser@2.3.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › socket.io-parser@2.3.1
Overview
socket.io-parser is a socket.io protocol parser
Affected versions of this package are vulnerable to Denial of Service (DoS) via a large packet because a concatenation approach is used.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade socket.io-parser
to version 3.3.2, 3.4.1 or higher.
References
high severity
- Vulnerable module: ws
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › ws@0.8.1Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › ws@0.8.1
Overview
ws
is a WebSocket client and server implementation.
Affected versions of this package did not limit the size of an incoming payload before it was processed by default. As a result, a very large payload (over 256MB in size) could lead to a failed allocation and crash the node process - enabling a Denial of Service attack.
While 256MB may seem excessive, note that the attack is likely to be sent from another server, not an end-user computer, using data-center connection speeds. In those speeds, a payload of this size can be transmitted in seconds.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Update to version 1.1.1 or greater, which sets a default maxPayload
of 100MB.
If you cannot upgrade, apply a Snyk patch, or provide ws
with options setting the maxPayload
to an appropriate size that is smaller than 256MB.
References
high severity
- Vulnerable module: ws
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › ws@0.8.1Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › ws@0.8.1
Overview
ws is a simple to use websocket client, server and console for node.js.
Affected versions of this package are vulnerable to Denial of Service (DoS)
attacks. A specially crafted value of the Sec-WebSocket-Extensions
header that used Object.prototype
property names as extension or parameter names could be used to make a ws server crash.
PoC:
const WebSocket = require('ws');
const net = require('net');
const wss = new WebSocket.Server({ port: 3000 }, function () {
const payload = 'constructor'; // or ',;constructor'
const request = [
'GET / HTTP/1.1',
'Connection: Upgrade',
'Sec-WebSocket-Key: test',
'Sec-WebSocket-Version: 8',
`Sec-WebSocket-Extensions: ${payload}`,
'Upgrade: websocket',
'\r\n'
].join('\r\n');
const socket = net.connect(3000, function () {
socket.resume();
socket.write(request);
});
});
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade ws
to version 1.1.5, 3.3.1 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution. The function defaultsDeep
could be tricked into adding or modifying properties of Object.prototype
using a constructor
payload.
PoC by Snyk
const mergeFn = require('lodash').defaultsDeep;
const payload = '{"constructor": {"prototype": {"a0": true}}}'
function check() {
mergeFn({}, JSON.parse(payload));
if (({})[`a0`] === true) {
console.log(`Vulnerable to Prototype Pollution via ${payload}`);
}
}
check();
For more information, check out our blog post
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.12 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution via the set
and setwith
functions due to improper user input sanitization.
PoC
lod = require('lodash')
lod.set({}, "__proto__[test2]", "456")
console.log(Object.prototype)
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.17 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution. The functions merge
, mergeWith
, and defaultsDeep
could be tricked into adding or modifying properties of Object.prototype
. This is due to an incomplete fix to CVE-2018-3721
.
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.11 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Code Injection via template
.
PoC
var _ = require('lodash');
_.template('', { variable: '){console.log(process.env)}; with(obj' })()
Remediation
Upgrade lodash
to version 4.17.21 or higher.
References
medium severity
- Vulnerable module: request
- Introduced through: csweb@0.3.28 and mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › request@2.88.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › request@2.88.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › request@2.88.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › request@2.88.2
…and 1 more
Overview
request is a simplified http request client.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) due to insufficient checks in the lib/redirect.js
file by allowing insecure redirects in the default configuration, via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).
NOTE: request
package has been deprecated, so a fix is not expected. See https://github.com/request/request/issues/3142.
Remediation
A fix was pushed into the master
branch but not yet published.
References
medium severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Uncontrolled Resource Consumption ('Resource Exhaustion') due to the lack of folders count validation during the folder creation process. An attacker who generates a large number of sub-folders can consume memory on the system running the software and even crash the client within few seconds of running it using a path with too many sub-folders inside.
Remediation
Upgrade tar
to version 6.2.1 or higher.
References
medium severity
- Vulnerable module: tough-cookie
- Introduced through: csweb@0.3.28 and mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › request@2.88.2 › tough-cookie@2.5.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › request@2.88.2 › tough-cookie@2.5.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › request@2.88.2 › tough-cookie@2.5.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › request@2.88.2 › tough-cookie@2.5.0
…and 1 more
Overview
tough-cookie is a RFC6265 Cookies and CookieJar module for Node.js.
Affected versions of this package are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false
mode. Due to an issue with the manner in which the objects are initialized, an attacker can expose or modify a limited amount of property information on those objects. There is no impact to availability.
PoC
// PoC.js
async function main(){
var tough = require("tough-cookie");
var cookiejar = new tough.CookieJar(undefined,{rejectPublicSuffixes:false});
// Exploit cookie
await cookiejar.setCookie(
"Slonser=polluted; Domain=__proto__; Path=/notauth",
"https://__proto__/admin"
);
// normal cookie
var cookie = await cookiejar.setCookie(
"Auth=Lol; Domain=google.com; Path=/notauth",
"https://google.com/"
);
//Exploit cookie
var a = {};
console.log(a["/notauth"]["Slonser"])
}
main();
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade tough-cookie
to version 4.1.3 or higher.
References
medium severity
patched
- Vulnerable module: ws
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Vulnerability patched for: hypertimer ws
Vulnerability patched for: csweb hypertimer ws
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › ws@0.8.1Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › ws@0.8.1Remediation: Open PR to patch ws@0.8.1.
Overview
ws
is a simple to use websocket client, server and console for node.js.
Affected versions of the package are vulnerable to Uninitialized Memory Exposure.
A client side memory disclosure vulnerability exists in ping functionality of the ws service. When a client sends a ping request and provides an integer value as ping data, it will result in leaking an uninitialized memory buffer.
This is a result of unobstructed use of the Buffer
constructor, whose insecure default constructor increases the odds of memory leakage.
ws
's ping
function uses the default Buffer
constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw memory, potentially holding secrets, private data and code.
Proof of Concept:
var ws = require('ws')
var server = new ws.Server({ port: 9000 })
var client = new ws('ws://localhost:9000')
client.on('open', function () {
console.log('open')
client.ping(50) // this makes the client allocate an uninitialized buffer of 50 bytes and send it to the server
client.on('pong', function (data) {
console.log('got pong')
console.log(data)
})
})
Details
The Buffer class on Node.js is a mutable array of binary data, and can be initialized with a string, array or number.
const buf1 = new Buffer([1,2,3]);
// creates a buffer containing [01, 02, 03]
const buf2 = new Buffer('test');
// creates a buffer containing ASCII bytes [74, 65, 73, 74]
const buf3 = new Buffer(10);
// creates a buffer of length 10
The first two variants simply create a binary representation of the value it received. The last one, however, pre-allocates a buffer of the specified size, making it a useful buffer, especially when reading data from a stream.
When using the number constructor of Buffer, it will allocate the memory, but will not fill it with zeros. Instead, the allocated buffer will hold whatever was in memory at the time. If the buffer is not zeroed
by using buf.fill(0)
, it may leak sensitive information like keys, source code, and system info.
Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.
References
medium severity
- Vulnerable module: cookie
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › engine.io@1.8.5 › cookie@0.3.1
Overview
Affected versions of this package are vulnerable to Cross-site Scripting (XSS) via the cookie name
, path
, or domain
, which can be used to set unexpected values to other cookie fields.
Workaround
Users who are not able to upgrade to the fixed version should avoid passing untrusted or arbitrary values for the cookie fields and ensure they are set by the application instead of user input.
Details
A cross-site scripting attack occurs when the attacker tricks a legitimate web-based application or site to accept a request as originating from a trusted source.
This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.
Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.
Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, <
can be coded as <
; and >
can be coded as >
; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses <
and >
as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.
The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.
Types of attacks
There are a few methods by which XSS can be manipulated:
Type | Origin | Description |
---|---|---|
Stored | Server | The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link. |
Reflected | Server | The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser. |
DOM-based | Client | The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data. |
Mutated | The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters. |
Affected environments
The following environments are susceptible to an XSS attack:
- Web servers
- Application servers
- Web application environments
How to prevent
This section describes the top best practices designed to specifically protect your code:
- Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
- Convert special characters such as
?
,&
,/
,<
,>
and spaces to their respective HTML or URL encoded equivalents. - Give users the option to disable client-side scripts.
- Redirect invalid requests.
- Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
- Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
- Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.
Remediation
Upgrade cookie
to version 0.7.0 or higher.
References
medium severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1Remediation: Open PR to patch lodash@3.10.1.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1Remediation: Open PR to patch lodash@3.10.1.
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object
prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.
PoC by Olivier Arteau (HoLyVieR)
var _= require('lodash');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
var a = {};
console.log("Before : " + a.oops);
_.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.5 or higher.
References
medium severity
- Vulnerable module: nanoid
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › nanoid@0.2.2
Overview
Affected versions of this package are vulnerable to Improper Input Validation due to the mishandling of fractional values in the nanoid
function. By exploiting this vulnerability, an attacker can achieve an infinite loop.
Remediation
Upgrade nanoid
to version 3.3.8, 5.0.9 or higher.
References
medium severity
- Vulnerable module: inflight
- Introduced through: fs-extra@0.30.0, csweb@0.3.28 and others
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › fs-extra@0.30.0 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › jasmine@2.99.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › fs-extra@0.26.7 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › mqtt@1.14.1 › help-me@1.1.0 › glob-stream@6.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › mqtt@1.14.1 › help-me@1.1.0 › glob-stream@6.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › mqtt@1.14.1 › help-me@1.1.0 › glob-stream@6.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
…and 15 more
Overview
Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres
function due to improperly deleting keys from the reqs
object after execution of callbacks. This behavior causes the keys to remain in the reqs
object, which leads to resource exhaustion.
Exploiting this vulnerability results in crashing the node
process or in the application crash.
Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.
To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.
PoC
const inflight = require('inflight');
function testInflight() {
let i = 0;
function scheduleNext() {
let key = `key-${i++}`;
const callback = () => {
};
for (let j = 0; j < 1000000; j++) {
inflight(key, callback);
}
setImmediate(scheduleNext);
}
if (i % 100 === 0) {
console.log(process.memoryUsage());
}
scheduleNext();
}
testInflight();
Remediation
There is no fixed version for inflight
.
References
medium severity
- Vulnerable module: underscore
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › node-zookeeper-client@0.2.3 › underscore@1.4.4
Overview
underscore is a JavaScript's functional programming helper library.
Affected versions of this package are vulnerable to Arbitrary Code Injection via the template
function, particularly when the variable
option is taken from _.templateSettings
as it is not sanitized.
PoC
const _ = require('underscore');
_.templateSettings.variable = "a = this.process.mainModule.require('child_process').execSync('touch HELLO')";
const t = _.template("")();
Remediation
Upgrade underscore
to version 1.13.0-2, 1.12.1 or higher.
References
medium severity
- Vulnerable module: glob-parent
- Introduced through: csweb@0.3.28 and mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › mqtt@1.14.1 › help-me@1.1.0 › glob-stream@6.1.0 › glob-parent@3.1.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › mqtt@1.14.1 › help-me@1.1.0 › glob-stream@6.1.0 › glob-parent@3.1.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › mqtt@1.14.1 › help-me@1.1.0 › glob-stream@6.1.0 › glob-parent@3.1.0
Overview
glob-parent is a package that helps extracting the non-magic parent path from a glob string.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The enclosure
regex used to check for strings ending in enclosure containing path separator.
PoC by Yeting Li
var globParent = require("glob-parent")
function build_attack(n) {
var ret = "{"
for (var i = 0; i < n; i++) {
ret += "/"
}
return ret;
}
globParent(build_attack(5000));
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade glob-parent
to version 5.1.2 or higher.
References
medium severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the toNumber
, trim
and trimEnd
functions.
POC
var lo = require('lodash');
function build_blank (n) {
var ret = "1"
for (var i = 0; i < n; i++) {
ret += " "
}
return ret + "1";
}
var s = build_blank(50000)
var time0 = Date.now();
lo.trim(s)
var time_cost0 = Date.now() - time0;
console.log("time_cost0: " + time_cost0)
var time1 = Date.now();
lo.toNumber(s)
var time_cost1 = Date.now() - time1;
console.log("time_cost1: " + time_cost1)
var time2 = Date.now();
lo.trimEnd(s)
var time_cost2 = Date.now() - time2;
console.log("time_cost2: " + time_cost2)
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade lodash
to version 4.17.21 or higher.
References
medium severity
- Vulnerable module: socket.io
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4
Overview
socket.io is a node.js realtime framework server.
Affected versions of this package are vulnerable to Insecure Defaults due to CORS Misconfiguration. All domains are whitelisted by default.
Remediation
Upgrade socket.io
to version 2.4.0 or higher.
References
medium severity
- Vulnerable module: ws
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › ws@0.8.1Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › ws@0.8.1Remediation: Open PR to patch ws@0.8.1.
Overview
ws
is a simple to use websocket client, server and console for node.js.
Affected versions of the package use the cryptographically insecure Math.random()
which can produce predictable values and should not be used in security-sensitive context.
Details
Computers are deterministic machines, and as such are unable to produce true randomness. Pseudo-Random Number Generators (PRNGs) approximate randomness algorithmically, starting with a seed from which subsequent values are calculated.
There are two types of PRNGs: statistical and cryptographic. Statistical PRNGs provide useful statistical properties, but their output is highly predictable and forms an easy to reproduce numeric stream that is unsuitable for use in cases where security depends on generated values being unpredictable. Cryptographic PRNGs address this problem by generating output that is more difficult to predict. For a value to be cryptographically secure, it must be impossible or highly improbable for an attacker to distinguish between it and a truly random value. In general, if a PRNG algorithm is not advertised as being cryptographically secure, then it is probably a statistical PRNG and should not be used in security-sensitive contexts.
You can read more about node's insecure Math.random()
in Mike Malone's post.
Remediation
Upgrade ws
to version 1.1.2 or higher.
References
medium severity
- Vulnerable module: ws
- Introduced through: hypertimer@2.1.3, csweb@0.3.28 and others
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › ws@0.8.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › ws@0.8.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › websocket-stream@3.1.0 › ws@1.1.5
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › mqtt@1.14.1 › websocket-stream@3.3.3 › ws@1.1.5
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › mqtt@1.14.1 › websocket-stream@3.3.3 › ws@1.1.5
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › engine.io@1.8.5 › ws@1.1.5
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › mqtt@1.14.1 › websocket-stream@3.3.3 › ws@1.1.5
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › engine.io-client@1.8.6 › ws@1.1.5
…and 5 more
Overview
ws is a simple to use websocket client, server and console for node.js.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). A specially crafted value of the Sec-Websocket-Protocol
header can be used to significantly slow down a ws
server.
##PoC
for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
const value = 'b' + ' '.repeat(length) + 'x';
const start = process.hrtime.bigint();
value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ws
to version 7.4.6, 6.2.2, 5.2.3 or higher.
References
medium severity
- Vulnerable module: xml2js
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › xml2js@0.4.23
Overview
Affected versions of this package are vulnerable to Prototype Pollution due to allowing an external attacker to edit or add new properties to an object. This is possible because the application does not properly validate incoming JSON keys, thus allowing the __proto__
property to be edited.
PoC
var parseString = require('xml2js').parseString;
let normal_user_request = "<role>admin</role>";
let malicious_user_request = "<__proto__><role>admin</role></__proto__>";
const update_user = (userProp) => {
// A user cannot alter his role. This way we prevent privilege escalations.
parseString(userProp, function (err, user) {
if(user.hasOwnProperty("role") && user?.role.toLowerCase() === "admin") {
console.log("Unauthorized Action");
} else {
console.log(user?.role[0]);
}
});
}
update_user(normal_user_request);
update_user(malicious_user_request);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade xml2js
to version 0.5.0 or higher.
References
medium severity
- Vulnerable module: bl
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › level-sublevel@6.6.5 › levelup@0.19.1 › bl@0.8.2
Overview
bl is a storage object for collections of Node Buffers.
A possible memory disclosure vulnerability exists when a value of type number
is provided to the append()
method and results in concatenation of uninitialized memory to the buffer collection.
This is a result of unobstructed use of the Buffer
constructor, whose insecure default constructor increases the odds of memory leakage.
Details
Constructing a Buffer
class with integer N
creates a Buffer
of length N
with raw (not "zero-ed") memory.
In the following example, the first call would allocate 100 bytes of memory, while the second example will allocate the memory needed for the string "100":
// uninitialized Buffer of length 100
x = new Buffer(100);
// initialized Buffer with value of '100'
x = new Buffer('100');
bl
's append
function uses the default Buffer
constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw server side memory, potentially holding secrets, private data and code. This is a similar vulnerability to the infamous Heartbleed
flaw in OpenSSL.
const BufferList = require('bl')
var bl = new BufferList()
bl.append(new Buffer('abcd'))
bl.append(new Buffer('efg'))
bl.append('100')
// appends a Buffer holding 100 bytes of uninitialized memory
bl.append(100)
bl.append(new Buffer('j'))
You can read more about the insecure Buffer
behavior on our blog.
Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.
Note This is vulnerable only for Node <=4
References
medium severity
- Vulnerable module: lodash
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1 › lodash@3.10.1
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › lodash@3.10.1
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It parses dates using regex strings, which may cause a slowdown of 2 seconds per 50k characters.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade lodash
to version 4.17.11 or higher.
References
medium severity
- Vulnerable module: ioredis
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › ioredis@2.5.0
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ioredis@1.15.1
Overview
ioredis is a Redis client for Node.js.
Affected versions of this package are vulnerable to Prototype Pollution. The reply transformer which is applied does not check for special field names. This only impacts applications that are directly allowing user-provided field names.
PoC
// Redis server running on localhost
const Redis = require("ioredis");
const client = new Redis();
async function f1() {
await client.hset('test_key', ['__proto__', 'hello']);
console.log('hget:', await client.hget('test_key', '__proto__')); // "hello"
console.log('hgetall:', await client.hgetall('test_key')); // does not include __proto__: hello
}
f1();
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade ioredis
to version 4.27.8 or higher.
References
medium severity
- Module: node-ninja
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2
MPL-2.0 license
low severity
- Vulnerable module: debug
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › debug@2.2.0Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › body-parser@1.14.1 › debug@2.2.0Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › debug@2.2.0Remediation: Open PR to patch debug@2.2.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › body-parser@1.14.1 › debug@2.2.0Remediation: Open PR to patch debug@2.2.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-parser@2.3.1 › debug@2.2.0Remediation: Open PR to patch debug@2.2.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-adapter@0.5.0 › socket.io-parser@2.3.1 › debug@2.2.0Remediation: Open PR to patch debug@2.2.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › socket.io-parser@2.3.1 › debug@2.2.0Remediation: Open PR to patch debug@2.2.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › debug@2.3.3Remediation: Open PR to patch debug@2.3.3.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › engine.io@1.8.5 › debug@2.3.3Remediation: Open PR to patch debug@2.3.3.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-adapter@0.5.0 › debug@2.3.3Remediation: Open PR to patch debug@2.3.3.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › debug@2.3.3Remediation: Open PR to patch debug@2.3.3.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › engine.io-client@1.8.6 › debug@2.3.3Remediation: Open PR to patch debug@2.3.3.
…and 9 more
Overview
debug is a small debugging utility.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in the function useColors
via manipulation of the str
argument.
The vulnerability can cause a very low impact of about 2 seconds of matching time for data 50k characters long.
Note: CVE-2017-20165 is a duplicate of this vulnerability.
PoC
Use the following regex in the %o
formatter.
/\s*\n\s*/
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade debug
to version 2.6.9, 3.1.0, 3.2.7, 4.3.1 or higher.
References
low severity
- Vulnerable module: jasmine-core
- Introduced through: csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › jasmine@2.99.0 › jasmine-core@2.99.1
Overview
jasmine-core is a Behavior Driven Development testing framework for JavaScript.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It used a regular expression (^\s*function\s*(\w*)\s*\(
) in order to parse JS toString
output on a function to get a function name. This can cause an impact of about 10 seconds matching time for data 64K characters long.
Disclosure Timeline
- Feb 15th, 2018 - Initial Disclosure to package owner
- Feb 15th, 2018 - Initial Response from package owner
- Feb 15th, 2018 - Fix issued, not yet published to npm.
- Feb 18th, 2018 - Vulnerability published
- Mar 1st, 2018 - Fix published to npm.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade jasmine-core
to version 3.1.0 or higher.
References
low severity
- Vulnerable module: ms
- Introduced through: hypertimer@2.1.3 and csweb@0.3.28
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › debug@2.2.0 › ms@0.7.1Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › hypertimer@2.1.3 › body-parser@1.14.1 › debug@2.2.0 › ms@0.7.1Remediation: Upgrade to hypertimer@3.0.0.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › debug@2.2.0 › ms@0.7.1Remediation: Open PR to patch ms@0.7.1.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › hypertimer@2.1.3 › body-parser@1.14.1 › debug@2.2.0 › ms@0.7.1Remediation: Open PR to patch ms@0.7.1.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-parser@2.3.1 › debug@2.2.0 › ms@0.7.1Remediation: Open PR to patch ms@0.7.1.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-adapter@0.5.0 › socket.io-parser@2.3.1 › debug@2.2.0 › ms@0.7.1Remediation: Open PR to patch ms@0.7.1.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › socket.io-parser@2.3.1 › debug@2.2.0 › ms@0.7.1Remediation: Open PR to patch ms@0.7.1.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › debug@2.3.3 › ms@0.7.2Remediation: Open PR to patch ms@0.7.2.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › engine.io@1.8.5 › debug@2.3.3 › ms@0.7.2Remediation: Open PR to patch ms@0.7.2.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-adapter@0.5.0 › debug@2.3.3 › ms@0.7.2Remediation: Open PR to patch ms@0.7.2.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › debug@2.3.3 › ms@0.7.2Remediation: Open PR to patch ms@0.7.2.
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › csweb@0.3.28 › socket.io@1.7.4 › socket.io-client@1.7.4 › engine.io-client@1.8.6 › debug@2.3.3 › ms@0.7.2Remediation: Open PR to patch ms@0.7.2.
…and 9 more
Overview
ms
is a tiny millisecond conversion utility.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms()
function.
Proof of concept
ms = require('ms');
ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s
Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.
For more information on Regular Expression Denial of Service (ReDoS)
attacks, go to our blog.
Disclosure Timeline
- Feb 9th, 2017 - Reported the issue to package owner.
- Feb 11th, 2017 - Issue acknowledged by package owner.
- April 12th, 2017 - Fix PR opened by Snyk Security Team.
- May 15th, 2017 - Vulnerability published.
- May 16th, 2017 - Issue fixed and version
2.0.0
released. - May 21th, 2017 - Patches released for versions
>=0.7.1, <=1.0.0
.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ms
to version 2.0.0 or higher.
References
low severity
- Vulnerable module: tar
- Introduced through: mosca@2.8.3
Detailed paths
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-gyp@3.8.0 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › leveldown@1.4.6 › prebuild@4.5.0 › node-ninja@1.0.2 › tar@2.2.2
-
Introduced through: csweb-sim@tnocs/csweb-sim#0c9275c8093540a680ac73b77785af479d0a559f › mosca@2.8.3 › ascoltatori@3.2.0 › kafka-node@0.5.9 › snappy@5.0.5 › node-gyp@3.4.0 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). When stripping the trailing slash from files
arguments, the f.replace(/\/+$/, '')
performance of this function can exponentially degrade when f
contains many /
characters resulting in ReDoS.
This vulnerability is not likely to be exploitable as it requires that the untrusted input is being passed into the tar.extract()
or tar.list()
array of entries to parse/extract, which would be unusual.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade tar
to version 6.1.4, 5.0.8, 4.4.16 or higher.