Vulnerabilities

79 via 338 paths

Dependencies

627

Source

GitHub

Commit

a37ee345

Find, fix and prevent vulnerabilities in your code.

Issue type
  • 79
  • 1
Severity
  • 2
  • 32
  • 36
  • 10
Status
  • 80
  • 0
  • 0

critical severity

Predictable Value Range from Previous Values

  • Vulnerable module: form-data
  • Introduced through: juice@1.5.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 web-resource-inliner@1.1.4 request@2.88.2 form-data@2.3.3
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 request@2.88.2 form-data@2.3.3
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 request@2.88.2 form-data@2.3.3
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 npm-registry-client@7.2.1 request@2.88.2 form-data@2.3.3
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 form-data@0.2.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 form-data@0.2.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 form-data@2.1.4
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 form-data@1.0.1

Overview

Affected versions of this package are vulnerable to Predictable Value Range from Previous Values via the boundary value, which uses Math.random(). An attacker can manipulate HTTP request boundaries by exploiting predictable values, potentially leading to HTTP parameter pollution.

Remediation

Upgrade form-data to version 2.5.4, 3.0.4, 4.0.4 or higher.

References

critical severity

Authentication Bypass

  • Vulnerable module: hawk
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 hawk@3.1.3
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 hawk@3.1.3

Overview

hawk is a library for the HTTP Hawk Authentication Scheme.

Affected versions of this package are vulnerable to Authentication Bypass. The incoming (client supplied) hash of the payload is trusted by the server and not verified before the signature is calculated.

A malicious actor in the middle can alter the payload and the server side will not identify the modification occurred because it simply uses the client provided value instead of verify the hash provided against the modified payload.

According to the maintainers this issue is to be considered out of scope as "payload hash validation is optional and up to developer to implement".

Remediation

There is no fixed version for hawk.

References

high severity

Arbitrary File Write

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.

This logic was insufficient when extracting tar files that contained both a directory and a symlink with the same name as the directory, where the symlink and directory names in the archive entry used backslashes as a path separator on posix systems. The cache checking logic used both \ and / characters as path separators. However, \ is a valid filename character on posix systems.

By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location. This can lead to extracting arbitrary files into that location, thus allowing arbitrary file creation and overwrite.

Additionally, a similar confusion could arise on case-insensitive filesystems. If a tar archive contained a directory at FOO, followed by a symbolic link named foo, then on case-insensitive file systems, the creation of the symbolic link would remove the directory from the filesystem, but not from the internal directory cache, as it would not be treated as a cache hit. A subsequent file entry within the FOO directory would then be placed in the target of the symbolic link, thinking that the directory had already been created.

Remediation

Upgrade tar to version 6.1.7, 5.0.8, 4.4.16 or higher.

References

high severity

Arbitrary File Write

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.

This logic is insufficient when extracting tar files that contain two directories and a symlink with names containing unicode values that normalized to the same value. Additionally, on Windows systems, long path portions would resolve to the same file system entities as their 8.3 "short path" counterparts. A specially crafted tar archive can include directories with two forms of the path that resolve to the same file system entity, followed by a symbolic link with a name in the first form, lastly followed by a file using the second form. This leads to bypassing node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and extracting arbitrary files into that location.

Remediation

Upgrade tar to version 6.1.9, 5.0.10, 4.4.18 or higher.

References

high severity

Arbitrary File Write

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be outside of the extraction target directory is not extracted. This is, in part, accomplished by sanitizing absolute paths of entries within the archive, skipping archive entries that contain .. path portions, and resolving the sanitized paths against the extraction target directory.

This logic is insufficient on Windows systems when extracting tar files that contain a path that is not an absolute path, but specify a drive letter different from the extraction target, such as C:some\path. If the drive letter does not match the extraction target, for example D:\extraction\dir, then the result of path.resolve(extractionDirectory, entryPath) resolves against the current working directory on the C: drive, rather than the extraction target directory.

Additionally, a .. portion of the path can occur immediately after the drive letter, such as C:../foo, and is not properly sanitized by the logic that checks for .. within the normalized and split portions of the path.

Note: This only affects users of node-tar on Windows systems.

Remediation

Upgrade tar to version 6.1.9, 5.0.10, 4.4.18 or higher.

References

high severity

Asymmetric Resource Consumption (Amplification)

  • Vulnerable module: body-parser
  • Introduced through: tiny-lr@0.2.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 body-parser@1.14.2
    Remediation: Upgrade to tiny-lr@1.0.0.

Overview

Affected versions of this package are vulnerable to Asymmetric Resource Consumption (Amplification) via the extendedparser and urlencoded functions when the URL encoding process is enabled. An attacker can flood the server with a large number of specially crafted requests.

Remediation

Upgrade body-parser to version 1.20.3 or higher.

References

high severity

Arbitrary File Overwrite

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient symlink protection. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.

This logic is insufficient when extracting tar files that contain both a directory and a symlink with the same name as the directory. This order of operations results in the directory being created and added to the node-tar directory cache. When a directory is present in the directory cache, subsequent calls to mkdir for that directory are skipped. However, this is also where node-tar checks for symlinks occur. By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and subsequently extracting arbitrary files into that location.

Remediation

Upgrade tar to version 3.2.3, 4.4.15, 5.0.7, 6.1.2 or higher.

References

high severity

Arbitrary File Overwrite

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient absolute path sanitization.

node-tar aims to prevent extraction of absolute file paths by turning absolute paths into relative paths when the preservePaths flag is not set to true. This is achieved by stripping the absolute path root from any absolute file paths contained in a tar file. For example, the path /home/user/.bashrc would turn into home/user/.bashrc.

This logic is insufficient when file paths contain repeated path roots such as ////home/user/.bashrc. node-tar only strips a single path root from such paths. When given an absolute file path with repeating path roots, the resulting path (e.g. ///home/user/.bashrc) still resolves to an absolute path.

Remediation

Upgrade tar to version 3.2.2, 4.4.14, 5.0.6, 6.1.1 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: ajv
  • Introduced through: npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 har-validator@4.2.1 ajv@4.11.8
    Remediation: Upgrade to npmi@3.0.0.

Overview

ajv is an Another JSON Schema Validator

Affected versions of this package are vulnerable to Prototype Pollution. A carefully crafted JSON schema could be provided that allows execution of other code by prototype pollution. (While untrusted schemas are recommended against, the worst case of an untrusted schema should be a denial of service, not execution of code.)

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade ajv to version 6.12.3 or higher.

References

high severity

Arbitrary File Overwrite

  • Vulnerable module: npm
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
    Remediation: Upgrade to npm@6.13.4.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12
    Remediation: Upgrade to npmi@4.0.0.

Overview

npm is a package manager for JavaScript.

Affected versions of this package are vulnerable to Arbitrary File Overwrite. It fails to prevent existing globally-installed binaries to be overwritten by other package installations. For example, if a package was installed globally and created a serve binary, any subsequent installs of packages that also create a serve binary would overwrite the first binary. This only affects files in /usr/local/bin.

For npm, this behaviour is still allowed in local installations and also through install scripts. This vulnerability bypasses a user using the --ignore-scripts install option.

Details

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

  • Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

  • Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade npm to version 6.13.4 or higher.

References

high severity

Arbitrary File Write

  • Vulnerable module: npm
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
    Remediation: Upgrade to npm@6.13.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12
    Remediation: Upgrade to npmi@4.0.0.

Overview

npm is a package manager for JavaScript.

Affected versions of this package are vulnerable to Arbitrary File Write. It fails to prevent access to folders outside of the intended node_modules folder through the bin field.

For npm, a properly constructed entry in the package.json bin field would allow a package publisher to modify and/or gain access to arbitrary files on a user’s system when the package is installed. This behaviour is possible through install scripts. This vulnerability bypasses a user using the --ignore-scripts install option.

Details

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

  • Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

  • Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade npm to version 6.13.3 or higher.

References

high severity

Arbitrary File Overwrite

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@2.14.2.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@2.14.13.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Arbitrary File Overwrite. Extracting tarballs containing a hard-link to a file that already exists in the system, and a file that matches the hard-link may overwrite system's files with the contents of the extracted file.

Remediation

Upgrade tar to version 2.2.2, 4.4.2 or higher.

References

high severity

Arbitrary Code Injection

  • Vulnerable module: xmlhttprequest
  • Introduced through: gitbook-parsers@0.8.9

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 asciidoctor.js@1.5.3-preview.1 xmlhttprequest@1.6.0

Overview

xmlhttprequest is a wrapper for the built-in http client to emulate the browser XMLHttpRequest object.

Affected versions of this package are vulnerable to Arbitrary Code Injection. Provided requests are sent synchronously (async=False on xhr.open), malicious user input flowing into xhr.send could result in arbitrary code being injected and run.

POC

const { XMLHttpRequest } = require("xmlhttprequest")

const xhr = new XMLHttpRequest()
xhr.open("POST", "http://localhost.invalid/", false /* use synchronize request */)
xhr.send("\\');require(\"fs\").writeFileSync(\"/tmp/aaaaa.txt\", \"poc-20210306\");req.end();//")

Remediation

Upgrade xmlhttprequest to version 1.7.0 or higher.

References

high severity

Uninitialized Memory Exposure

  • Vulnerable module: bl
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 bl@0.9.5
    Remediation: Upgrade to request@2.76.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 bl@0.9.5
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 bl@1.1.2
    Remediation: Upgrade to npmi@2.0.1.

Overview

bl is a library that allows you to collect buffers and access with a standard readable buffer interface.

Affected versions of this package are vulnerable to Uninitialized Memory Exposure. If user input ends up in consume() argument and can become negative, BufferList state can be corrupted, tricking it into exposing uninitialized memory via regular .slice() calls.

PoC by chalker

const { BufferList } = require('bl')
const secret = require('crypto').randomBytes(256)
for (let i = 0; i < 1e6; i++) {
  const clone = Buffer.from(secret)
  const bl = new BufferList()
  bl.append(Buffer.from('a'))
  bl.consume(-1024)
  const buf = bl.slice(1)
  if (buf.indexOf(clone) !== -1) {
    console.error(`Match (at ${i})`, buf)
  }
}

Remediation

Upgrade bl to version 2.2.1, 3.0.1, 4.0.3, 1.2.3 or higher.

References

high severity

Excessive Platform Resource Consumption within a Loop

  • Vulnerable module: braces
  • Introduced through: chokidar@1.0.6 and nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 chokidar@1.0.6 anymatch@1.3.2 micromatch@2.3.11 braces@1.8.5
    Remediation: Upgrade to chokidar@4.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 anymatch@1.3.2 micromatch@2.3.11 braces@1.8.5
    Remediation: Upgrade to nunjucks@3.2.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10 braces@2.3.2

Overview

braces is a Bash-like brace expansion, implemented in JavaScript.

Affected versions of this package are vulnerable to Excessive Platform Resource Consumption within a Loop due improper limitation of the number of characters it can handle, through the parse function. An attacker can cause the application to allocate excessive memory and potentially crash by sending imbalanced braces as input.

PoC

const { braces } = require('micromatch');

console.log("Executing payloads...");

const maxRepeats = 10;

for (let repeats = 1; repeats <= maxRepeats; repeats += 1) {
  const payload = '{'.repeat(repeats*90000);

  console.log(`Testing with ${repeats} repeats...`);
  const startTime = Date.now();
  braces(payload);
  const endTime = Date.now();
  const executionTime = endTime - startTime;
  console.log(`Regex executed in ${executionTime / 1000}s.\n`);
} 

Remediation

Upgrade braces to version 3.0.3 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: fresh
  • Introduced through: send@0.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 send@0.2.0 fresh@0.2.4
    Remediation: Upgrade to send@0.15.5.

Overview

fresh is HTTP response freshness testing.

Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS) attacks. A Regular Expression (/ *, */) was used for parsing HTTP headers and take about 2 seconds matching time for 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade fresh to version 0.5.2 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.17.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution through the zipObjectDeep function due to improper user input sanitization in the baseZipObject function.

PoC

lodash.zipobjectdeep:

const zipObjectDeep = require("lodash.zipobjectdeep");

let emptyObject = {};


console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined

zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function

console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true

lodash:

const test = require("lodash");

let emptyObject = {};


console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined

test.zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function

console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.17 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: minimatch
  • Introduced through: chokidar@1.0.6, fstream-ignore@1.0.2 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 chokidar@1.0.6 readdirp@1.4.0 minimatch@0.2.14
    Remediation: Upgrade to chokidar@1.1.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 fstream-ignore@1.0.2 minimatch@2.0.10
    Remediation: Upgrade to fstream-ignore@1.0.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 minimatch@2.0.10
    Remediation: Upgrade to npm@2.14.9.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 glob@4.3.5 minimatch@2.0.10
    Remediation: Upgrade to npm@2.7.4.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.7.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.15.9.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-package-json@1.2.7 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 minimatch@1.0.0
    Remediation: Upgrade to npm@2.15.9.

Overview

minimatch is a minimal matching utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via complicated and illegal regexes.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade minimatch to version 3.0.2 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: minimatch
  • Introduced through: chokidar@1.0.6, fstream-ignore@1.0.2 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 chokidar@1.0.6 readdirp@1.4.0 minimatch@0.2.14
    Remediation: Upgrade to chokidar@1.1.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 fstream-ignore@1.0.2 minimatch@2.0.10
    Remediation: Upgrade to fstream-ignore@1.0.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 minimatch@2.0.10
    Remediation: Upgrade to npm@2.14.9.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 glob@4.3.5 minimatch@2.0.10
    Remediation: Upgrade to npm@2.7.4.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.7.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.15.9.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-package-json@1.2.7 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 minimatch@1.0.0
    Remediation: Upgrade to npm@2.15.9.

Overview

minimatch is a minimal matching utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS).

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade minimatch to version 3.0.2 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: npm-user-validate
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-user-validate@0.1.5
    Remediation: Upgrade to npm@5.0.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 npm-user-validate@0.1.5
    Remediation: Upgrade to npmi@3.0.0.

Overview

npm-user-validate is an User validations for npm

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The regex that validates user emails took exponentially longer to process long input strings beginning with @ characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade npm-user-validate to version 1.0.1 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: nth-check
  • Introduced through: cheerio@0.19.0, juice@1.5.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 css-select@1.0.0 nth-check@1.0.2
    Remediation: Upgrade to cheerio@1.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 css-select@1.0.0 nth-check@1.0.2
    Remediation: Upgrade to juice@7.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 css-select@1.0.0 nth-check@1.0.2
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 css-select@1.0.0 nth-check@1.0.2

Overview

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) when parsing crafted invalid CSS nth-checks, due to the sub-pattern \s*(?:([+-]?)\s*(\d+))? in RE_NTH_ELEMENT with quantified overlapping adjacency.

PoC

var nthCheck = require("nth-check")
for(var i = 1; i <= 50000; i++) {
    var time = Date.now();
    var attack_str = '2n' + ' '.repeat(i*10000)+"!";
    try {
        nthCheck.parse(attack_str) 
    }
    catch(err) {
        var time_cost = Date.now() - time;
        console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
    }
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade nth-check to version 2.0.1 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: nunjucks
  • Introduced through: nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0
    Remediation: Upgrade to nunjucks@3.2.3.

Overview

nunjucks is a powerful templating engine with inheritance, asynchronous control, and more (jinja2 inspired).

Affected versions of this package are vulnerable to Prototype Pollution. via the constructor class in nunjucks/src/runtime.js.

Remediation

Upgrade nunjucks to version 3.2.3 or higher.

References

high severity

Prototype Override Protection Bypass

  • Vulnerable module: qs
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 qs@2.3.3
    Remediation: Upgrade to request@2.68.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 qs@2.3.3
    Remediation: Upgrade to npm@2.14.18.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 body-parser@1.14.2 qs@5.2.0
    Remediation: Upgrade to tiny-lr@1.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 qs@5.1.0
    Remediation: Upgrade to tiny-lr@1.0.0.

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

Affected versions of this package are vulnerable to Prototype Override Protection Bypass. By default qs protects against attacks that attempt to overwrite an object's existing prototype properties, such as toString(), hasOwnProperty(),etc.

From qs documentation:

By default parameters that would overwrite properties on the object prototype are ignored, if you wish to keep the data from those fields either use plainObjects as mentioned above, or set allowPrototypes to true which will allow user input to overwrite those properties. WARNING It is generally a bad idea to enable this option as it can cause problems when attempting to use the properties that have been overwritten. Always be careful with this option.

Overwriting these properties can impact application logic, potentially allowing attackers to work around security controls, modify data, make the application unstable and more.

In versions of the package affected by this vulnerability, it is possible to circumvent this protection and overwrite prototype properties and functions by prefixing the name of the parameter with [ or ]. e.g. qs.parse("]=toString") will return {toString = true}, as a result, calling toString() on the object will throw an exception.

Example:

qs.parse('toString=foo', { allowPrototypes: false })
// {}

qs.parse("]=toString", { allowPrototypes: false })
// {toString = true} <== prototype overwritten

For more information, you can check out our blog.

Disclosure Timeline

  • February 13th, 2017 - Reported the issue to package owner.
  • February 13th, 2017 - Issue acknowledged by package owner.
  • February 16th, 2017 - Partial fix released in versions 6.0.3, 6.1.1, 6.2.2, 6.3.1.
  • March 6th, 2017 - Final fix released in versions 6.4.0,6.3.2, 6.2.3, 6.1.2 and 6.0.4

Remediation

Upgrade qs to version 6.0.4, 6.1.2, 6.2.3, 6.3.2 or higher.

References

high severity

Prototype Poisoning

  • Vulnerable module: qs
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 qs@2.3.3
    Remediation: Upgrade to request@2.73.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 qs@2.3.3
    Remediation: Upgrade to npm@2.15.10.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 body-parser@1.14.2 qs@5.2.0
    Remediation: Upgrade to tiny-lr@1.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 qs@5.1.0
    Remediation: Upgrade to tiny-lr@1.0.0.

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

Affected versions of this package are vulnerable to Prototype Poisoning which allows attackers to cause a Node process to hang, processing an Array object whose prototype has been replaced by one with an excessive length value.

Note: In many typical Express use cases, an unauthenticated remote attacker can place the attack payload in the query string of the URL that is used to visit the application, such as a[__proto__]=b&a[__proto__]&a[length]=100000000.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.

Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.

One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.

When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.

Two common types of DoS vulnerabilities:

  • High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.

  • Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm ws package

Remediation

Upgrade qs to version 6.2.4, 6.3.3, 6.4.1, 6.5.3, 6.6.1, 6.7.3, 6.8.3, 6.9.7, 6.10.3 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver
  • Introduced through: npmi@0.1.1, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 semver@4.3.6
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 normalize-package-data@1.0.3 semver@4.3.6
    Remediation: Upgrade to npm@2.12.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 semver@4.3.6
    Remediation: Upgrade to npm@2.12.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 semver@4.3.6
    Remediation: Upgrade to npm@2.14.4.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-package-arg@2.1.3 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 semver@4.3.6
    Remediation: Upgrade to npm@2.13.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-installed@3.1.5 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 normalize-package-data@1.0.3 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-package-json@1.2.7 normalize-package-data@1.0.3 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 realize-package-specifier@1.3.0 npm-package-arg@2.1.3 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 npm-package-arg@3.1.1 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 read-package-json@1.3.3 normalize-package-data@1.0.3 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-installed@3.1.5 read-package-json@1.3.3 normalize-package-data@1.0.3 semver@4.3.6
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 semver@4.2.2
    Remediation: Upgrade to npm@5.7.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 semver@5.3.0
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 semver@5.1.1
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 semver@5.0.1
    Remediation: Upgrade to semver@5.7.2.

Overview

semver is a semantic version parser used by npm.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

PoC


const semver = require('semver')
const lengths_2 = [2000, 4000, 8000, 16000, 32000, 64000, 128000]

console.log("n[+] Valid range - Test payloads")
for (let i = 0; i =1.2.3' + ' '.repeat(lengths_2[i]) + '<1.3.0';
const start = Date.now()
semver.validRange(value)
// semver.minVersion(value)
// semver.maxSatisfying(["1.2.3"], value)
// semver.minSatisfying(["1.2.3"], value)
// new semver.Range(value, {})

const end = Date.now();
console.log('length=%d, time=%d ms', value.length, end - start);
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver to version 5.7.2, 6.3.1, 7.5.2 or higher.

References

high severity

Symlink File Overwrite

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@2.7.5.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@2.14.13.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Symlink File Overwrite. It does not properly normalize symbolic links pointing to targets outside the extraction root. As a result, packages may hold symbolic links to parent and sibling directories and overwrite those files when the package is extracted.

Remediation

Upgrade tar to version 2.0.0 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: unset-value
  • Introduced through: nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10 braces@2.3.2 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10 extglob@2.0.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10 nanomatch@1.2.13 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10 extglob@2.0.4 expand-brackets@2.1.4 snapdragon@0.8.2 base@0.11.2 cache-base@1.0.1 unset-value@1.0.0

Overview

Affected versions of this package are vulnerable to Prototype Pollution via the unset function in index.js, because it allows access to object prototype properties.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade unset-value to version 2.0.1 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: hawk
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1
    Remediation: Upgrade to request@2.87.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 hawk@3.1.3
    Remediation: Upgrade to npmi@2.0.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 hawk@3.1.3
    Remediation: Upgrade to npmi@3.0.0.

Overview

hawk is a library for the HTTP Hawk Authentication Scheme.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in header parsing where each added character in the attacker's input increases the computation time exponentially.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade hawk to version 9.0.1 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.12.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The function defaultsDeep could be tricked into adding or modifying properties of Object.prototype using a constructor payload.

PoC by Snyk

const mergeFn = require('lodash').defaultsDeep;
const payload = '{"constructor": {"prototype": {"a0": true}}}'

function check() {
    mergeFn({}, JSON.parse(payload));
    if (({})[`a0`] === true) {
        console.log(`Vulnerable to Prototype Pollution via ${payload}`);
    }
  }

check();

For more information, check out our blog post

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.12 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.17.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution via the set and setwith functions due to improper user input sanitization.

PoC

lod = require('lodash')
lod.set({}, "__proto__[test2]", "456")
console.log(Object.prototype)

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.17 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.11.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The functions merge, mergeWith, and defaultsDeep could be tricked into adding or modifying properties of Object.prototype. This is due to an incomplete fix to CVE-2018-3721.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.11 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.7.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Prototype Pollution via parseQuery().

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade urijs to version 1.19.7 or higher.

References

high severity

Code Injection

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.21.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Code Injection via template.

PoC

var _ = require('lodash');

_.template('', { variable: '){console.log(process.env)}; with(obj' })()

Remediation

Upgrade lodash to version 4.17.21 or higher.

References

high severity

Cross-site Scripting (XSS)

  • Vulnerable module: nunjucks
  • Introduced through: nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0
    Remediation: Upgrade to nunjucks@2.4.3.

Overview

nunjucks is a powerful templating engine.

Like many templating engines, it automatically HTML encodes any string value included in the template using the {{ some-variable }} notation. These variables are often user-generated, but the HTML Encoding protects the application from Cross-site Scripting (XSS) attacks.

However, if the variable passed in is an array, no HTML encoding is applied, exposing an easy path to XSS. The risk of exploit is especially high given the fact express, koa and many other Node.js servers allow users to force a query parameter to be an array using the param[]=value notation.

Details

The issue opened by Matt Austin explains the vulnerability very well:

The following string works as expected:

var res = nunjucks.renderString('Hello {{ username }}', { username: '<s>Matt</s>' });
console.log(res); //Hello &lt;s&gt;Matt&lt;/s&gt;

If however the variable passed to the template is an array autoescape does nothing:

var res = nunjucks.renderString('Hello {{ username }}', { username: ['<s>Matt</s>'] });
console.log(res); // Hello <s>Matt</s>

...

In express / Koa / (anything else using qs or body-parser) is is trivial to coerce query params types. See the following simple example in express:

var app = express();
var env = nunjucks.configure('views', {
    autoescape: true,
    express: app
});
app.get('/', function(req, res) {     
    // This should be fine autoescape is on...
    res.send(nunjucks.renderString('Hello {{ username }}', { username: req.query.name }));
    //res.render('index.html', { username: req.query.name });
});

Attack URL: http://127.0.0.1:3000/?name[]=<script>alert(1)</script>matt

A more complete proof of concept (POC) can be found here: https://github.com/matt-/nunjucks_test

Details

<>

Remediation

Upgrade to nunjucks version 2.4.3 or newer.

References

medium severity

npm Token Leak

  • Vulnerable module: npm
  • Introduced through: npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
    Remediation: Upgrade to npm@2.15.1.

Overview

This vulnerability could cause the unintentional leakage of bearer tokens. A design flaw in npm's registry allows an attacker to set up an HTTP server that could collect authentication information, and then use this authentication information to impersonate the users whose tokens they collected. The attacker could do anything the compromised users could do, including publishing new versions of packages.

Details

The primary npm registry has, since late 2014, used HTTP bearer tokens to authenticate requests from the npm command-line interface. Due to a design flaw in the CLI, these bearer tokens were sent with every request made by logged-in users, regardless of the destination of the request. (The bearers only should have been included for requests made against a registry or registries used for the current install.)

This flaw allows an attacker to set up an HTTP server that could collect authentication information. They could then use this information to impersonate the users whose tokens they collected. This impersonation would allow them to do anything the compromised users could do, including publishing new versions of packages.

With the fixes npm have released, the CLI will only send bearer tokens with requests made against a registry. npm’s CLI team believe that the fix won’t break any existing registry setups. However, it’s possible the change will be breaking in some cases, due to the large number of registry software suites used.

Remediation

  1. Upgrade npm to ">= 3.8.3 || >= 2.15.1"
  2. Invalidate your current npm bearer tokens

References

medium severity

Symlink Attack

  • Vulnerable module: tmp
  • Introduced through: tmp@0.0.24 and gitbook-parsers@0.8.9

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tmp@0.0.24
    Remediation: Upgrade to tmp@0.2.4.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 tmp@0.0.24

Overview

Affected versions of this package are vulnerable to Symlink Attack via the dir parameter. An attacker can cause files or directories to be written to arbitrary locations by supplying a crafted symbolic link that resolves outside the intended temporary directory.

PoC

const tmp = require('tmp');

const tmpobj = tmp.fileSync({ 'dir': 'evil-dir'});
console.log('File: ', tmpobj.name);

try {
    tmp.fileSync({ 'dir': 'mydir1'});
} catch (err) {
    console.log('test 1:', err.message)
}

try {
    tmp.fileSync({ 'dir': '/foo'});
} catch (err) {
    console.log('test 2:', err.message)
}

try {
    const fs = require('node:fs');
    const resolved = fs.realpathSync('/tmp/evil-dir');
    tmp.fileSync({ 'dir': resolved});
} catch (err) {
    console.log('test 3:', err.message)
}

Remediation

Upgrade tmp to version 0.2.4 or higher.

References

medium severity

Timing Attack

  • Vulnerable module: http-signature
  • Introduced through: request@2.51.0 and npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 http-signature@0.10.1
    Remediation: Upgrade to request@2.66.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 http-signature@0.10.1
    Remediation: Upgrade to npm@2.14.15.

Overview

http-signature is a reference implementation of Joyent's HTTP Signature scheme.

Affected versions of the package are vulnerable to Timing Attacks due to time-variable comparison of signatures.

The library implemented a character to character comparison, similar to the built-in string comparison mechanism, ===, and not a time constant string comparison. As a result, the comparison will fail faster when the first characters in the signature are incorrect. An attacker can use this difference to perform a timing attack, essentially allowing them to guess the signature one character at a time.

You can read more about timing attacks in Node.js on the Snyk blog.

Remediation

Upgrade http-signature to version 1.0.0 or higher.

References

medium severity

Server-side Request Forgery (SSRF)

  • Vulnerable module: request
  • Introduced through: juice@1.5.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 web-resource-inliner@1.1.4 request@2.88.2
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 request@2.88.2
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 request@2.88.2
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 npm-registry-client@7.2.1 request@2.88.2
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0

Overview

request is a simplified http request client.

Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) due to insufficient checks in the lib/redirect.js file by allowing insecure redirects in the default configuration, via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).

NOTE: request package has been deprecated, so a fix is not expected. See https://github.com/request/request/issues/3142.

Remediation

A fix was pushed into the master branch but not yet published.

References

medium severity

Uncontrolled Resource Consumption ('Resource Exhaustion')

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@7.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@4.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Uncontrolled Resource Consumption ('Resource Exhaustion') due to the lack of folders count validation during the folder creation process. An attacker who generates a large number of sub-folders can consume memory on the system running the software and even crash the client within few seconds of running it using a path with too many sub-folders inside.

Remediation

Upgrade tar to version 6.2.1 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: tough-cookie
  • Introduced through: juice@1.5.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 web-resource-inliner@1.1.4 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 npm-registry-client@7.2.1 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 tough-cookie@2.3.4
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 tough-cookie@2.3.4

Overview

tough-cookie is a RFC6265 Cookies and CookieJar module for Node.js.

Affected versions of this package are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. Due to an issue with the manner in which the objects are initialized, an attacker can expose or modify a limited amount of property information on those objects. There is no impact to availability.

PoC

// PoC.js
async function main(){
var tough = require("tough-cookie");
var cookiejar = new tough.CookieJar(undefined,{rejectPublicSuffixes:false});
// Exploit cookie
await cookiejar.setCookie(
  "Slonser=polluted; Domain=__proto__; Path=/notauth",
  "https://__proto__/admin"
);
// normal cookie
var cookie = await cookiejar.setCookie(
  "Auth=Lol; Domain=google.com; Path=/notauth",
  "https://google.com/"
);

//Exploit cookie
var a = {};
console.log(a["/notauth"]["Slonser"])
}
main();

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade tough-cookie to version 4.1.3 or higher.

References

medium severity

Improper Input Validation

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.4.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Improper Input Validation. The hostname could be spoofed by using a backslash (`)character followed by an at(@)` character.

Remediation

Upgrade urijs to version 1.19.4 or higher.

References

medium severity

Misinterpretation of Input

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.11.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Misinterpretation of Input when parsing a URL without a scheme and with excessive slashes.

Remediation

Upgrade urijs to version 1.19.11 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: hoek
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1 hoek@0.9.1
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1 boom@0.4.2 hoek@0.9.1
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1 sntp@0.2.4 hoek@0.9.1
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1 hoek@0.9.1
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1 cryptiles@0.2.2 boom@0.4.2 hoek@0.9.1
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1 boom@0.4.2 hoek@0.9.1
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1 sntp@0.2.4 hoek@0.9.1
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1 cryptiles@0.2.2 boom@0.4.2 hoek@0.9.1
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Upgrade to npmi@2.0.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to npmi@2.0.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Upgrade to npmi@2.0.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to npmi@2.0.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 request@2.81.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to npmi@3.0.0.

Overview

hoek is an Utility methods for the hapi ecosystem.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var Hoek = require('hoek');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
Hoek.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade hoek to version 4.2.1, 5.0.3 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.5.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
    Remediation: Open PR to patch lodash@3.10.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var _= require('lodash');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
_.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.5 or higher.

References

medium severity

Missing Release of Resource after Effective Lifetime

  • Vulnerable module: inflight
  • Introduced through: npm@2.4.1, npmi@0.1.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 glob@4.3.5 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 fs-extra@0.16.5 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 glob@4.5.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 glob@4.5.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-package-json@1.2.7 glob@4.5.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 glob@7.0.6 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 fstream-ignore@1.0.2 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 fs-vacuum@1.2.10 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 init-package-json@1.9.6 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 read-package-json@2.0.13 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 rimraf@2.5.4 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 read-package-json@1.3.3 glob@5.0.15 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-installed@3.1.5 read-package-json@1.3.3 glob@5.0.15 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 fs-vacuum@1.2.10 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 init-package-json@1.9.6 read-package-json@2.1.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 read-installed@4.0.3 read-package-json@2.1.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 fstream-npm@1.0.7 fstream-ignore@1.0.5 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 fstream-npm@1.1.1 fstream-ignore@1.0.5 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2 fstream@1.0.12 rimraf@2.7.1 glob@7.2.3 inflight@1.0.6

Overview

Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.

Exploiting this vulnerability results in crashing the node process or in the application crash.

Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.

To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.

PoC

const inflight = require('inflight');

function testInflight() {
  let i = 0;
  function scheduleNext() {
    let key = `key-${i++}`;
    const callback = () => {
    };
    for (let j = 0; j < 1000000; j++) {
      inflight(key, callback);
    }

    setImmediate(scheduleNext);
  }


  if (i % 100 === 0) {
    console.log(process.memoryUsage());
  }

  scheduleNext();
}

testInflight();

Remediation

There is no fixed version for inflight.

References

medium severity

Cross-site Scripting (XSS)

  • Vulnerable module: nunjucks
  • Introduced through: nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0
    Remediation: Upgrade to nunjucks@3.2.4.

Overview

nunjucks is a powerful templating engine with inheritance, asynchronous control, and more (jinja2 inspired).

Affected versions of this package are vulnerable to Cross-site Scripting (XSS) in the second parameter, when more than one user-controlled parameter is used on the same line in a view. Autoescaping can be bypassed by including a \ in the user input string.

PoC

https://<application-url>/?lang=jp\&place=};alert(document.domain)//

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade nunjucks to version 3.2.4 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: highlight.js
  • Introduced through: gitbook-plugin-highlight@1.0.3

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-highlight@1.0.3 highlight.js@8.8.0

Overview

highlight.js is a syntax highlighter written in JavaScript. It works in the browser as well as on the server. It works with pretty much any markup, doesn’t depend on any framework, and has automatic language detection.

Affected versions of this package are vulnerable to Prototype Pollution. A malicious HTML code block can be crafted that will result in prototype pollution of the base object's prototype during highlighting. If you allow users to insert custom HTML code blocks into your page/app via parsing Markdown code blocks (or similar) and do not filter the language names the user can provide you may be vulnerable.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade highlight.js to version 9.18.2, 10.1.2 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: minimist
  • Introduced through: nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 optimist@0.6.1 minimist@0.0.10

Overview

minimist is a parse argument options module.

Affected versions of this package are vulnerable to Prototype Pollution. The library could be tricked into adding or modifying properties of Object.prototype using a constructor or __proto__ payload.

PoC by Snyk

require('minimist')('--__proto__.injected0 value0'.split(' '));
console.log(({}).injected0 === 'value0'); // true

require('minimist')('--constructor.prototype.injected1 value1'.split(' '));
console.log(({}).injected1 === 'value1'); // true

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade minimist to version 0.2.1, 1.2.3 or higher.

References

medium severity

Cross-site Scripting (XSS)

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.11.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Cross-site Scripting (XSS) due to improper sanitization in the URI.parse() function, which makes it possible to use \r, \n\, and \t characters.

PoC:

const parse = require('urijs')
const express = require('express')
const app = express()
const port = 3000

input = "ja\r\nvascript:alert(1)"
url = parse(input)

console.log(url)

app.get('/', (req, res) => {
  if (url.protocol !== "javascript:") {res.send("<a href=\'" + input + "\'>CLICK ME!</a>")}
})

app.listen(port, () => {
  console.log(`Example app listening on port ${port}`)
})

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade urijs to version 1.19.11 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: css-what
  • Introduced through: cheerio@0.19.0, juice@1.5.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 css-select@1.0.0 css-what@1.0.0
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 css-select@1.0.0 css-what@1.0.0
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 css-select@1.0.0 css-what@1.0.0
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 css-select@1.0.0 css-what@1.0.0

Overview

css-what is an a CSS selector parser

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to the usage of insecure regular expression in the re_attr variable of index.js. The exploitation of this vulnerability could be triggered via the parse function.

PoC

const parse = require('css-what');
const payload = '\\=\\='.repeat(800000);
parse('[' + payload);

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade css-what to version 2.1.3 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: hosted-git-info
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 npm-package-arg@3.1.1 hosted-git-info@1.6.0
    Remediation: Upgrade to npm@2.8.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 hosted-git-info@2.1.5
    Remediation: Upgrade to npmi@3.0.0.

Overview

hosted-git-info is a Provides metadata and conversions from repository urls for Github, Bitbucket and Gitlab

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via regular expression shortcutMatch in the fromUrl function in index.js. The affected regular expression exhibits polynomial worst-case time complexity.

PoC by Yeting Li

var hostedGitInfo = require("hosted-git-info")
function build_attack(n) {
    var ret = "a:"
    for (var i = 0; i < n; i++) {
        ret += "a"
    }
    return ret + "!";
}

for(var i = 1; i <= 5000000; i++) {
   if (i % 1000 == 0) {
        var time = Date.now();
        var attack_str = build_attack(i)
       var parsedInfo = hostedGitInfo.fromUrl(attack_str)
        var time_cost = Date.now() - time;
        console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade hosted-git-info to version 3.0.8, 2.8.9 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.21.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the toNumber, trim and trimEnd functions.

POC

var lo = require('lodash');

function build_blank (n) {
var ret = "1"
for (var i = 0; i < n; i++) {
ret += " "
}

return ret + "1";
}

var s = build_blank(50000)
var time0 = Date.now();
lo.trim(s)
var time_cost0 = Date.now() - time0;
console.log("time_cost0: " + time_cost0)

var time1 = Date.now();
lo.toNumber(s)
var time_cost1 = Date.now() - time1;
console.log("time_cost1: " + time_cost1)

var time2 = Date.now();
lo.trimEnd(s)
var time_cost2 = Date.now() - time2;
console.log("time_cost2: " + time_cost2)

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade lodash to version 4.17.21 or higher.

References

medium severity

Inefficient Regular Expression Complexity

  • Vulnerable module: micromatch
  • Introduced through: chokidar@1.0.6 and nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 chokidar@1.0.6 anymatch@1.3.2 micromatch@2.3.11
    Remediation: Upgrade to chokidar@4.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 anymatch@1.3.2 micromatch@2.3.11
    Remediation: Upgrade to nunjucks@3.2.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 readdirp@2.2.1 micromatch@3.1.10

Overview

Affected versions of this package are vulnerable to Inefficient Regular Expression Complexity due to the use of unsafe pattern configurations that allow greedy matching through the micromatch.braces() function. An attacker can cause the application to hang or slow down by passing a malicious payload that triggers extensive backtracking in regular expression processing.

Remediation

Upgrade micromatch to version 4.0.8 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: minimatch
  • Introduced through: chokidar@1.0.6, fstream-ignore@1.0.2 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 chokidar@1.0.6 readdirp@1.4.0 minimatch@0.2.14
    Remediation: Upgrade to chokidar@1.1.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 fstream-ignore@1.0.2 minimatch@2.0.10
    Remediation: Upgrade to fstream-ignore@1.0.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 minimatch@2.0.10
    Remediation: Upgrade to npm@2.14.9.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 glob@4.3.5 minimatch@2.0.10
    Remediation: Upgrade to npm@2.7.4.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 init-package-json@1.2.0 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.7.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.15.9.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 read-package-json@1.2.7 glob@4.5.3 minimatch@2.0.10
    Remediation: Upgrade to npm@2.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 minimatch@1.0.0
    Remediation: Upgrade to npm@2.15.9.

Overview

minimatch is a minimal matching utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the braceExpand function in minimatch.js.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade minimatch to version 3.0.5 or higher.

References

medium severity

Access Restriction Bypass

  • Vulnerable module: npm
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
    Remediation: Upgrade to npm@5.7.1.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12
    Remediation: Upgrade to npmi@3.0.0.

Overview

npm is a package manager for JavaScript.

Affected versions of this package are vulnerable to Access Restriction Bypass. It might allow local users to bypass intended filesystem access restrictions due to ownerships of /etc and /usr directories are being changed unexpectedly, related to a "correctMkdir" issue.

Remediation

Upgrade npm to version 5.7.1 or higher.

References

medium severity

Insertion of Sensitive Information into Log File

  • Vulnerable module: npm
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
    Remediation: Upgrade to npm@6.14.6.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12
    Remediation: Upgrade to npmi@4.0.0.

Overview

npm is a package manager for JavaScript.

Affected versions of this package are vulnerable to Insertion of Sensitive Information into Log File. The CLI supports URLs like <protocol>://[<user>[:<password>]@]<hostname>[:<port>][:][/]<path>. The password value is not redacted and is printed to stdout and also to any generated log files.

Remediation

Upgrade npm to version 6.14.6 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver
  • Introduced through: npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 semver@4.2.2
    Remediation: Upgrade to npm@2.6.0.

Overview

semver is a semantic version parser used by npm.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The semver module uses regular expressions when parsing a version string. For a carefully crafted input, the time it takes to process these regular expressions is not linear to the length of the input. Since the semver module did not enforce a limit on the version string length, an attacker could provide a long string that would take up a large amount of resources, potentially taking a server down. This issue therefore enables a potential Denial of Service attack.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver to version 4.3.2 or higher.

References

medium severity

Root Path Disclosure

  • Vulnerable module: send
  • Introduced through: send@0.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 send@0.2.0
    Remediation: Upgrade to send@0.11.1.

Overview

Send is a library for streaming files from the file system as an http response. It supports partial responses (Ranges), conditional-GET negotiation, high test coverage, and granular events which may be leveraged to take appropriate actions in your application or framework.

Affected versions of this package are vulnerable to a Root Path Disclosure.

Remediation

Upgrade send to version 0.11.1 or higher. If a direct dependency update is not possible, use snyk wizard to patch this vulnerability.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: uglify-js
  • Introduced through: juice@1.5.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 web-resource-inliner@1.1.4 uglify-js@2.8.29
    Remediation: Upgrade to juice@3.0.0.

Overview

uglify-js is a JavaScript parser, minifier, compressor and beautifier toolkit.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the string_template and the decode_template functions.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade uglify-js to version 3.14.3 or higher.

References

medium severity

Improper Input Validation

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.6.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Improper Input Validation. It mishandles certain uses of backslash such as http:/ and interprets the URI as a relative path.

Remediation

Upgrade urijs to version 1.19.6 or higher.

References

medium severity

Improper Input Validation

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.9.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Improper Input Validation due to a possible bypass to the protocol validation, using leading whitespaces.

Remediation

Upgrade urijs to version 1.19.9 or higher.

References

medium severity

Open Redirect

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.7.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Open Redirect. It mishandles certain uses of backslash such as https:/\ and interprets the URI as a relative path. Browsers usually accept backslashes after the protocol, and treat it as a normal slash.

PoC

var URI = require('urijs');
var url = new URI("https:/\/\/\www.google.com");
console.log(url);  // Which will return -->  path: "/www.google.com"

Remediation

Upgrade urijs to version 1.19.7 or higher.

References

medium severity

Open Redirect

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.8.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Open Redirect. An attacker can use case-insensitive protocol schemes in order to bypass the patch to CVE-2021-3647.

Remediation

Upgrade urijs to version 1.19.8 or higher.

References

medium severity

Open Redirect

  • Vulnerable module: urijs
  • Introduced through: urijs@1.17.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 urijs@1.17.0
    Remediation: Upgrade to urijs@1.19.10.

Overview

urijs is a Javascript library for working with URLs.

Affected versions of this package are vulnerable to Open Redirect by bypassing the fix for CVE-2022-0613 an attacker is still able to redirect.

PoC

// PoC.js
var URI = require('urijs');
var url = new URI("https::\\\github.com/foo/bar");
console.log(url);

Remediation

Upgrade urijs to version 1.19.10 or higher.

References

medium severity

Remote Memory Exposure

  • Vulnerable module: request
  • Introduced through: request@2.51.0 and npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0
    Remediation: Upgrade to request@2.68.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0
    Remediation: Upgrade to npm@2.14.18.

Overview

request is a simplified http request client.

Affected versions of this package are vulnerable to Remote Memory Exposure. A potential remote memory exposure vulnerability exists in request. If a request uses a multipart attachment and the body type option is number with value X, then X bytes of uninitialized memory will be sent in the body of the request.

Note that while the impact of this vulnerability is high (memory exposure), exploiting it is likely difficult, as the attacker needs to somehow control the body type of the request. One potential exploit scenario is when a request is composed based on JSON input, including the body type, allowing a malicious JSON to trigger the memory leak.

Details

Constructing a Buffer class with integer N creates a Buffer of length N with non zero-ed out memory. Example:

var x = new Buffer(100); // uninitialized Buffer of length 100
// vs
var x = new Buffer('100'); // initialized Buffer with value of '100'

Initializing a multipart body in such manner will cause uninitialized memory to be sent in the body of the request.

Proof of concept

var http = require('http')
var request = require('request')

http.createServer(function (req, res) {
  var data = ''
  req.setEncoding('utf8')
  req.on('data', function (chunk) {
    console.log('data')
    data += chunk
  })
  req.on('end', function () {
    // this will print uninitialized memory from the client
    console.log('Client sent:\n', data)
  })
  res.end()
}).listen(8000)

request({
  method: 'POST',
  uri: 'http://localhost:8000',
  multipart: [{ body: 1000 }]
},
function (err, res, body) {
  if (err) return console.error('upload failed:', err)
  console.log('sent')
})

Remediation

Upgrade request to version 2.68.0 or higher.

References

medium severity

Uninitialized Memory Exposure

  • Vulnerable module: tunnel-agent
  • Introduced through: request@2.51.0, npm@2.4.1 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 tunnel-agent@0.4.3
    Remediation: Upgrade to request@2.81.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 tunnel-agent@0.4.3
    Remediation: Upgrade to npm@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 request@2.74.0 tunnel-agent@0.4.3
    Remediation: Upgrade to npmi@2.0.1.

Overview

tunnel-agent is HTTP proxy tunneling agent. Affected versions of the package are vulnerable to Uninitialized Memory Exposure.

A possible memory disclosure vulnerability exists when a value of type number is used to set the proxy.auth option of a request request and results in a possible uninitialized memory exposures in the request body.

This is a result of unobstructed use of the Buffer constructor, whose insecure default constructor increases the odds of memory leakage.

Details

Constructing a Buffer class with integer N creates a Buffer of length N with raw (not "zero-ed") memory.

In the following example, the first call would allocate 100 bytes of memory, while the second example will allocate the memory needed for the string "100":

// uninitialized Buffer of length 100
x = new Buffer(100);
// initialized Buffer with value of '100'
x = new Buffer('100');

tunnel-agent's request construction uses the default Buffer constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw server side memory, potentially holding secrets, private data and code. This is a similar vulnerability to the infamous Heartbleed flaw in OpenSSL.

Proof of concept by ChALkeR

require('request')({
  method: 'GET',
  uri: 'http://www.example.com',
  tunnel: true,
  proxy:{
      protocol: 'http:',
      host:"127.0.0.1",
      port:8080,
      auth:80
  }
});

You can read more about the insecure Buffer behavior on our blog.

Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.

Remediation

Upgrade tunnel-agent to version 0.6.0 or higher. Note This is vulnerable only for Node <=4

References

medium severity

Time of Check Time of Use (TOCTOU)

  • Vulnerable module: chownr
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 chownr@0.0.2
    Remediation: Upgrade to npm@6.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 npm-registry-client@6.0.7 chownr@0.0.2
    Remediation: Upgrade to npm@2.14.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 chownr@1.0.1
    Remediation: Upgrade to npmi@4.0.0.

Overview

chownr is a package that takes the same arguments as fs.chown()

Affected versions of this package are vulnerable to Time of Check Time of Use (TOCTOU). Affected versions of this package are vulnerable toTime of Check Time of Use (TOCTOU) attacks.

It does not dereference symbolic links and changes the owner of the link, which can trick it into descending into unintended trees if a non-symlink is replaced by a symlink at a critical moment:

      fs.lstat(pathChild, function(er, stats) {
        if (er)
          return cb(er)
        if (!stats.isSymbolicLink())
          chownr(pathChild, uid, gid, then)

Remediation

Upgrade chownr to version 1.1.0 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, cheerio@0.19.0 and others

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.11.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to cheerio@0.20.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-search@1.1.0 lodash@3.10.1
    Remediation: Upgrade to gitbook-plugin-search@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-plugin-sharing@1.0.1 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 cheerio@0.19.0 lodash@3.10.1
    Remediation: Upgrade to juice@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-markdown@0.5.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-asciidoc@0.2.4 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 gitbook-parsers@0.8.9 gitbook-restructuredtext@0.2.3 cheerio@0.19.0 lodash@3.10.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 merge-defaults@0.2.1 lodash@2.4.2
    Remediation: Upgrade to merge-defaults@0.2.2.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It parses dates using regex strings, which may cause a slowdown of 2 seconds per 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade lodash to version 4.17.11 or higher.

References

medium severity

Directory Traversal

  • Vulnerable module: send
  • Introduced through: send@0.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 send@0.2.0
    Remediation: Upgrade to send@0.8.4.

Overview

send is a library for streaming files from the file system.

Affected versions of this package are vulnerable to Directory-Traversal attacks due to insecure comparison. When relying on the root option to restrict file access a malicious user may escape out of the restricted directory and access files in a similarly named directory. For example, a path like /my-secret is consedered fine for the root /my.

Details

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

  • Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

  • Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade to a version greater than or equal to 0.8.4.

References

medium severity

Artistic-2.0 license

  • Module: npm
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12

Artistic-2.0 license

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: braces
  • Introduced through: chokidar@1.0.6 and nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 chokidar@1.0.6 anymatch@1.3.2 micromatch@2.3.11 braces@1.8.5
    Remediation: Upgrade to chokidar@2.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 chokidar@1.7.0 anymatch@1.3.2 micromatch@2.3.11 braces@1.8.5
    Remediation: Upgrade to nunjucks@3.1.3.

Overview

braces is a Bash-like brace expansion, implemented in JavaScript.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It used a regular expression (^\{(,+(?:(\{,+\})*),*|,*(?:(\{,+\})*),+)\}) in order to detects empty braces. This can cause an impact of about 10 seconds matching time for data 50K characters long.

Disclosure Timeline

  • Feb 15th, 2018 - Initial Disclosure to package owner
  • Feb 16th, 2018 - Initial Response from package owner
  • Feb 18th, 2018 - Fix issued
  • Feb 19th, 2018 - Vulnerability published

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade braces to version 2.3.1 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: clean-css
  • Introduced through: juice@1.5.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 juice@1.5.0 web-resource-inliner@1.1.4 clean-css@1.1.7
    Remediation: Upgrade to juice@3.0.0.

Overview

clean-css is a fast and efficient CSS optimizer for Node.js platform and any modern browser.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). attacks. This can cause an impact of about 10 seconds matching time for data 70k characters long.

Disclosure Timeline

  • Feb 15th, 2018 - Initial Disclosure to package owner
  • Feb 20th, 2018 - Initial Response from package owner
  • Mar 6th, 2018 - Fix issued
  • Mar 7th, 2018 - Vulnerability published

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade clean-css to version 4.1.11 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: debug
  • Introduced through: tiny-lr@0.2.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 debug@2.2.0
    Remediation: Upgrade to tiny-lr@1.0.5.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 body-parser@1.14.2 debug@2.2.0
    Remediation: Upgrade to tiny-lr@1.0.0.

Overview

debug is a small debugging utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in the function useColors via manipulation of the str argument. The vulnerability can cause a very low impact of about 2 seconds of matching time for data 50k characters long.

Note: CVE-2017-20165 is a duplicate of this vulnerability.

PoC

Use the following regex in the %o formatter.

/\s*\n\s*/

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade debug to version 2.6.9, 3.1.0, 3.2.7, 4.3.1 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: hawk
  • Introduced through: request@2.51.0 and npm@2.4.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 request@2.51.0 hawk@1.1.1
    Remediation: Upgrade to request@2.59.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 request@2.51.0 hawk@1.1.1
    Remediation: Upgrade to npm@2.13.3.

Overview

hawk is an HTTP authentication scheme using a message authentication code (MAC) algorithm to provide partial HTTP request cryptographic verification.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

You can read more about Regular Expression Denial of Service (ReDoS) on our blog.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: mime
  • Introduced through: send@0.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 send@0.2.0 mime@1.2.11
    Remediation: Upgrade to send@0.16.0.

Overview

mime is a comprehensive, compact MIME type module.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It uses regex the following regex /.*[\.\/\\]/ in its lookup, which can cause a slowdown of 2 seconds for 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade mime to version 1.4.1, 2.0.3 or higher.

References

low severity

Prototype Pollution

  • Vulnerable module: minimist
  • Introduced through: nunjucks@2.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 nunjucks@2.2.0 optimist@0.6.1 minimist@0.0.10

Overview

minimist is a parse argument options module.

Affected versions of this package are vulnerable to Prototype Pollution due to a missing handler to Function.prototype.

Notes:

  • This vulnerability is a bypass to CVE-2020-7598

  • The reason for the different CVSS between CVE-2021-44906 to CVE-2020-7598, is that CVE-2020-7598 can pollute objects, while CVE-2021-44906 can pollute only function.

PoC by Snyk

require('minimist')('--_.constructor.constructor.prototype.foo bar'.split(' '));
console.log((function(){}).foo); // bar

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade minimist to version 0.2.4, 1.2.6 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: ms
  • Introduced through: tiny-lr@0.2.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 debug@2.2.0 ms@0.7.1
    Remediation: Upgrade to tiny-lr@1.0.5.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 tiny-lr@0.2.1 body-parser@1.14.2 debug@2.2.0 ms@0.7.1
    Remediation: Upgrade to tiny-lr@1.0.0.

Overview

ms is a tiny millisecond conversion utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms() function.

Proof of concept

ms = require('ms');
ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s

Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.

For more information on Regular Expression Denial of Service (ReDoS) attacks, go to our blog.

Disclosure Timeline

  • Feb 9th, 2017 - Reported the issue to package owner.
  • Feb 11th, 2017 - Issue acknowledged by package owner.
  • April 12th, 2017 - Fix PR opened by Snyk Security Team.
  • May 15th, 2017 - Vulnerability published.
  • May 16th, 2017 - Issue fixed and version 2.0.0 released.
  • May 21th, 2017 - Patches released for versions >=0.7.1, <=1.0.0.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade ms to version 2.0.0 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: tar
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1 node-gyp@1.0.3 tar@1.0.3
    Remediation: Upgrade to npm@5.6.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12 node-gyp@3.6.3 tar@2.2.2
    Remediation: Upgrade to npmi@3.0.0.

Overview

tar is a full-featured Tar for Node.js.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). When stripping the trailing slash from files arguments, the f.replace(/\/+$/, '') performance of this function can exponentially degrade when f contains many / characters resulting in ReDoS.

This vulnerability is not likely to be exploitable as it requires that the untrusted input is being passed into the tar.extract() or tar.list() array of entries to parse/extract, which would be unusual.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade tar to version 6.1.4, 5.0.8, 4.4.16 or higher.

References

low severity

Unauthorized File Access

  • Vulnerable module: npm
  • Introduced through: npm@2.4.1 and npmi@0.1.1

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npm@2.4.1
    Remediation: Upgrade to npm@6.13.3.
  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 npmi@0.1.1 npm@2.15.12
    Remediation: Upgrade to npmi@4.0.0.

Overview

npm is a package manager for JavaScript.

Affected versions of this package are vulnerable to Unauthorized File Access. It is possible for packages to create symlinks to files outside of thenode_modules folder through the bin field upon installation.

For npm, a properly constructed entry in the package.json bin field would allow a package publisher to create a symlink pointing to arbitrary files on a user’s system when the package is installed. This behaviour is possible through install scripts. This vulnerability bypasses a user using the --ignore-scripts install option.

Remediation

Upgrade npm to version 6.13.3 or higher.

References

low severity

Cross-site Scripting

  • Vulnerable module: send
  • Introduced through: send@0.2.0

Detailed paths

  • Introduced through: gitbook@noscripter/gitbook-1#a37ee3457ab27573e6a7f52a1bfa25ec63b5dc69 send@0.2.0
    Remediation: Upgrade to send@0.19.0.

Overview

send is a Better streaming static file server with Range and conditional-GET support

Affected versions of this package are vulnerable to Cross-site Scripting due to improper user input sanitization passed to the SendStream.redirect() function, which executes untrusted code. An attacker can execute arbitrary code by manipulating the input parameters to this method.

Note:

Exploiting this vulnerability requires the following:

  1. The attacker needs to control the input to response.redirect()

  2. Express MUST NOT redirect before the template appears

  3. The browser MUST NOT complete redirection before

  4. The user MUST click on the link in the template

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade send to version 0.19.0, 1.1.0 or higher.

References