Vulnerabilities

58 via 260 paths

Dependencies

545

Source

GitHub

Commit

34a9d196

Find, fix and prevent vulnerabilities in your code.

Issue type
  • 58
  • 1
Severity
  • 2
  • 23
  • 26
  • 8
Status
  • 59
  • 0
  • 0

critical severity

Predictable Value Range from Previous Values

  • Vulnerable module: form-data
  • Introduced through: request@2.84.0, quick-gist@1.5.1 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b request@2.84.0 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b quick-gist@1.5.1 request@2.88.2 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b cheerio@0.20.0 jsdom@7.2.2 request@2.88.2 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-eavesdrop@2.3.0 quick-gist@1.3.1 request@2.88.2 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-matteruser@4.4.0 mattermost-client@4.4.0 request@2.88.2 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 mana@0.1.41 request@2.88.2 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 githulk@0.0.7 mana@0.1.41 request@2.88.2 form-data@2.3.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 npm-registry@0.1.13 mana@0.1.41 request@2.88.2 form-data@2.3.3

Overview

Affected versions of this package are vulnerable to Predictable Value Range from Previous Values via the boundary value, which uses Math.random(). An attacker can manipulate HTTP request boundaries by exploiting predictable values, potentially leading to HTTP parameter pollution.

Remediation

Upgrade form-data to version 2.5.4, 3.0.4, 4.0.4 or higher.

References

critical severity

Authentication Bypass

  • Vulnerable module: hawk
  • Introduced through: request@2.84.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b request@2.84.0 hawk@7.0.10

Overview

hawk is a library for the HTTP Hawk Authentication Scheme.

Affected versions of this package are vulnerable to Authentication Bypass. The incoming (client supplied) hash of the payload is trusted by the server and not verified before the signature is calculated.

A malicious actor in the middle can alter the payload and the server side will not identify the modification occurred because it simply uses the client provided value instead of verify the hash provided against the modified payload.

According to the maintainers this issue is to be considered out of scope as "payload hash validation is optional and up to developer to implement".

Remediation

There is no fixed version for hawk.

References

high severity

Uninitialized Memory Exposure

  • Vulnerable module: base64-url
  • Introduced through: hubot-github-identity@0.10.0, hubot-acrogov@2.4.1 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 csurf@1.4.1 csrf@2.0.7 base64-url@1.2.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 csurf@1.4.1 csrf@2.0.7 uid-safe@1.1.0 base64-url@1.2.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 uid-safe@2.0.0 base64-url@1.2.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 uid-safe@2.0.0 base64-url@1.2.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 express-session@1.7.6 uid-safe@1.0.1 base64-url@1.3.3

Overview

base64-url Base64 encode, decode, escape and unescape for URL applications.

Affected versions of this package are vulnerable to Uninitialized Memory Exposure. An attacker may extract sensitive data from uninitialized memory or may cause a DoS by passing in a large number, in setups where typed user input can be passed (e.g. from JSON).

Details

The Buffer class on Node.js is a mutable array of binary data, and can be initialized with a string, array or number.

const buf1 = new Buffer([1,2,3]);
// creates a buffer containing [01, 02, 03]
const buf2 = new Buffer('test');
// creates a buffer containing ASCII bytes [74, 65, 73, 74]
const buf3 = new Buffer(10);
// creates a buffer of length 10

The first two variants simply create a binary representation of the value it received. The last one, however, pre-allocates a buffer of the specified size, making it a useful buffer, especially when reading data from a stream. When using the number constructor of Buffer, it will allocate the memory, but will not fill it with zeros. Instead, the allocated buffer will hold whatever was in memory at the time. If the buffer is not zeroed by using buf.fill(0), it may leak sensitive information like keys, source code, and system info.

Remediation

Upgrade base64-url to version 2.0.0 or higher. Note This is vulnerable only for Node <=4

References

high severity

Asymmetric Resource Consumption (Amplification)

  • Vulnerable module: body-parser
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 body-parser@1.6.7

Overview

Affected versions of this package are vulnerable to Asymmetric Resource Consumption (Amplification) via the extendedparser and urlencoded functions when the URL encoding process is enabled. An attacker can flood the server with a large number of specially crafted requests.

Remediation

Upgrade body-parser to version 1.20.3 or higher.

References

high severity

Uninitialized Memory Exposure

  • Vulnerable module: https-proxy-agent
  • Introduced through: hubot-github-management@2.0.0 and hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 https-proxy-agent@1.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 https-proxy-agent@1.0.0

Overview

https-proxy-agent provides an http.Agent implementation that connects to a specified HTTP or HTTPS proxy server, and can be used with the built-in https module.

Affected versions of this package are vulnerable to Uninitialized Memory Exposure and Denial of Service (DoS) attacks due to passing unsanitized options to Buffer(arg).

Note: CVE-2018-3739 is a duplicate of CVE-2018-3736.

Uninitialized memory Exposre PoC by ChALKer

// listen with: nc -l -p 8080

var url = require('url');
var https = require('https');
var HttpsProxyAgent = require('https-proxy-agent');

var proxy = {
  protocol: 'http:',
  host: "127.0.0.1",
  port: 8080
};

proxy.auth = 500; // a number as 'auth'
var opts = url.parse('https://example.com/');
var agent = new HttpsProxyAgent(proxy);
opts.agent = agent;
https.get(opts);

Details

The Buffer class on Node.js is a mutable array of binary data, and can be initialized with a string, array or number.

const buf1 = new Buffer([1,2,3]);
// creates a buffer containing [01, 02, 03]
const buf2 = new Buffer('test');
// creates a buffer containing ASCII bytes [74, 65, 73, 74]
const buf3 = new Buffer(10);
// creates a buffer of length 10

The first two variants simply create a binary representation of the value it received. The last one, however, pre-allocates a buffer of the specified size, making it a useful buffer, especially when reading data from a stream. When using the number constructor of Buffer, it will allocate the memory, but will not fill it with zeros. Instead, the allocated buffer will hold whatever was in memory at the time. If the buffer is not zeroed by using buf.fill(0), it may leak sensitive information like keys, source code, and system info.

Remediation

Upgrade https-proxy-agent to version 2.2.0 or higher. Note This is vulnerable only for Node <=4

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0 and lodash@4.17.12

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b lodash@4.17.12
    Remediation: Upgrade to lodash@4.17.20.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The function zipObjectDeep can be tricked into adding or modifying properties of the Object prototype. These properties will be present on all objects.

PoC

const _ = require('lodash');

_.zipObjectDeep(['__proto__.z'],[123]);

console.log(z); // 123

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.20 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: ajv
  • Introduced through: request@2.84.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b request@2.84.0 har-validator@5.0.3 ajv@5.5.2
    Remediation: Upgrade to request@2.88.0.

Overview

ajv is an Another JSON Schema Validator

Affected versions of this package are vulnerable to Prototype Pollution. A carefully crafted JSON schema could be provided that allows execution of other code by prototype pollution. (While untrusted schemas are recommended against, the worst case of an untrusted schema should be a denial of service, not execution of code.)

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade ajv to version 6.12.3 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: chrono-node
  • Introduced through: chrono-node@1.2.1

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b chrono-node@1.2.1
    Remediation: Upgrade to chrono-node@2.2.4.

Overview

chrono-node is an A natural language date parser in Javascript

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It hangs on a date-like string with lots of embedded spaces.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade chrono-node to version 2.2.4 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: fresh
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 send@0.13.0 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 send@0.13.0 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-favicon@2.3.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-favicon@2.3.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 fresh@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 fresh@0.2.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-favicon@2.0.1 fresh@0.2.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 fresh@0.2.2

Overview

fresh is HTTP response freshness testing.

Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS) attacks. A Regular Expression (/ *, */) was used for parsing HTTP headers and take about 2 seconds matching time for 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade fresh to version 0.5.2 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0 and lodash@4.17.12

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b lodash@4.17.12
    Remediation: Upgrade to lodash@4.17.17.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution through the zipObjectDeep function due to improper user input sanitization in the baseZipObject function.

PoC

lodash.zipobjectdeep:

const zipObjectDeep = require("lodash.zipobjectdeep");

let emptyObject = {};


console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined

zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function

console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true

lodash:

const test = require("lodash");

let emptyObject = {};


console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined

test.zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function

console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.17 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: method-override
  • Introduced through: hubot-github-identity@0.10.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 method-override@2.1.3

Overview

method-override is a module to override HTTP verbs.

Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS). It uses regex the following regex / *, */ in order to split HTTP headers. An attacker may send specially crafted input in the X-HTTP-Method-Override header and cause a significant slowdown.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade method-override to version 2.3.10 or higher.

References

high severity

Directory Traversal

  • Vulnerable module: moment
  • Introduced through: moment@2.19.3

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b moment@2.19.3
    Remediation: Upgrade to moment@2.29.2.

Overview

moment is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates.

Affected versions of this package are vulnerable to Directory Traversal when a user provides a locale string which is directly used to switch moment locale.

Details

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

  • Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

  • Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade moment to version 2.29.2 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: moment
  • Introduced through: moment@2.19.3

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b moment@2.19.3
    Remediation: Upgrade to moment@2.29.4.

Overview

moment is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the preprocessRFC2822() function in from-string.js, when processing a very long crafted string (over 10k characters).

PoC:

moment("(".repeat(500000))

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade moment to version 2.29.4 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: negotiator
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 accepts@1.2.13 negotiator@0.5.3
    Remediation: Open PR to patch negotiator@0.5.3.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 accepts@1.2.13 negotiator@0.5.3
    Remediation: Open PR to patch negotiator@0.5.3.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-index@1.7.3 accepts@1.2.13 negotiator@0.5.3
    Remediation: Open PR to patch negotiator@0.5.3.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-index@1.7.3 accepts@1.2.13 negotiator@0.5.3
    Remediation: Open PR to patch negotiator@0.5.3.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 compression@1.0.11 accepts@1.0.7 negotiator@0.4.7
    Remediation: Open PR to patch negotiator@0.4.7.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 errorhandler@1.1.1 accepts@1.0.7 negotiator@0.4.7
    Remediation: Open PR to patch negotiator@0.4.7.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-index@1.1.6 accepts@1.0.7 negotiator@0.4.7
    Remediation: Open PR to patch negotiator@0.4.7.

Overview

negotiator is an HTTP content negotiator for Node.js.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) when parsing Accept-Language http header.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade negotiator to version 0.6.1 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: nth-check
  • Introduced through: cheerio@0.20.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b cheerio@0.20.0 css-select@1.2.0 nth-check@1.0.2
    Remediation: Upgrade to cheerio@1.0.0.

Overview

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) when parsing crafted invalid CSS nth-checks, due to the sub-pattern \s*(?:([+-]?)\s*(\d+))? in RE_NTH_ELEMENT with quantified overlapping adjacency.

PoC

var nthCheck = require("nth-check")
for(var i = 1; i <= 50000; i++) {
    var time = Date.now();
    var attack_str = '2n' + ' '.repeat(i*10000)+"!";
    try {
        nthCheck.parse(attack_str) 
    }
    catch(err) {
        var time_cost = Date.now() - time;
        console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
    }
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade nth-check to version 2.0.1 or higher.

References

high severity

Prototype Override Protection Bypass

  • Vulnerable module: qs
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 connect-multiparty@1.2.5 qs@2.2.5
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 connect-multiparty@1.2.5 qs@2.2.5
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 qs@2.2.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 body-parser@1.6.7 qs@2.2.2

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

Affected versions of this package are vulnerable to Prototype Override Protection Bypass. By default qs protects against attacks that attempt to overwrite an object's existing prototype properties, such as toString(), hasOwnProperty(),etc.

From qs documentation:

By default parameters that would overwrite properties on the object prototype are ignored, if you wish to keep the data from those fields either use plainObjects as mentioned above, or set allowPrototypes to true which will allow user input to overwrite those properties. WARNING It is generally a bad idea to enable this option as it can cause problems when attempting to use the properties that have been overwritten. Always be careful with this option.

Overwriting these properties can impact application logic, potentially allowing attackers to work around security controls, modify data, make the application unstable and more.

In versions of the package affected by this vulnerability, it is possible to circumvent this protection and overwrite prototype properties and functions by prefixing the name of the parameter with [ or ]. e.g. qs.parse("]=toString") will return {toString = true}, as a result, calling toString() on the object will throw an exception.

Example:

qs.parse('toString=foo', { allowPrototypes: false })
// {}

qs.parse("]=toString", { allowPrototypes: false })
// {toString = true} <== prototype overwritten

For more information, you can check out our blog.

Disclosure Timeline

  • February 13th, 2017 - Reported the issue to package owner.
  • February 13th, 2017 - Issue acknowledged by package owner.
  • February 16th, 2017 - Partial fix released in versions 6.0.3, 6.1.1, 6.2.2, 6.3.1.
  • March 6th, 2017 - Final fix released in versions 6.4.0,6.3.2, 6.2.3, 6.1.2 and 6.0.4

Remediation

Upgrade qs to version 6.0.4, 6.1.2, 6.2.3, 6.3.2 or higher.

References

high severity

Prototype Poisoning

  • Vulnerable module: qs
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 connect-multiparty@1.2.5 qs@2.2.5
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 connect-multiparty@1.2.5 qs@2.2.5
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 qs@4.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 qs@2.2.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 body-parser@1.6.7 qs@2.2.2

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

Affected versions of this package are vulnerable to Prototype Poisoning which allows attackers to cause a Node process to hang, processing an Array object whose prototype has been replaced by one with an excessive length value.

Note: In many typical Express use cases, an unauthenticated remote attacker can place the attack payload in the query string of the URL that is used to visit the application, such as a[__proto__]=b&a[__proto__]&a[length]=100000000.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.

Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.

One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.

When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.

Two common types of DoS vulnerabilities:

  • High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.

  • Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm ws package

Remediation

Upgrade qs to version 6.2.4, 6.3.3, 6.4.1, 6.5.3, 6.6.1, 6.7.3, 6.8.3, 6.9.7, 6.10.3 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver
  • Introduced through: hubot-github-management@2.0.0, hubot-lgtm@2.1.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 https-proxy-agent@1.0.0 agent-base@2.1.1 semver@5.0.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 https-proxy-agent@1.0.0 agent-base@2.1.1 semver@5.0.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 semver@2.2.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 npm-registry@0.1.13 semver@2.2.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b semver@5.1.0
    Remediation: Upgrade to semver@5.7.2.

Overview

semver is a semantic version parser used by npm.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

PoC


const semver = require('semver')
const lengths_2 = [2000, 4000, 8000, 16000, 32000, 64000, 128000]

console.log("n[+] Valid range - Test payloads")
for (let i = 0; i =1.2.3' + ' '.repeat(lengths_2[i]) + '<1.3.0';
const start = Date.now()
semver.validRange(value)
// semver.minVersion(value)
// semver.maxSatisfying(["1.2.3"], value)
// semver.minSatisfying(["1.2.3"], value)
// new semver.Range(value, {})

const end = Date.now();
console.log('length=%d, time=%d ms', value.length, end - start);
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver to version 5.7.2, 6.3.1, 7.5.2 or higher.

References

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: hawk
  • Introduced through: request@2.84.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b request@2.84.0 hawk@7.0.10
    Remediation: Upgrade to request@2.87.0.

Overview

hawk is a library for the HTTP Hawk Authentication Scheme.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in header parsing where each added character in the attacker's input increases the computation time exponentially.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade hawk to version 9.0.1 or higher.

References

high severity

Improper Handling of Extra Parameters

  • Vulnerable module: follow-redirects
  • Introduced through: hubot-github-management@2.0.0 and hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 follow-redirects@0.0.7
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 follow-redirects@0.0.7

Overview

Affected versions of this package are vulnerable to Improper Handling of Extra Parameters due to the improper handling of URLs by the url.parse() function. When new URL() throws an error, it can be manipulated to misinterpret the hostname. An attacker could exploit this weakness to redirect traffic to a malicious site, potentially leading to information disclosure, phishing attacks, or other security breaches.

PoC

# Case 1 : Bypassing localhost restriction
let url = 'http://[localhost]/admin';
try{
    new URL(url); // ERROR : Invalid URL
}catch{
    url.parse(url); // -> http://localhost/admin
}

# Case 2 : Bypassing domain restriction
let url = 'http://attacker.domain*.allowed.domain:a';
try{
    new URL(url); // ERROR : Invalid URL
}catch{
    url.parse(url); // -> http://attacker.domain/*.allowed.domain:a
}

Remediation

Upgrade follow-redirects to version 1.15.4 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The function defaultsDeep could be tricked into adding or modifying properties of Object.prototype using a constructor payload.

PoC by Snyk

const mergeFn = require('lodash').defaultsDeep;
const payload = '{"constructor": {"prototype": {"a0": true}}}'

function check() {
    mergeFn({}, JSON.parse(payload));
    if (({})[`a0`] === true) {
        console.log(`Vulnerable to Prototype Pollution via ${payload}`);
    }
  }

check();

For more information, check out our blog post

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.12 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0 and lodash@4.17.12

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b lodash@4.17.12
    Remediation: Upgrade to lodash@4.17.17.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution via the set and setwith functions due to improper user input sanitization.

PoC

lod = require('lodash')
lod.set({}, "__proto__[test2]", "456")
console.log(Object.prototype)

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.17 or higher.

References

high severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The functions merge, mergeWith, and defaultsDeep could be tricked into adding or modifying properties of Object.prototype. This is due to an incomplete fix to CVE-2018-3721.

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.11 or higher.

References

high severity

Code Injection

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0 and lodash@4.17.12

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b lodash@4.17.12
    Remediation: Upgrade to lodash@4.17.21.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Code Injection via template.

PoC

var _ = require('lodash');

_.template('', { variable: '){console.log(process.env)}; with(obj' })()

Remediation

Upgrade lodash to version 4.17.21 or higher.

References

high severity

GPL-2.0 license

  • Module: hubot-twitter-search
  • Introduced through: hubot-twitter-search@1.0.3

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-twitter-search@1.0.3

GPL-2.0 license

medium severity

Observable Timing Discrepancy

  • Vulnerable module: basic-auth-connect
  • Introduced through: hubot-github-identity@0.10.0, hubot-acrogov@2.4.1 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 basic-auth-connect@1.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 basic-auth-connect@1.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 basic-auth-connect@1.0.0

Overview

basic-auth-connect is a Basic auth middleware for node and connect

Affected versions of this package are vulnerable to Observable Timing Discrepancy due to the use of a timing-unsafe equality comparison. An attacker can infer sensitive data.

Remediation

Upgrade basic-auth-connect to version 1.1.0 or higher.

References

medium severity

Arbitrary Code Injection

  • Vulnerable module: morgan
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 morgan@1.2.3

Overview

morgan is a HTTP request logger middleware for node.js.

Affected versions of this package are vulnerable to Arbitrary Code Injection. An attacker could use the format parameter to inject arbitrary commands.

Remediation

Upgrade morgan to version 1.9.1 or higher.

References

medium severity

Symlink Attack

  • Vulnerable module: tmp
  • Introduced through: hubot-capital-framework@2.4.0 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-capital-framework@2.4.0 tmp@0.0.28
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 tmp@0.0.31

Overview

Affected versions of this package are vulnerable to Symlink Attack via the dir parameter. An attacker can cause files or directories to be written to arbitrary locations by supplying a crafted symbolic link that resolves outside the intended temporary directory.

PoC

const tmp = require('tmp');

const tmpobj = tmp.fileSync({ 'dir': 'evil-dir'});
console.log('File: ', tmpobj.name);

try {
    tmp.fileSync({ 'dir': 'mydir1'});
} catch (err) {
    console.log('test 1:', err.message)
}

try {
    tmp.fileSync({ 'dir': '/foo'});
} catch (err) {
    console.log('test 2:', err.message)
}

try {
    const fs = require('node:fs');
    const resolved = fs.realpathSync('/tmp/evil-dir');
    tmp.fileSync({ 'dir': resolved});
} catch (err) {
    console.log('test 3:', err.message)
}

Remediation

Upgrade tmp to version 0.2.4 or higher.

References

medium severity

Information Exposure

  • Vulnerable module: follow-redirects
  • Introduced through: hubot-github-management@2.0.0 and hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 follow-redirects@0.0.7
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 follow-redirects@0.0.7

Overview

Affected versions of this package are vulnerable to Information Exposure due to the handling of the Proxy-Authorization header across hosts. When using a dependent library, it only clears the authorization header during cross-domain redirects but allows the proxy-authentication header, which contains credentials, to persist. This behavior may lead to the unintended leakage of credentials if an attacker can trigger a cross-domain redirect and capture the persistent proxy-authentication header.

PoC

const axios = require('axios');

axios.get('http://127.0.0.1:10081/',{
headers: {
'AuThorization': 'Rear Test',
'ProXy-AuthoriZation': 'Rear Test',
'coOkie': 't=1'
}
}).then(function (response) {
console.log(response);
})

Remediation

Upgrade follow-redirects to version 1.15.6 or higher.

References

medium severity

Server-side Request Forgery (SSRF)

  • Vulnerable module: request
  • Introduced through: quick-gist@1.5.1, cheerio@0.20.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b quick-gist@1.5.1 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b cheerio@0.20.0 jsdom@7.2.2 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-eavesdrop@2.3.0 quick-gist@1.3.1 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-matteruser@4.4.0 mattermost-client@4.4.0 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 mana@0.1.41 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 githulk@0.0.7 mana@0.1.41 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 npm-registry@0.1.13 mana@0.1.41 request@2.88.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b request@2.84.0

Overview

request is a simplified http request client.

Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) due to insufficient checks in the lib/redirect.js file by allowing insecure redirects in the default configuration, via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).

NOTE: request package has been deprecated, so a fix is not expected. See https://github.com/request/request/issues/3142.

Remediation

A fix was pushed into the master branch but not yet published.

References

medium severity

Cross-site Scripting (XSS)

  • Vulnerable module: serve-index
  • Introduced through: hubot-github-identity@0.10.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-index@1.1.6

Overview

serve-index Serves pages that contain directory listings for a given path.

Affected versions of this package are vulnerable to Cross-site Scripting (XSS) attacks. When using serve-index middleware, file and directory names are not escaped in HTML output. If a remote attcker can influence these names, it may trigger a persistent XSS attack.

Details

<>

Remediation

Upgrade to version 1.6.3 or greater

References

medium severity

Prototype Pollution

  • Vulnerable module: tough-cookie
  • Introduced through: quick-gist@1.5.1, cheerio@0.20.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b quick-gist@1.5.1 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b cheerio@0.20.0 jsdom@7.2.2 tough-cookie@2.5.0
    Remediation: Upgrade to cheerio@0.22.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b cheerio@0.20.0 jsdom@7.2.2 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-eavesdrop@2.3.0 quick-gist@1.3.1 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-matteruser@4.4.0 mattermost-client@4.4.0 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 mana@0.1.41 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 githulk@0.0.7 mana@0.1.41 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 npm-registry@0.1.13 mana@0.1.41 request@2.88.2 tough-cookie@2.5.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b request@2.84.0 tough-cookie@2.3.4

Overview

tough-cookie is a RFC6265 Cookies and CookieJar module for Node.js.

Affected versions of this package are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. Due to an issue with the manner in which the objects are initialized, an attacker can expose or modify a limited amount of property information on those objects. There is no impact to availability.

PoC

// PoC.js
async function main(){
var tough = require("tough-cookie");
var cookiejar = new tough.CookieJar(undefined,{rejectPublicSuffixes:false});
// Exploit cookie
await cookiejar.setCookie(
  "Slonser=polluted; Domain=__proto__; Path=/notauth",
  "https://__proto__/admin"
);
// normal cookie
var cookie = await cookiejar.setCookie(
  "Auth=Lol; Domain=google.com; Path=/notauth",
  "https://google.com/"
);

//Exploit cookie
var a = {};
console.log(a["/notauth"]["Slonser"])
}
main();

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade tough-cookie to version 4.1.3 or higher.

References

medium severity

  • Vulnerable module: cookie
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 cookie-parser@1.3.5 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 cookie-parser@1.3.5 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 csurf@1.8.3 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 csurf@1.8.3 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 cookie@0.1.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 cookie@0.1.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 cookie-parser@1.3.2 cookie@0.1.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 csurf@1.4.1 cookie@0.1.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 express-session@1.7.6 cookie@0.1.2

Overview

Affected versions of this package are vulnerable to Cross-site Scripting (XSS) via the cookie name, path, or domain, which can be used to set unexpected values to other cookie fields.

Workaround

Users who are not able to upgrade to the fixed version should avoid passing untrusted or arbitrary values for the cookie fields and ensure they are set by the application instead of user input.

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade cookie to version 0.7.0 or higher.

References

medium severity

Improper Neutralization of Special Elements in Output Used by a Downstream Component ('Injection')

  • Vulnerable module: express
  • Introduced through: hubot-acrogov@2.4.1 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2

Overview

express is a minimalist web framework.

Affected versions of this package are vulnerable to Improper Neutralization of Special Elements in Output Used by a Downstream Component ('Injection') through the response.links function. An attacker can inject arbitrary resources into the Link header by using unsanitized input that includes special characters such as commas, semicolons, and angle brackets.

PoC

var express = require('express')
var app = express()

app.get('/', function (req, res) {
  res.links({"preload": req.query.resource});
  if(req.query.resource){
    console.log(res.getHeaders().link)
  }
  res.send('ok');
});
  
app.listen(3000);

// note how the query param uses < > to load arbitrary resource
const maliciousQueryParam = '?resource=http://api.example.com/users?resource=>; rel="preload", <http://api.malicious.com/1.js>; rel="preload"; as="script", <http:/api.example.com';

const url = `http://localhost:3000/${maliciousQueryParam}`;
  
fetch(url);

Remediation

Upgrade express to version 4.0.0-rc1 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var _= require('lodash');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
_.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade lodash to version 4.17.5 or higher.

References

medium severity

Missing Release of Resource after Effective Lifetime

  • Vulnerable module: inflight
  • Introduced through: hubot-acrogov@2.4.1 and hubot-keys@2.1.2

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 grunt@1.6.1 glob@7.1.7 inflight@1.0.6
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-keys@2.1.2 grunt@1.6.1 glob@7.1.7 inflight@1.0.6

Overview

Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.

Exploiting this vulnerability results in crashing the node process or in the application crash.

Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.

To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.

PoC

const inflight = require('inflight');

function testInflight() {
  let i = 0;
  function scheduleNext() {
    let key = `key-${i++}`;
    const callback = () => {
    };
    for (let j = 0; j < 1000000; j++) {
      inflight(key, callback);
    }

    setImmediate(scheduleNext);
  }


  if (i % 100 === 0) {
    console.log(process.memoryUsage());
  }

  scheduleNext();
}

testInflight();

Remediation

There is no fixed version for inflight.

References

medium severity

Open Redirect

  • Vulnerable module: express
  • Introduced through: hubot-acrogov@2.4.1 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2

Overview

express is a minimalist web framework.

Affected versions of this package are vulnerable to Open Redirect due to the implementation of URL encoding using encodeurl before passing it to the location header. This can lead to unexpected evaluations of malformed URLs by common redirect allow list implementations in applications, allowing an attacker to bypass a properly implemented allow list and redirect users to malicious sites.

Remediation

Upgrade express to version 4.19.2, 5.0.0-beta.3 or higher.

References

medium severity

Man-in-the-Middle (MitM)

  • Vulnerable module: https-proxy-agent
  • Introduced through: hubot-github-management@2.0.0 and hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 https-proxy-agent@1.0.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 https-proxy-agent@1.0.0

Overview

https-proxy-agent is a module that provides an http.Agent implementation that connects to a specified HTTP or HTTPS proxy server, and can be used with the built-in https module.

Affected versions of this package are vulnerable to Man-in-the-Middle (MitM). When targeting a HTTP proxy, https-proxy-agent opens a socket to the proxy, and sends the proxy server a CONNECT request. If the proxy server responds with something other than a HTTP response 200, https-proxy-agent incorrectly returns the socket without any TLS upgrade. This request data may contain basic auth credentials or other secrets, is sent over an unencrypted connection. A suitably positioned attacker could steal these secrets and impersonate the client.

PoC by Kris Adler

var url = require('url');
var https = require('https');
var HttpsProxyAgent = require('https-proxy-agent');

var proxyOpts = url.parse('http://127.0.0.1:80');
var opts = url.parse('https://www.google.com');
var agent = new HttpsProxyAgent(proxyOpts);
opts.agent = agent;
opts.auth = 'username:password';
https.get(opts);

Remediation

Upgrade https-proxy-agent to version 2.2.3 or higher.

References

medium severity

Prototype Pollution

  • Vulnerable module: minimist
  • Introduced through: hubot-acrogov@2.4.1 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 mkdirp@0.5.1 minimist@0.0.8
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 mkdirp@0.5.1 minimist@0.0.8

Overview

minimist is a parse argument options module.

Affected versions of this package are vulnerable to Prototype Pollution. The library could be tricked into adding or modifying properties of Object.prototype using a constructor or __proto__ payload.

PoC by Snyk

require('minimist')('--__proto__.injected0 value0'.split(' '));
console.log(({}).injected0 === 'value0'); // true

require('minimist')('--constructor.prototype.injected1 value1'.split(' '));
console.log(({}).injected1 === 'value1'); // true

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade minimist to version 0.2.1, 1.2.3 or higher.

References

medium severity

Arbitrary Code Injection

  • Vulnerable module: underscore
  • Introduced through: underscore@1.8.3 and hubot-standup-alarm@0.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b underscore@1.8.3
    Remediation: Upgrade to underscore@1.12.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-standup-alarm@0.1.0 underscore@1.8.3

Overview

underscore is a JavaScript's functional programming helper library.

Affected versions of this package are vulnerable to Arbitrary Code Injection via the template function, particularly when the variable option is taken from _.templateSettings as it is not sanitized.

PoC

const _ = require('underscore');
_.templateSettings.variable = "a = this.process.mainModule.require('child_process').execSync('touch HELLO')";
const t = _.template("")();

Remediation

Upgrade underscore to version 1.13.0-2, 1.12.1 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: color-string
  • Introduced through: npm-registry@0.1.13

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 mana@0.1.41 diagnostics@1.0.1 colorspace@1.0.1 color@0.8.0 color-string@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 githulk@0.0.7 mana@0.1.41 diagnostics@1.0.1 colorspace@1.0.1 color@0.8.0 color-string@0.3.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 npm-registry@0.1.13 mana@0.1.41 diagnostics@1.0.1 colorspace@1.0.1 color@0.8.0 color-string@0.3.0

Overview

color-string is a Parser and generator for CSS color strings

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the hwb regular expression in the cs.get.hwb function in index.js. The affected regular expression exhibits quadratic worst-case time complexity.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade color-string to version 1.5.5 or higher.

References

medium severity

Information Exposure

  • Vulnerable module: follow-redirects
  • Introduced through: hubot-github-management@2.0.0 and hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 follow-redirects@0.0.7
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 follow-redirects@0.0.7

Overview

Affected versions of this package are vulnerable to Information Exposure by leaking the cookie header to a third party site in the process of fetching a remote URL with the cookie in the request body. If the response contains a location header, it will follow the redirect to another URL of a potentially malicious actor, to which the cookie would be exposed.

Remediation

Upgrade follow-redirects to version 1.14.7 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0 and lodash@4.17.12

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b lodash@4.17.12
    Remediation: Upgrade to lodash@4.17.21.

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the toNumber, trim and trimEnd functions.

POC

var lo = require('lodash');

function build_blank (n) {
var ret = "1"
for (var i = 0; i < n; i++) {
ret += " "
}

return ret + "1";
}

var s = build_blank(50000)
var time0 = Date.now();
lo.trim(s)
var time_cost0 = Date.now() - time0;
console.log("time_cost0: " + time_cost0)

var time1 = Date.now();
lo.toNumber(s)
var time_cost1 = Date.now() - time1;
console.log("time_cost1: " + time_cost1)

var time2 = Date.now();
lo.trimEnd(s)
var time_cost2 = Date.now() - time2;
console.log("time_cost2: " + time_cost2)

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade lodash to version 4.17.21 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: ms
  • Introduced through: hubot-github-identity@0.10.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 connect-timeout@1.2.2 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 compression@1.0.11 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 connect-timeout@1.2.2 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 express-session@1.7.6 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 finalhandler@0.1.0 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 method-override@2.1.3 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 debug@1.0.4 ms@0.6.2
    Remediation: Open PR to patch ms@0.6.2.

Overview

ms is a tiny milisecond conversion utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attack when converting a time period string (i.e. "2 days", "1h") into a milliseconds integer. A malicious user could pass extremely long strings to ms(), causing the server to take a long time to process, subsequently blocking the event loop for that extended period.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade ms to version 0.7.1 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: semver
  • Introduced through: npm-registry@0.1.13

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 semver@2.2.1
    Remediation: Open PR to patch semver@2.2.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b npm-registry@0.1.13 licenses@0.0.20 npm-registry@0.1.13 semver@2.2.1
    Remediation: Open PR to patch semver@2.2.1.

Overview

semver is a semantic version parser used by npm.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The semver module uses regular expressions when parsing a version string. For a carefully crafted input, the time it takes to process these regular expressions is not linear to the length of the input. Since the semver module did not enforce a limit on the version string length, an attacker could provide a long string that would take up a large amount of resources, potentially taking a server down. This issue therefore enables a potential Denial of Service attack.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade semver to version 4.3.2 or higher.

References

medium severity

Root Path Disclosure

  • Vulnerable module: send
  • Introduced through: hubot-github-identity@0.10.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5

Overview

Send is a library for streaming files from the file system as an http response. It supports partial responses (Ranges), conditional-GET negotiation, high test coverage, and granular events which may be leveraged to take appropriate actions in your application or framework.

Affected versions of this package are vulnerable to a Root Path Disclosure.

Remediation

Upgrade send to version 0.11.1 or higher. If a direct dependency update is not possible, use snyk wizard to patch this vulnerability.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: ws
  • Introduced through: hubot-matteruser@4.4.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-matteruser@4.4.0 mattermost-client@4.4.0 ws@1.1.5
    Remediation: Upgrade to hubot-matteruser@5.1.0.

Overview

ws is a simple to use websocket client, server and console for node.js.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

##PoC

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade ws to version 7.4.6, 6.2.2, 5.2.3 or higher.

References

medium severity

Cross-site Scripting

  • Vulnerable module: express
  • Introduced through: hubot-acrogov@2.4.1 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2

Overview

express is a minimalist web framework.

Affected versions of this package are vulnerable to Cross-site Scripting due to improper handling of user input in the response.redirect method. An attacker can execute arbitrary code by passing malicious input to this method.

Note

To exploit this vulnerability, the following conditions are required:

  1. The attacker should be able to control the input to response.redirect()

  2. express must not redirect before the template appears

  3. the browser must not complete redirection before:

  4. the user must click on the link in the template

Remediation

Upgrade express to version 4.20.0, 5.0.0 or higher.

References

medium severity

Open Redirect

  • Vulnerable module: express
  • Introduced through: hubot-acrogov@2.4.1 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2

Overview

express is a minimalist web framework.

Affected versions of this package are vulnerable to Open Redirect via the location() method in response.js.

Notes:

  1. Express 3 has reached End-of-Life and will not receive any updates to address this issue.

  2. This vulnerability is achievable only when: a request path begins with double slashes // and a relative path for redirection begins with ./ and is provided from user-controlled input and the Location header is set with that user-controlled input.

Remediation

Upgrade express to version 4.0.0 or higher.

References

medium severity

Improper Handling of Unexpected Data Type

  • Vulnerable module: on-headers
  • Introduced through: hubot-github-identity@0.10.0, hubot-acrogov@2.4.1 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 compression@1.0.11 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 connect-timeout@1.2.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 express-session@1.7.6 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 response-time@2.0.1 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1 on-headers@1.0.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1 on-headers@1.0.2

Overview

Affected versions of this package are vulnerable to Improper Handling of Unexpected Data Type via the response.writeHead function. An attacker can manipulate HTTP response headers by passing an array to this function, potentially leading to unintended disclosure or modification of header information.

Workaround

This vulnerability can be mitigated by passing an object to response.writeHead() instead of an array.

Remediation

Upgrade on-headers to version 1.1.0 or higher.

References

medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: lodash
  • Introduced through: hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 nock@8.2.2 lodash@4.9.0

Overview

lodash is a modern JavaScript utility library delivering modularity, performance, & extras.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It parses dates using regex strings, which may cause a slowdown of 2 seconds per 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade lodash to version 4.17.11 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: debug
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 send@0.13.0 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 send@0.13.0 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 finalhandler@0.4.0 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 finalhandler@0.4.0 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-index@1.7.3 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-index@1.7.3 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 debug@2.2.0
    Remediation: Open PR to patch debug@2.2.0.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 debug@1.0.4
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 compression@1.0.11 debug@1.0.4
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 connect-timeout@1.2.2 debug@1.0.4
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 express-session@1.7.6 debug@1.0.4
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 finalhandler@0.1.0 debug@1.0.4
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 method-override@2.1.3 debug@1.0.4
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 debug@1.0.4

Overview

debug is a small debugging utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in the function useColors via manipulation of the str argument. The vulnerability can cause a very low impact of about 2 seconds of matching time for data 50k characters long.

Note: CVE-2017-20165 is a duplicate of this vulnerability.

PoC

Use the following regex in the %o formatter.

/\s*\n\s*/

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade debug to version 2.6.9, 3.1.0, 3.2.7, 4.3.1 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: mime
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 send@0.13.0 mime@1.3.4
    Remediation: Open PR to patch mime@1.3.4.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 send@0.13.0 mime@1.3.4
    Remediation: Open PR to patch mime@1.3.4.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 mime@1.3.4
    Remediation: Open PR to patch mime@1.3.4.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 mime@1.3.4
    Remediation: Open PR to patch mime@1.3.4.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 mime@1.2.11
    Remediation: Open PR to patch mime@1.2.11.

Overview

mime is a comprehensive, compact MIME type module.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It uses regex the following regex /.*[\.\/\\]/ in its lookup, which can cause a slowdown of 2 seconds for 50k characters.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade mime to version 1.4.1, 2.0.3 or higher.

References

low severity

Prototype Pollution

  • Vulnerable module: minimist
  • Introduced through: hubot-acrogov@2.4.1 and hubot-github-management@2.0.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 mkdirp@0.5.1 minimist@0.0.8
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 mkdirp@0.5.1 minimist@0.0.8

Overview

minimist is a parse argument options module.

Affected versions of this package are vulnerable to Prototype Pollution due to a missing handler to Function.prototype.

Notes:

  • This vulnerability is a bypass to CVE-2020-7598

  • The reason for the different CVSS between CVE-2021-44906 to CVE-2020-7598, is that CVE-2020-7598 can pollute objects, while CVE-2021-44906 can pollute only function.

PoC by Snyk

require('minimist')('--_.constructor.constructor.prototype.foo bar'.split(' '));
console.log((function(){}).foo); // bar

Details

Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.

There are two main ways in which the pollution of prototypes occurs:

  • Unsafe Object recursive merge

  • Property definition by path

Unsafe Object recursive merge

The logic of a vulnerable recursive merge function follows the following high-level model:

merge (target, source)

  foreach property of source

    if property exists and is an object on both the target and the source

      merge(target[property], source[property])

    else

      target[property] = source[property]

When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.

Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).

lodash and Hoek are examples of libraries susceptible to recursive merge attacks.

Property definition by path

There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)

If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.

Types of attacks

There are a few methods by which Prototype Pollution can be manipulated:

Type Origin Short description
Denial of service (DoS) Client This is the most likely attack.
DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf).
The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service.
For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail.
Remote Code Execution Client Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation.
For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code.
Property Injection Client The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens.
For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges.

Affected environments

The following environments are susceptible to a Prototype Pollution attack:

  • Application server

  • Web server

  • Web browser

How to prevent

  1. Freeze the prototype— use Object.freeze (Object.prototype).

  2. Require schema validation of JSON input.

  3. Avoid using unsafe recursive merge functions.

  4. Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.

  5. As a best practice use Map instead of Object.

For more information on this vulnerability type:

Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018

Remediation

Upgrade minimist to version 0.2.4, 1.2.6 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: ms
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 send@0.13.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 send@0.13.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 send@0.13.0 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 send@0.13.0 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 body-parser@1.13.3 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 compression@1.5.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 connect-timeout@1.6.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 express-session@1.11.3 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 finalhandler@0.4.0 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 finalhandler@0.4.0 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 morgan@1.6.1 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-index@1.7.3 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-index@1.7.3 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2 debug@2.2.0 ms@0.7.1
    Remediation: Open PR to patch ms@0.7.1.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-favicon@2.3.2 ms@0.7.2
    Remediation: Open PR to patch ms@0.7.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-favicon@2.3.2 ms@0.7.2
    Remediation: Open PR to patch ms@0.7.2.
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 debug@1.0.4 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 connect-timeout@1.2.2 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 compression@1.0.11 debug@1.0.4 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 connect-timeout@1.2.2 debug@1.0.4 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 express-session@1.7.6 debug@1.0.4 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 finalhandler@0.1.0 debug@1.0.4 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 method-override@2.1.3 debug@1.0.4 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 ms@0.6.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5 debug@1.0.4 ms@0.6.2

Overview

ms is a tiny millisecond conversion utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms() function.

Proof of concept

ms = require('ms');
ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s

Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.

For more information on Regular Expression Denial of Service (ReDoS) attacks, go to our blog.

Disclosure Timeline

  • Feb 9th, 2017 - Reported the issue to package owner.
  • Feb 11th, 2017 - Issue acknowledged by package owner.
  • April 12th, 2017 - Fix PR opened by Snyk Security Team.
  • May 15th, 2017 - Vulnerability published.
  • May 16th, 2017 - Issue fixed and version 2.0.0 released.
  • May 21th, 2017 - Patches released for versions >=0.7.1, <=1.0.0.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade ms to version 2.0.0 or higher.

References

low severity

Open Redirect

  • Vulnerable module: serve-static
  • Introduced through: hubot-github-identity@0.10.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4

Overview

When using serve-static middleware version < 1.7.2 and it's configured to mount at the root, it creates an open redirect on the site.

Source: Node Security Project

Details

For example:

If a user visits http://example.com//www.google.com/%2e%2e they will be redirected to //www.google.com/%2e%2e, which some browsers interpret as http://www.google.com/%2e%2e.

Remediation

  • Update to version 1.7.2 or greater (or 1.6.5 if sticking to the 1.6.x line).
  • Disable redirects if not using the feature with 'redirect: false' option and cannot upgrade.

References

low severity

Information Exposure

  • Vulnerable module: follow-redirects
  • Introduced through: hubot-github-management@2.0.0 and hubot-lgtm@2.1.0

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 github@8.2.1 follow-redirects@0.0.7
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-lgtm@2.1.0 github@11.0.0 follow-redirects@0.0.7

Overview

Affected versions of this package are vulnerable to Information Exposure due a leakage of the Authorization header from the same hostname during HTTPS to HTTP redirection. An attacker who can listen in on the wire (or perform a MITM attack) will be able to receive the Authorization header due to the usage of the insecure HTTP protocol which does not verify the hostname the request is sending to.

Remediation

Upgrade follow-redirects to version 1.14.8 or higher.

References

low severity

Cross-site Scripting

  • Vulnerable module: send
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3 send@0.13.2
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 send@0.13.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 send@0.13.0
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4 send@0.8.5

Overview

send is a Better streaming static file server with Range and conditional-GET support

Affected versions of this package are vulnerable to Cross-site Scripting due to improper user input sanitization passed to the SendStream.redirect() function, which executes untrusted code. An attacker can execute arbitrary code by manipulating the input parameters to this method.

Note:

Exploiting this vulnerability requires the following:

  1. The attacker needs to control the input to response.redirect()

  2. Express MUST NOT redirect before the template appears

  3. The browser MUST NOT complete redirection before

  4. The user MUST click on the link in the template

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade send to version 0.19.0, 1.1.0 or higher.

References

low severity

Cross-site Scripting

  • Vulnerable module: serve-static
  • Introduced through: hubot-acrogov@2.4.1, hubot-github-management@2.0.0 and others

Detailed paths

  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-acrogov@2.4.1 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-management@2.0.0 hubot@2.19.0 express@3.21.2 connect@2.30.2 serve-static@1.10.3
  • Introduced through: cfpbot@cfpb/cfpbot#34a9d196959816209a68b26b6e17b9e47cc2915b hubot-github-identity@0.10.0 connect@2.25.10 serve-static@1.5.4

Overview

serve-static is a server.

Affected versions of this package are vulnerable to Cross-site Scripting due to improper sanitization of user input in the redirect function. An attacker can manipulate the redirection process by injecting malicious code into the input.

Note

To exploit this vulnerability, the following conditions are required:

  1. The attacker should be able to control the input to response.redirect()

  2. express must not redirect before the template appears

  3. the browser must not complete redirection before:

  4. the user must click on the link in the template

Details

Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.

This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.

Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.

Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, < can be coded as &lt; and > can be coded as &gt; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses < and > as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.

The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.

Types of attacks

There are a few methods by which XSS can be manipulated:

Type Origin Description
Stored Server The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link.
Reflected Server The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser.
DOM-based Client The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data.
Mutated The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters.

Affected environments

The following environments are susceptible to an XSS attack:

  • Web servers
  • Application servers
  • Web application environments

How to prevent

This section describes the top best practices designed to specifically protect your code:

  • Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
  • Convert special characters such as ?, &, /, <, > and spaces to their respective HTML or URL encoded equivalents.
  • Give users the option to disable client-side scripts.
  • Redirect invalid requests.
  • Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
  • Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
  • Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.

Remediation

Upgrade serve-static to version 1.16.0, 2.1.0 or higher.

References