Find, fix and prevent vulnerabilities in your code.
high severity
- Vulnerable module: url-parse
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › amqplib@0.5.6 › url-parse@1.4.7
Overview
url-parse is a Small footprint URL parser that works seamlessly across Node.js and browser environments.
Affected versions of this package are vulnerable to Improper Input Validation due to improper fix of CVE-2020-8124 , it is possible to be exploited via the \b
(backspace) character.
PoC:
const parse = require('./index.js')
url = parse('\bhttp://google.com')
console.log(url)
Output:
{
slashes: false,
protocol: '',
hash: '',
query: '',
pathname: '\bhttp://google.com',
auth: '',
host: '',
port: '',
hostname: '',
password: '',
username: '',
origin: 'null',
href: '\bhttp://google.com'
}
Remediation
Upgrade url-parse
to version 1.5.9 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution through the zipObjectDeep
function due to improper user input sanitization in the baseZipObject
function.
PoC
lodash.zipobjectdeep:
const zipObjectDeep = require("lodash.zipobjectdeep");
let emptyObject = {};
console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined
zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function
console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true
lodash:
const test = require("lodash");
let emptyObject = {};
console.log(`[+] Before prototype pollution : ${emptyObject.polluted}`);
//[+] Before prototype pollution : undefined
test.zipObjectDeep(["constructor.prototype.polluted"], [true]);
//we inject our malicious attributes in the vulnerable function
console.log(`[+] After prototype pollution : ${emptyObject.polluted}`);
//[+] After prototype pollution : true
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.17 or higher.
References
high severity
- Vulnerable module: moment
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › moment@2.10.2
Overview
moment is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates.
Affected versions of this package are vulnerable to Directory Traversal when a user provides a locale string which is directly used to switch moment locale.
Details
A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.
Directory Traversal vulnerabilities can be generally divided into two types:
- Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.
st
is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public
route.
If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.
curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa
Note %2e
is the URL encoded version of .
(dot).
- Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as
Zip-Slip
.
One way to achieve this is by using a malicious zip
archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.
The following is an example of a zip
archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/
overwriting the authorized_keys
file:
2018-04-15 22:04:29 ..... 19 19 good.txt
2018-04-15 22:04:42 ..... 20 20 ../../../../../../root/.ssh/authorized_keys
Remediation
Upgrade moment
to version 2.29.2 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution. The function defaultsDeep
could be tricked into adding or modifying properties of Object.prototype
using a constructor
payload.
PoC by Snyk
const mergeFn = require('lodash').defaultsDeep;
const payload = '{"constructor": {"prototype": {"a0": true}}}'
function check() {
mergeFn({}, JSON.parse(payload));
if (({})[`a0`] === true) {
console.log(`Vulnerable to Prototype Pollution via ${payload}`);
}
}
check();
For more information, check out our blog post
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.12 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution via the set
and setwith
functions due to improper user input sanitization.
PoC
lod = require('lodash')
lod.set({}, "__proto__[test2]", "456")
console.log(Object.prototype)
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.17 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution. The functions merge
, mergeWith
, and defaultsDeep
could be tricked into adding or modifying properties of Object.prototype
. This is due to an incomplete fix to CVE-2018-3721
.
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.11 or higher.
References
high severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Code Injection via template
.
PoC
var _ = require('lodash');
_.template('', { variable: '){console.log(process.env)}; with(obj' })()
Remediation
Upgrade lodash
to version 4.17.21 or higher.
References
medium severity
- Vulnerable module: jsonwebtoken
- Introduced through: jsonwebtoken@7.3.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › jsonwebtoken@7.3.0Remediation: Upgrade to jsonwebtoken@9.0.0.
Overview
jsonwebtoken is a JSON Web Token implementation (symmetric and asymmetric)
Affected versions of this package are vulnerable to Use of a Broken or Risky Cryptographic Algorithm such that the library can be misconfigured to use legacy, insecure key types for signature verification. For example, DSA keys could be used with the RS256 algorithm.
Exploitability
Users are affected when using an algorithm and a key type other than the combinations mentioned below:
EC: ES256, ES384, ES512
RSA: RS256, RS384, RS512, PS256, PS384, PS512
RSA-PSS: PS256, PS384, PS512
And for Elliptic Curve algorithms:
ES256: prime256v1
ES384: secp384r1
ES512: secp521r1
Workaround
Users who are unable to upgrade to the fixed version can use the allowInvalidAsymmetricKeyTypes
option to true
in the sign()
and verify()
functions to continue usage of invalid key type/algorithm combination in 9.0.0 for legacy compatibility.
Remediation
Upgrade jsonwebtoken
to version 9.0.0 or higher.
References
medium severity
- Vulnerable module: jsonwebtoken
- Introduced through: jsonwebtoken@7.3.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › jsonwebtoken@7.3.0Remediation: Upgrade to jsonwebtoken@9.0.0.
Overview
jsonwebtoken is a JSON Web Token implementation (symmetric and asymmetric)
Affected versions of this package are vulnerable to Improper Restriction of Security Token Assignment via the secretOrPublicKey
argument due to misconfigurations of the key retrieval function jwt.verify()
. Exploiting this vulnerability might result in incorrect verification of forged tokens when tokens signed with an asymmetric public key could be verified with a symmetric HS256 algorithm.
Note:
This vulnerability affects your application if it supports the usage of both symmetric and asymmetric keys in jwt.verify()
implementation with the same key retrieval function.
Remediation
Upgrade jsonwebtoken
to version 9.0.0 or higher.
References
medium severity
- Vulnerable module: jsonwebtoken
- Introduced through: jsonwebtoken@7.3.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › jsonwebtoken@7.3.0Remediation: Upgrade to jsonwebtoken@9.0.0.
Overview
jsonwebtoken is a JSON Web Token implementation (symmetric and asymmetric)
Affected versions of this package are vulnerable to Improper Authentication such that the lack of algorithm definition in the jwt.verify()
function can lead to signature validation bypass due to defaulting to the none
algorithm for signature verification.
Exploitability
Users are affected only if all of the following conditions are true for the jwt.verify()
function:
A token with no signature is received.
No algorithms are specified.
A falsy (e.g.,
null
,false
,undefined
) secret or key is passed.
Remediation
Upgrade jsonwebtoken
to version 9.0.0 or higher.
References
medium severity
- Vulnerable module: url-parse
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › amqplib@0.5.6 › url-parse@1.4.7
Overview
url-parse is a Small footprint URL parser that works seamlessly across Node.js and browser environments.
Affected versions of this package are vulnerable to Access Restriction Bypass due to improper parsing process, that may lead to incorrect handling of authentication credentials and hostname, which allows bypass of hostname validation.
PoC:
// PoC.js
var parse = require('url-parse')
var cc=parse("http://admin:password123@@127.0.0.1")
//Output:
{ slashes: true,
protocol: 'http:',
hash: '',
query: '',
pathname: '/',
auth: 'admin:password123',
host: '@127.0.0.1',
port: '',
hostname: '@127.0.0.1',
password: 'password123',
username: 'admin',
origin: 'http://@127.0.0.1',
href: 'http://admin:password123@@127.0.0.1/' }
Remediation
Upgrade url-parse
to version 1.5.6 or higher.
References
medium severity
- Vulnerable module: url-parse
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › amqplib@0.5.6 › url-parse@1.4.7
Overview
url-parse is a Small footprint URL parser that works seamlessly across Node.js and browser environments.
Affected versions of this package are vulnerable to Authorization Bypass via the hostname
field of a parsed URL, because "url-parse" is unable to find the correct hostname when no port number is provided in the URL.
PoC:
var Url = require('url-parse');
var PAYLOAD = "http://example.com:";
console.log(Url(PAYLOAD));
// Expected hostname: example.com
// Actual hostname by url-parse: example.com:
Output:
{
slashes: true,
protocol: 'http:',
hash: '',
query: '',
pathname: '/',
auth: '',
host: 'example.com:',
port: '',
hostname: 'example.com:',
password: '',
username: '',
origin: 'http://example.com:',
href: 'http://example.com:/'
}
Remediation
Upgrade url-parse
to version 1.5.8 or higher.
References
medium severity
- Vulnerable module: hoek
- Introduced through: jsonwebtoken@7.3.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › jsonwebtoken@7.3.0 › joi@6.10.1 › hoek@2.16.3Remediation: Upgrade to jsonwebtoken@8.0.0.
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › jsonwebtoken@7.3.0 › joi@6.10.1 › topo@1.1.0 › hoek@2.16.3Remediation: Upgrade to jsonwebtoken@8.0.0.
Overview
hoek is an Utility methods for the hapi ecosystem.
Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object
prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.
PoC by Olivier Arteau (HoLyVieR)
var Hoek = require('hoek');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
var a = {};
console.log("Before : " + a.oops);
Hoek.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade hoek
to version 4.2.1, 5.0.3 or higher.
References
medium severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1Remediation: Open PR to patch lodash@3.10.1.
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1Remediation: Open PR to patch lodash@3.10.1.
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1Remediation: Open PR to patch lodash@3.10.1.
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1Remediation: Open PR to patch lodash@3.10.1.
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object
prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.
PoC by Olivier Arteau (HoLyVieR)
var _= require('lodash');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
var a = {};
console.log("Before : " + a.oops);
_.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade lodash
to version 4.17.5 or higher.
References
medium severity
- Vulnerable module: url-parse
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › amqplib@0.5.6 › url-parse@1.4.7
Overview
url-parse is a Small footprint URL parser that works seamlessly across Node.js and browser environments.
Affected versions of this package are vulnerable to Authorization Bypass Through User-Controlled Key due to incorrect conversion of @
in the protocol field of the HREF.
PoC:
parse = require('url-parse')
console.log(parse("http:@/127.0.0.1"))
Output:
{
slashes: true,
protocol: 'http:',
hash: '',
query: '',
pathname: '/127.0.0.1',
auth: '',
host: '',
port: '',
hostname: '',
password: '',
username: '',
origin: 'null',
href: 'http:///127.0.0.1'
}
Remediation
Upgrade url-parse
to version 1.5.7 or higher.
References
medium severity
- Vulnerable module: moment
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › moment@2.10.2
Overview
moment
is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates.
Affected versions of the package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks for any locale that has separate format and standalone options and format
input can be controlled by the user.
An attacker can provide a specially crafted input to the format
function, which nearly matches the pattern being matched. This will cause the regular expression matching to take a long time, all the while occupying the event loop and preventing it from processing other requests and making the server unavailable (a Denial of Service attack).
Disclosure Timeline
- October 19th, 2016 - Reported the issue to package owner.
- October 19th, 2016 - Issue acknowledged by package owner.
- October 24th, 2016 - Issue fixed and version
2.15.2
released.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
References
medium severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the toNumber
, trim
and trimEnd
functions.
POC
var lo = require('lodash');
function build_blank (n) {
var ret = "1"
for (var i = 0; i < n; i++) {
ret += " "
}
return ret + "1";
}
var s = build_blank(50000)
var time0 = Date.now();
lo.trim(s)
var time_cost0 = Date.now() - time0;
console.log("time_cost0: " + time_cost0)
var time1 = Date.now();
lo.toNumber(s)
var time_cost1 = Date.now() - time1;
console.log("time_cost1: " + time_cost1)
var time2 = Date.now();
lo.trimEnd(s)
var time_cost2 = Date.now() - time2;
console.log("time_cost2: " + time_cost2)
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade lodash
to version 4.17.21 or higher.
References
medium severity
- Vulnerable module: moment
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › moment@2.10.2Remediation: Open PR to patch moment@2.10.2.
Overview
moment
is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates.
An attacker can provide a long value to the duration
function, which nearly matches the pattern being matched. This will cause the regular expression matching to take a long time, all the while occupying the event loop and preventing it from processing other requests and making the server unavailable (a Denial of Service attack).
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade moment
to version 2.11.2
or greater.
References
medium severity
- Vulnerable module: url-parse
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › amqplib@0.5.6 › url-parse@1.4.7
Overview
url-parse is a Small footprint URL parser that works seamlessly across Node.js and browser environments.
Affected versions of this package are vulnerable to Improper Input Validation. It mishandles certain uses of backslash such as http:\/
and interprets the URI as a relative path.
Remediation
Upgrade url-parse
to version 1.5.0 or higher.
References
medium severity
- Vulnerable module: url-parse
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › amqplib@0.5.6 › url-parse@1.4.7
Overview
url-parse is a Small footprint URL parser that works seamlessly across Node.js and browser environments.
Affected versions of this package are vulnerable to Open Redirect due to improper escaping of slash characters.
Remediation
Upgrade url-parse
to version 1.5.2 or higher.
References
medium severity
- Vulnerable module: passport
- Introduced through: passport@0.4.1
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › passport@0.4.1Remediation: Upgrade to passport@0.6.0.
Overview
passport is a Simple, unobtrusive authentication for Node.js.
Affected versions of this package are vulnerable to Session Fixation. When a user logs in or logs out, the session is regenerated instead of being closed.
Remediation
Upgrade passport
to version 0.6.0 or higher.
References
medium severity
- Vulnerable module: lodash
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › machina@2.0.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › machina@1.1.2 › lodash@3.10.1
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › monologue.js@0.3.5 › riveter@0.2.0 › lodash@2.4.2
Overview
lodash is a modern JavaScript utility library delivering modularity, performance, & extras.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It parses dates using regex strings, which may cause a slowdown of 2 seconds per 50k characters.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade lodash
to version 4.17.11 or higher.
References
medium severity
- Module: sequelize-stream
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › sequelize-stream@1.0.2
Artistic-2.0 license
low severity
- Vulnerable module: debug
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › debug@2.2.0Remediation: Open PR to patch debug@2.2.0.
Overview
debug is a small debugging utility.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) in the function useColors
via manipulation of the str
argument.
The vulnerability can cause a very low impact of about 2 seconds of matching time for data 50k characters long.
Note: CVE-2017-20165 is a duplicate of this vulnerability.
PoC
Use the following regex in the %o
formatter.
/\s*\n\s*/
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade debug
to version 2.6.9, 3.1.0, 3.2.7, 4.3.1 or higher.
References
low severity
- Vulnerable module: moment
- Introduced through: trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › moment@2.10.2
Overview
moment is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). It used a regular expression (/[0-9]*['a-z\u00A0-\u05FF\u0700-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]+|[\u0600-\u06FF\/]+(\s*?[\u0600-\u06FF]+){1,2}/i
) in order to parse dates specified as strings. This can cause a very low impact of about 2 seconds matching time for data 50k characters long.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade moment
to version 2.19.3 or higher.
References
low severity
- Vulnerable module: ms
- Introduced through: jsonwebtoken@7.3.0 and trailpack-proxy-email@2.1.0
Detailed paths
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › jsonwebtoken@7.3.0 › ms@0.7.3Remediation: Upgrade to jsonwebtoken@7.4.1.
-
Introduced through: trailpack-proxy-passport@calistyle/trailpack-proxy-passport#40d52fee67cf8bbe0ccf916035726d7521274d18 › trailpack-proxy-email@2.1.0 › trailpack-proxy-engine@2.1.13 › rabbot@1.1.0 › whistlepunk@0.3.3 › debug@2.2.0 › ms@0.7.1Remediation: Open PR to patch ms@0.7.1.
Overview
ms
is a tiny millisecond conversion utility.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms()
function.
Proof of concept
ms = require('ms');
ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s
Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.
For more information on Regular Expression Denial of Service (ReDoS)
attacks, go to our blog.
Disclosure Timeline
- Feb 9th, 2017 - Reported the issue to package owner.
- Feb 11th, 2017 - Issue acknowledged by package owner.
- April 12th, 2017 - Fix PR opened by Snyk Security Team.
- May 15th, 2017 - Vulnerability published.
- May 16th, 2017 - Issue fixed and version
2.0.0
released. - May 21th, 2017 - Patches released for versions
>=0.7.1, <=1.0.0
.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ms
to version 2.0.0 or higher.