bahmutov/next-update

Tests if module's dependencies can be updated to the newer version without breaking the tests.
Vulnerabilities 5 via 14 paths
Dependencies 282
Source GitHub
Commit 230d136b

Snyk continuously finds and fixes vulnerabilities in your dependencies.

Filter by issue type
  • 1
  • 4
Filter by issue policy
  • 0
  • 0
medium severity

Uninitialized Memory Exposure

  • Vulnerable module: tunnel-agent
  • Introduced through: request@2.74.0

Detailed paths

  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 request@2.74.0 tunnel-agent@0.4.3
    Remediation: Upgrade to request@2.81.0.

Overview

tunnel-agent is HTTP proxy tunneling agent. Affected versions of the package are vulnerable to Uninitialized Memory Exposure.

A possible memory disclosure vulnerability exists when a value of type number is used to set the proxy.auth option of a request request and results in a possible uninitialized memory exposures in the request body.

This is a result of unobstructed use of the Buffer constructor, whose insecure default constructor increases the odds of memory leakage.

Details

Constructing a Buffer class with integer N creates a Buffer of length N with raw (not "zero-ed") memory.

In the following example, the first call would allocate 100 bytes of memory, while the second example will allocate the memory needed for the string "100":

// uninitialized Buffer of length 100
        x = new Buffer(100);
        // initialized Buffer with value of '100'
        x = new Buffer('100');
        

tunnel-agent's request construction uses the default Buffer constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw server side memory, potentially holding secrets, private data and code. This is a similar vulnerability to the infamous Heartbleed flaw in OpenSSL.

Proof of concept by ChALkeR

require('request')({
          method: 'GET',
          uri: 'http://www.example.com',
          tunnel: true,
          proxy:{
              protocol: 'http:',
              host:"127.0.0.1",
              port:8080,
              auth:80
          }
        });
        

You can read more about the insecure Buffer behavior on our blog.

Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.

Remediation

Upgrade tunnel-agent to version 0.6.0 or higher.

References

low severity

Prototype Pollution

  • Vulnerable module: hoek
  • Introduced through: request@2.74.0

Detailed paths

  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 request@2.74.0 hawk@3.1.3 hoek@2.16.3
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 request@2.74.0 hawk@3.1.3 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 request@2.74.0 hawk@3.1.3 cryptiles@2.0.5 boom@2.10.1 hoek@2.16.3
    Remediation: Upgrade to request@2.82.0.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 request@2.74.0 hawk@3.1.3 sntp@1.0.9 hoek@2.16.3
    Remediation: Upgrade to request@2.82.0.

Overview

hoek is a Utility methods for the hapi ecosystem.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var Hoek = require('hoek');
        var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
        
        var a = {};
        console.log("Before : " + a.oops);
        Hoek.merge({}, JSON.parse(malicious_payload));
        console.log("After : " + a.oops);
        
        

Remediation

Upgrade hoek to versions 4.2.1, 5.0.3 or higher.

References

low severity

Prototype Pollution

  • Vulnerable module: lodash
  • Introduced through: lodash@3.10.1, changed-log@0.11.0 and others

Detailed paths

  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 lodash@3.10.1
    Remediation: Upgrade to lodash@4.17.5.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 changed-log@0.11.0 lodash@3.10.1
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 deps-ok@1.1.0 lodash@3.10.1

Overview

lodash is a javaScript utility library delivering modularity, performance & extras.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var _= require('lodash');
        var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
        
        var a = {};
        console.log("Before : " + a.oops);
        _.merge({}, JSON.parse(malicious_payload));
        console.log("After : " + a.oops);
        

Remediation

Upgrade lodash to version 4.17.5 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: debug
  • Introduced through: debug@2.2.0, npm-utils@1.7.1 and others

Detailed paths

  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 debug@2.2.0
    Remediation: Upgrade to debug@2.6.9.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 npm-utils@1.7.1 debug@2.2.0
    Remediation: Run snyk wizard to patch debug@2.2.0.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 changed-log@0.11.0 debug@2.2.0
    Remediation: Run snyk wizard to patch debug@2.2.0.

Overview

debug is a JavaScript debugging utility modelled after Node.js core's debugging technique..

debug uses printf-style formatting. Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS) attacks via the the %o formatter (Pretty-print an Object all on a single line). It used a regular expression (/\s*\n\s*/g) in order to strip whitespaces and replace newlines with spaces, in order to join the data into a single line. This can cause a very low impact of about 2 seconds matching time for data 50k characters long.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Many Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size), allowing an attacker to exploit this and can cause the program to enter these extreme situations by using a specially crafted input and cause the service to excessively consume CPU, resulting in a Denial of Service.

You can read more about Regular Expression Denial of Service (ReDoS) on our blog.

Remediation

Upgrade debug to version 2.6.9, 3.1.0 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: ms
  • Introduced through: debug@2.2.0, npm-utils@1.7.1 and others

Detailed paths

  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 debug@2.2.0 ms@0.7.1
    Remediation: Upgrade to debug@2.6.7.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 npm-utils@1.7.1 debug@2.2.0 ms@0.7.1
    Remediation: Upgrade to npm-utils@2.0.0.
  • Introduced through: next-update@bahmutov/next-update#230d136b5c68dadb1fd5459619df8f7678d28429 changed-log@0.11.0 debug@2.2.0 ms@0.7.1
    Remediation: Run snyk wizard to patch ms@0.7.1.

Overview

ms is a tiny millisecond conversion utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms() function.

Proof of concept

ms = require('ms');
        ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s
        

Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.

For more information on Regular Expression Denial of Service (ReDoS) attacks, go to our blog.

Disclosure Timeline

  • Feb 9th, 2017 - Reported the issue to package owner.
  • Feb 11th, 2017 - Issue acknowledged by package owner.
  • April 12th, 2017 - Fix PR opened by Snyk Security Team.
  • May 15th, 2017 - Vulnerability published.
  • May 16th, 2017 - Issue fixed and version 2.0.0 released.
  • May 21th, 2017 - Patches released for versions >=0.7.1, <=1.0.0.

Remediation

Upgrade ms to version 2.0.0 or higher.

References