bag-man/nodestack

Description of project.
Vulnerabilities 3 via 17 paths
Dependencies 661
Source GitHub
Commit a3c5814b

Snyk continuously finds and fixes vulnerabilities in your dependencies.

Filter by issue type
  • 1
  • 2
Filter by issue policy
  • 0
  • 0
medium severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: parsejson
  • Introduced through: socket.io@1.7.4

Detailed paths

  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 engine.io-client@1.8.5 parsejson@0.0.3

Overview

parsejson is a Method that parses a JSON string and returns a JSON object.

Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS) attacks. An attacker may pass a specially crafted JSON data, causing the server to hang.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/
        

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
        0.04s user 0.01s system 95% cpu 0.052 total
        
        $ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
        1.79s user 0.02s system 99% cpu 1.812 total
        

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

There is no fix available.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: debug
  • Introduced through: socket.io@1.7.4

Detailed paths

  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 debug@2.3.3
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 engine.io@1.8.5 debug@2.3.3
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-adapter@0.5.0 debug@2.3.3
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 debug@2.3.3
    Remediation: Upgrade to socket.io@2.0.2.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 engine.io-client@1.8.5 debug@2.3.3
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-parser@2.3.1 debug@2.2.0
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-adapter@0.5.0 socket.io-parser@2.3.1 debug@2.2.0
    Remediation: Run snyk wizard to patch debug@2.2.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 socket.io-parser@2.3.1 debug@2.2.0
    Remediation: Upgrade to socket.io@2.0.0.

Overview

debug is a JavaScript debugging utility modelled after Node.js core's debugging technique..

debug uses printf-style formatting. Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS) attacks via the the %o formatter (Pretty-print an Object all on a single line). It used a regular expression (/\s*\n\s*/g) in order to strip whitespaces and replace newlines with spaces, in order to join the data into a single line. This can cause a very low impact of about 2 seconds matching time for data 50k characters long.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/
        

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
        0.04s user 0.01s system 95% cpu 0.052 total
        
        $ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
        1.79s user 0.02s system 99% cpu 1.812 total
        

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade debug to version 2.6.9, 3.1.0 or higher.

References

low severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: ms
  • Introduced through: socket.io@1.7.4

Detailed paths

  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 debug@2.3.3 ms@0.7.2
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 engine.io@1.8.5 debug@2.3.3 ms@0.7.2
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-adapter@0.5.0 debug@2.3.3 ms@0.7.2
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 debug@2.3.3 ms@0.7.2
    Remediation: Upgrade to socket.io@2.0.2.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 engine.io-client@1.8.5 debug@2.3.3 ms@0.7.2
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-parser@2.3.1 debug@2.2.0 ms@0.7.1
    Remediation: Upgrade to socket.io@2.0.0.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-adapter@0.5.0 socket.io-parser@2.3.1 debug@2.2.0 ms@0.7.1
    Remediation: Run snyk wizard to patch ms@0.7.1.
  • Introduced through: ProjectName@bag-man/nodestack#a3c5814b9e6258c7245f5eedd08d33797b07776a socket.io@1.7.4 socket.io-client@1.7.4 socket.io-parser@2.3.1 debug@2.2.0 ms@0.7.1
    Remediation: Upgrade to socket.io@2.0.0.

Overview

ms is a tiny millisecond conversion utility.

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms() function.

Proof of concept

ms = require('ms');
        ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s
        

Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.

For more information on Regular Expression Denial of Service (ReDoS) attacks, go to our blog.

Disclosure Timeline

  • Feb 9th, 2017 - Reported the issue to package owner.
  • Feb 11th, 2017 - Issue acknowledged by package owner.
  • April 12th, 2017 - Fix PR opened by Snyk Security Team.
  • May 15th, 2017 - Vulnerability published.
  • May 16th, 2017 - Issue fixed and version 2.0.0 released.
  • May 21th, 2017 - Patches released for versions >=0.7.1, <=1.0.0.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/
        

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
        0.04s user 0.01s system 95% cpu 0.052 total
        
        $ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
        1.79s user 0.02s system 99% cpu 1.812 total
        

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade ms to version 2.0.0 or higher.

References