Vulnerabilities

10 via 34 paths

Dependencies

275

Source

GitHub

Commit

9a9bb822

Find, fix and prevent vulnerabilities in your code.

Severity
  • 1
  • 6
  • 3
Status
  • 10
  • 0
  • 0

high severity

Regular Expression Denial of Service (ReDoS)

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.19.1.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the Headers.set() and Headers.append() methods, when untrusted values are passed into the functions. This is due to the inefficient regular expression used to normalize the values in the headerValueNormalize() utility function.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade undici to version 5.19.1 or higher.

References

medium severity

Server-side Request Forgery (SSRF)

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.8.2.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) when an application takes in unsanitized user input into the path/pathname option of undici.request.

Remediation

Upgrade undici to version 5.8.2 or higher.

References

medium severity

Missing Release of Resource after Effective Lifetime

  • Vulnerable module: inflight
  • Introduced through: libnpmpack@3.1.0, eslint@8.57.0 and others

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 cacache@15.3.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 @npmcli/run-script@2.0.0 node-gyp@8.4.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 npm-packlist@3.0.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a eslint@8.57.0 file-entry-cache@6.0.1 flat-cache@3.2.0 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 cacache@15.3.0 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 @npmcli/run-script@2.0.0 node-gyp@8.4.1 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpublish@4.0.2 npm-registry-fetch@11.0.0 make-fetch-happen@9.1.0 cacache@15.3.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a npm-profile@5.0.4 npm-registry-fetch@11.0.0 make-fetch-happen@9.1.0 cacache@15.3.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 @npmcli/run-script@2.0.0 node-gyp@8.4.1 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 cacache@15.3.0 @npmcli/move-file@1.1.2 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpublish@4.0.2 npm-registry-fetch@11.0.0 make-fetch-happen@9.1.0 cacache@15.3.0 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a npm-profile@5.0.4 npm-registry-fetch@11.0.0 make-fetch-happen@9.1.0 cacache@15.3.0 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 @npmcli/run-script@2.0.0 node-gyp@8.4.1 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 @npmcli/run-script@2.0.0 node-gyp@8.4.1 make-fetch-happen@9.1.0 cacache@15.3.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 npm-registry-fetch@12.0.2 make-fetch-happen@10.2.1 cacache@16.1.3 glob@8.1.0 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpublish@4.0.2 npm-registry-fetch@11.0.0 make-fetch-happen@9.1.0 cacache@15.3.0 @npmcli/move-file@1.1.2 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a npm-profile@5.0.4 npm-registry-fetch@11.0.0 make-fetch-happen@9.1.0 cacache@15.3.0 @npmcli/move-file@1.1.2 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 @npmcli/run-script@2.0.0 node-gyp@8.4.1 make-fetch-happen@9.1.0 cacache@15.3.0 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 npm-registry-fetch@12.0.2 make-fetch-happen@10.2.1 cacache@16.1.3 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 @npmcli/run-script@2.0.0 node-gyp@8.4.1 make-fetch-happen@9.1.0 cacache@15.3.0 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 @npmcli/run-script@2.0.0 node-gyp@8.4.1 make-fetch-happen@9.1.0 cacache@15.3.0 @npmcli/move-file@1.1.2 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 @npmcli/run-script@2.0.0 node-gyp@8.4.1 make-fetch-happen@9.1.0 cacache@15.3.0 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 npm-registry-fetch@12.0.2 make-fetch-happen@10.2.1 cacache@16.1.3 @npmcli/move-file@2.0.1 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6
  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a libnpmpack@3.1.0 pacote@12.0.3 @npmcli/run-script@2.0.0 node-gyp@8.4.1 make-fetch-happen@9.1.0 cacache@15.3.0 @npmcli/move-file@1.1.2 rimraf@3.0.2 glob@7.2.3 inflight@1.0.6

Overview

Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.

Exploiting this vulnerability results in crashing the node process or in the application crash.

Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.

To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.

PoC

const inflight = require('inflight');

function testInflight() {
  let i = 0;
  function scheduleNext() {
    let key = `key-${i++}`;
    const callback = () => {
    };
    for (let j = 0; j < 1000000; j++) {
      inflight(key, callback);
    }

    setImmediate(scheduleNext);
  }


  if (i % 100 === 0) {
    console.log(process.memoryUsage());
  }

  scheduleNext();
}

testInflight();

Remediation

There is no fixed version for inflight.

References

medium severity

CRLF Injection

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.8.2.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to CRLF Injection when using unsanitized input as request headers (for example, inside the content-type header).

Remediation

Upgrade undici to version 5.8.2 or higher.

References

medium severity

Improper Certificate Validation

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.5.1.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to Improper Certificate Validation due to Undici.ProxyAgent missing verification of the remote server's certificate, which leads to exposure of all the requests and responses data to the proxy.

PoC:

setGlobalDispatcher(new ProxyAgent('http://localhost:8000/')) // HTTP Proxy
// or
undici.request('https://example.com/', { dispatcher: new ProxyAgent('http://localhost:8000') }) // HTTP Proxy
// or
fetch('https://example.com/', { dispatcher: new ProxyAgent('http://localhost:8000') }) // HTTP Proxy

Workarounds:

If upgrading is not possible - avoid using ProxyAgent as a dispatcher for TLS Connections.

Remediation

Upgrade undici to version 5.5.1 or higher.

References

medium severity

CRLF Injection

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.8.0.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to CRLF Injection in lib/core/request.js that allows HTTP requests to be injected via unexpected CRLF (\r\n) sequences in request path, method, and headers received from untrusted sources.

Remediation

Upgrade undici to version 5.8.0 or higher.

References

medium severity

CRLF Injection

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.19.1.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to CRLF Injection due to missing protection for the host HTTP header.

Workaround

Users who are unable to upgrade to the fixed version should sanitize the headers.host string before passing to undici.

Remediation

Upgrade undici to version 5.19.1 or higher.

References

low severity

Information Exposure

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.26.2.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to Information Exposure during the Cookie headers handling process. An attacker can potentially leak sensitive information to a third-party site or a malicious actor who can control the redirection target (i.e., an open redirector) by exploiting the disconnect between the spec's assumptions and the implementation of fetch.

Note:

This is only exploitable if the attacker can control the redirection target.

Remediation

Upgrade undici to version 5.26.2 or higher.

References

low severity

Permissive Cross-domain Policy with Untrusted Domains

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.28.3.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to Permissive Cross-domain Policy with Untrusted Domains due to not clearing Proxy-Authentication headers on cross-origin redirects. An attacker can intercept the improperly cleared headers.

Remediation

Upgrade undici to version 5.28.3, 6.6.1 or higher.

References

low severity

Information Exposure

  • Vulnerable module: undici
  • Introduced through: undici@4.16.0

Detailed paths

  • Introduced through: @xh4h/loki@xh4h/Loki#9a9bb8224d8f08f6ce0ecc422174b9ae91ab498a undici@4.16.0
    Remediation: Upgrade to undici@5.8.0.

Overview

undici is an An HTTP/1.1 client, written from scratch for Node.js

Affected versions of this package are vulnerable to Information Exposure by not clearing cookie headers upon third party redirect.

Note: This is only exploitable when maxRedirections is changed from its default value of 0.

Remediation

Upgrade undici to version 5.8.0 or higher.

References