Find, fix and prevent vulnerabilities in your code.
critical severity
new
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Interpretation Conflict via the asn1.validate() function. An attacker can cause schema validation to become desynchronized, resulting in semantic divergence that may allow bypassing cryptographic verifications and security decisions, by passing in ASN.1 data with optional parameters that may be interpreted as object boundaries.
Remediation
Upgrade node-forge to version 1.3.2 or higher.
References
high severity
new
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Uncontrolled Recursion via the fromDer function in asn1.js, which lacks recursion depth. An attacker can cause stack exhaustion and disrupt service availability by submitting specially crafted, deeply nested DER-encoded ASN.1 data.
Remediation
Upgrade node-forge to version 1.3.2 or higher.
References
high severity
- Vulnerable module: json-bigint
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gcp-metadata@3.5.0 › json-bigint@0.3.1Remediation: Upgrade to dialogflow@4.0.3.
Overview
json-bigint is a JSON.parse with bigints support
Affected versions of this package are vulnerable to Prototype Pollution via the parse function.
POC
const JSONbig = require('json-bigint')
const json = '{"__proto__":1000000000000000,"c":{"__proto__":[],"length":1e200}}'
const r = JSONbig.parse(json)
console.log(r.toString())
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade json-bigint to version 1.0.0 or higher.
References
high severity
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSA's PKCS#1 v1.5 signature verification code which does not check for tailing garbage bytes after decoding a DigestInfo ASN.1 structure. This can allow padding bytes to be removed and garbage data added to forge a signature when a low public exponent is being used.
Remediation
Upgrade node-forge to version 1.3.0 or higher.
References
medium severity
- Vulnerable module: @grpc/grpc-js
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › @grpc/grpc-js@1.3.8Remediation: Upgrade to dialogflow@4.0.3.
Overview
@grpc/grpc-js is a gRPC Library for Node
Affected versions of this package are vulnerable to Uncontrolled Resource Consumption ('Resource Exhaustion') via the grpc.max_receive_message_length channel option. An attacker can cause a denial of service by sending messages that exceed the configured limits, which are then buffered or decompressed into memory.
Remediation
Upgrade @grpc/grpc-js to version 1.8.22, 1.9.15, 1.10.9 or higher.
References
medium severity
new
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Integer Overflow or Wraparound via the derToOid function in the asn1.js file, which decodes ASN.1 structures containing OIDs with oversized arcs. An attacker can bypass security decisions based on OID validation by crafting malicious ASN.1 data that exploits 32-bit bitwise truncation.
Remediation
Upgrade node-forge to version 1.3.2 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Prototype Pollution via the forge.debug API if called with untrusted input.
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Objectrecursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__ defined with Object.defineProperty() , the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object and the source of Object as defined by the attacker. Properties are then copied on the Object prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source).
lodash and Hoek are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue. myValue is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
| Type | Origin | Short description |
|---|---|---|
| Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object. In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
| Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr). In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
| Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin, then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true, they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype).Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)), breaking the prototype chain and preventing pollution.As a best practice use
Mapinstead ofObject.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade node-forge to version 1.0.0 or higher.
References
medium severity
- Vulnerable module: inflight
- Introduced through: archiver@3.1.1 and unzipper@0.10.14
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › archiver@3.1.1 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › archiver@3.1.1 › archiver-utils@2.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › archiver@3.1.1 › zip-stream@2.1.3 › archiver-utils@2.1.0 › glob@7.2.3 › inflight@1.0.6
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › unzipper@0.10.14 › fstream@1.0.12 › rimraf@2.7.1 › glob@7.2.3 › inflight@1.0.6
Overview
Affected versions of this package are vulnerable to Missing Release of Resource after Effective Lifetime via the makeres function due to improperly deleting keys from the reqs object after execution of callbacks. This behavior causes the keys to remain in the reqs object, which leads to resource exhaustion.
Exploiting this vulnerability results in crashing the node process or in the application crash.
Note: This library is not maintained, and currently, there is no fix for this issue. To overcome this vulnerability, several dependent packages have eliminated the use of this library.
To trigger the memory leak, an attacker would need to have the ability to execute or influence the asynchronous operations that use the inflight module within the application. This typically requires access to the internal workings of the server or application, which is not commonly exposed to remote users. Therefore, “Attack vector” is marked as “Local”.
PoC
const inflight = require('inflight');
function testInflight() {
let i = 0;
function scheduleNext() {
let key = `key-${i++}`;
const callback = () => {
};
for (let j = 0; j < 1000000; j++) {
inflight(key, callback);
}
setImmediate(scheduleNext);
}
if (i % 100 === 0) {
console.log(process.memoryUsage());
}
scheduleNext();
}
testInflight();
Remediation
There is no fixed version for inflight.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSA's PKCS#1 v1.5 signature verification code which does not properly check DigestInfo for a proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.
Remediation
Upgrade node-forge to version 1.3.0 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Improper Verification of Cryptographic Signature due to RSAs PKCS#1` v1.5 signature verification code which is lenient in checking the digest algorithm structure. This can allow a crafted structure that steals padding bytes and uses unchecked portion of the PKCS#1 encoded message to forge a signature when a low public exponent is being used.
Remediation
Upgrade node-forge to version 1.3.0 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: dialogflow@0.10.3
Detailed paths
-
Introduced through: dialogflow-cli@onedox/dialogflow-cli#d9a1ccd443aa3b228ea566bf1b15af2d7e1d148b › dialogflow@0.10.3 › google-gax@1.15.4 › google-auth-library@5.10.1 › gtoken@4.1.4 › google-p12-pem@2.0.5 › node-forge@0.10.0Remediation: Upgrade to dialogflow@4.0.3.
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Open Redirect via parseUrl function when it mishandles certain uses of backslash such as https:/\/\/\ and interprets the URI as a relative path.
PoC:
// poc.js
var forge = require("node-forge");
var url = forge.util.parseUrl("https:/\/\/\www.github.com/foo/bar");
console.log(url);
// Output of node poc.js:
{
full: 'https://',
scheme: 'https',
host: '',
port: 443,
path: '/www.github.com/foo/bar', <<<---- path should be "/foo/bar"
fullHost: ''
}
Remediation
Upgrade node-forge to version 1.0.0 or higher.