Find, fix and prevent vulnerabilities in your code.
high severity
- Vulnerable module: netmask
- Introduced through: netmask@1.0.6
Detailed paths
-
Introduced through: webhook-tunnel@lmammino/webhook-tunnel#79a1e3b2e92f27bd4f8eb7ec3636ff75c799fb12 › netmask@1.0.6Remediation: Upgrade to netmask@2.0.1.
Overview
netmask is a library to parse IPv4 CIDR blocks.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF). It incorrectly evaluates individual IPv4 octets that contain octal strings as left-stripped integers, leading to an inordinate attack surface on hundreds of thousands of projects that rely on netmask
to filter or evaluate IPv4 block ranges, both inbound and outbound.
For example, a remote unauthenticated attacker can request local resources using input data 0177.0.0.1
(127.0.0.1
), which netmask
evaluates as the public IP 177.0.0.1
.
Contrastingly, a remote authenticated or unauthenticated attacker can input the data 0127.0.0.01
(87.0.0.1
) as localhost, yet the input data is a public IP and can potentially cause local and remote file inclusion (LFI/RFI).
A remote authenticated or unauthenticated attacker can bypass packages that rely on netmask
to filter IP address blocks to reach intranets, VPNs, containers, adjacent VPC instances, or LAN hosts, using input data such as 012.0.0.1
(10.0.0.1
), which netmask
evaluates as 12.0.0.1
(public).
NOTE: This vulnerability has also been identified as: CVE-2021-29418
Remediation
Upgrade netmask
to version 2.0.1 or higher.
References
high severity
- Vulnerable module: netmask
- Introduced through: netmask@1.0.6
Detailed paths
-
Introduced through: webhook-tunnel@lmammino/webhook-tunnel#79a1e3b2e92f27bd4f8eb7ec3636ff75c799fb12 › netmask@1.0.6Remediation: Upgrade to netmask@2.0.1.
Overview
netmask is a library to parse IPv4 CIDR blocks.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF). It incorrectly evaluates individual IPv4 octets that contain octal strings as left-stripped integers, leading to an inordinate attack surface on hundreds of thousands of projects that rely on netmask
to filter or evaluate IPv4 block ranges, both inbound and outbound.
For example, a remote unauthenticated attacker can request local resources using input data 0177.0.0.1
(127.0.0.1
), which netmask
evaluates as the public IP 177.0.0.1
.
Contrastingly, a remote authenticated or unauthenticated attacker can input the data 0127.0.0.01
(87.0.0.1
) as localhost, yet the input data is a public IP and can potentially cause local and remote file inclusion (LFI/RFI).
A remote authenticated or unauthenticated attacker can bypass packages that rely on netmask
to filter IP address blocks to reach intranets, VPNs, containers, adjacent VPC instances, or LAN hosts, using input data such as 012.0.0.1
(10.0.0.1
), which netmask
evaluates as 12.0.0.1
(public).
NOTE: This vulnerability has also been identified as: CVE-2021-28918
Remediation
Upgrade netmask
to version 2.0.1 or higher.
References
high severity
- Vulnerable module: ansi-regex
- Introduced through: yargs@12.0.5
Detailed paths
-
Introduced through: webhook-tunnel@lmammino/webhook-tunnel#79a1e3b2e92f27bd4f8eb7ec3636ff75c799fb12 › yargs@12.0.5 › cliui@4.1.0 › wrap-ansi@2.1.0 › strip-ansi@3.0.1 › ansi-regex@2.1.1Remediation: Upgrade to yargs@13.2.4.
-
Introduced through: webhook-tunnel@lmammino/webhook-tunnel#79a1e3b2e92f27bd4f8eb7ec3636ff75c799fb12 › yargs@12.0.5 › cliui@4.1.0 › wrap-ansi@2.1.0 › string-width@1.0.2 › strip-ansi@3.0.1 › ansi-regex@2.1.1Remediation: Upgrade to yargs@13.2.4.
Overview
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to the sub-patterns [[\\]()#;?]*
and (?:;[-a-zA-Z\\d\\/#&.:=?%@~_]*)*
.
PoC
import ansiRegex from 'ansi-regex';
for(var i = 1; i <= 50000; i++) {
var time = Date.now();
var attack_str = "\u001B["+";".repeat(i*10000);
ansiRegex().test(attack_str)
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade ansi-regex
to version 3.0.1, 4.1.1, 5.0.1, 6.0.1 or higher.
References
medium severity
- Vulnerable module: yargs-parser
- Introduced through: yargs@12.0.5
Detailed paths
-
Introduced through: webhook-tunnel@lmammino/webhook-tunnel#79a1e3b2e92f27bd4f8eb7ec3636ff75c799fb12 › yargs@12.0.5 › yargs-parser@11.1.1Remediation: Upgrade to yargs@13.1.0.
Overview
yargs-parser is a mighty option parser used by yargs.
Affected versions of this package are vulnerable to Prototype Pollution. The library could be tricked into adding or modifying properties of Object.prototype
using a __proto__
payload.
Our research team checked several attack vectors to verify this vulnerability:
- It could be used for privilege escalation.
- The library could be used to parse user input received from different sources:
- terminal emulators
- system calls from other code bases
- CLI RPC servers
PoC by Snyk
const parser = require("yargs-parser");
console.log(parser('--foo.__proto__.bar baz'));
console.log(({}).bar);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
Unsafe
Object
recursive mergeProperty definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named __proto__
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to __proto__.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
Application server
Web server
Web browser
How to prevent
Freeze the prototype— use
Object.freeze (Object.prototype)
.Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution.As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade yargs-parser
to version 5.0.1, 13.1.2, 15.0.1, 18.1.1 or higher.