Find, fix and prevent vulnerabilities in your code.
critical severity
- Vulnerable module: multer
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › multer@0.1.8Remediation: Upgrade to swagger-express-middleware@3.0.0.
Overview
Affected versions of this package are vulnerable to Uncaught Exception in makeMiddleware
, when processing a file upload request. An attacker can cause the application to crash by sending a request with a field name containing an empty string.
Remediation
Upgrade multer
to version 2.0.1 or higher.
References
high severity
- Vulnerable module: multer
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › multer@0.1.8Remediation: Upgrade to swagger-express-middleware@3.0.0.
Overview
Affected versions of this package are vulnerable to Missing Release of Memory after Effective Lifetime due to improper handling of error events in HTTP request streams, which fails to close the internal busboy
stream. An attacker can cause a denial of service by repeatedly triggering errors in file upload streams, leading to resource exhaustion and memory leaks.
Note:
This is only exploitable if the server is handling file uploads.
Remediation
Upgrade multer
to version 2.0.0 or higher.
References
high severity
- Vulnerable module: multer
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › multer@0.1.8Remediation: Upgrade to swagger-express-middleware@3.0.0.
Overview
Affected versions of this package are vulnerable to Uncaught Exception due to an error
event thrown by busboy
. An attacker can cause a full nodejs application to crash by sending a specially crafted multi-part upload request.
PoC
const express = require('express')
const multer = require('multer')
const http = require('http')
const upload = multer({ dest: 'uploads/' })
const port = 8888
const app = express()
app.post('/upload', upload.single('file'), function (req, res) {
res.send({})
})
app.listen(port, () => {
console.log(`Listening on port ${port}`)
const boundary = 'AaB03x'
const body = [
'--' + boundary,
'Content-Disposition: form-data; name="file"; filename="test.txt"',
'Content-Type: text/plain',
'',
'test without end boundary'
].join('\r\n')
const options = {
hostname: 'localhost',
port,
path: '/upload',
method: 'POST',
headers: {
'content-type': 'multipart/form-data; boundary=' + boundary,
'content-length': body.length,
}
}
const req = http.request(options, (res) => {
console.log(res.statusCode)
})
req.on('error', (err) => {
console.error(err)
})
req.write(body)
req.end()
})
Remediation
Upgrade multer
to version 2.0.0 or higher.
References
high severity
- Vulnerable module: dicer
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › multer@0.1.8 › busboy@0.2.14 › dicer@0.2.5
Overview
Affected versions of this package are vulnerable to Denial of Service (DoS). A malicious attacker can send a modified form to server, and crash the nodejs service. An attacker could sent the payload again and again so that the service continuously crashes.
PoC
await fetch('http://127.0.0.1:8000', { method: 'POST', headers: { ['content-type']: 'multipart/form-data; boundary=----WebKitFormBoundaryoo6vortfDzBsDiro', ['content-length']: '145', connection: 'keep-alive', }, body: '------WebKitFormBoundaryoo6vortfDzBsDiro\r\n Content-Disposition: form-data; name="bildbeschreibung"\r\n\r\n\r\n------WebKitFormBoundaryoo6vortfDzBsDiro--' });
Remediation
There is no fixed version for dicer
.
References
high severity
- Vulnerable module: qs
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › multer@0.1.8 › qs@1.2.2Remediation: Upgrade to swagger-express-middleware@3.0.0.
Overview
qs is a querystring parser that supports nesting and arrays, with a depth limit.
Affected versions of this package are vulnerable to Prototype Override Protection Bypass. By default qs
protects against attacks that attempt to overwrite an object's existing prototype properties, such as toString()
, hasOwnProperty()
,etc.
From qs
documentation:
By default parameters that would overwrite properties on the object prototype are ignored, if you wish to keep the data from those fields either use plainObjects as mentioned above, or set allowPrototypes to true which will allow user input to overwrite those properties. WARNING It is generally a bad idea to enable this option as it can cause problems when attempting to use the properties that have been overwritten. Always be careful with this option.
Overwriting these properties can impact application logic, potentially allowing attackers to work around security controls, modify data, make the application unstable and more.
In versions of the package affected by this vulnerability, it is possible to circumvent this protection and overwrite prototype properties and functions by prefixing the name of the parameter with [
or ]
. e.g. qs.parse("]=toString")
will return {toString = true}
, as a result, calling toString()
on the object will throw an exception.
Example:
qs.parse('toString=foo', { allowPrototypes: false })
// {}
qs.parse("]=toString", { allowPrototypes: false })
// {toString = true} <== prototype overwritten
For more information, you can check out our blog.
Disclosure Timeline
- February 13th, 2017 - Reported the issue to package owner.
- February 13th, 2017 - Issue acknowledged by package owner.
- February 16th, 2017 - Partial fix released in versions
6.0.3
,6.1.1
,6.2.2
,6.3.1
. - March 6th, 2017 - Final fix released in versions
6.4.0
,6.3.2
,6.2.3
,6.1.2
and6.0.4
Remediation
Upgrade qs
to version 6.0.4, 6.1.2, 6.2.3, 6.3.2 or higher.
References
high severity
- Vulnerable module: qs
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › multer@0.1.8 › qs@1.2.2Remediation: Upgrade to swagger-express-middleware@3.0.0.
Overview
qs is a querystring parser that supports nesting and arrays, with a depth limit.
Affected versions of this package are vulnerable to Prototype Poisoning which allows attackers to cause a Node process to hang, processing an Array object whose prototype has been replaced by one with an excessive length value.
Note: In many typical Express use cases, an unauthenticated remote attacker can place the attack payload in the query string of the URL that is used to visit the application, such as a[__proto__]=b&a[__proto__]&a[length]=100000000
.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade qs
to version 6.2.4, 6.3.3, 6.4.1, 6.5.3, 6.6.1, 6.7.3, 6.8.3, 6.9.7, 6.10.3 or higher.
References
high severity
- Vulnerable module: static-eval
- Introduced through: jsonpath@0.2.12
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › jsonpath@0.2.12 › static-eval@0.2.3Remediation: Upgrade to jsonpath@1.0.1.
Overview
static-eval evaluates statically-analyzable expressions.
Affected versions of this package are vulnerable to Arbitrary Code Execution. It passes untrusted user input directly to the global function constructor, resulting in an arbitrary code execution vulnerability when user input is parsed via the package.
Proof of concept
var evaluate = require('static-eval');
var parse = require('esprima').parse;
var src = process.argv[2];
var payload = '(function({x}){return x.constructor})({x:"".sub})("console.log(process.env)")()'
var ast = parse(payload).body[0].expression;
console.log(evaluate(ast, {x:1}));
Remediation
Upgrade static-eval
to version 2.0.2 or higher.
References
high severity
- Vulnerable module: static-eval
- Introduced through: jsonpath@0.2.12
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › jsonpath@0.2.12 › static-eval@0.2.3Remediation: Upgrade to jsonpath@1.0.0.
Overview
static-eval
is a module to evaluate statically-analyzable expressions.
Affected versions of the package are vulnerable to Arbitrary Code Execution. If un-sanitized user input is passed to static-eval
, it is possible to break out of the sandboxed instance, and execute arbitrary code from the standard library.
Remediation
Upgrade static-eval
to version 2.0.0 or higher.
References
medium severity
- Vulnerable module: tmp
- Introduced through: swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › tmp@0.0.33Remediation: Upgrade to swagger-express-middleware@3.0.0.
Overview
Affected versions of this package are vulnerable to Symlink Attack via the dir
parameter. An attacker can cause files or directories to be written to arbitrary locations by supplying a crafted symbolic link that resolves outside the intended temporary directory.
PoC
const tmp = require('tmp');
const tmpobj = tmp.fileSync({ 'dir': 'evil-dir'});
console.log('File: ', tmpobj.name);
try {
tmp.fileSync({ 'dir': 'mydir1'});
} catch (err) {
console.log('test 1:', err.message)
}
try {
tmp.fileSync({ 'dir': '/foo'});
} catch (err) {
console.log('test 2:', err.message)
}
try {
const fs = require('node:fs');
const resolved = fs.realpathSync('/tmp/evil-dir');
tmp.fileSync({ 'dir': resolved});
} catch (err) {
console.log('test 3:', err.message)
}
Remediation
Upgrade tmp
to version 0.2.4 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@3.20.9.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Cross-site Scripting (XSS) due to a lack of sanitization of URLs used for OAuth auth flow.
Details
Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.
This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.
Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.
Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, <
can be coded as <
; and >
can be coded as >
; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses <
and >
as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.
The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.
Types of attacks
There are a few methods by which XSS can be manipulated:
Type | Origin | Description |
---|---|---|
Stored | Server | The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link. |
Reflected | Server | The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser. |
DOM-based | Client | The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data. |
Mutated | The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters. |
Affected environments
The following environments are susceptible to an XSS attack:
- Web servers
- Application servers
- Web application environments
How to prevent
This section describes the top best practices designed to specifically protect your code:
- Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
- Convert special characters such as
?
,&
,/
,<
,>
and spaces to their respective HTML or URL encoded equivalents. - Give users the option to disable client-side scripts.
- Redirect invalid requests.
- Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
- Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
- Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.
Remediation
Upgrade swagger-ui
to version 3.20.9 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@3.4.2.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Cross-site Scripting (XSS) due to insertion of javascript:
and data:
URLs from user-influenced href fields in Swagger-UI.
Details
Cross-site scripting (or XSS) is a code vulnerability that occurs when an attacker “injects” a malicious script into an otherwise trusted website. The injected script gets downloaded and executed by the end user’s browser when the user interacts with the compromised website.
This is done by escaping the context of the web application; the web application then delivers that data to its users along with other trusted dynamic content, without validating it. The browser unknowingly executes malicious script on the client side (through client-side languages; usually JavaScript or HTML) in order to perform actions that are otherwise typically blocked by the browser’s Same Origin Policy.
Injecting malicious code is the most prevalent manner by which XSS is exploited; for this reason, escaping characters in order to prevent this manipulation is the top method for securing code against this vulnerability.
Escaping means that the application is coded to mark key characters, and particularly key characters included in user input, to prevent those characters from being interpreted in a dangerous context. For example, in HTML, <
can be coded as <
; and >
can be coded as >
; in order to be interpreted and displayed as themselves in text, while within the code itself, they are used for HTML tags. If malicious content is injected into an application that escapes special characters and that malicious content uses <
and >
as HTML tags, those characters are nonetheless not interpreted as HTML tags by the browser if they’ve been correctly escaped in the application code and in this way the attempted attack is diverted.
The most prominent use of XSS is to steal cookies (source: OWASP HttpOnly) and hijack user sessions, but XSS exploits have been used to expose sensitive information, enable access to privileged services and functionality and deliver malware.
Types of attacks
There are a few methods by which XSS can be manipulated:
Type | Origin | Description |
---|---|---|
Stored | Server | The malicious code is inserted in the application (usually as a link) by the attacker. The code is activated every time a user clicks the link. |
Reflected | Server | The attacker delivers a malicious link externally from the vulnerable web site application to a user. When clicked, malicious code is sent to the vulnerable web site, which reflects the attack back to the user’s browser. |
DOM-based | Client | The attacker forces the user’s browser to render a malicious page. The data in the page itself delivers the cross-site scripting data. |
Mutated | The attacker injects code that appears safe, but is then rewritten and modified by the browser, while parsing the markup. An example is rebalancing unclosed quotation marks or even adding quotation marks to unquoted parameters. |
Affected environments
The following environments are susceptible to an XSS attack:
- Web servers
- Application servers
- Web application environments
How to prevent
This section describes the top best practices designed to specifically protect your code:
- Sanitize data input in an HTTP request before reflecting it back, ensuring all data is validated, filtered or escaped before echoing anything back to the user, such as the values of query parameters during searches.
- Convert special characters such as
?
,&
,/
,<
,>
and spaces to their respective HTML or URL encoded equivalents. - Give users the option to disable client-side scripts.
- Redirect invalid requests.
- Detect simultaneous logins, including those from two separate IP addresses, and invalidate those sessions.
- Use and enforce a Content Security Policy (source: Wikipedia) to disable any features that might be manipulated for an XSS attack.
- Read the documentation for any of the libraries referenced in your code to understand which elements allow for embedded HTML.
Remediation
Upgrade swagger-ui
to version 3.4.2 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@3.23.11.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Relative Path Overwrite (RPO). Attackers are able to use the Relative Path Overwrite (RPO) technique to perform CSS-based input field value exfiltration, such as exfiltration of a CSRF token value i.e. allows the embedding of untrusted JSON data from remote servers, using <style>@import
within the JSON data.
Remediation
Upgrade swagger-ui
to version 3.23.11 or higher.
References
medium severity
- Vulnerable module: underscore
- Introduced through: jsonpath@0.2.12
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › jsonpath@0.2.12 › underscore@1.7.0Remediation: Upgrade to jsonpath@1.1.1.
Overview
underscore is a JavaScript's functional programming helper library.
Affected versions of this package are vulnerable to Arbitrary Code Injection via the template
function, particularly when the variable
option is taken from _.templateSettings
as it is not sanitized.
PoC
const _ = require('underscore');
_.templateSettings.variable = "a = this.process.mainModule.require('child_process').execSync('touch HELLO')";
const t = _.template("")();
Remediation
Upgrade underscore
to version 1.13.0-2, 1.12.1 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@4.1.3.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) via the ?url
parameter, which was intended to allow displaying remote OpenAPI definitions. This functionality may pose a risk for users who host their own SwaggerUI instances. In particular, including remote OpenAPI definitions opens a vector for phishing attacks by abusing the trusted names/domains of self-hosted instances.
NOTE: This vulnerability has also been identified as: CVE-2021-46708
Remediation
Upgrade swagger-ui
to version 4.1.3 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@4.1.3.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Server-side Request Forgery (SSRF) via the ?url
parameter, which was intended to allow displaying remote OpenAPI definitions. This functionality may pose a risk for users who host their own SwaggerUI instances. In particular, including remote OpenAPI definitions opens a vector for phishing attacks by abusing the trusted names/domains of self-hosted instances.
NOTE: This vulnerability has also been identified as: CVE-2018-25031
Remediation
Upgrade swagger-ui
to version 4.1.3 or higher.
References
medium severity
- Vulnerable module: jison
- Introduced through: jsonpath@0.2.12
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › jsonpath@0.2.12 › jison@0.4.13
Overview
jison is a package that provides an API for creating parsers in JavaScript.
Affected versions of this package are vulnerable to Command Injection. Arbitrary OS shell command execution is possible through a crafted command-line argument.
Remediation
There is no fixed version for jison
.
References
medium severity
- Vulnerable module: validator
- Introduced through: json-schema-ref-parser@3.3.1 and swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › json-schema-ref-parser@3.3.1 › z-schema@3.25.1 › validator@10.11.0Remediation: Upgrade to json-schema-ref-parser@4.0.2.
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › swagger-parser@6.0.5 › z-schema@3.25.1 › validator@10.11.0Remediation: Upgrade to swagger-express-middleware@2.0.3.
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the isSlug
function
PoC
var validator = require("validator")
function build_attack(n) {
var ret = "111"
for (var i = 0; i < n; i++) {
ret += "a"
}
return ret+"_";
}
for(var i = 1; i <= 50000; i++) {
if (i % 10000 == 0) {
var time = Date.now();
var attack_str = build_attack(i)
validator.isSlug(attack_str)
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade validator
to version 13.6.0 or higher.
References
medium severity
- Vulnerable module: validator
- Introduced through: json-schema-ref-parser@3.3.1 and swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › json-schema-ref-parser@3.3.1 › z-schema@3.25.1 › validator@10.11.0Remediation: Upgrade to json-schema-ref-parser@4.0.2.
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › swagger-parser@6.0.5 › z-schema@3.25.1 › validator@10.11.0Remediation: Upgrade to swagger-express-middleware@2.0.3.
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the isHSL
function.
PoC
var validator = require("validator")
function build_attack(n) {
var ret = "hsla(0"
for (var i = 0; i < n; i++) {
ret += " "
}
return ret+"◎";
}
for(var i = 1; i <= 50000; i++) {
if (i % 1000 == 0) {
var time = Date.now();
var attack_str = build_attack(i)
validator.isHSL(attack_str)
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade validator
to version 13.6.0 or higher.
References
medium severity
- Vulnerable module: validator
- Introduced through: json-schema-ref-parser@3.3.1 and swagger-express-middleware@1.2.0
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › json-schema-ref-parser@3.3.1 › z-schema@3.25.1 › validator@10.11.0Remediation: Upgrade to json-schema-ref-parser@4.0.2.
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-express-middleware@1.2.0 › swagger-parser@6.0.5 › z-schema@3.25.1 › validator@10.11.0Remediation: Upgrade to swagger-express-middleware@2.0.3.
Overview
validator is a library of string validators and sanitizers.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) via the isEmail
function.
PoC
var validator = require("validator")
function build_attack(n) {
var ret = ""
for (var i = 0; i < n; i++) {
ret += "<"
}
return ret+"";
}
for(var i = 1; i <= 50000; i++) {
if (i % 10000 == 0) {
var time = Date.now();
var attack_str = build_attack(i)
validator.isEmail(attack_str,{ allow_display_name: true })
var time_cost = Date.now() - time;
console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms")
}
}
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade validator
to version 13.6.0 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@3.26.1.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Insecure Defaults. Markdown rendering allows class
, style
and data
attributes in the result by default.
Remediation
Upgrade swagger-ui
to version 3.26.1 or higher.
References
medium severity
- Vulnerable module: swagger-ui
- Introduced through: swagger-ui@2.2.10
Detailed paths
-
Introduced through: kunware@kalibrr/kunware#2499f47fbc5db51d2864930e7bc9918af1514e6e › swagger-ui@2.2.10Remediation: Upgrade to swagger-ui@3.18.0.
Overview
swagger-ui is a library that allows interaction and visualisation of APIs.
Affected versions of this package are vulnerable to Reverse Tabnabbing. Setting target="_blank"
on anchor tags is unsafe unless used in conjunction with the rel="noopener"
attribute. A link opened via target blank attribute can make changes to the original page, essentially bypassing same origin policy restrictions set by the browser.
Remediation
Upgrade swagger-ui
to version 3.18.0 or higher.