gotois/ProstoDiary_bot

ProstoDiary: your personal all-in-one virtual assistant.
Vulnerabilities 2 via 2 paths
Dependencies 794
Source GitHub
Commit 31c0791d

Find, fix and prevent vulnerabilities in your code.

Severity
  • 2
Status
  • 2
  • 0
  • 0
high severity
new

Command Injection

  • Vulnerable module: tree-kill
  • Introduced through: snyk@1.253.0

Detailed paths

  • Introduced through: prosto-diary@gotois/ProstoDiary_bot#31c0791d28d47672b68ca1cdc6880a8210fe5bc4 snyk@1.253.0 snyk-sbt-plugin@2.9.0 tree-kill@1.2.1

Overview

tree-kill is a package to kill all processes in the process tree, including the root process.

Affected versions of this package are vulnerable to Command Injection. User input is concatenated with a command within tree-kill and treekill that will be executed without any check.

Note: This vulnerability is only applicable if the package is used on a Windows operating system.

PoC by mik317

1) Create this POC file

//poc.js
var kill = require('tree-kill');
kill('3333332 & echo "HACKED" > HACKED.txt & ');

2) Execute the following commands in another terminal:

npm i tree-kill # Install affected module
dir # Check *HACKED.txt* doesn't exist
node poc.js #  Run the PoC
dir # Now *HACKED.txt* exists :)

3) A new file called HACKED.txt will be created, containing the HACKED string

Remediation

There is no fixed version for tree-kill.

References

high severity

Denial of Service (DoS)

  • Vulnerable module: mailparser
  • Introduced through: mail-notifier@0.5.0

Detailed paths

  • Introduced through: prosto-diary@gotois/ProstoDiary_bot#31c0791d28d47672b68ca1cdc6880a8210fe5bc4 mail-notifier@0.5.0 mailparser@0.6.2

Overview

mailparser is a email parser.

Affected versions of this package are vulnerable to Denial of Service (DoS).

Overview

mailparser is an email parser.

Affected versions of this package are vulnerable to Denial of Service (DoS) attacks via a crafted email containing a few million multiparts.

MIME (Multipurpose Internet Mail Extentions) is an internet standard that extends the format of email to support: Non-ACSII character sets, non-text attachments, and more.

Most Node.js MIME decoders do not validate the number of multiparts they are willing to decode, allowing an attacker to send a crafted email containing a few million multiparts, which will then block the Node.js event loop for tens of seconds, explode RAM usage, and cause an out of memory crash.

Disclosure Timeline

  • April 23rd, 2018 - Initial private disclosure to package owner
  • April 24th, 2018 - Initial response from package owner
  • June 25th, 2018 - Public disclosure

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.

Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.

One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.

When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.

Two common types of DoS vulnerabilities:

  • High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.

  • Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm ws package

Remediation

Upgrade mailparser to version 2.3.0 or higher.

References