borja/herocalf

Vulnerabilities

4 via 14 paths

Dependencies

29

Source

GitHub

Find, fix and prevent vulnerabilities in your code.

Severity
  • 2
  • 2
Status
  • 4
  • 0
  • 0

high severity

Denial of Service (DoS)

  • Vulnerable module: json
  • Introduced through: simplecov@0.16.1, codecov@0.1.15 and others

Detailed paths

  • Introduced through: borja/herocalf@borja/herocalf simplecov@0.16.1 json@2.2.0
    Remediation: Upgrade to simplecov@0.16.1.
  • Introduced through: borja/herocalf@borja/herocalf codecov@0.1.15 json@2.2.0
    Remediation: Upgrade to codecov@0.1.15.
  • Introduced through: borja/herocalf@borja/herocalf coveralls@0.8.23 json@2.2.0
    Remediation: Upgrade to coveralls@0.8.23.
  • Introduced through: borja/herocalf@borja/herocalf codecov@0.1.15 simplecov@0.16.1 json@2.2.0
    Remediation: Upgrade to codecov@0.1.15.
  • Introduced through: borja/herocalf@borja/herocalf coveralls@0.8.23 simplecov@0.16.1 json@2.2.0
    Remediation: Upgrade to coveralls@0.8.23.

Overview

json is a JSON implementation as a Ruby extension in C.

Affected versions of this package are vulnerable to Denial of Service (DoS). When parsing certain JSON documents, the json gem (including the one bundled with Ruby) can be coerced into creating arbitrary objects in the target system.

This is the same issue as CVE-2013-0269. The previous fix was incomplete, which addressed JSON.parse(user_input), but didn’t address some other styles of JSON parsing including JSON(user_input) and JSON.parse(user_input, nil).

See CVE-2013-0269 in detail.

Details

Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.

Let’s take the following regular expression as an example:

regex = /A(B|C+)+D/

This regular expression accomplishes the following:

  • A The string must start with the letter 'A'
  • (B|C+)+ The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the + matches one or more times). The + at the end of this section states that we can look for one or more matches of this section.
  • D Finally, we ensure this section of the string ends with a 'D'

The expression would match inputs such as ABBD, ABCCCCD, ABCBCCCD and ACCCCCD

It most cases, it doesn't take very long for a regex engine to find a match:

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total

$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total

The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.

Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.

Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:

  1. CCC
  2. CC+C
  3. C+CC
  4. C+C+C.

The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.

From there, the number of steps the engine must use to validate a string just continues to grow.

String Number of C's Number of steps
ACCCX 3 38
ACCCCX 4 71
ACCCCCX 5 136
ACCCCCCCCCCCCCCX 14 65,553

By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.

Remediation

Upgrade json to version 2.3.0 or higher.

References

high severity

Directory Traversal

  • Vulnerable module: rack
  • Introduced through: rack-test@1.1.0 and sinatra@2.0.8.1

Detailed paths

  • Introduced through: borja/herocalf@borja/herocalf rack-test@1.1.0 rack@2.0.7
    Remediation: Upgrade to rack-test@1.1.0.
  • Introduced through: borja/herocalf@borja/herocalf sinatra@2.0.8.1 rack@2.0.7
    Remediation: Upgrade to sinatra@2.0.8.1.
  • Introduced through: borja/herocalf@borja/herocalf sinatra@2.0.8.1 rack-protection@2.0.8.1 rack@2.0.7
    Remediation: Upgrade to sinatra@2.0.8.1.

Overview

rack is a minimal, modular and adaptable interface for developing web applications in Ruby. By wrapping HTTP requests and responses in the simplest way possible, it unifies and distills the API for web servers, web frameworks, and software in between (the so-called middleware) into a single method call.

Affected versions of this package are vulnerable to Directory Traversal. If certain directories exist in a directory that is managed by Rack::Directory, an attacker could, using this vulnerability, read the contents of files on the server that were outside of the root specified in the Rack::Directory initializer.

Details

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

  • Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

  • Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

Remediation

Upgrade rack to version 2.1.3 or higher.

References

medium severity

Cross-site Request Forgery (CSRF)

  • Vulnerable module: rack
  • Introduced through: rack-test@1.1.0 and sinatra@2.0.8.1

Detailed paths

  • Introduced through: borja/herocalf@borja/herocalf rack-test@1.1.0 rack@2.0.7
    Remediation: Upgrade to rack-test@1.1.0.
  • Introduced through: borja/herocalf@borja/herocalf sinatra@2.0.8.1 rack@2.0.7
    Remediation: Upgrade to sinatra@2.0.8.1.
  • Introduced through: borja/herocalf@borja/herocalf sinatra@2.0.8.1 rack-protection@2.0.8.1 rack@2.0.7
    Remediation: Upgrade to sinatra@2.0.8.1.

Overview

rack is a minimal, modular and adaptable interface for developing web applications in Ruby. By wrapping HTTP requests and responses in the simplest way possible, it unifies and distills the API for web servers, web frameworks, and software in between (the so-called middleware) into a single method call.

Affected versions of this package are vulnerable to Cross-site Request Forgery (CSRF). It is possible to forge a secure or host-only cookie prefix in Rack using an arbitrary cookie write by using URL encoding (percent-encoding) on the name of the cookie. This could result in an application that is dependent on this prefix to determine if a cookie is safe to process being manipulated into processing an insecure or cross-origin request.

Remediation

Upgrade rack to version 2.1.4, 2.2.3 or higher.

References

medium severity

Information Exposure

  • Vulnerable module: rack
  • Introduced through: rack-test@1.1.0 and sinatra@2.0.8.1

Detailed paths

  • Introduced through: borja/herocalf@borja/herocalf rack-test@1.1.0 rack@2.0.7
    Remediation: Upgrade to rack-test@1.1.0.
  • Introduced through: borja/herocalf@borja/herocalf sinatra@2.0.8.1 rack@2.0.7
    Remediation: Upgrade to sinatra@2.0.8.1.
  • Introduced through: borja/herocalf@borja/herocalf sinatra@2.0.8.1 rack-protection@2.0.8.1 rack@2.0.7
    Remediation: Upgrade to sinatra@2.0.8.1.

Overview

rack is a minimal, modular and adaptable interface for developing web applications in Ruby. By wrapping HTTP requests and responses in the simplest way possible, it unifies and distills the API for web servers, web frameworks, and software in between (the so-called middleware) into a single method call.

Affected versions of this package are vulnerable to Information Exposure. Attackers may be able to find and hijack sessions by using timing attacks targeting the session id. Session ids are usually stored and indexed in a database that uses some kind of scheme for speeding up lookups of that session id. By carefully measuring the amount of time it takes to look up a session, an attacker may be able to find a valid session id and hijack the session.

Remediation

Upgrade rack to version 1.6.12, 2.0.8 or higher.

References