adobe/hypermedia-pipeline:package.json

Vulnerabilities 1 via 4 paths
Dependencies 530
Source GitHub
Commit 104bff39

Find, fix and prevent vulnerabilities in your code.

Severity
  • 1
Status
  • 1
  • 0
  • 0
medium severity
new

Man-in-the-Middle (MitM)

  • Vulnerable module: https-proxy-agent
  • Introduced through: snyk@1.235.1 and @adobe/helix-shared@3.0.4

Detailed paths

  • Introduced through: @adobe/helix-pipeline@adobe/hypermedia-pipeline#104bff398f10f497ac27278b1f0ddd8232951489 snyk@1.235.1 proxy-agent@3.1.0 https-proxy-agent@2.2.2
    Remediation: Open PR to patch https-proxy-agent@2.2.2.
  • Introduced through: @adobe/helix-pipeline@adobe/hypermedia-pipeline#104bff398f10f497ac27278b1f0ddd8232951489 snyk@1.235.1 proxy-agent@3.1.0 pac-proxy-agent@3.0.0 https-proxy-agent@2.2.2
    Remediation: Open PR to patch https-proxy-agent@2.2.2.
  • Introduced through: @adobe/helix-pipeline@adobe/hypermedia-pipeline#104bff398f10f497ac27278b1f0ddd8232951489 @adobe/helix-shared@3.0.4 snyk@1.235.1 proxy-agent@3.1.0 https-proxy-agent@2.2.2
    Remediation: Open PR to patch https-proxy-agent@2.2.2.
  • Introduced through: @adobe/helix-pipeline@adobe/hypermedia-pipeline#104bff398f10f497ac27278b1f0ddd8232951489 @adobe/helix-shared@3.0.4 snyk@1.235.1 proxy-agent@3.1.0 pac-proxy-agent@3.0.0 https-proxy-agent@2.2.2
    Remediation: Open PR to patch https-proxy-agent@2.2.2.

Overview

https-proxy-agent is a module that provides an http.Agent implementation that connects to a specified HTTP or HTTPS proxy server, and can be used with the built-in https module.

Affected versions of this package are vulnerable to Man-in-the-Middle (MitM). When targeting a HTTP proxy, https-proxy-agent opens a socket to the proxy, and sends the proxy server a CONNECT request. If the proxy server responds with something other than a HTTP response 200, https-proxy-agent incorrectly returns the socket without any TLS upgrade. This request data may contain basic auth credentials or other secrets, is sent over an unencrypted connection. A suitably positioned attacker could steal these secrets and impersonate the client.

PoC by Kris Adler

var url = require('url');
var https = require('https');
var HttpsProxyAgent = require('https-proxy-agent');

var proxyOpts = url.parse('http://127.0.0.1:80');
var opts = url.parse('https://www.google.com');
var agent = new HttpsProxyAgent(proxyOpts);
opts.agent = agent;
opts.auth = 'username:password';
https.get(opts);

Remediation

Upgrade https-proxy-agent to version 3.0.0 or higher.

References