magicmirror

The open source modular smart mirror platform.

Known vulnerabilities1
Vulnerable paths1
Dependencies309

Regular Expression Denial of Service (ReDoS)

low severity
  • Vulnerable module: ms
  • Introduced through: electron@1.8.0

Detailed paths

  • Introduced through: magicmirror@MichMich/MagicMirror#8a101f9e9ad885289c687d6ea627dfa7294a0da0 electron@1.8.0 extract-zip@1.6.5 debug@2.2.0 ms@0.7.1

Overview

ms is a tiny milisecond conversion utility. Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) due to an incomplete fix for previously reported vulnerability npm:ms:20151024. The fix limited the length of accepted input string to 10,000 characters, and turned to be insufficient making it possible to block the event loop for 0.3 seconds (on a typical laptop) with a specially crafted string passed to ms() function.

Proof of concept

ms = require('ms');
            ms('1'.repeat(9998) + 'Q') // Takes about ~0.3s
            

Note: Snyk's patch for this vulnerability limits input length to 100 characters. This new limit was deemed to be a breaking change by the author. Based on user feedback, we believe the risk of breakage is very low, while the value to your security is much greater, and therefore opted to still capture this change in a patch for earlier versions as well. Whenever patching security issues, we always suggest to run tests on your code to validate that nothing has been broken.

For more information on Regular Expression Denial of Service (ReDoS) attacks, go to our blog.

Disclosure Timeline

  • Feb 9th, 2017 - Reported the issue to package owner.
  • Feb 11th, 2017 - Issue acknowledged by package owner.
  • April 12th, 2017 - Fix PR opened by Snyk Security Team.
  • May 15th, 2017 - Vulnerability published.
  • May 16th, 2017 - Issue fixed and version 2.0.0 released.
  • May 21th, 2017 - Patches released for versions >=0.7.1, <=1.0.0.

Remediation

Upgrade ms to version 2.0.0 or higher.

References