Last tested: 20 Feb, 2018

winston vulnerabilities

A multi-transport async logging library for Node.js

View on npm

winston (latest)

Published 18 Feb, 2018

Known vulnerabilities0
Vulnerable paths0
Dependencies20

No known vulnerabilities in winston

Security wise, winston seems to be a safe package to use.
Over time, new vulnerabilities may be disclosed on winston and other packages. To easily find, fix and prevent such vulnerabilties, protect your repos with Snyk!

Vulnerable versions of winston

Fixed in 0.8.0

Prototype Pollution

low severity

Detailed paths

  • Introduced through: winston@0.7.3 > request@2.16.6 > hawk@0.10.2 > hoek@0.7.6
  • Introduced through: winston@0.7.3 > request@2.16.6 > hawk@0.10.2 > boom@0.3.8 > hoek@0.7.6
  • Introduced through: winston@0.7.3 > request@2.16.6 > hawk@0.10.2 > cryptiles@0.1.3 > boom@0.3.8 > hoek@0.7.6
  • Introduced through: winston@0.7.3 > request@2.16.6 > hawk@0.10.2 > sntp@0.1.4 > hoek@0.7.6

Overview

hoek is a Utility methods for the hapi ecosystem.

Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.

PoC by Olivier Arteau (HoLyVieR)

var Hoek = require('hoek');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';

var a = {};
console.log("Before : " + a.oops);
Hoek.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);

Remediation

Upgrade hoek to versions 4.2.1, 5.0.3 or higher.

References

Uninitialized Memory Exposure

medium severity

Detailed paths

  • Introduced through: winston@0.7.3 > request@2.16.6 > tunnel-agent@0.2.0

Overview

tunnel-agent is HTTP proxy tunneling agent. Affected versions of the package are vulnerable to Uninitialized Memory Exposure.

A possible memory disclosure vulnerability exists when a value of type number is used to set the proxy.auth option of a request request and results in a possible uninitialized memory exposures in the request body.

This is a result of unobstructed use of the Buffer constructor, whose insecure default constructor increases the odds of memory leakage.

Details

Constructing a Buffer class with integer N creates a Buffer of length N with raw (not "zero-ed") memory.

In the following example, the first call would allocate 100 bytes of memory, while the second example will allocate the memory needed for the string "100":

// uninitialized Buffer of length 100
x = new Buffer(100);
// initialized Buffer with value of '100'
x = new Buffer('100');

tunnel-agent's request construction uses the default Buffer constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw server side memory, potentially holding secrets, private data and code. This is a similar vulnerability to the infamous Heartbleed flaw in OpenSSL.

Proof of concept by ChALkeR

require('request')({
  method: 'GET',
  uri: 'http://www.example.com',
  tunnel: true,
  proxy:{
      protocol: 'http:',
      host:"127.0.0.1",
      port:8080,
      auth:80
  }
});

You can read more about the insecure Buffer behavior on our blog.

Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.

Remediation

Upgrade tunnel-agent to version 0.6.0 or higher.

References

Remote Memory Exposure

medium severity

Detailed paths

  • Introduced through: forever@0.7.3 > winston@0.5.11 > loggly@0.3.11 > request@2.9.203
  • Introduced through: forever@0.7.3 > clip@0.1.6 > prompt@0.1.12 > winston@0.5.11 > loggly@0.3.11 > request@2.9.203
  • Introduced through: forever@0.7.3 > clip@0.1.6 > winston@0.3.5 > loggly@0.3.11 > request@2.9.203
  • Introduced through: winston@0.7.3 > request@2.16.6

Overview

request is a simplified http request client. A potential remote memory exposure vulnerability exists in request. If a request uses a multipart attachment and the body type option is number with value X, then X bytes of uninitialized memory will be sent in the body of the request.

Note that while the impact of this vulnerability is high (memory exposure), exploiting it is likely difficult, as the attacker needs to somehow control the body type of the request. One potential exploit scenario is when a request is composed based on JSON input, including the body type, allowing a malicious JSON to trigger the memory leak.

Details

Constructing a Buffer class with integer N creates a Buffer of length N with non zero-ed out memory. Example:

var x = new Buffer(100); // uninitialized Buffer of length 100
// vs
var x = new Buffer('100'); // initialized Buffer with value of '100'

Initializing a multipart body in such manner will cause uninitialized memory to be sent in the body of the request.

Proof of concept

var http = require('http')
var request = require('request')

http.createServer(function (req, res) {
  var data = ''
  req.setEncoding('utf8')
  req.on('data', function (chunk) {
    console.log('data')
    data += chunk
  })
  req.on('end', function () {
    // this will print uninitialized memory from the client
    console.log('Client sent:\n', data)
  })
  res.end()
}).listen(8000)

request({
  method: 'POST',
  uri: 'http://localhost:8000',
  multipart: [{ body: 1000 }]
},
function (err, res, body) {
  if (err) return console.error('upload failed:', err)
  console.log('sent')
})

Remediation

Upgrade request to version 2.68.0 or higher.

If a direct dependency update is not possible, use snyk wizard to patch this vulnerability.

References

Regular Expression Denial of Service (DoS)

low severity

Detailed paths

  • Introduced through: winston@0.7.3 > request@2.16.6 > hawk@0.10.2

Overview

hawk Hawk is an HTTP authentication scheme using a message authentication code (MAC) algorithm to provide partial HTTP request cryptographic verification. Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Many Regular Expression implementations may reach edge cases that causes them to work very slowly (exponentially related to input size), allowing an attacker to exploit this and can cause the program to enter these extreme situations by using a specially crafted input and cause the service to excessively consume CPU, resulting in a Denial of Service.

An attacker can provide a long url, which nearly matches the pattern being matched. This will cause the regular expression matching to take a long time, all the while occupying the event loop and preventing it from processing other requests and making the server unavailable (a Denial of Service attack).

You can read more about Regular Expression Denial of Service (ReDoS) on our blog.

References

Denial of Service (Event Loop Blocking)

medium severity

Detailed paths

  • Introduced through: http-server@0.7.3 > union@0.3.8 > qs@0.5.6
  • Introduced through: browser-sync@0.7.3 > connect@2.13.1 > qs@0.6.6
  • Introduced through: winston@0.7.3 > request@2.16.6 > qs@0.5.6

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

When parsing a string representing a deeply nested object, qs will block the event loop for long periods of time. Such a delay may hold up the server's resources, keeping it from processing other requests in the meantime, thus enabling a Denial-of-Service attack.

Remediation

Update qs to version 1.0.0 or higher. In these versions, qs enforces a max object depth (along with other limits), limiting the event loop length and thus preventing such an attack.

References

Prototype Override Protection Bypass

high severity

Detailed paths

  • Introduced through: http-server@0.7.3 > union@0.3.8 > qs@0.5.6
  • Introduced through: browser-sync@0.7.3 > connect@2.13.1 > qs@0.6.6
  • Introduced through: winston@0.7.3 > request@2.16.6 > qs@0.5.6

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

By default qs protects against attacks that attempt to overwrite an object's existing prototype properties, such as toString(), hasOwnProperty(),etc.

From qs documentation:

By default parameters that would overwrite properties on the object prototype are ignored, if you wish to keep the data from those fields either use plainObjects as mentioned above, or set allowPrototypes to true which will allow user input to overwrite those properties. WARNING It is generally a bad idea to enable this option as it can cause problems when attempting to use the properties that have been overwritten. Always be careful with this option.

Overwriting these properties can impact application logic, potentially allowing attackers to work around security controls, modify data, make the application unstable and more.

In versions of the package affected by this vulnerability, it is possible to circumvent this protection and overwrite prototype properties and functions by prefixing the name of the parameter with [ or ]. e.g. qs.parse("]=toString") will return {toString = true}, as a result, calling toString() on the object will throw an exception.

Example:

qs.parse('toString=foo', { allowPrototypes: false })
// {}

qs.parse("]=toString", { allowPrototypes: false })
// {toString = true} <== prototype overwritten

For more information, you can check out our blog.

Disclosure Timeline

  • February 13th, 2017 - Reported the issue to package owner.
  • February 13th, 2017 - Issue acknowledged by package owner.
  • February 16th, 2017 - Partial fix released in versions 6.0.3, 6.1.1, 6.2.2, 6.3.1.
  • March 6th, 2017 - Final fix released in versions 6.4.0,6.3.2, 6.2.3, 6.1.2 and 6.0.4

Remediation

Upgrade qs to version 6.4.0 or higher. Note: The fix was backported to the following versions 6.3.2, 6.2.3, 6.1.2, 6.0.4.

References

Regular Expression Denial of Service (ReDoS)

low severity

Detailed paths

  • Introduced through: browser-sync@0.7.3 > connect@2.13.1 > send@0.1.4 > mime@1.2.11
  • Introduced through: winston@0.7.3 > request@2.16.6 > mime@1.2.11
  • Introduced through: winston@0.7.3 > request@2.16.6 > form-data@0.0.10 > mime@1.2.11

Overview

mime is a comprehensive, compact MIME type module.

Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS). It uses regex the following regex /.*[\.\/\\]/ in its lookup, which can cause a slowdown of 2 seconds for 50k characters.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Many Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size), allowing an attacker to exploit this and can cause the program to enter these extreme situations by using a specially crafted input and cause the service to excessively consume CPU, resulting in a Denial of Service.

You can read more about Regular Expression Denial of Service (ReDoS) on our blog.

Remediation

Upgrade mime to versions 1.4.1, 2.0.3 or higher.

References

Denial of Service (Memory Exhaustion)

high severity

Detailed paths

  • Introduced through: http-server@0.7.3 > union@0.3.8 > qs@0.5.6
  • Introduced through: http-server@0.7.3 > union@0.3.8 > qs@0.5.6
  • Introduced through: browser-sync@0.7.3 > connect@2.13.1 > qs@0.6.6
  • Introduced through: winston@0.7.3 > request@2.16.6 > qs@0.5.6

Overview

qs is a querystring parser that supports nesting and arrays, with a depth limit.

During parsing, the qs module may create a sparse area (an array where no elements are filled), and grow that array to the necessary size based on the indices used on it. An attacker can specify a high index value in a query string, thus making the server allocate a respectively big array. Truly large values can cause the server to run out of memory and cause it to crash - thus enabling a Denial-of-Service attack.

Remediation

Upgrade qs to version 1.0.0 or greater. In these versions, qs introduced a low limit on the index value, preventing such an attack

References

Fixed in 0.6.1

Regular Expression Denial of Service (ReDoS)

high severity

Detailed paths

  • Introduced through: winston@0.5.11 > loggly@0.3.11 > timespan@2.3.0

Overview

timespan is a JavaScript TimeSpan library for node.js (and soon the browser).

Affected versions of this package are vulnerable to Regular expression Denial of Service (ReDoS). It parses dates using regex strings, which may cause a slowdown of 10 seconds per 50k characters.

The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Many Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size), allowing an attacker to exploit this and can cause the program to enter these extreme situations by using a specially crafted input and cause the service to excessively consume CPU, resulting in a Denial of Service.

You can read more about Regular Expression Denial of Service (ReDoS) on our blog.

Remediation

There is no fix version for timespan.

References