Improve output when wrapping functions (e.g. `async` functions) #15922

liuxingbaoyu · 2023-09-03T07:12:33Z

Q	A
Fixed Issues?	Fixes #15921
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

babel-bot · 2023-09-03T07:14:37Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55388/

liuxingbaoyu · 2023-09-03T07:50:57Z

...babel-plugin-transform-async-to-generator/test/fixtures/regression/test262-fn-length/exec.js

@@ -0,0 +1,2 @@
+var a = async (b) => {}
+expect(a.length).toBe(1);


I'm very happy that test262 helped me find a regression.🎉

...transform-async-to-generator/test/fixtures/async-to-generator/deeply-nested-asyncs/output.js

JLHwung · 2023-09-07T14:42:51Z

packages/babel-helper-wrap-function/src/index.ts

+//       ];
+//     };
+//   };
+// };


Unused typings should be removed.

I just pushed a commit that does it

…s) (babel#15922)" This reverts commit b9a2244.

* Add a test * Revert "Improve output when wrapping functions (e.g. `async` functions) (#15922)" This reverts commit b9a2244. * Update snapshot

<p>This PR was automatically created by Snyk using the credentials of a real user.</p><br /><h3>Snyk has created this PR to upgrade multiple dependencies.</h3> 👯‍♂ The following dependencies are linked and will therefore be updated together. </br></br> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. </br></br> Name | Versions | Released on :-------------|:-------------|:------------- **@babel/parser**</br>from 7.22.11 to 7.22.16 | **4 versions** ahead of your current version | **a month ago**</br>on 2023-09-06 **@babel/types**</br>from 7.22.15 to 7.22.19 | **2 versions** ahead of your current version | **22 days ago**</br>on 2023-09-14 <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@babel/parser</b></summary> <ul> <li> <b>7.22.16</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.16">2023-09-06</a></br><h2>v7.22.16 (2023-09-06)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15935" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15935/hovercard">#15935</a> fix: <code>__esModule</code> is missing from published <code>@ babel/parser</code> (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15936" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15936/hovercard">#15936</a> Skip deprecation warning tests when in a folder named <code>@ babel</code> (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 3</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.22.15</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.15">2023-09-04</a></br><h2>v7.22.15 (2023-09-04)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15923" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15923/hovercard">#15923</a> Only perform config loading re-entrancy check for cjs (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><em>Every package</em> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15892" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15892/hovercard">#15892</a> Add explicit <code>.ts</code>/<code>.js</code> extension to all imports in <code>src</code> (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 4</h4> <ul> <li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@ babel-bot</a>)</li> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.22.14</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.14">2023-08-30</a></br><h2>v7.22.14 (2023-08-30)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15907" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15907/hovercard">#15907</a> Avoid dynamic require call in preset-env (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15884" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15884/hovercard">#15884</a> Simplify parser errors creation (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-compilation-targets</code>, <code>babel-helper-simple-access</code>, <code>babel-parser</code>, <code>babel-plugin-syntax-decorators</code>, <code>babel-preset-env</code>, <code>babel-preset-flow</code>, <code>babel-preset-react</code>, <code>babel-preset-typescript</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15902" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15902/hovercard">#15902</a> extract more test helpers to repo-utils (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> </ul> <h4>Committers: 2</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li> <b>7.22.13</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.13">2023-08-28</a></br><h2>v7.22.13 (2023-08-28)</h2> <h4>🏠 Internal</h4> <ul> <li><code>babel-helper-fixtures</code>, <code>babel-plugin-proposal-function-bind</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15890" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15890/hovercard">#15890</a> Improve helper-fixtures (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> </ul> <h4>↩️ Revert</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15901" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15901/hovercard">#15901</a> Revert "Do not record trailing comma pos when <code>maybeAsyncArrow: false</code>" (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 2</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li> <b>7.22.11</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.11">2023-08-24</a></br><h2>v7.22.11 (2023-08-24)</h2> <p>Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/0o001/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/0o001">@ 0o001</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/yangguansen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/yangguansen">@ yangguansen</a> for your first PRs!</p> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-typescript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15882" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15882/hovercard">#15882</a> Fix: fully remove TS nested type-only exported namespaces (<a href="https://snyk.io/redirect/github/yangguansen">@ yangguansen</a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15867" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15867/hovercard">#15867</a> fix: definition of TS function type params (<a href="https://snyk.io/redirect/github/danez">@ danez</a>)</li> </ul> </li> <li><code>babel-plugin-transform-async-generator-functions</code>, <code>babel-plugin-transform-class-static-block</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-export-namespace-from</code>, <code>babel-plugin-transform-json-strings</code>, <code>babel-plugin-transform-logical-assignment-operators</code>, <code>babel-plugin-transform-nullish-coalescing-operator</code>, <code>babel-plugin-transform-numeric-separator</code>, <code>babel-plugin-transform-object-rest-spread</code>, <code>babel-plugin-transform-optional-catch-binding</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-plugin-transform-private-property-in-object</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15858" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15858/hovercard">#15858</a> fix(standalone): strip archived syntax plugins (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-core</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15850" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15850/hovercard">#15850</a> Support configuring cache in ESM configs (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/10940" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/10940/hovercard">#10940</a> Do not record trailing comma pos when <code>maybeAsyncArrow: false</code> (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helper-compilation-targets</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-syntax-decorators</code>, <code>babel-preset-env</code>, <code>babel-preset-react</code>, <code>babel-register</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15872" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15872/hovercard">#15872</a> enable jest/no-standalone-expect (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-core</code>, <code>babel-helpers</code>, <code>babel-plugin-transform-async-generator-functions</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-regenerator</code>, <code>babel-preset-env</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15833" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15833/hovercard">#15833</a> bump json5, terser and webpack, further minimize babel helpers (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li>Other <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15846" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15846/hovercard">#15846</a> Use Babel 8.0 alpha to build babel (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15856" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15856/hovercard">#15856</a> Exclude redundant files from publish process (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> </ul> <h4>🔬 Output optimization</h4> <ul> <li><code>babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining</code>, <code>babel-plugin-transform-class-properties</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15871" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15871/hovercard">#15871</a> Simplify <code>?.</code> output when chain result is ignored (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 7</h4> <ul> <li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@ babel-bot</a>)</li> <li>Daniel Tschinder (<a href="https://snyk.io/redirect/github/danez">@ danez</a>)</li> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Mustafa Ateş Uzun (<a href="https://snyk.io/redirect/github/0o001">@ 0o001</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> <li>sanmu (<a href="https://snyk.io/redirect/github/yangguansen">@ yangguansen</a>)</li> </ul> </li> </ul> from <a href="https://snyk.io/redirect/github/babel/babel/releases">@babel/parser GitHub release notes</a> </details> <details> <summary>Package name: <b>@babel/types</b></summary> <ul> <li> <b>7.22.19</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.19">2023-09-14</a></br><h2>v7.22.19 (2023-09-14)</h2> <p>Re-published 7.22.18, due to a releasing error.</p> </li> <li> <b>7.22.17</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.17">2023-09-08</a></br><h2>v7.22.17 (2023-09-08)</h2> <p>Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jordanbtucker/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/jordanbtucker">@ jordanbtucker</a> for your first PR!</p> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15947" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15947/hovercard">#15947</a> Fix compatibility with Node.js 20.6 (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-modules-commonjs</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15941" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15941/hovercard">#15941</a> Fix compiling duplicate ns imports to lazy CommonJS (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15920" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15920/hovercard">#15920</a> Make <code>ClassDeclaration["id"]</code> optional in babel-types (<a href="https://snyk.io/redirect/github/jordanbtucker">@ jordanbtucker</a>)</li> </ul> </li> </ul> <h4>🔬 Output optimization</h4> <ul> <li><code>babel-helper-remap-async-to-generator</code>, <code>babel-helper-wrap-function</code>, <code>babel-plugin-proposal-explicit-resource-management</code>, <code>babel-plugin-proposal-function-sent</code>, <code>babel-plugin-transform-async-generator-functions</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-block-scoping</code>, <code>babel-plugin-transform-class-properties</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15922" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15922/hovercard">#15922</a> Improve output when wrapping functions (e.g. <code>async</code> functions) (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>Committers: 3</h4> <ul> <li>Jordan Tucker (<a href="https://snyk.io/redirect/github/jordanbtucker">@ jordanbtucker</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.22.15</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.15">2023-09-04</a></br><h2>v7.22.15 (2023-09-04)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-core</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15923" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15923/hovercard">#15923</a> Only perform config loading re-entrancy check for cjs (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><em>Every package</em> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15892" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15892/hovercard">#15892</a> Add explicit <code>.ts</code>/<code>.js</code> extension to all imports in <code>src</code> (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 4</h4> <ul> <li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@ babel-bot</a>)</li> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> </ul> from <a href="https://snyk.io/redirect/github/babel/babel/releases">@babel/types GitHub release notes</a> </details> </details> <hr/> **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.* For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI5ZDI4MmM3Ni1jM2U5LTQ5NDEtYjM0Zi00YzIzZTYzYWE2ZWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjlkMjgyYzc2LWMzZTktNDk0MS1iMzRmLTRjMjNlNjNhYTZlZSJ9fQ==" width="0" height="0"/> 🧐 [View latest project report](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603?utm_source=github&utm_medium=referral&page=upgrade-pr) 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603/settings/integration?pkg=@babel/parser&pkg=@babel/types&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)

liuxingbaoyu added the PR: Output optimization 🔬 A type of pull request used for our changelog categories label Sep 3, 2023

liuxingbaoyu changed the title ~~Improve output of async~~ Improve output of async functions Sep 3, 2023

liuxingbaoyu marked this pull request as draft September 3, 2023 07:44

liuxingbaoyu marked this pull request as ready for review September 3, 2023 07:49

liuxingbaoyu commented Sep 3, 2023

View reviewed changes

liuxingbaoyu marked this pull request as draft September 3, 2023 09:28

liuxingbaoyu marked this pull request as ready for review September 3, 2023 11:00

liuxingbaoyu force-pushed the async-gen branch 3 times, most recently from e413175 to 68abb51 Compare September 4, 2023 04:39

liuxingbaoyu added 5 commits September 7, 2023 16:51

improve

81317f0

fix

1cab1d8

clean

db24d0a

fix

15eb97d

misc

db2821c

JLHwung approved these changes Sep 7, 2023

View reviewed changes

Simplify code

5ec09ea

nicolo-ribaudo force-pushed the async-gen branch from 68abb51 to 5ec09ea Compare September 7, 2023 15:06

nicolo-ribaudo approved these changes Sep 7, 2023

View reviewed changes

nicolo-ribaudo changed the title ~~Improve output of async functions~~ Improve output when wrapping functions (e.g. async functions) Sep 7, 2023

nicolo-ribaudo merged commit b9a2244 into babel:main Sep 7, 2023
47 checks passed

nicolo-ribaudo mentioned this pull request Sep 11, 2023

The generated code for function.sent seems excessive #15521

Open

1 task

jjonescz mentioned this pull request Sep 16, 2023

[Bug]: plugin-transform-async-to-generator incorrectly captures outer variable in a loop #15978

Closed

1 task

jjonescz added a commit to jjonescz/babel that referenced this pull request Sep 16, 2023

Revert "Improve output when wrapping functions (e.g. async function…

9d4a696

…s) (babel#15922)" This reverts commit b9a2244.

nicolo-ribaudo pushed a commit that referenced this pull request Sep 16, 2023

Revert "Improve output when wrapping functions" (#15979)

ad26f90

* Add a test * Revert "Improve output when wrapping functions (e.g. `async` functions) (#15922)" This reverts commit b9a2244. * Update snapshot

Omrisnyk mentioned this pull request Oct 16, 2023

[Snyk] Security upgrade @babel/traverse from 7.0.0 to 7.23.2 Omrisnyk/npm-lockfiles#121

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 8, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve output when wrapping functions (e.g. `async` functions) #15922

Improve output when wrapping functions (e.g. `async` functions) #15922

liuxingbaoyu commented Sep 3, 2023 •

edited by nicolo-ribaudo

babel-bot commented Sep 3, 2023 •

edited

liuxingbaoyu Sep 3, 2023

JLHwung Sep 7, 2023

nicolo-ribaudo Sep 7, 2023

		@@ -0,0 +1,2 @@
		var a = async (b) => {}
		expect(a.length).toBe(1);

Improve output when wrapping functions (e.g. async functions) #15922

Improve output when wrapping functions (e.g. async functions) #15922

Conversation

liuxingbaoyu commented Sep 3, 2023 • edited by nicolo-ribaudo

babel-bot commented Sep 3, 2023 • edited

liuxingbaoyu Sep 3, 2023

Choose a reason for hiding this comment

JLHwung Sep 7, 2023

Choose a reason for hiding this comment

nicolo-ribaudo Sep 7, 2023

Choose a reason for hiding this comment

Improve output when wrapping functions (e.g. `async` functions) #15922

Improve output when wrapping functions (e.g. `async` functions) #15922

liuxingbaoyu commented Sep 3, 2023 •

edited by nicolo-ribaudo

babel-bot commented Sep 3, 2023 •

edited