Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dynamic require call in preset-env #15907

Merged
merged 3 commits into from Aug 30, 2023
Merged

Avoid dynamic require call in preset-env #15907

merged 3 commits into from Aug 30, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 29, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #15906
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The good old copy-pasting, who needs abstractions anyway 😌

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression pkg: preset-env labels Aug 29, 2023
nicolo-ribaudo
nicolo-ribaudo commented Aug 29, 2023
View reviewed changes
babel.config.js
[
pluginToggleBooleanFlag,
{
name: "USE_ESM_OR_STANDALONE",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can then use this in other packages, so that we don't have to manually check for both cases.

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 29, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55284/

@JLHwung
Copy link
Contributor

JLHwung commented Aug 29, 2023 •
edited

CI failure seems related.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft August 30, 2023 09:11
@nicolo-ribaudo nicolo-ribaudo force-pushed the env-no-dynamic-require branch 2 times, most recently from 9864a5e to b75930e Compare August 30, 2023 09:25
@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Aug 30, 2023 •
edited

I am incredibly confused. @babel/plugin-syntax-unicode-sets-regex is not part of the monorepo, so it shouldn't be affected by this change. It has a dependency on @babel/helper-create-regexp-features-plugin, which it should be getting from the registry, but for some reason the dependency is no there.

From yarn info -R @babel/helper-create-regexp-features-plugin:

   ├─ @babel/preset-env@npm:7.22.14 [9548c] (via npm:latest [9548c])
   │  ├─ @babel/plugin-syntax-unicode-sets-regex@npm:7.18.6 [0d136] (via npm:^7.18.6 [0d136])
   │  │  └─ @babel/helper-create-regexp-features-plugin@workspace:packages/babel-helper-create-regexp-features-plugin [c1822] (via workspace:* [c1822])

@nicolo-ribaudo
Copy link
Member Author

Oh well,

babel/package.json

Line 101 in 235a7ac

"@babel/plugin-syntax-unicode-sets-regex/@babel/helper-create-regexp-features-plugin": "workspace:*",

It looks like now this package is being required before that it's dependency is transpiled, causing this new error.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review August 30, 2023 10:04
@nicolo-ribaudo @liuxingbaoyu
Update packages/babel-preset-env/src/available-plugins.ts
6bb3ea8 
Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
@nicolo-ribaudo nicolo-ribaudo merged commit f9d1adf into babel:main Aug 30, 2023
47 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the env-no-dynamic-require branch August 30, 2023 10:24
Woodpile37 added a commit to Woodpile37/ethers.js that referenced this pull request Oct 7, 2023
@Woodpile37
[Snyk] Upgrade: @babel/parser, @babel/types (#95)
016eb8a 
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade multiple
dependencies.</h3>
👯‍♂ The following dependencies are linked and will therefore be updated
together.
</br></br>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
</br></br>

 Name         | Versions     | Released on
:-------------|:-------------|:-------------
**@babel/parser**</br>from 7.22.11 to 7.22.16 | **4 versions** ahead of
your current version | **a month ago**</br>on 2023-09-06
**@babel/types**</br>from 7.22.15 to 7.22.19 | **2 versions** ahead of
your current version | **22 days ago**</br>on 2023-09-14



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>@babel/parser</b></summary>
    <ul>
      <li>
<b>7.22.16</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.16">2023-09-06</a></br><h2>v7.22.16
(2023-09-06)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15935"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15935/hovercard">#15935</a> fix:
<code>__esModule</code> is missing from published <code>@
babel/parser</code> (<a
href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15936"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15936/hovercard">#15936</a> Skip
deprecation warning tests when in a folder named <code>@ babel</code>
(<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 3</h4>
<ul>
<li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@
JLHwung</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
<li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a></li>
</ul>
      </li>
      <li>
<b>7.22.15</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.15">2023-09-04</a></br><h2>v7.22.15
(2023-09-04)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-core</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15923"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15923/hovercard">#15923</a> Only
perform config loading re-entrancy check for cjs (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><em>Every package</em>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15892"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15892/hovercard">#15892</a> Add
explicit <code>.ts</code>/<code>.js</code> extension to all imports in
<code>src</code> (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 4</h4>
<ul>
<li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@
babel-bot</a>)</li>
<li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@
JLHwung</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
<li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a></li>
</ul>
      </li>
      <li>
<b>7.22.14</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.14">2023-08-30</a></br><h2>v7.22.14
(2023-08-30)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-preset-env</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15907"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15907/hovercard">#15907</a> Avoid
dynamic require call in preset-env (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15884"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15884/hovercard">#15884</a>
Simplify parser errors creation (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
<li><code>babel-core</code>,
<code>babel-helper-compilation-targets</code>,
<code>babel-helper-simple-access</code>, <code>babel-parser</code>,
<code>babel-plugin-syntax-decorators</code>,
<code>babel-preset-env</code>, <code>babel-preset-flow</code>,
<code>babel-preset-react</code>, <code>babel-preset-typescript</code>,
<code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15902"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15902/hovercard">#15902</a>
extract more test helpers to repo-utils (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 2</h4>
<ul>
<li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@
JLHwung</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
      </li>
      <li>
<b>7.22.13</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.13">2023-08-28</a></br><h2>v7.22.13
(2023-08-28)</h2>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-helper-fixtures</code>,
<code>babel-plugin-proposal-function-bind</code>,
<code>babel-plugin-transform-modules-commonjs</code>,
<code>babel-preset-env</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15890"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15890/hovercard">#15890</a>
Improve helper-fixtures (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
</ul>
<h4>↩️ Revert</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15901"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15901/hovercard">#15901</a> Revert
"Do not record trailing comma pos when <code>maybeAsyncArrow:
false</code>" (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 2</h4>
<ul>
<li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@
JLHwung</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
      </li>
      <li>
<b>7.22.11</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.11">2023-08-24</a></br><h2>v7.22.11
(2023-08-24)</h2>
<p>Thanks <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/0o001/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/0o001">@ 0o001</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/yangguansen/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/yangguansen">@ yangguansen</a> for
your first PRs!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-plugin-transform-typescript</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15882"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15882/hovercard">#15882</a> Fix:
fully remove TS nested type-only exported namespaces (<a
href="https://snyk.io/redirect/github/yangguansen">@
yangguansen</a>)</li>
</ul>
</li>
<li><code>babel-types</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15867"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15867/hovercard">#15867</a> fix:
definition of TS function type params (<a
href="https://snyk.io/redirect/github/danez">@ danez</a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-async-generator-functions</code>,
<code>babel-plugin-transform-class-static-block</code>,
<code>babel-plugin-transform-dynamic-import</code>,
<code>babel-plugin-transform-export-namespace-from</code>,
<code>babel-plugin-transform-json-strings</code>,
<code>babel-plugin-transform-logical-assignment-operators</code>,
<code>babel-plugin-transform-nullish-coalescing-operator</code>,
<code>babel-plugin-transform-numeric-separator</code>,
<code>babel-plugin-transform-object-rest-spread</code>,
<code>babel-plugin-transform-optional-catch-binding</code>,
<code>babel-plugin-transform-optional-chaining</code>,
<code>babel-plugin-transform-private-property-in-object</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15858"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15858/hovercard">#15858</a>
fix(standalone): strip archived syntax plugins (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
<li><code>babel-core</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15850"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15850/hovercard">#15850</a>
Support configuring cache in ESM configs (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/10940"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/10940/hovercard">#10940</a> Do not
record trailing comma pos when <code>maybeAsyncArrow: false</code> (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
<li><code>babel-core</code>,
<code>babel-helper-compilation-targets</code>,
<code>babel-parser</code>,
<code>babel-plugin-proposal-destructuring-private</code>,
<code>babel-plugin-syntax-decorators</code>,
<code>babel-preset-env</code>, <code>babel-preset-react</code>,
<code>babel-register</code>, <code>babel-traverse</code>,
<code>babel-types</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15872"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15872/hovercard">#15872</a> enable
jest/no-standalone-expect (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
<li><code>babel-core</code>, <code>babel-helpers</code>,
<code>babel-plugin-transform-async-generator-functions</code>,
<code>babel-plugin-transform-modules-commonjs</code>,
<code>babel-plugin-transform-regenerator</code>,
<code>babel-preset-env</code>, <code>babel-runtime-corejs2</code>,
<code>babel-runtime-corejs3</code>, <code>babel-runtime</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15833"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15833/hovercard">#15833</a> bump
json5, terser and webpack, further minimize babel helpers (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
<li>Other
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15846"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15846/hovercard">#15846</a> Use
Babel 8.0 alpha to build babel (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15856"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15856/hovercard">#15856</a>
Exclude redundant files from publish process (<a
href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
</ul>
<h4>🔬 Output optimization</h4>
<ul>

<li><code>babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining</code>,
<code>babel-plugin-transform-class-properties</code>,
<code>babel-plugin-transform-classes</code>,
<code>babel-plugin-transform-optional-chaining</code>,
<code>babel-preset-env</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15871"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15871/hovercard">#15871</a>
Simplify <code>?.</code> output when chain result is ignored (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 7</h4>
<ul>
<li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@
babel-bot</a>)</li>
<li>Daniel Tschinder (<a href="https://snyk.io/redirect/github/danez">@
danez</a>)</li>
<li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@
JLHwung</a>)</li>
<li>Mustafa Ateş Uzun (<a href="https://snyk.io/redirect/github/0o001">@
0o001</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
<li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a></li>
<li>sanmu (<a href="https://snyk.io/redirect/github/yangguansen">@
yangguansen</a>)</li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/babel/babel/releases">@babel/parser
GitHub release notes</a>
  </details>
  <details>
    <summary>Package name: <b>@babel/types</b></summary>
    <ul>
      <li>
<b>7.22.19</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.19">2023-09-14</a></br><h2>v7.22.19
(2023-09-14)</h2>
<p>Re-published 7.22.18, due to a releasing error.</p>
      </li>
      <li>
<b>7.22.17</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.17">2023-09-08</a></br><h2>v7.22.17
(2023-09-08)</h2>
<p>Thanks <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jordanbtucker/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/jordanbtucker">@ jordanbtucker</a>
for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-core</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15947"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15947/hovercard">#15947</a> Fix
compatibility with Node.js 20.6 (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
<li><code>babel-helper-module-transforms</code>,
<code>babel-plugin-transform-modules-commonjs</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15941"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15941/hovercard">#15941</a> Fix
compiling duplicate ns imports to lazy CommonJS (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
<li><code>babel-types</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15920"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15920/hovercard">#15920</a> Make
<code>ClassDeclaration["id"]</code> optional in babel-types (<a
href="https://snyk.io/redirect/github/jordanbtucker">@
jordanbtucker</a>)</li>
</ul>
</li>
</ul>
<h4>🔬 Output optimization</h4>
<ul>
<li><code>babel-helper-remap-async-to-generator</code>,
<code>babel-helper-wrap-function</code>,
<code>babel-plugin-proposal-explicit-resource-management</code>,
<code>babel-plugin-proposal-function-sent</code>,
<code>babel-plugin-transform-async-generator-functions</code>,
<code>babel-plugin-transform-async-to-generator</code>,
<code>babel-plugin-transform-block-scoping</code>,
<code>babel-plugin-transform-class-properties</code>,
<code>babel-plugin-transform-classes</code>,
<code>babel-plugin-transform-parameters</code>,
<code>babel-plugin-transform-runtime</code>,
<code>babel-preset-env</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15922"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15922/hovercard">#15922</a>
Improve output when wrapping functions (e.g. <code>async</code>
functions) (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 3</h4>
<ul>
<li>Jordan Tucker (<a
href="https://snyk.io/redirect/github/jordanbtucker">@
jordanbtucker</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
<li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a></li>
</ul>
      </li>
      <li>
<b>7.22.15</b> - <a
href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.15">2023-09-04</a></br><h2>v7.22.15
(2023-09-04)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-core</code>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15923"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15923/hovercard">#15923</a> Only
perform config loading re-entrancy check for cjs (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><em>Every package</em>
<ul>
<li><a href="https://snyk.io/redirect/github/babel/babel/pull/15892"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/15892/hovercard">#15892</a> Add
explicit <code>.ts</code>/<code>.js</code> extension to all imports in
<code>src</code> (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 4</h4>
<ul>
<li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@
babel-bot</a>)</li>
<li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@
JLHwung</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://snyk.io/redirect/github/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
<li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@
liuxingbaoyu</a></li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/babel/babel/releases">@babel/types
GitHub release notes</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI5ZDI4MmM3Ni1jM2U5LTQ5NDEtYjM0Zi00YzIzZTYzYWE2ZWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjlkMjgyYzc2LWMzZTktNDk0MS1iMzRmLTRjMjNlNjNhYTZlZSJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603/settings/integration?pkg&#x3D;@babel/parser&amp;pkg&#x3D;@babel/types&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"9d282c76-c3e9-4941-b34f-4c23e63aa6ee","prPublicId":"9d282c76-c3e9-4941-b34f-4c23e63aa6ee","dependencies":[{"name":"@babel/parser","from":"7.22.11","to":"7.22.16"},{"name":"@babel/types","from":"7.22.15","to":"7.22.19"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"e5e31077-489f-44c1-b24d-4af9a1a8d603","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":4,"publishedDate":"2023-09-06T15:18:22.879Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected token, Unexpected character ' '
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu