Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: zeke/standard-markdown
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 847efc96194eecc9d484ccb2fdd52f083eae1e42
Choose a base ref
...
head repository: zeke/standard-markdown
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a5c3ee935f952ab51ad6090e7fa03b4ea23d9d1e
Choose a head ref
  • 7 commits
  • 4 files changed
  • 3 contributors

Commits on Sep 5, 2018

  1. Fix as cli failed 

    The following is an error.
```
path.js:39
    throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at assertPath (path.js:39:11)
    at Object.resolve (path.js:1090:7)
    at Command.<anonymous> (/home/vagrant/work/standard-markdown/cli.js:34:28)
    at Command.listener (/home/vagrant/work/standard-markdown/node_modules/commander/index.js:315:8)
    at Command.emit (events.js:182:13)
    at Command.parseArgs (/home/vagrant/work/standard-markdown/node_modules/commander/index.js:665:12)
    at Command.parse (/home/vagrant/work/standard-markdown/node_modules/commander/index.js:474:21)
    at Object.<anonymous> (/home/vagrant/work/standard-markdown/cli.js:42:4)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
```
    @abetomo
    abetomo committed Sep 5, 2018
    Copy the full SHA
    7b83a0e View commit details

Commits on Sep 7, 2018

  1. Update CI test to LTS version 

    https://github.com/nodejs/Release#release-schedule
    @abetomo
    abetomo committed Sep 7, 2018
    Copy the full SHA
    fae907f View commit details

  2. Merge pull request #25 from abetomo/fix_pathjs_error 

    Fix as cli failed
    @zeke
    zeke authored Sep 7, 2018
    Copy the full SHA
    2738ffa View commit details

  3. Merge pull request #26 from abetomo/update_ci_test_to_lts_version 

    Update CI test to LTS version
    @zeke
    zeke authored Sep 7, 2018
    Copy the full SHA
    d4692c5 View commit details

  4. Modify to follow the rules of the new 'standard' 

    I upgraded the package and
fixed it according to the latest 'standard' rules.
    @abetomo
    abetomo committed Sep 7, 2018
    Copy the full SHA
    95dad5d View commit details

Commits on Sep 12, 2018

  1. Merge pull request #27 from abetomo/upgrade_packages 

    Modify to follow the rules of the new 'standard'
    @zeke
    zeke authored Sep 12, 2018
    Copy the full SHA
    8023aa4 View commit details

  2. 5.0.0

    @zeke
    zeke committed Sep 12, 2018
    Copy the full SHA
    a5c3ee9 View commit details
Showing with 15 additions and 14 deletions.
  1. +2 −2 .travis.yml
  2. +1 −0 cli.js
  3. +10 −10 package.json
  4. +2 −2 tests/fixtures/clean.md
4 changes: 2 additions & 2 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
language: node_js
node_js:
- "4"
- "6"
- "7"
- "8"
- "10"
1 change: 1 addition & 0 deletions cli.js
View file
Original file line number Diff line number Diff line change
@@ -27,6 +27,7 @@ program
.option('-f, --fix', 'Attempt to fix basic standard JS issues')
.option('-v, --verbose', 'Verbose mode')
.action(function (cwdValue, patternArgs) {
if (cwdValue == null) return
// If cwd is an actual path, set it to be the cwd
// Otherwise interpret it as a glob pattern
if (fs.existsSync(path.resolve(cwdValue)) && fs.lstatSync(path.resolve(cwdValue)).isDirectory()) {
20 changes: 10 additions & 10 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "standard-markdown",
"version": "4.0.2",
"version": "5.0.0",
"description": "Test your Markdown files for Standard JavaScript Style™",
"main": "index.js",
"bin": "cli.js",
@@ -20,17 +20,17 @@
"author": "Zeke Sikelianos <zeke@sikelianos.com> (http://zeke.sikelianos.com)",
"license": "MIT",
"dependencies": {
"async": "^2.0.1",
"commander": "^2.9.0",
"globby": "^6.0.0",
"lodash.flatten": "^4.2.0",
"lodash.range": "^3.1.5",
"ora": "^1.2.0",
"standard": "^10.0.2"
"async": "^2.6.1",
"commander": "^2.18.0",
"globby": "^8.0.1",
"lodash.flatten": "^4.4.0",
"lodash.range": "^3.2.0",
"ora": "^3.0.0",
"standard": "^12.0.1"
},
"devDependencies": {
"tap-spec": "^4.1.1",
"tape": "^4.6.0"
"tap-spec": "^5.0.0",
"tape": "^4.9.1"
},
"engines": {
"node": ">=4"
4 changes: 2 additions & 2 deletions tests/fixtures/clean.md
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ It should allow creation of unused variables

```js
// `BrowserWindow` is declared but not used
const {BrowserWindow} = require('electron')
const { BrowserWindow } = require('electron')
```

It should allow orphan objects:
@@ -60,7 +60,7 @@ and wrapped arrays:
Electron docs have a bunch of non-node-style callbacks that don't have `err` as the first arg:

```javascript
const {app} = require('electron')
const { app } = require('electron')

app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
if (url === 'https://github.com') {