Skip to content

Commit 03a9523

Browse files
authoredMar 5, 2019
chore: forgoing dropping Node 6 until yargs@14 (#1308)
1 parent 14920d1 commit 03a9523

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed
 

‎.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
language: node_js
22

33
node_js:
4+
- "6"
45
- "8"
56
- "10"
67
# - "11" TODO: add 11 in April when 12 goes live.

‎CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ All notable changes to this project will be documented in this file. See [standa
3636

3737
### Chores
3838

39-
* drop Node 6 from testing matrix ([#1287](https://github.com/yargs/yargs/issues/1287)) ([ef16792](https://github.com/yargs/yargs/commit/ef16792))
39+
* ~drop Node 6 from testing matrix ([#1287](https://github.com/yargs/yargs/issues/1287)) ([ef16792](https://github.com/yargs/yargs/commit/ef16792))~
40+
* _opting to not drop Node 6 support until April, [see](https://github.com/nodejs/Release)._
4041
* update dependencies ([#1284](https://github.com/yargs/yargs/issues/1284)) ([f25de4f](https://github.com/yargs/yargs/commit/f25de4f))
4142

4243

‎test/middleware.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,10 @@ describe('middleware', () => {
261261
it('throws an error if async function provided', function () {
262262
expect(() => {
263263
yargs(['mw'])
264-
.middleware([async function (argv) {
264+
.middleware([function (argv) {
265265
argv.mw = 'mw'
266266
argv.other = true
267+
return Promise.resolve(argv)
267268
}], true)
268269
.command(
269270
'mw',

0 commit comments

Comments
 (0)
Please sign in to comment.