Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update description for --no-client #4250

Merged
merged 1 commit into from Feb 6, 2022
Merged

fix: update description for --no-client #4250

merged 1 commit into from Feb 6, 2022

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated snapshots.

Motivation / Use-Case

update description for --no-client.

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #4250 (2f5b733) into master (72cdfa4) will increase coverage by 20.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4250       +/-   ##
===========================================
+ Coverage   71.58%   92.34%   +20.75%     
===========================================
  Files          14       14               
  Lines        1179     1541      +362     
  Branches      349      590      +241     
===========================================
+ Hits          844     1423      +579     
- Misses         79      109       +30     
+ Partials      256        9      -247     
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
client-src/utils/sendMessage.js 83.33% <0.00%> (-16.67%) ⬇️
client-src/utils/log.js 100.00% <0.00%> (ø)
lib/servers/BaseServer.js 100.00% <0.00%> (ø)
client-src/clients/SockJSClient.js 100.00% <0.00%> (ø)
client-src/clients/WebSocketClient.js 100.00% <0.00%> (ø)
lib/servers/WebsocketServer.js 89.74% <0.00%> (+1.86%) ⬆️
client-src/utils/reloadApp.js 78.57% <0.00%> (+6.57%) ⬆️
client-src/utils/parseURL.js 100.00% <0.00%> (+7.69%) ⬆️
client-src/index.js 77.67% <0.00%> (+7.91%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cdfa4...2f5b733. Read the comment docs.

@snitin315 snitin315 merged commit c3b6690 into master Feb 6, 2022
@snitin315 snitin315 deleted the no-client-des branch February 6, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants