fix(isUrlRequest): ignore about:blank

webpack · Dec 21, 2018 · ac05880 · ac05880
1 parent 47e2e02
commit ac05880
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/isUrlRequest.js b/lib/isUrlRequest.js
@@ -5,7 +5,7 @@ function isUrlRequest(url, root) {
 	// 1. it's a Data Url
 	// 2. it's an absolute url or and protocol-relative
 	// 3. it's some kind of url for a template
-	if(/^data:|^.+-extension:\/|^(https?:)?\/\/|^[\{\}\[\]#*;,'§\$%&\(=?`´\^°<>]/.test(url)) {
+	if(/^data:|^.+-extension:\/|^about:blank$|^(https?:)?\/\/|^[\{\}\[\]#*;,'§\$%&\(=?`´\^°<>]/.test(url)) {
 		return false;
 	}
 

diff --git a/test/isUrlRequest.test.js b/test/isUrlRequest.test.js
@@ -51,7 +51,10 @@ describe("isUrlRequest()", () => {
 		[["/path/to/thing", 1], new ExpectedError(/unexpected parameters/i), "should throw an error on invalid root"],
 
 		// empty url
-		[[""], true, "should be positive if url is empty"]
+		[[""], true, "should be positive if url is empty"],
+
+		// about url
+		[["about:blank"], false, "should be negative for about:blank"]
 	].forEach((test) => {
 		it(test[2], () => {
 			const expected = test[1];