fix: ignore all nonstandard extension protocols

Author: evilebottnawi

lib/isUrlRequest.js

@@ -5,9 +5,15 @@ function isUrlRequest(url, root) {
 	// 1. it's a Data Url
 	// 2. it's an absolute url or and protocol-relative
 	// 3. it's some kind of url for a template
-	if(/^data:|^chrome-extension:|^moz-extension:|^ms-browser-extension:|^(https?:)?\/\/|^[\{\}\[\]#*;,'§\$%&\(=?`´\^°<>]/.test(url)) return false;
+	if(/^data:|^.+-extension:\/|^(https?:)?\/\/|^[\{\}\[\]#*;,'§\$%&\(=?`´\^°<>]/.test(url)) {
+		return false;
+	}
+
 	// 4. It's also not an request if root isn't set and it's a root-relative url
-	if((root === undefined || root === false) && /^\//.test(url)) return false;
+	if((root === undefined || root === false) && /^\//.test(url)) {
+		return false;
+	}
+
 	return true;
 }
 

test/isUrlRequest.test.js

@@ -16,28 +16,37 @@ describe("isUrlRequest()", () => {
 		[["//google.com"], false, "should be negative for scheme-agnostic urls"],
 		[["http://google.com"], false, "should be negative for http urls"],
 		[["https://google.com"], false, "should be negative for https urls"],
-		[["chrome-extension://"], false, "should be negative for https urls"],
-		[["moz-extension://"], false, "should be negative for https urls"],
-		[["ms-browser-extension://"], false, "should be negative for https urls"],
+
+		[["chrome-extension://"], false, "should be negative for nonstandard urls"],
+		[["moz-extension://"], false, "should be negative for nonstandard urls"],
+		[["ms-browser-extension://"], false, "should be negative for nonstandard urls"],
+		[["custom-extension://"], false, "should be negative for nonstandard urls"],
+
 		[["path/to/thing"], true, "should be positive for implicit relative urls"],
 		[["./path/to/thing"], true, "should be positive for explicit relative urls"],
 		[["~path/to/thing"], true, "should be positive for module urls (with ~)"],
 		[["some/other/stuff/and/then~path/to/thing"], true, "should be positive for module urls with path prefix"],
 		[["./some/other/stuff/and/then~path/to/thing"], true, "should be positive for module urls with relative path prefix"],
+
 		// with root (normal path)
 		[["path/to/thing", "root/dir"], true, "should be positive with root if implicit relative url"],
 		[["./path/to/thing", "root/dir"], true, "should be positive with root if explicit relative url"],
 		[["/path/to/thing", "root/dir"], true, "should be positive with root if root-relative url"],
+
 		// with root (boolean)
 		[["/path/to/thing", true], true, "should be positive for root-relative if root = `true`"],
+
 		// with root (boolean) on Windows
 		[["C:\\path\\to\\thing"], true, "should be positive for Windows absolute paths with drive letter"],
 		[["\\\\?\\UNC\\ComputerName\\path\\to\\thing"], true, "should be positive for Windows absolute UNC paths"],
+
 		// with root (module)
 		[["/path/to/thing", "~"], true, "should be positive for module url if root = ~"],
+
 		// with root (module path)
 		[["/path/to/thing", "~module"], true, "should be positive for module prefixes when root starts with ~"],
 		[["/path/to/thing", "~module/"], true, "should be positive for module prefixes (with trailing slash) when root starts with ~"],
+
 		// error cases
 		[["/path/to/thing", 1], new ExpectedError(/unexpected parameters/i), "should throw an error on invalid root"],