Skip to content
This repository was archived by the owner on Sep 9, 2021. It is now read-only.

Commit e832f7b

Browse files
committedFeb 22, 2017
Remove destructuring
1 parent c1c63c2 commit e832f7b

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed
 

‎index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ module.exports.pitch = function pitch(request) {
4242
workerCompiler.runAsChild((err, entries, compilation) => {
4343
if (err) return callback(err);
4444
if (entries[0]) {
45-
const [workerFile] = entries[0].files;
45+
const workerFile = entries[0].files[0];
4646
let constructor = `new Worker(__webpack_public_path__ + ${JSON.stringify(workerFile)})`;
4747
if (query.inline) {
4848
constructor = `require(${JSON.stringify(`!!${path.join(__dirname, 'createInlineWorker.js')}`)})(${

‎package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
}
2323
],
2424
"no-underscore-dangle": 0,
25-
"no-param-reassign": 0
25+
"no-param-reassign": 0,
26+
"prefer-destructuring": 0
2627
}
2728
},
2829
"peerDependencies": {

‎test/index.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ const makeBundle = name => del(`expected/${name}`).then(() => {
2929
describe('worker-loader', () => {
3030
it('should create chunk with worker', () =>
3131
makeBundle('worker').then((stats) => {
32-
const [workerFile] = stats.toJson('minimal').children
32+
const workerFile = stats.toJson('minimal').children
3333
.map(item => item.chunks)
3434
.reduce((acc, item) => acc.concat(item), [])
3535
.map(item => item.files)
36-
.map(item => `expected/worker/${item}`);
36+
.map(item => `expected/worker/${item}`)[0];
3737
assert(workerFile);
3838
assert.notEqual(readFile(workerFile).indexOf('// worker test mark'), -1);
3939
})
@@ -42,22 +42,22 @@ describe('worker-loader', () => {
4242
it('should create chunk with specified name', () =>
4343
makeBundle('name').then((stats) => {
4444
const workerFile = 'expected/name/namedWorker.js';
45-
const [receivedWorkerFile] = stats.toJson('minimal').children
45+
const receivedWorkerFile = stats.toJson('minimal').children
4646
.map(item => item.chunks)
4747
.reduce((acc, item) => acc.concat(item), [])
4848
.map(item => item.files)
49-
.map(item => `expected/name/${item}`);
49+
.map(item => `expected/name/${item}`)[0];
5050
assert.equal(receivedWorkerFile, workerFile);
5151
assert.notEqual(readFile(workerFile).indexOf('// named worker test mark'), -1);
5252
})
5353
);
5454

5555
it('should inline worker with inline option', () =>
5656
makeBundle('inline').then((stats) => {
57-
const [bundleFile] = stats.toJson('minimal').chunks
57+
const bundleFile = stats.toJson('minimal').chunks
5858
.map(item => item.files)
5959
.reduce((acc, item) => acc.concat(item), [])
60-
.map(item => `expected/inline/${item}`);
60+
.map(item => `expected/inline/${item}`)[0];
6161
assert(bundleFile);
6262
assert.notEqual(readFile(bundleFile).indexOf('// inlined worker test mark'), -1);
6363
})

0 commit comments

Comments
 (0)
This repository has been archived.