Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webpack-contrib/url-loader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5574ed3ec10c71440f6de32f0abcd5d2609ffb79
Choose a base ref
...
head repository: webpack-contrib/url-loader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8828d64dbd6cea392a277360dcd1db7297c07451
Choose a head ref

Commits on Jun 13, 2017

  1. Copy the full SHA
    ced5990 View commit details

Commits on Jun 20, 2017

  1. Copy the full SHA
    2de70bb View commit details

Commits on Sep 13, 2017

  1. Copy the full SHA
    f3f5fce View commit details

Commits on Sep 14, 2017

  1. Copy the full SHA
    636ebed View commit details

Commits on Oct 2, 2017

  1. Copy the full SHA
    d19ee2d View commit details

Commits on Oct 3, 2017

  1. chore: Fix mime version

    joshwiens committed Oct 3, 2017
    Copy the full SHA
    a1e1fef View commit details
  2. chore(release): 0.6.0

    joshwiens committed Oct 3, 2017
    Copy the full SHA
    1934507 View commit details
  3. Copy the full SHA
    11dce14 View commit details

Commits on Oct 4, 2017

  1. Copy the full SHA
    2b01ea2 View commit details
  2. chore(release): 0.6.1

    joshwiens committed Oct 4, 2017
    Copy the full SHA
    a8f338e View commit details
  3. fix: allow use limit as string (#96)

    evilebottnawi authored and joshwiens committed Oct 4, 2017
    Copy the full SHA
    b31684d View commit details
  4. chore(release): 0.6.2

    joshwiens committed Oct 4, 2017
    Copy the full SHA
    672ba80 View commit details

Commits on Dec 17, 2017

  1. refactor: apply webpack-defaults (#102)

    - Upgrades to `webpack-defaults@2.0.0`
    - Drops support for `node =< v4.0.0`
    - Sets the minimum `peerDependency` to `webpack >= 3.0.0`
    
    BREAKING CHANGE: Sets `engines` to `"node": ">= 6.9.0 || >= 8.9.0"`
    BREAKING CHANGE: Drops support for `webpack =< v2.0.0`
    michael-ciniawsky authored and joshwiens committed Dec 17, 2017
    Copy the full SHA
    073b588 View commit details
  2. Copy the full SHA
    5ce17f7 View commit details
  3. Copy the full SHA
    f9174d2 View commit details
  4. Copy the full SHA
    b61859c View commit details
  5. Copy the full SHA
    3c87902 View commit details

Commits on Dec 20, 2017

  1. Copy the full SHA
    5aeba3e View commit details
  2. Copy the full SHA
    4a62cd5 View commit details
  3. Copy the full SHA
    b4be0c8 View commit details

Commits on Mar 3, 2018

  1. Copy the full SHA
    457618b View commit details
  2. Copy the full SHA
    0390cdb View commit details
  3. Copy the full SHA
    0eeaaa9 View commit details
  4. Copy the full SHA
    18555fa View commit details
  5. Copy the full SHA
    7b60cc2 View commit details
  6. Copy the full SHA
    08135bc View commit details

Commits on May 14, 2018

  1. Copy the full SHA
    0256fe7 View commit details

Commits on Jun 16, 2018

  1. refactor: webpack-defaults (#129)

    * refactor: webpack-defaults
    
    * chore: update package-lock
    
    * test: update error test and snapshot to pass in coverage
    shellscape authored Jun 16, 2018
    14
    Copy the full SHA
    9946374 View commit details
  2. feat: support fallback loader in options.fallback (#123)

    Resolves #118
    
    It is now possible to explicitly specify options for the fallback loader.
    
    The new definition (schema) for the fallback option is a lighter variant of the one for module.rules.use. See schemas/WebpackOptions.json in the webpack repository.
    Pimm authored and shellscape committed Jun 16, 2018
    2
    Copy the full SHA
    017adc7 View commit details

Commits on Jul 21, 2018

  1. test: fix a test (#130)

    Pimm authored and evilebottnawi committed Jul 21, 2018
    Copy the full SHA
    4941853 View commit details

Commits on Jul 30, 2018

  1. Copy the full SHA
    827da9f View commit details

Commits on Aug 13, 2018

  1. refactor: utils (#136)

    evilebottnawi authored Aug 13, 2018
    Copy the full SHA
    50ab086 View commit details
  2. chore(release): 1.1.0

    alexander-akait committed Aug 13, 2018
    Copy the full SHA
    7c8f03b View commit details

Commits on Aug 14, 2018

  1. Copy the full SHA
    75d9d8b View commit details

Commits on Aug 15, 2018

  1. fix(utils/normalizeFallback): correctly pass all options to the def…

    …ault fallback (`file-loader`) (#139)
    insin authored and michael-ciniawsky committed Aug 15, 2018
    Copy the full SHA
    401be63 View commit details

Commits on Aug 16, 2018

  1. Copy the full SHA
    e4d10a2 View commit details

Commits on Aug 17, 2018

  1. Copy the full SHA
    03e631f View commit details
  2. chore(release): 1.1.1

    alexander-akait committed Aug 17, 2018
    Copy the full SHA
    31b51c3 View commit details

Commits on Sep 12, 2018

  1. Copy the full SHA
    a6860fc View commit details

Commits on Oct 10, 2018

  1. Fix doc formating (#153)

    MattGurneyAMP authored and michael-ciniawsky committed Oct 10, 2018
    Copy the full SHA
    fb465ad View commit details
  2. Copy the full SHA
    d37b108 View commit details
  3. Copy the full SHA
    0bbe0b8 View commit details

Commits on Oct 25, 2018

  1. Copy the full SHA
    b603665 View commit details

Commits on Dec 20, 2018

  1. Copy the full SHA
    16bc97c View commit details
  2. Copy the full SHA
    c2d7b73 View commit details

Commits on Apr 4, 2019

  1. test: test svg scenario. #176 (#177)

    Jeff-Tian authored and evilebottnawi committed Apr 4, 2019
    Copy the full SHA
    a6705cc View commit details

Commits on Jun 5, 2019

  1. fix: fallback loader will be used than limit is equal or greater (#179)

    BREAKING CHANGE: fix: fallback loader will be used than limit is equal or greater
    evilebottnawi authored Jun 5, 2019
    Copy the full SHA
    3c24545 View commit details
  2. fix: limit should always be a number and 0 value handles as number (#…

    …180)
    
    BREAKING CHANGE: `limit` should always be a number and 0 value handles as number
    evilebottnawi authored Jun 5, 2019
    Copy the full SHA
    d82e453 View commit details
  3. Copy the full SHA
    60d2cb3 View commit details
  4. chore(deps): update (#182)

    BREAKING CHANGE: minimum required nodejs version is `8.9.0`
    evilebottnawi authored Jun 5, 2019
    Copy the full SHA
    4386b3e View commit details
Showing with 16,815 additions and 236 deletions.
  1. +12 −0 .editorconfig
  2. +4 −0 .eslintignore
  3. +4 −0 .eslintrc.js
  4. +4 −0 .gitattributes
  5. +6 −0 .github/CODEOWNERS
  6. +160 −0 .github/CONTRIBUTING.md
  7. +1 −0 .github/FUNDING.yml
  8. +13 −12 .github/ISSUE_TEMPLATE.md
  9. +50 −0 .github/ISSUE_TEMPLATE/BUG.md
  10. +28 −0 .github/ISSUE_TEMPLATE/DOCS.md
  11. +25 −0 .github/ISSUE_TEMPLATE/FEATURE.md
  12. +27 −0 .github/ISSUE_TEMPLATE/MODIFICATION.md
  13. +8 −0 .github/ISSUE_TEMPLATE/SUPPORT.md
  14. +28 −11 .github/PULL_REQUEST_TEMPLATE.md
  15. +17 −1 .gitignore
  16. +5 −0 .prettierignore
  17. +5 −0 .prettierrc.js
  18. +185 −1 CHANGELOG.md
  19. +265 −163 README.md
  20. +200 −0 azure-pipelines.yml
  21. +19 −0 babel.config.js
  22. +3 −0 commitlint.config.js
  23. +6 −0 husky.config.js
  24. +0 −34 index.js
  25. +4 −0 lint-staged.config.js
  26. +13,952 −0 package-lock.json
  27. +74 −14 package.json
  28. +4 −0 src/cjs.js
  29. +75 −0 src/index.js
  30. +47 −0 src/options.json
  31. +27 −0 src/utils/normalizeFallback.js
  32. +19 −0 test/__snapshots__/esModule-options.test.js.snap
  33. +121 −0 test/__snapshots__/fallback-option.test.js.snap
  34. +213 −0 test/__snapshots__/limit-option.test.js.snap
  35. +62 −0 test/__snapshots__/loader.test.js.snap
  36. +37 −0 test/__snapshots__/mimetype-option.test.js.snap
  37. +38 −0 test/__snapshots__/validate-options.test.js.snap
  38. +12 −0 test/cjs.test.js
  39. +53 −0 test/esModule-options.test.js
  40. +156 −0 test/fallback-option.test.js
  41. BIN test/fixtures/file.gif
  42. BIN test/fixtures/file.jpg
  43. BIN test/fixtures/file.png
  44. +48 −0 test/fixtures/file.svg
  45. +6 −0 test/fixtures/simple-svg.js
  46. +5 −0 test/fixtures/simple.js
  47. +3 −0 test/fixtures/string-raw-loader/index.js
  48. +7 −0 test/fixtures/x-custom-loader/index.js
  49. +11 −0 test/helpers/compile.js
  50. +22 −0 test/helpers/execute.js
  51. +45 −0 test/helpers/getCompiler.js
  52. +7 −0 test/helpers/index.js
  53. +25 −0 test/helpers/normalizeErrors.js
  54. +15 −0 test/helpers/readAsset.js
  55. +279 −0 test/limit-option.test.js
  56. +133 −0 test/loader.test.js
  57. +55 −0 test/mimetype-option.test.js
  58. +51 −0 test/utils/__snapshots__/normalizeFallback.test.js.snap
  59. +55 −0 test/utils/normalizeFallback.test.js
  60. +79 −0 test/validate-options.test.js
12 changes: 12 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# editorconfig.org

[*]
charset = utf-8
indent_style = space
indent_size = 2
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

[*.md]
trim_trailing_whitespace = false
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/coverage
/dist
/node_modules
/test/fixtures
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
root: true,
extends: ['@webpack-contrib/eslint-config-webpack', 'prettier'],
};
4 changes: 4 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package-lock.json -diff
* text=auto
bin/* eol=lf
yarn.lock -diff
6 changes: 6 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# These are the default owners for everything in
# webpack-contrib
@webpack-contrib/org-maintainers

# Add repository specific users / groups
# below here for libs that are not maintained by the org.
160 changes: 160 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
# Contributing in @webpack-contrib

We'd always love contributions to further improve the webpack / webpack-contrib ecosystem!
Here are the guidelines we'd like you to follow:

- [Questions and Problems](#question)
- [Issues and Bugs](#issue)
- [Feature Requests](#feature)
- [Pull Request Submission Guidelines](#submit-pr)
- [Commit Message Conventions](#commit)

## <a name="question"></a> Got a Question or Problem?

Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack).
StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack).
The issue tracker is for bug reports and feature discussions.

## <a name="issue"></a> Found an Issue or Bug?

Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.

We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we ask that you to provide a minimal reproduction scenario (github repo or failing test case). Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like:

- version of Webpack used
- version of the loader / plugin you are creating a bug report for
- the use-case that fails

A minimal reproduce scenario allows us to quickly confirm a bug (or point out config problems) as well as confirm that we are fixing the right problem.

We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.

Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.

## <a name="feature"></a> Feature Requests?

You can _request_ a new feature by creating an issue on Github.

If you would like to _implement_ a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.

## <a name="submit-pr"></a> Pull Request Submission Guidelines

Before you submit your Pull Request (PR) consider the following guidelines:

- Search Github for an open or closed PR that relates to your submission. You don't want to duplicate effort.
- Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit). Adherence to these conventions is necessary because release notes are automatically generated from these messages.
- Fill out our `Pull Request Template`. Your pull request will not be considered if it is ignored.
- Please sign the `Contributor License Agreement (CLA)` when a pull request is opened. We cannot accept your pull request without this. Make sure you sign with the primary email address associated with your local / github account.

## <a name="commit"></a> Webpack Contrib Commit Conventions

Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
format that includes a **type**, a **scope** and a **subject**:

```
<type>(<scope>): <subject>
<BLANK LINE>
<body>
<BLANK LINE>
<footer>
```

The **header** is mandatory and the **scope** of the header is optional.

Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
to read on GitHub as well as in various git tools.

The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.

Examples:

```
docs(readme): update install instructions
```

```
fix: refer to the `entrypoint` instead of the first `module`
```

### Revert

If the commit reverts a previous commit, it should begin with `revert:`, followed by the header of the reverted commit.
In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.

### Type

Must be one of the following:

- **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
- **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
- **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
- **docs**: Documentation only changes (example scopes: readme, changelog)
- **feat**: A new feature
- **fix**: A bug fix
- **perf**: A code change that improves performance
- **refactor**: A code change that neither fixes a bug nor adds a feature
- **revert**: Used when reverting a committed change
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
- **test**: Addition of or updates to Jest tests

### Scope

The scope is subjective & depends on the `type` see above. A good example would be a change to a particular class / module.

### Subject

The subject contains a succinct description of the change:

- use the imperative, present tense: "change" not "changed" nor "changes"
- don't capitalize the first letter
- no dot (.) at the end

### Body

Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
The body should include the motivation for the change and contrast this with previous behavior.

### Footer

The footer should contain any information about **Breaking Changes** and is also the place to
reference GitHub issues that this commit **Closes**.

**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.

Example

```
BREAKING CHANGE: Updates to `Chunk.mapModules`.
This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764
Migration: see webpack/webpack#5225
```

## Testing Your Pull Request

You may have the need to test your changes in a real-world project or dependent
module. Thankfully, Github provides a means to do this. Add a dependency to the
`package.json` for such a project as follows:

```json
{
"devDependencies": {
"url-loader": "webpack-contrib/url-loader#{id}/head"
}
}
```

Where `{id}` is the # ID of your Pull Request.

## Contributor License Agreement

When submitting your contribution, a CLA (Contributor License Agreement) bot will come by to verify that you signed the [CLA](https://cla.js.foundation/webpack-contrib/url-loader).
If it is your first time, it will link you to the right place to sign it.
However, if you have committed your contributions using an email that is not the same as your email used on GitHub, the CLA bot can't accept your contribution.

Run `git config user.email` to see your Git email, and verify it with [your GitHub email](https://github.com/settings/emails).

## Thanks

For your interest, time, understanding, and for following this simple guide.
1 change: 1 addition & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
open_collective: webpack
25 changes: 13 additions & 12 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
<!-- Before creating an issue please make sure you are using the latest version of url-loader. -->
<!--
👉🏽 Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
**Do you want to request a *feature* or report a *bug*?**
<!-- Please ask questions on StackOverflow or the webpack Gitter (https://gitter.im/webpack/webpack). Questions will be closed. -->
Hey there!
**What is the current behavior?**
You arrived at this template because you felt none of the other options
matched the kind of issue you'd like to report. Please use this opportunity to
tell us about your particular type of issue so we can try to accomodate
similar issues in the future.
**If the current behavior is a bug, please provide the steps to reproduce.**
<!-- A great way to do this is to provide your configuration via a GitHub gist. -->

**What is the expected behavior?**

**If this is a feature request, what is motivation or use case for changing the behavior?**

**Please mention other relevant information such as your webpack version, Node.js version and Operating System.**
PLEASE do note, if you're using this to report an issue already covered by the
existing template types, your issue may be closed as invalid. Our issue
templates contain fields that help us help you, and without that important
info, we might as well be ice-skating uphill, carrying a wooly mammoth.
-->
50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
---
name: 🐛 Bug Report
about: Something went awry and you'd like to tell us about it.
---

<!--
Issues are so 🔥
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
👉🏽 Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- url-loader Version:

### Expected Behavior

<!-- Remove this section if not reporting a bug or modification request. -->

### Actual Behavior

<!-- Remove this section if not reporting a bug or modification request. -->

### Code

```js
// webpack.config.js
// If your code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
```

```js
// additional code, HEY YO remove this block if you don't need it
```

### How Do We Reproduce?

<!--
Remove this section if not reporting a bug.
If your webpack config is over 50 lines long, please provide a URL to a repo
for your beefy 🍖 app that we can use to reproduce.
-->
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/DOCS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: 📚 Documentation
about: Are the docs lacking or missing something? Do they need some new 🔥 hotness? Tell us here.
---

<!--
Issues are so 🔥
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
👉🏽 Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

Documentation Is:

<!-- Please place an x (no spaces!) in all [ ] that apply -->

- [ ] Missing
- [ ] Needed
- [ ] Confusing
- [ ] Not Sure?

### Please Explain in Detail...

### Your Proposal for Changes
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: ✨ Feature Request
about: Suggest an idea for this project
---

<!--
Issues are so 🔥
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
👉🏽 Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- url-loader Version:

### Feature Proposal

### Feature Use Case
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE/MODIFICATION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
name: 🔧 Modification Request
about: Would you like something work differently? Have an alternative approach? This is the template for you.
---

<!--
Issues are so 🔥
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
👉🏽 Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- url-loader Version:

### Expected Behavior / Situation

### Actual Behavior / Situation

### Modification Proposal
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/SUPPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
name: 🆘 Support, Help, and Advice
about: 👉🏽 Need support, help, or advice? Don't open an issue! Head to StackOverflow or https://gitter.im/webpack/webpack.
---

Hey there! If you need support, help, or advice then this is not the place to ask.
Please visit [StackOverflow](https://stackoverflow.com/questions/tagged/webpack)
or [the Webpack Gitter](https://gitter.im/webpack/webpack) instead.
Loading