Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webpack-contrib/sass-loader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d0b35cb4cc7a1b2f4713809c94baac2d20f75006
Choose a base ref
...
head repository: webpack-contrib/sass-loader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 45bd8655864adbfe7e1c71a277c8e9cbb22b86ab
Choose a head ref

Commits on Aug 1, 2018

  1. test: Refactor module import tests (#599)

    In preparation for #573
    Imports without file extensions are deprecated in LibSass and
    even not supported in DartSass.
    jhnns authored Aug 1, 2018
    Copy the full SHA
    714f5c6 View commit details
  2. feat: Make this package implementation-agnostic (#573)

    Rather than always loading Node Sass, this now requires users to pass in
    either Dart Sass or Node Sass as an option to the loader.
    
    Closes #435
    nex3 authored and jhnns committed Aug 1, 2018
    Copy the full SHA
    bed9fb5 View commit details
  3. chore(release): 7.1.0

    jhnns committed Aug 1, 2018
    Copy the full SHA
    aada4c3 View commit details
  4. Copy the full SHA
    6085bf6 View commit details

Commits on Aug 7, 2018

  1. Copy the full SHA
    b7aca40 View commit details

Commits on Aug 23, 2018

  1. Copy the full SHA
    f4bdcfe View commit details

Commits on Aug 25, 2018

  1. Copy the full SHA
    a7bf7c0 View commit details

Commits on Oct 30, 2018

  1. Copy the full SHA
    472d09a View commit details

Commits on Dec 12, 2018

  1. Copy the full SHA
    5984a2c View commit details
  2. Copy the full SHA
    69dc5e5 View commit details
  3. Copy the full SHA
    d56c0f8 View commit details
  4. Copy the full SHA
    f799569 View commit details

Commits on Dec 13, 2018

  1. Copy the full SHA
    a80cdb1 View commit details
  2. Copy the full SHA
    bc3b848 View commit details
  3. Copy the full SHA
    2adcca3 View commit details

Commits on Dec 14, 2018

  1. Copy the full SHA
    f524223 View commit details
  2. feat: support auto resolving dart-sass

    Now you don't need setup `implementation: require('sass')`, just add `sass` to your `package.json` and install dependencies and `sass-loader` automatically load `sass`. Beware situation when `node-sass` and `sass` was installed, by default `sass-loader` loads `node-sass`, to avoid this situation use `implementation` option.
    evilebottnawi authored Dec 14, 2018
    Copy the full SHA
    ff90dd6 View commit details
  3. Copy the full SHA
    a8709c9 View commit details
  4. Copy the full SHA
    aa64e1b View commit details
  5. Copy the full SHA
    2d6045b View commit details

Commits on Dec 17, 2018

  1. Copy the full SHA
    6c9654d View commit details

Commits on Mar 14, 2019

  1. docs: add source-map to style-loader (#661)

    Jack Zhao authored and evilebottnawi committed Mar 14, 2019
    Copy the full SHA
    69c6f91 View commit details

Commits on Mar 26, 2019

  1. Copy the full SHA
    9162e45 View commit details

Commits on May 7, 2019

  1. Copy the full SHA
    e279f2a View commit details

Commits on Aug 8, 2019

  1. Copy the full SHA
    9e5a45d View commit details
  2. Copy the full SHA
    2a51502 View commit details
  3. Copy the full SHA
    28f1884 View commit details
  4. Copy the full SHA
    6fc9d4e View commit details
  5. Copy the full SHA
    bcb06d5 View commit details

Commits on Aug 9, 2019

  1. Copy the full SHA
    45ac0b5 View commit details
  2. Copy the full SHA
    6e8e409 View commit details
  3. Copy the full SHA
    865f713 View commit details

Commits on Aug 10, 2019

  1. Copy the full SHA
    f59646f View commit details

Commits on Aug 13, 2019

  1. Copy the full SHA
    39b3bf4 View commit details

Commits on Aug 14, 2019

  1. Copy the full SHA
    1905e7b View commit details
  2. refactor: code (#719)

    evilebottnawi authored Aug 14, 2019
    Copy the full SHA
    c459352 View commit details
  3. Copy the full SHA
    96f436f View commit details

Commits on Aug 15, 2019

  1. Copy the full SHA
    0e94940 View commit details

Commits on Aug 16, 2019

  1. Copy the full SHA
    55f1af8 View commit details
  2. Copy the full SHA
    b8a7ca7 View commit details
  3. refactor: code

    alexander-akait committed Aug 16, 2019
    Copy the full SHA
    3545434 View commit details
  4. Copy the full SHA
    b2af379 View commit details
  5. Copy the full SHA
    97c93dd View commit details
  6. refactor: code (#725)

    evilebottnawi authored Aug 16, 2019
    Copy the full SHA
    dc23895 View commit details
  7. Copy the full SHA
    6be93c8 View commit details
  8. Copy the full SHA
    071fa88 View commit details

Commits on Aug 20, 2019

  1. Copy the full SHA
    997a255 View commit details
  2. Copy the full SHA
    0330253 View commit details
  3. Copy the full SHA
    6f4ea37 View commit details
  4. chore(release): 7.3.0

    alexander-akait committed Aug 20, 2019
    Copy the full SHA
    a3ac649 View commit details
Showing 351 changed files with 189,154 additions and 12,259 deletions.
17 changes: 7 additions & 10 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
# This file is for unifying the coding style for different editors and IDEs.
# More information at http://EditorConfig.org

# No .editorconfig files above the root directory
root = true
# editorconfig.org

[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
indent_style = space
indent_size = 2
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

[package.json]
indent_size = 2
[*.md]
trim_trailing_whitespace = false
9 changes: 4 additions & 5 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Compiled by webpack
test/output

# Fake node_modules folder for tests
test/node_modules
/coverage
/dist
/node_modules
/test/fixtures
17 changes: 17 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module.exports = {
root: true,
extends: ['@webpack-contrib/eslint-config-webpack', 'prettier'],
overrides: [
{
files: [
'test/watch/**/*.js',
'test/hmr/**/*.js',
'test/extractText/**/*.js',
'test/helpers/testLoader.js',
],
rules: {
strict: 'off',
},
},
],
};
9 changes: 0 additions & 9 deletions .eslintrc.json

This file was deleted.

4 changes: 4 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package-lock.json -diff
* text=auto
bin/* eol=lf
yarn.lock -diff
6 changes: 6 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# These are the default owners for everything in
# webpack-contrib
@webpack-contrib/org-maintainers

# Add repository specific users / groups
# below here for libs that are not maintained by the org.
160 changes: 160 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
# Contributing in @webpack-contrib

We'd always love contributions to further improve the webpack / webpack-contrib ecosystem!
Here are the guidelines we'd like you to follow:

- [Questions and Problems](#question)
- [Issues and Bugs](#issue)
- [Feature Requests](#feature)
- [Pull Request Submission Guidelines](#submit-pr)
- [Commit Message Conventions](#commit)

## <a name="question"></a> Got a Question or Problem?

Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack).
StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack).
The issue tracker is for bug reports and feature discussions.

## <a name="issue"></a> Found an Issue or Bug?

Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.

We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we ask that you to provide a minimal reproduction scenario (github repo or failing test case). Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like:

- version of Webpack used
- version of the loader / plugin you are creating a bug report for
- the use-case that fails

A minimal reproduce scenario allows us to quickly confirm a bug (or point out config problems) as well as confirm that we are fixing the right problem.

We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.

Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.

## <a name="feature"></a> Feature Requests?

You can _request_ a new feature by creating an issue on Github.

If you would like to _implement_ a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.

## <a name="submit-pr"></a> Pull Request Submission Guidelines

Before you submit your Pull Request (PR) consider the following guidelines:

- Search Github for an open or closed PR that relates to your submission. You don't want to duplicate effort.
- Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit). Adherence to these conventions is necessary because release notes are automatically generated from these messages.
- Fill out our `Pull Request Template`. Your pull request will not be considered if it is ignored.
- Please sign the `Contributor License Agreement (CLA)` when a pull request is opened. We cannot accept your pull request without this. Make sure you sign with the primary email address associated with your local / github account.

## <a name="commit"></a> Webpack Contrib Commit Conventions

Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
format that includes a **type**, a **scope** and a **subject**:

```
<type>(<scope>): <subject>
<BLANK LINE>
<body>
<BLANK LINE>
<footer>
```

The **header** is mandatory and the **scope** of the header is optional.

Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
to read on GitHub as well as in various git tools.

The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.

Examples:

```
docs(readme): update install instructions
```

```
fix: refer to the `entrypoint` instead of the first `module`
```

### Revert

If the commit reverts a previous commit, it should begin with `revert:`, followed by the header of the reverted commit.
In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.

### Type

Must be one of the following:

- **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
- **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
- **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
- **docs**: Documentation only changes (example scopes: readme, changelog)
- **feat**: A new feature
- **fix**: A bug fix
- **perf**: A code change that improves performance
- **refactor**: A code change that neither fixes a bug nor adds a feature
- **revert**: Used when reverting a committed change
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
- **test**: Addition of or updates to Jest tests

### Scope

The scope is subjective & depends on the `type` see above. A good example would be a change to a particular class / module.

### Subject

The subject contains a succinct description of the change:

- use the imperative, present tense: "change" not "changed" nor "changes"
- don't capitalize the first letter
- no dot (.) at the end

### Body

Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
The body should include the motivation for the change and contrast this with previous behavior.

### Footer

The footer should contain any information about **Breaking Changes** and is also the place to
reference GitHub issues that this commit **Closes**.

**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.

Example

```
BREAKING CHANGE: Updates to `Chunk.mapModules`.
This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764
Migration: see webpack/webpack#5225
```

## Testing Your Pull Request

You may have the need to test your changes in a real-world project or dependent
module. Thankfully, Github provides a means to do this. Add a dependency to the
`package.json` for such a project as follows:

```json
{
"devDependencies": {
"sass-loader": "webpack-contrib/sass-loader#{id}/head"
}
}
```

Where `{id}` is the # ID of your Pull Request.

## Contributor License Agreement

When submitting your contribution, a CLA (Contributor License Agreement) bot will come by to verify that you signed the [CLA](https://cla.js.foundation/webpack-contrib/sass-loader).
If it is your first time, it will link you to the right place to sign it.
However, if you have committed your contributions using an email that is not the same as your email used on GitHub, the CLA bot can't accept your contribution.

Run `git config user.email` to see your Git email, and verify it with [your GitHub email](https://github.com/settings/emails).

## Thanks

For your interest, time, understanding, and for following this simple guide.
1 change: 1 addition & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
open_collective: webpack
16 changes: 16 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!--
πŸ‘‰πŸ½ Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
Hey there!
You arrived at this template because you felt none of the other options
matched the kind of issue you'd like to report. Please use this opportunity to
tell us about your particular type of issue so we can try to accomodate
similar issues in the future.
PLEASE do note, if you're using this to report an issue already covered by the
existing template types, your issue may be closed as invalid. Our issue
templates contain fields that help us help you, and without that important
info, we might as well be ice-skating uphill, carrying a wooly mammoth.
-->
50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
---
name: πŸ› Bug Report
about: Something went awry and you'd like to tell us about it.
---

<!--
Issues are so πŸ”₯
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
πŸ‘‰πŸ½ Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- sass-loader Version:

### Expected Behavior

<!-- Remove this section if not reporting a bug or modification request. -->

### Actual Behavior

<!-- Remove this section if not reporting a bug or modification request. -->

### Code

```js
// webpack.config.js
// If your code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
```

```js
// additional code, HEY YO remove this block if you don't need it
```

### How Do We Reproduce?

<!--
Remove this section if not reporting a bug.
If your webpack config is over 50 lines long, please provide a URL to a repo
for your beefy πŸ– app that we can use to reproduce.
-->
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/DOCS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: πŸ“š Documentation
about: Are the docs lacking or missing something? Do they need some new πŸ”₯ hotness? Tell us here.
---

<!--
Issues are so πŸ”₯
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
πŸ‘‰πŸ½ Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

Documentation Is:

<!-- Please place an x (no spaces!) in all [ ] that apply -->

- [ ] Missing
- [ ] Needed
- [ ] Confusing
- [ ] Not Sure?

### Please Explain in Detail...

### Your Proposal for Changes
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: ✨ Feature Request
about: Suggest an idea for this project
---

<!--
Issues are so πŸ”₯
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
πŸ‘‰πŸ½ Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- sass-loader Version:

### Feature Proposal

### Feature Use Case
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE/MODIFICATION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
name: πŸ”§ Modification Request
about: Would you like something work differently? Have an alternative approach? This is the template for you.
---

<!--
Issues are so πŸ”₯
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
of Github will appear and pile-drive the close button from a great height
while making animal noises.
πŸ‘‰πŸ½ Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- sass-loader Version:

### Expected Behavior / Situation

### Actual Behavior / Situation

### Modification Proposal
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/SUPPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
name: πŸ†˜ Support, Help, and Advice
about: πŸ‘‰πŸ½ Need support, help, or advice? Don't open an issue! Head to StackOverflow or https://gitter.im/webpack/webpack.
---

Hey there! If you need support, help, or advice then this is not the place to ask.
Please visit [StackOverflow](https://stackoverflow.com/questions/tagged/webpack)
or [the Webpack Gitter](https://gitter.im/webpack/webpack) instead.
Loading