Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webpack-contrib/sass-loader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bcb06d5b59b3c60199185a41f1d0cc8afc504a14
Choose a base ref
...
head repository: webpack-contrib/sass-loader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 45bd8655864adbfe7e1c71a277c8e9cbb22b86ab
Choose a head ref

Commits on Aug 9, 2019

  1. Copy the full SHA
    45ac0b5 View commit details
  2. Copy the full SHA
    6e8e409 View commit details
  3. Copy the full SHA
    865f713 View commit details

Commits on Aug 10, 2019

  1. Copy the full SHA
    f59646f View commit details

Commits on Aug 13, 2019

  1. Copy the full SHA
    39b3bf4 View commit details

Commits on Aug 14, 2019

  1. Copy the full SHA
    1905e7b View commit details
  2. refactor: code (#719)

    evilebottnawi authored Aug 14, 2019
    Copy the full SHA
    c459352 View commit details
  3. Copy the full SHA
    96f436f View commit details

Commits on Aug 15, 2019

  1. Copy the full SHA
    0e94940 View commit details

Commits on Aug 16, 2019

  1. Copy the full SHA
    55f1af8 View commit details
  2. Copy the full SHA
    b8a7ca7 View commit details
  3. refactor: code

    alexander-akait committed Aug 16, 2019
    Copy the full SHA
    3545434 View commit details
  4. Copy the full SHA
    b2af379 View commit details
  5. Copy the full SHA
    97c93dd View commit details
  6. refactor: code (#725)

    evilebottnawi authored Aug 16, 2019
    Copy the full SHA
    dc23895 View commit details
  7. Copy the full SHA
    6be93c8 View commit details
  8. Copy the full SHA
    071fa88 View commit details

Commits on Aug 20, 2019

  1. Copy the full SHA
    997a255 View commit details
  2. Copy the full SHA
    0330253 View commit details
  3. Copy the full SHA
    6f4ea37 View commit details
  4. chore(release): 7.3.0

    alexander-akait committed Aug 20, 2019
    Copy the full SHA
    a3ac649 View commit details
  5. Copy the full SHA
    1175920 View commit details
  6. chore(release): 7.3.1

    alexander-akait committed Aug 20, 2019
    Copy the full SHA
    194fea4 View commit details

Commits on Aug 29, 2019

  1. chore: next (#748)

    evilebottnawi authored Aug 29, 2019
    Copy the full SHA
    45ad0be View commit details
  2. chore(release): 8.0.0

    alexander-akait committed Aug 29, 2019
    Copy the full SHA
    aa9b53b View commit details

Commits on Oct 7, 2019

  1. test: sass modules "@use" (#770)

    donnysim authored and evilebottnawi committed Oct 7, 2019
    Copy the full SHA
    185ba80 View commit details

Commits on Oct 8, 2019

  1. docs: overhaul readme (#771)

    madflow authored and evilebottnawi committed Oct 8, 2019
    Copy the full SHA
    6d11b7b View commit details
  2. Copy the full SHA
    9274387 View commit details

Commits on Dec 10, 2019

  1. Copy the full SHA
    2e14b68 View commit details

Commits on Jan 10, 2020

  1. Copy the full SHA
    ed345fa View commit details
  2. Copy the full SHA
    22c597b View commit details
  3. Copy the full SHA
    4834287 View commit details
  4. Copy the full SHA
    5611f73 View commit details
  5. Copy the full SHA
    6c59e37 View commit details
  6. chore(release): 8.0.1

    alexander-akait committed Jan 10, 2020
    Copy the full SHA
    3b51d47 View commit details

Commits on Jan 13, 2020

  1. Copy the full SHA
    6f3852f View commit details
  2. chore(release): 8.0.2

    alexander-akait committed Jan 13, 2020
    Copy the full SHA
    0377315 View commit details

Commits on Jan 28, 2020

  1. Copy the full SHA
    b009381 View commit details

Commits on Mar 2, 2020

  1. Copy the full SHA
    69e3ddc View commit details

Commits on Mar 25, 2020

  1. Copy the full SHA
    1a13a39 View commit details
  2. Copy the full SHA
    8c6fa3c View commit details

Commits on Mar 31, 2020

  1. docs: update readme (#819)

    chenxsan authored Mar 31, 2020
    Copy the full SHA
    21ccd86 View commit details

Commits on Apr 9, 2020

  1. Copy the full SHA
    977f34d View commit details

Commits on Apr 10, 2020

  1. Copy the full SHA
    65fb67e View commit details
  2. Copy the full SHA
    d2e5262 View commit details

Commits on Apr 11, 2020

  1. refactor: code

    evilebottnawi authored Apr 11, 2020
    Copy the full SHA
    e74b5aa View commit details
  2. feat: prefer sass (dart-sass) by default (#826)

    BREAKING CHANGE: prefer `sass` (`dart-sass`) by default
    evilebottnawi authored Apr 11, 2020
    Copy the full SHA
    3ad5291 View commit details

Commits on Apr 12, 2020

  1. Copy the full SHA
    cbe5ad4 View commit details

Commits on Apr 13, 2020

  1. chore: minimum supported Nodejs version is 10.13 (#828)

    BREAKING CHANGE: minimum supported Nodejs version is `10.13`
    evilebottnawi authored Apr 13, 2020
    Copy the full SHA
    a3dec34 View commit details
  2. Copy the full SHA
    41e0e45 View commit details
Showing 302 changed files with 187,307 additions and 12,302 deletions.
1 change: 0 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -9,5 +9,4 @@ insert_final_newline = true
trim_trailing_whitespace = true

[*.md]
insert_final_newline = true
trim_trailing_whitespace = false
7 changes: 3 additions & 4 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/coverage
/dist
/node_modules
# Compiled by webpack
test/output
# Fake node_modules folder for tests
test/node_modules
/test/fixtures
24 changes: 14 additions & 10 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
module.exports = {
root: true,
plugins: ['prettier'],
extends: ['@webpack-contrib/eslint-config-webpack'],
rules: {
// Remove strict rule in next major
strict: 'off',
'prettier/prettier': [
'error',
{ singleQuote: true, trailingComma: 'es5', arrowParens: 'always' },
],
},
extends: ['@webpack-contrib/eslint-config-webpack', 'prettier'],
overrides: [
{
files: [
'test/watch/**/*.js',
'test/hmr/**/*.js',
'test/extractText/**/*.js',
'test/helpers/testLoader.js',
],
rules: {
strict: 'off',
},
},
],
};
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package-lock.json -diff
* text=auto
bin/* eol=lf
yarn.lock -diff
118 changes: 77 additions & 41 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
## Contributing in @webpack-contrib
# Contributing in @webpack-contrib

We'd always love contributions to further improve the webpack / webpack-contrib ecosystem!
We'd always love contributions to further improve the webpack / webpack-contrib ecosystem!
Here are the guidelines we'd like you to follow:

* [Questions and Problems](#question)
* [Issues and Bugs](#issue)
* [Feature Requests](#feature)
* [Pull Request Submission Guidelines](#submit-pr)
* [Commit Message Conventions](#commit)
- [Questions and Problems](#question)
- [Issues and Bugs](#issue)
- [Feature Requests](#feature)
- [Pull Request Submission Guidelines](#submit-pr)
- [Commit Message Conventions](#commit)

### <a name="question"></a> Got a Question or Problem?
## <a name="question"></a> Got a Question or Problem?

Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack).
StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack).
Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack).
StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack).
The issue tracker is for bug reports and feature discussions.

### <a name="issue"></a> Found an Issue or Bug?
## <a name="issue"></a> Found an Issue or Bug?

Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.

@@ -31,13 +31,13 @@ We will be insisting on a minimal reproduce scenario in order to save maintainer

Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.

### <a name="feature"></a> Feature Requests?
## <a name="feature"></a> Feature Requests?

You can *request* a new feature by creating an issue on Github.
You can _request_ a new feature by creating an issue on Github.

If you would like to *implement* a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.
If you would like to _implement_ a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.

### <a name="submit-pr"></a> Pull Request Submission Guidelines
## <a name="submit-pr"></a> Pull Request Submission Guidelines

Before you submit your Pull Request (PR) consider the following guidelines:

@@ -46,9 +46,9 @@ Before you submit your Pull Request (PR) consider the following guidelines:
- Fill out our `Pull Request Template`. Your pull request will not be considered if it is ignored.
- Please sign the `Contributor License Agreement (CLA)` when a pull request is opened. We cannot accept your pull request without this. Make sure you sign with the primary email address associated with your local / github account.

### <a name="commit"></a> Webpack Contrib Commit Conventions
## <a name="commit"></a> Webpack Contrib Commit Conventions

Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
format that includes a **type**, a **scope** and a **subject**:

```
@@ -66,48 +66,56 @@ to read on GitHub as well as in various git tools.

The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.

Examples:
Examples:

```
docs(readme): update install instructions
```

```
fix: refer to the `entrypoint` instead of the first `module`
```

#### Revert
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit.
### Revert

If the commit reverts a previous commit, it should begin with `revert:`, followed by the header of the reverted commit.
In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.

#### Type
### Type

Must be one of the following:

* **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
* **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
* **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
* **docs**: Documentation only changes (example scopes: readme, changelog)
* **feat**: A new feature
* **fix**: A bug fix
* **perf**: A code change that improves performance
* **refactor**: A code change that neither fixes a bug nor adds a feature
* **revert**: Used when reverting a committed change
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
* **test**: Addition of or updates to Jest tests

#### Scope
- **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
- **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
- **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
- **docs**: Documentation only changes (example scopes: readme, changelog)
- **feat**: A new feature
- **fix**: A bug fix
- **perf**: A code change that improves performance
- **refactor**: A code change that neither fixes a bug nor adds a feature
- **revert**: Used when reverting a committed change
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
- **test**: Addition of or updates to Jest tests

### Scope

The scope is subjective & depends on the `type` see above. A good example would be a change to a particular class / module.

#### Subject
### Subject

The subject contains a succinct description of the change:

* use the imperative, present tense: "change" not "changed" nor "changes"
* don't capitalize the first letter
* no dot (.) at the end
- use the imperative, present tense: "change" not "changed" nor "changes"
- don't capitalize the first letter
- no dot (.) at the end

### Body

#### Body
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
The body should include the motivation for the change and contrast this with previous behavior.

#### Footer
### Footer

The footer should contain any information about **Breaking Changes** and is also the place to
reference GitHub issues that this commit **Closes**.

@@ -116,9 +124,37 @@ reference GitHub issues that this commit **Closes**.
Example

```
BREAKING CHANGE: Updates to `Chunk.mapModules`.
BREAKING CHANGE: Updates to `Chunk.mapModules`.
This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764
Migration: see webpack/webpack#5225
```

## Testing Your Pull Request

You may have the need to test your changes in a real-world project or dependent
module. Thankfully, Github provides a means to do this. Add a dependency to the
`package.json` for such a project as follows:

```json
{
"devDependencies": {
"sass-loader": "webpack-contrib/sass-loader#{id}/head"
}
}
```

Where `{id}` is the # ID of your Pull Request.

## Contributor License Agreement

When submitting your contribution, a CLA (Contributor License Agreement) bot will come by to verify that you signed the [CLA](https://cla.js.foundation/webpack-contrib/sass-loader).
If it is your first time, it will link you to the right place to sign it.
However, if you have committed your contributions using an email that is not the same as your email used on GitHub, the CLA bot can't accept your contribution.

Run `git config user.email` to see your Git email, and verify it with [your GitHub email](https://github.com/settings/emails).

## Thanks

For your interest, time, understanding, and for following this simple guide.
1 change: 1 addition & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
open_collective: webpack
19 changes: 9 additions & 10 deletions .github/ISSUE_TEMPLATE/BUG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 🐛 Bug Report
about: Something went awry and you'd like to tell us about it.

---

<!--
@@ -15,11 +14,11 @@ about: Something went awry and you'd like to tell us about it.
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

* Operating System:
* Node Version:
* NPM Version:
* webpack Version:
* sass-loader Version:
- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- sass-loader Version:

### Expected Behavior

@@ -32,13 +31,13 @@ about: Something went awry and you'd like to tell us about it.
### Code

```js
// webpack.config.js
// If your bitchin' code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
// webpack.config.js
// If your code blocks are over 20 lines, please paste a link to a gist
// (https://gist.github.com).
```

```js
// additional code, HEY YO remove this block if you don't need it
// additional code, HEY YO remove this block if you don't need it
```

### How Do We Reproduce?
2 changes: 0 additions & 2 deletions .github/ISSUE_TEMPLATE/DOCS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 📚 Documentation
about: Are the docs lacking or missing something? Do they need some new 🔥 hotness? Tell us here.

---

<!--
@@ -26,5 +25,4 @@ Documentation Is:

### Please Explain in Detail...


### Your Proposal for Changes
13 changes: 5 additions & 8 deletions .github/ISSUE_TEMPLATE/FEATURE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: ✨ Feature Request
about: Suggest an idea for this project

---

<!--
@@ -15,14 +14,12 @@ about: Suggest an idea for this project
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

* Operating System:
* Node Version:
* NPM Version:
* webpack Version:
* sass-loader Version:
- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- sass-loader Version:

### Feature Proposal



### Feature Use Case
16 changes: 5 additions & 11 deletions .github/ISSUE_TEMPLATE/MODIFICATION.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 🔧 Modification Request
about: Would you like something work differently? Have an alternative approach? This is the template for you.

---

<!--
@@ -15,19 +14,14 @@ about: Would you like something work differently? Have an alternative approach?
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->

* Operating System:
* Node Version:
* NPM Version:
* webpack Version:
* sass-loader Version:

- Operating System:
- Node Version:
- NPM Version:
- webpack Version:
- sass-loader Version:

### Expected Behavior / Situation



### Actual Behavior / Situation



### Modification Proposal
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/SUPPORT.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: 🆘 Support, Help, and Advice
about: 👉🏽 Need support, help, or advice? Don't open an issue! Head to StackOverflow or https://gitter.im/webpack/webpack.

---

Hey there! If you need support, help, or advice then this is not the place to ask.
Loading