test: fix

Author: evilebottnawi

.github/workflows/nodejs.yml

@@ -43,8 +43,8 @@ jobs:
       - name: Lint
         run: npm run lint
 
-      # - name: Security audit
-      #  run: npm run security
+      - name: Security audit
+        run: npm run security
 
       - name: Check commit message
         uses: wagoid/commitlint-github-action@v1

package-lock.json

@@ -42,32 +42,32 @@
   },
   "dependencies": {
     "loader-utils": "^2.0.0",
-    "schema-utils": "^2.7.0"
+    "schema-utils": "^2.7.1"
   },
   "devDependencies": {
-    "@babel/cli": "^7.10.3",
-    "@babel/core": "^7.10.3",
-    "@babel/preset-env": "^7.10.3",
-    "@commitlint/cli": "^9.0.1",
-    "@commitlint/config-conventional": "^9.0.1",
+    "@babel/cli": "^7.10.5",
+    "@babel/core": "^7.11.4",
+    "@babel/preset-env": "^7.11.0",
+    "@commitlint/cli": "^10.0.0",
+    "@commitlint/config-conventional": "^10.0.0",
     "@webpack-contrib/defaults": "^6.3.0",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
-    "babel-jest": "^26.0.1",
+    "babel-jest": "^26.3.0",
     "cross-env": "^7.0.2",
     "del": "^5.1.0",
     "del-cli": "^3.0.1",
-    "eslint": "^7.3.0",
+    "eslint": "^7.7.0",
     "eslint-config-prettier": "^6.11.0",
-    "eslint-plugin-import": "^2.21.2",
+    "eslint-plugin-import": "^2.22.0",
     "husky": "^4.2.5",
-    "jest": "^26.0.1",
-    "lint-staged": "^10.2.11",
+    "jest": "^26.4.2",
+    "lint-staged": "^10.2.13",
     "memfs": "^3.2.0",
     "npm-run-all": "^4.1.5",
-    "prettier": "^2.0.5",
-    "standard-version": "^8.0.0",
+    "prettier": "^2.1.1",
+    "standard-version": "^9.0.0",
     "url-loader": "^4.1.0",
-    "webpack": "^4.43.0"
+    "webpack": "^4.44.1"
   },
   "keywords": [
     "webpack"

package.json

@@ -112,7 +112,7 @@ describe('loader', () => {
     expect(normalizeErrors(stats.compilation.errors)).toMatchSnapshot('errors');
 
     if (stats.compilation.modules.size) {
-      expect(stats.compilation.modules.size).toBe(2);
+      expect(stats.compilation.modules.size).toBe(3);
     } else {
       expect(stats.compilation.modules.length).toBe(1);
     }

test/loader.test.js

@@ -83,37 +83,61 @@ describe('"name" option', () => {
     expect(normalizeErrors(stats.compilation.errors)).toMatchSnapshot('errors');
   });
 
-  it('should mark hashed asset as immutable', async () => {
+  it('should work and emit "immutable" for assets flag by default', async () => {
+    expect.assertions(1);
+
+    const compiler = getCompiler('simple.js');
+    const stats = await compile(compiler);
+
+    for (const [name, info] of stats.compilation.assetsInfo) {
+      if (name.endsWith('png')) {
+        expect(info.immutable).toBe(true);
+      }
+    }
+  });
+
+  it('should work and emit "immutable" for hashed assets', async () => {
+    expect.assertions(1);
+
     const compiler = getCompiler('simple.js', {
       name: '[md5:hash:hex:8].asset.[ext]',
     });
     const stats = await compile(compiler);
 
-    let assetInfo;
     for (const [name, info] of stats.compilation.assetsInfo) {
-      if (name.match('asset.')) {
-        assetInfo = info;
-        break;
+      if (name.endsWith('png')) {
+        expect(info.immutable).toBe(true);
       }
     }
+  });
 
-    expect(assetInfo.immutable).toBe(true);
+  it('should work and emit "immutable" for hashed assets #2', async () => {
+    expect.assertions(1);
+
+    const compiler = getCompiler('simple.js', {
+      name: '[name].[contenthash].asset.[ext]',
+    });
+    const stats = await compile(compiler);
+
+    for (const [name, info] of stats.compilation.assetsInfo) {
+      if (name.endsWith('png')) {
+        expect(info.immutable).toBe(true);
+      }
+    }
   });
 
   it('should not mark unhashed asset as immutable', async () => {
+    expect.assertions(1);
+
     const compiler = getCompiler('simple.js', {
       name: 'asset.[ext]',
     });
     const stats = await compile(compiler);
 
-    let assetInfo;
     for (const [name, info] of stats.compilation.assetsInfo) {
-      if (name.match('asset.')) {
-        assetInfo = info;
-        break;
+      if (name.endsWith('png')) {
+        expect(info.immutable).toBe(false);
       }
     }
-
-    expect(assetInfo.immutable).toBe(false);
   });
 });