This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Update the Plugin documentation #6165
Merged
+96
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
…web3-is-used-and-the-module-augmentation-is-simplified
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6165 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 197 197
Lines 7548 7550 +2
Branches 2059 2059
=======================================
+ Hits 6595 6597 +2
Misses 953 953
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
| Latest commit: |
1dbf0cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e7bf2f0.web3-js-docs.pages.dev |
| Branch Preview URL: | https://6161-update-the-plugin-docum.web3-js-docs.pages.dev |
…ed-and-the-module-augmentation-is-simplified' of https://github.com/ChainSafe/web3.js into 6161-update-the-plugin-documentation-so-only-web3-is-used-and-the-module-augmentation-is-simplified
…web3-is-used-and-the-module-augmentation-is-simplified
Muhammad-Altabba
requested review from
avkos,
jdevcs,
luu-alex and
spacesailor24
as code owners
avkos
approved these changes
Jun 8, 2023
jdevcs
approved these changes
Jun 8, 2023
Muhammad-Altabba
deleted the
6161-update-the-plugin-documentation-so-only-web3-is-used-and-the-module-augmentation-is-simplified
branch
17 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Plugin documentation so only web3 is used and the Module Augmentation is simplified
Fixes #6161
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.