Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation for web3.eth.accounts.signTransaction #5121

Merged
merged 5 commits into from Jun 28, 2022
Merged

Fixed documentation for web3.eth.accounts.signTransaction #5121

merged 5 commits into from Jun 28, 2022

Conversation

Neurone
Copy link

@Neurone Neurone commented Jun 10, 2022 •
edited

Description

Fixed documentation for maxPriorityFeePerGas and maxFeePerGas in web3.eth.accounts.signTransaction

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@Neurone
Fixed documentation for web3.eth.accounts.signTransaction
6dcead0 
Fixed documentation for maxPriorityFeePerGas and maxFeePerGas in web3.eth.accounts.signTransaction
nazarhussain
nazarhussain requested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to CHANGELOG.md

@nazarhussain nazarhussain added Documentation Relates to project wiki or documentation 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Jun 22, 2022
@Neurone
Copy link
Author

Neurone commented Jun 22, 2022

Please add an entry to CHANGELOG.md

Done.

@nikoulai nikoulai mentioned this pull request Jun 23, 2022
Closed
1 task
@nazarhussain nazarhussain linked an issue Jun 23, 2022 that may be closed by this pull request
web3.eth.accounts.signTransaction VS EIP-1559 #5141
Closed
1 task
@nazarhussain nazarhussain added Future Release For future release. and removed Review Needed Maintainer(s) need to review labels Jun 23, 2022
avkos
avkos approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the support. Just fix merge conflicts

@Neurone
Copy link
Author

Neurone commented Jun 27, 2022

Thanks for the support. Just fix merge conflicts

Done.

@jdevcs jdevcs merged commit 8f05f19 into web3:1.x Jun 28, 2022
@jdevcs jdevcs mentioned this pull request Jul 15, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@avkos avkos avkos approved these changes

@nikoulai nikoulai nikoulai approved these changes

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex luu-alex is a code owner

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Future Release For future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web3.eth.accounts.signTransaction VS EIP-1559
5 participants
@Neurone @nazarhussain @avkos @nikoulai @jdevcs