Skip to content

Commit 38f71de

Browse files
authoredJun 2, 2021
fix(v-slot): fix scoped slot normalization combined with v-if (#12104)
1 parent 67901e7 commit 38f71de

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed
 

‎src/core/vdom/helpers/normalize-scoped-slots.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ function normalizeScopedSlot(normalSlots, key, fn) {
6161
res = res && typeof res === 'object' && !Array.isArray(res)
6262
? [res] // single vnode
6363
: normalizeChildren(res)
64-
let vnode: VNode = res && res[0]
64+
let vnode: ?VNode = res && res[0]
6565
return res && (
6666
!vnode ||
67-
(vnode.isComment && !isAsyncPlaceholder(vnode)) // #9658, #10391
67+
(res.length === 1 && vnode.isComment && !isAsyncPlaceholder(vnode)) // #9658, #10391
6868
) ? undefined
6969
: res
7070
}

‎test/unit/features/component/component-slot.spec.js

+14
Original file line numberDiff line numberDiff line change
@@ -986,4 +986,18 @@ describe('Component slot', () => {
986986
expect(vm.$el.firstChild.innerHTML).toBe('<span><b>2</b></span>')
987987
}).then(done)
988988
})
989+
990+
// #12102
991+
it('v-if inside scoped slot', () => {
992+
const vm = new Vue({
993+
template: `<test><template #custom><span v-if="false">a</span><span>b</span></template></test>`,
994+
components: {
995+
test: {
996+
template: `<div><slot name="custom"/></div>`
997+
}
998+
}
999+
}).$mount()
1000+
1001+
expect(vm.$el.innerHTML).toBe(`<!----><span>b</span>`)
1002+
})
9891003
})

0 commit comments

Comments
 (0)
Please sign in to comment.