Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates with-supertokens example #38369

Merged
merged 132 commits into from
Jul 6, 2022
Merged

Updates with-supertokens example #38369

merged 132 commits into from
Jul 6, 2022

Conversation

rishabhpoddar
Copy link
Contributor

  • Updates supertokens-auth-react and supertokens-node versions to the latest ones.
  • Uses nextJS router with SuperTokens frontend SDK so that navigation across auth pages is quicker.
  • Removes the use of NextJS' dynamic HOC since supertokens-auth-react's auth component now support SSR
  • Wraps the entire app with <SuperTokensWrapper> so that we can access the session context from anywhere easily.

NkxxkN and others added 30 commits February 16, 2021 15:21
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 6, 2022
@rishabhpoddar rishabhpoddar marked this pull request as ready for review July 6, 2022 09:54
@rishabhpoddar
Copy link
Contributor Author

@balazsorban44 can this PR be merged please? All checks have passed as well. I think it used to auto merge before, but it didn't happen this time

@balazsorban44
Copy link
Member

image

Please be patient. 🙏 Don't merge canary as that might delay auto-merging.

@ijjk
Copy link
Member

ijjk commented Jul 6, 2022

@rishabhpoddar the PR did not automerge as changes from contributors is disabled on this PR preventing us from auto-updating and merging the PR.

@ijjk ijjk merged commit b83107c into vercel:canary Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants