Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): fix experiments loading npm wasm #38348

Merged
merged 2 commits into from
Jul 6, 2022
Merged

chore(examples): fix experiments loading npm wasm #38348

merged 2 commits into from
Jul 6, 2022
+1 −1

Conversation

j-mendez
Copy link
Contributor

@j-mendez j-mendez commented Jul 5, 2022

  • enables default config that handles npm wasm bundles

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Sorry, something went wrong.

@j-mendez
chore(config): fix experiments loading npm wasm

Verified

This commit was signed with the committer’s verified signature.
dimkl Dimitris Klouvas
GPG key ID: 0931F5B7A6BC310B
Verified
Learn about vigilant mode
73c6713 
* enables default config that handles npm wasm bundles
@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 5, 2022
@j-mendez j-mendez changed the title chore(config): fix experiments loading npm wasm chore(examples): fix experiments loading npm wasm Jul 5, 2022
balazsorban44
balazsorban44 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq
Merge branch 'canary' into patch-1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
03827c9
@kodiakhq kodiakhq bot merged commit 616e0d7 into vercel:canary Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44

@timneutkens timneutkens

@ijjk ijjk

@shuding shuding

@leerob leerob

@steven-tey steven-tey

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-mendez @balazsorban44 @ijjk