Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update docs for swc styled components #38280

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Fix/update docs for swc styled components #38280

merged 4 commits into from
Jul 6, 2022
+1 −1

Conversation

marjorg
Copy link
Contributor

@marjorg marjorg commented Jul 3, 2022

According to #30802 SWC transforms for styled-components were updated with support for cssProp, fileName and namespace. The docs only mention support for ssr and displayName.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint

Sorry, something went wrong.

marjorg added 2 commits July 3, 2022 20:15
@marjorg
Update text about supported SWC transforms for styled-components

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
7d32cb5
@marjorg
Add back note about main ssr and displayName

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
fb37bda
balazsorban44
balazsorban44 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kodiakhq bot and others added 2 commits July 6, 2022 14:30
@kodiakhq
Merge branch 'canary' into fix/update-docs-for-swc-styled-components

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
4b704e8
@ijjk
Merge branch 'canary' into fix/update-docs-for-swc-styled-components
2a7049d
@kodiakhq kodiakhq bot merged commit 3ae343f into vercel:canary Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44

@ijjk ijjk

@timneutkens timneutkens

@shuding shuding

@styfle styfle

@huozhi huozhi

@padmaia padmaia

@leerob leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marjorg @balazsorban44 @ijjk