Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): Convert blog example to TypeScript #38095

Merged
merged 11 commits into from
Jul 6, 2022
Merged

chore(examples): Convert blog example to TypeScript #38095

merged 11 commits into from
Jul 6, 2022
+66 −22

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Jun 28, 2022 •
edited
Loading

Converted Blog example over to TypeScript to match the Contribution guidelines.

I also simplified the example by removing _document.js and prettier from package.json.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Sorry, something went wrong.

@maxproske
Convert blog example to TypeScript

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
f060f50
@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 28, 2022
@maxproske
Copy link
Contributor Author

maxproske commented Jun 28, 2022 •
edited
Loading

I noticed this example is built with a static site generator, Nextra, and could be renamed accordingly.

Should I move this example from blog to blog-nextra, and put a redirect notice at examples/blog/README.md?

@maxproske
Disable TypeScript strict mode

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
9958f39
balazsorban44
balazsorban44 reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added a small note

maxproske added 2 commits June 29, 2022 23:57
@maxproske
Upgrade nextra/blog theme to 2.0.0-beta.5, Restore _document.tsx

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
0faec6c
@maxproske
Merge branch 'canary' into feature/convert-blog-typescript
e72ab49
@maxproske
Copy link
Contributor Author

@balazsorban44 Made all your requested changes - Ready for review!

@maxproske maxproske changed the title Convert blog example to TypeScript chore(examples): Convert blog example to TypeScript Jul 6, 2022
@maxproske maxproske changed the title chore(examples): Convert blog example to TypeScript chore(examples): Convert blog example to TypeScript Jul 6, 2022
balazsorban44
balazsorban44 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 0f4333a into vercel:canary Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44

@timneutkens timneutkens

@ijjk ijjk

@shuding shuding

@leerob leerob

@steven-tey steven-tey

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxproske @balazsorban44 @ijjk