fix: update with-msw example to function properly for all use cases #38050
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinsgoodman
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
balazsorban44
approved these changes
Jul 6, 2022
ijjk
approved these changes
Jul 6, 2022
|
🎉 Thanks everyone! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #numbercontributing.mdDocumentation / Examples
pnpm lintI had opened mswjs/data#226 to resolve an issue with MSW and its related libraries. One of the maintainers pointed me to this: mswjs/msw#1227 (comment). Turns out that the example in this repository uses a different require strategy that doesn't resolve properly under all conditions. This PR simply updates the example to the MSW maintainer's recommendation.
Let me know if there's more needed to get this merged. I noticed the existing example is TypeScript which deviates from the example guidelines so I can make those updates if needed.