Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vercel/next.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6b97bcea5ba851740404e8192fc9ebff711e1b83
Choose a base ref
...
head repository: vercel/next.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 804971fd9a49dfd009f7339dd8bf4bc32e6eb02c
Choose a head ref

Commits on Apr 28, 2021

  1. Fix: with-passport example dependency issue (#24567)

    fixes #24401
    
    Simply bumping `swr` to the latest version seems to fix the issue. 🥂 
    
    Couldn't find a consistent pattern across the examples, but most examples are flexible with swr version and use the semver caret.
    
    Very standard use of the useSWR hook is there in the example with nothing obviously version specific.
    darshkpatel authored Apr 28, 2021
    Copy the full SHA
    2d6b560 View commit details
  2. Copy the full SHA
    9721374 View commit details
  3. Remove unnecessary optimizeFonts key from type (#24563)

    #21676 moved `fontOptimization` out of the experimental key of `NextConfig` to the top level, so it should be removed from the type
    
    ## Bug
    
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    sumanthratna authored Apr 28, 2021
    Copy the full SHA
    a35dedb View commit details

Commits on Apr 29, 2021

  1. Fix Image compatibility issue when using sizes (#24569)

    When using `sizes`, [`matchAll`](https://caniuse.com/mdn-javascript_builtins_string_matchall) isn't supported by older browsers like IE and Safari 12. This PR changes it to `exec`.
    
    There're already tests of `sizes` with multiple `vw` values covered.
    
    Fixes #23677.
    
    ## Bug
    
    - [x] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [x] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    shuding authored Apr 29, 2021
    Copy the full SHA
    89d2c4e View commit details
  2. Copy the full SHA
    1e441fe View commit details
  3. v10.2.1-canary.0

    ijjk committed Apr 29, 2021
    1
    Copy the full SHA
    f9faf3f View commit details

Commits on Apr 30, 2021

  1. Copy the full SHA
    01c15c5 View commit details
  2. v10.2.1-canary.1

    ijjk committed Apr 30, 2021
    1
    Copy the full SHA
    49cd08d View commit details
  3. Adds ESLint with default rule-set (#23702)

    This PR re-includes ESLint with some notable changes, namely a guided setup similar to how TypeScript is instantiated in a Next.js application.
    
    To add ESLint to a project, developers will have to create an `.eslintrc` file in the root of their project or add an empty `eslintConfig` object to their `package.json` file.
    
    ```js
    touch .eslintrc
    ```
    
    Then running `next build` will show instructions to install the required packages needed:
    
    <img width="862" alt="Screen Shot 2021-04-19 at 7 38 27 PM" src="https://user-images.githubusercontent.com/12476932/115316182-dfd51b00-a146-11eb-830c-90bad20ed151.png">
    
    Once installed and `next build` is run again, `.eslintrc` will be automatically configured to include the default config:
    
    ```json
    {
      "extends": "next"
    }
    ```
    
    In addition to this change:
    
    - The feature is now under the experimental flag and requires opt-in. After testing and feedback, it will be switched to the top-level namespace and turned on by default.
    - A new ESLint shareable configuration package is included that can be extended in any application with `{ extends: 'next' }`
      - This default config extends recommended rule sets from [`eslint-plugin-react`](https://www.npmjs.com/package/eslint-plugin-react), [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks), and [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next)
    - All rules in [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) have been modified to include actionable links that show more information to help resolve each issue
    housseindjirdeh authored Apr 30, 2021
    Copy the full SHA
    e783b0a View commit details
  4. Don't swallow MODULE_NOT_FOUND error (#24577)

    ## Bug
    
    - [x] Related issues linked using [`fixes #24328`](#24328 (comment))
    - [ ] Integration tests added
    
    The change in #24328 will swallow any `MODULE_NOT_FOUND` errors triggered in the page. If you for example have a page with a broken import, it will tell you `Error: Failed to load /whatever`. This of course doesn't really tell people what is going on internally (a broken import). I added a check to see if the error actually happened in the page.
    PepijnSenders authored Apr 30, 2021
    Copy the full SHA
    d5de1c5 View commit details
  5. Fix/link router 24075 take asPath instead of pathName in router (#24199)

    Fixes: #24075
    
    ## Bug
     
    - [X] Related issues linked using `fixes #number`
    - [X] Integration tests added
    
    
    ## Documentation / Examples
    
    - [x] Make sure the linting passes
    ishank-s authored Apr 30, 2021
    Copy the full SHA
    9bbb968 View commit details
  6. Add experimental blurry placeholder to image component (#24153)

    This is the image component implementation of the blurry placeholder as described in #24004. The matching server side implementation is currently planned.
    
    ## Feature
    
    - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [x] Related issue #18858 
    - [x] Integration tests added
    
    (Documentation and telemetry to follow after server side is implemented)
    Joonpark13 authored Apr 30, 2021
    Copy the full SHA
    c76170e View commit details
  7. v10.2.1-canary.2

    ijjk committed Apr 30, 2021
    1
    Copy the full SHA
    9c47ca2 View commit details

Commits on May 1, 2021

  1. Clarify whether router.pathname includes basePath (#24675)

    The docs were vague on this -- `router.asPath` mentions that it doesn't include `basePath` but `router.pathname` didn't say either way.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes: I haven't checked; I presume you have a CI bot for this.
    tremby authored May 1, 2021
    Copy the full SHA
    a77f384 View commit details

Commits on May 3, 2021

  1. update webpack to 5.36.2, use dependOn (#24656)

    * update webpack to 5.36.2
    * use dependOn to optimize chunks
    * disable vendor splitting for main and _app chunks
    
    => decreases bundle size in general, gets rid of the 2 extra vendor chunks shared by all pages.
    
    ## Bug
    
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    sokra authored May 3, 2021
    Copy the full SHA
    1d643eb View commit details
  2. Copy the full SHA
    3e6ce90 View commit details

Commits on May 4, 2021

  1. Add type checking events (#24595)

    Will send events like this:
    
    ```
    [telemetry] {
      "eventName": "NEXT_TYPE_CHECK_COMPLETED",
      "payload": {
        "durationInSeconds": 2,
        "typescriptVersion": "3.8.3",
        "inputFilesCount": 16,
        "totalFilesCount": 289,
        "incremental": false
      }
    }
    ```
    
    ## Bug
    
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    sokra authored May 4, 2021
    Copy the full SHA
    3a78ccd View commit details

Commits on May 5, 2021

  1. fix(next-storybook): make rules an array in webpack config (#22125)

    the `next-storybook` plugin throws an error since version `10.0.6-canary.9`, specifically since #17306:
    
    ```
    ERR! WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
    ERR!  - configuration.module.rules should be an array
    ```
    
    this PR makes `module.rules` an array again.
    
    also see #17306 (comment)
    stefanprobst authored May 5, 2021
    Copy the full SHA
    3a2cd0e View commit details
  2. fix memory leak in require.cache (#24282)

    Previously only the top-level page would be cleared from the require cache, with this change it also clears `module.parent` and `modules.children`.
    sokra authored May 5, 2021
    Copy the full SHA
    83395c9 View commit details
  3. demo serving storybook static build with serve (#24812)

    Unfortunately I couldn't push up changes for that branch as maintainers access was disabled.
    
    Closes #18775
    
    ## Bug
    
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    timneutkens authored May 5, 2021
    Copy the full SHA
    3a2b88b View commit details
  4. Update signin/signup form samples (#24524)

    Fix warning: Prop `href` did not match. Server: "signin" Client: "/signin"
    Fix warning: Prop `href` did not match. Server: "signup" Client: "/signup"
    
    ## Documentation / Examples
    
    - [] Make sure the linting passes
    Lau Wei Lim authored May 5, 2021
    Copy the full SHA
    fc9b48b View commit details
  5. Bumps version of supertokens dependencies and updates its README (#24571

    )
    
    Co-authored-by: Lee Robinson <me@leerob.io>
    Co-authored-by: NkxxkN <kevin@supertokens.io>
    Co-authored-by: NkxxkN <kevin.antoine@protonmail.com>
    4 people authored May 5, 2021
    Copy the full SHA
    243472f View commit details
  6. react-hook-form example (#21245)

    Co-authored-by: Tim Neutkens <timneutkens@me.com>
    aydinkn and timneutkens authored May 5, 2021
    Copy the full SHA
    9721aaf View commit details
  7. Copy the full SHA
    192d42b View commit details
  8. Don't throw 500 error when Content-type is invalid (#24818)

    Fixes #24768
    
    ## Bug
    
    - [x] Related issues linked using `fixes #number`
    - [x] Integration tests added
    vitalybaev authored May 5, 2021
    Copy the full SHA
    54ff322 View commit details
  9. docs(next/router): Update router.push api (#24833)

    Documentation page: https://nextjs.org/docs/api-reference/next/router#routerpush
    
    Add `locale`  as supported options in `route.push()` (#17898)
    ErfanMirzapour authored May 5, 2021
    Copy the full SHA
    2251658 View commit details
  10. Copy the full SHA
    cc41a19 View commit details

Commits on May 6, 2021

  1. Land - Font optimizations - Adobe Fonts / Typekit support (#24834)

    This updates this initial PR here #18146 to resolve merge conflicts and updates tests since we aren't able to update that PR itself.
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [ ] Related issues linked using `fixes #number`
    - [x] Integration tests added
    - [x] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    Closes: #18146
    ijjk authored May 6, 2021
    Copy the full SHA
    802af5f View commit details
  2. Add version note for has property (#24836)

    The guides for `next.config.js` never specify that the `has: { }` syntax is only available for v10.1, and not for v10.0. Add a note that indicates these features are only available in the latest version.
    
    ## Documentation / Examples
    
    - [x] Make sure the linting passes
    tubbo authored May 6, 2021
    Copy the full SHA
    73e1fb4 View commit details
  3. Remove old docs sections (#24853)

    Co-authored-by: Lee Robinson <me@leerob.io>
    timneutkens and leerob authored May 6, 2021
    Copy the full SHA
    81cc1c5 View commit details
  4. Add additional reason for the Prerender Error when running next export (

    #24828)
    
    Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
    frontendtony and kodiakhq[bot] authored May 6, 2021
    Copy the full SHA
    467ec21 View commit details
  5. Fix rewrite shape in Storybook (#24827)

    This fixes a bug in `@next/plugin-storybook` caused by an update in the rewrite structure, solution was provided by @stefanprobst #19345 (comment)
    
    Secondary question: it would be awesome if someone at Next could help translating `preset.js` into TypeScript, this would catch those bugs immediately. I've tried in #18367 but failed to build correctly.
    
    ## Bug
    
    - [X] Related issues linked using `fixes #number` => parent issue is an umbrella of various small issues: #19345
    - [X] Integration tests added => reproduction is implemented in https://github.com/lbke/next-plugin-storybook-demo until the package is more stable
    eric-burel authored May 6, 2021
    Copy the full SHA
    796c021 View commit details

Commits on May 7, 2021

  1. feat(create-next-app): add --ts, --typescript support (#24655)

    Co-authored-by: Tim Neutkens <timneutkens@me.com>
    ctjlewis and timneutkens authored May 7, 2021
    Copy the full SHA
    9c77cda View commit details
  2. ESLint Plugin: Disallow <title> in Head from next/document (#24868)

    Adds lint rule warning to the Next.js ESLint plugin to disallow `<title>` in `Head` imported from `next/document`.
    housseindjirdeh authored May 7, 2021
    Copy the full SHA
    656c2ef View commit details
  3. updated zustand example (#24884)

    ..to use new zustand/context module from zustand 3.5.0. Also fixed code for merging states on client-side navigation.
    
    
    ## Documentation / Examples
    
    - [x] Make sure the linting passes
    Munawwar authored May 7, 2021
    Copy the full SHA
    60d844c View commit details
  4. Update example with-sentry (#24819)

    The [official Sentry Next.js SDK](https://docs.sentry.io/platforms/javascript/guides/nextjs/) is now the recommended choice to use with Next.js, instead of the previous workarounds. This PR updates the example, which now uses the SDK.
    iker-barriocanal authored May 7, 2021
    Copy the full SHA
    4bc87e4 View commit details
  5. Clarify rewrites and other docs cleanup. (#24890)

    Based on user feedback, this clarifies the difference between rewrites and redirects, as well as follows the new pattern for showing version history with a collapsible table.
    leerob authored May 7, 2021
    Copy the full SHA
    f6c6094 View commit details
  6. feat(build): Log whether type checking is actually performed (#24440)

    Closes #24889
    
    ## Feature
    
    Currently `next build` is logging "Checking validity of types" even if `typescript.ignoreBuildErrors` is `true`. It seems like these options still work so `next build` either shouldn't log anything related to type-checking or log that type-checking is skipped.
    
    I decided to branch the log message for clarity.
    
    Happy to add a test but I'm not sure if you have existing infra considering https://github.com/vercel/next.js/pull/23226/files (which added the message) didn't add or change tests either.
    
    CI failures look unrelated to me.
    eps1lon authored May 7, 2021
    Copy the full SHA
    7c7e864 View commit details
  7. webpack 5 externals fixes (#24603)

    * fix check in externals that validate if the require is resolve-able for the server
    * performance improvements
    
    Fixes #23130
    
    ## Bug
    
    - [x] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [x] Related issues linked using `fixes #number`
    - [x] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    sokra authored May 7, 2021
    Copy the full SHA
    33e09df View commit details
  8. Copy the full SHA
    9506f15 View commit details
  9. Copy the full SHA
    42c4743 View commit details
  10. cache typechecking with incremental compilation (#24559)

    Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
    sokra and kodiakhq[bot] authored May 7, 2021
    Copy the full SHA
    4e8fac9 View commit details
  11. Ensure next/dynamic transpiles for tests (#24751)

    Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
    ijjk and sokra authored May 7, 2021
    Copy the full SHA
    9d25194 View commit details
  12. fix: handle compression for custom-server render calls (#16378) (#18891)

    Co-authored-by: Radosław Grochowski <radoslaw.grochowski@grupawp.pl>
    Co-authored-by: Tim Neutkens <timneutkens@me.com>
    3 people authored May 7, 2021
    Copy the full SHA
    7f1c8a9 View commit details
  13. v10.2.1-canary.3

    timneutkens committed May 7, 2021
    1
    Copy the full SHA
    8218d5d View commit details
  14. Copy the full SHA
    0425763 View commit details

Commits on May 10, 2021

  1. Copy the full SHA
    59d50ff View commit details
  2. Copy the full SHA
    8682705 View commit details
  3. Fix: Non-writable pages/_app breaks build (#24849)

    Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
    darshkpatel and kodiakhq[bot] authored May 10, 2021
    Copy the full SHA
    9e87596 View commit details
  4. Remove outdated/deprecated/unmainted examples (#24945)

    ## Bug
    
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    
    ## Feature
    
    - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    - [ ] Related issues linked using `fixes #number`
    - [ ] Integration tests added
    - [ ] Documentation added
    - [ ] Telemetry added. In case of a feature if it's used or not.
    
    ## Documentation / Examples
    
    - [ ] Make sure the linting passes
    timneutkens authored May 10, 2021
    Copy the full SHA
    802a772 View commit details
Loading