-
Notifications
You must be signed in to change notification settings - Fork 27.9k
Comparing changes
Open a pull request
base repository: vercel/next.js
base: 6b97bcea5ba851740404e8192fc9ebff711e1b83
head repository: vercel/next.js
compare: 804971fd9a49dfd009f7339dd8bf4bc32e6eb02c
Commits on Apr 28, 2021
-
Fix: with-passport example dependency issue (#24567)
fixes #24401 Simply bumping `swr` to the latest version seems to fix the issue. 🥂 Couldn't find a consistent pattern across the examples, but most examples are flexible with swr version and use the semver caret. Very standard use of the useSWR hook is there in the example with nothing obviously version specific.
Configuration menu - View commit details
-
Copy full SHA for 2d6b560 - Browse repository at this point
Copy the full SHA 2d6b560View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9721374 - Browse repository at this point
Copy the full SHA 9721374View commit details -
Remove unnecessary optimizeFonts key from type (#24563)
#21676 moved `fontOptimization` out of the experimental key of `NextConfig` to the top level, so it should be removed from the type ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for a35dedb - Browse repository at this point
Copy the full SHA a35dedbView commit details
Commits on Apr 29, 2021
-
Fix Image compatibility issue when using
sizes
(#24569)When using `sizes`, [`matchAll`](https://caniuse.com/mdn-javascript_builtins_string_matchall) isn't supported by older browsers like IE and Safari 12. This PR changes it to `exec`. There're already tests of `sizes` with multiple `vw` values covered. Fixes #23677. ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 89d2c4e - Browse repository at this point
Copy the full SHA 89d2c4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e441fe - Browse repository at this point
Copy the full SHA 1e441feView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for f9faf3f - Browse repository at this point
Copy the full SHA f9faf3fView commit details
Commits on Apr 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 01c15c5 - Browse repository at this point
Copy the full SHA 01c15c5View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 49cd08d - Browse repository at this point
Copy the full SHA 49cd08dView commit details -
Adds ESLint with default rule-set (#23702)
This PR re-includes ESLint with some notable changes, namely a guided setup similar to how TypeScript is instantiated in a Next.js application. To add ESLint to a project, developers will have to create an `.eslintrc` file in the root of their project or add an empty `eslintConfig` object to their `package.json` file. ```js touch .eslintrc ``` Then running `next build` will show instructions to install the required packages needed: <img width="862" alt="Screen Shot 2021-04-19 at 7 38 27 PM" src="https://user-images.githubusercontent.com/12476932/115316182-dfd51b00-a146-11eb-830c-90bad20ed151.png"> Once installed and `next build` is run again, `.eslintrc` will be automatically configured to include the default config: ```json { "extends": "next" } ``` In addition to this change: - The feature is now under the experimental flag and requires opt-in. After testing and feedback, it will be switched to the top-level namespace and turned on by default. - A new ESLint shareable configuration package is included that can be extended in any application with `{ extends: 'next' }` - This default config extends recommended rule sets from [`eslint-plugin-react`](https://www.npmjs.com/package/eslint-plugin-react), [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks), and [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) - All rules in [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) have been modified to include actionable links that show more information to help resolve each issue
Configuration menu - View commit details
-
Copy full SHA for e783b0a - Browse repository at this point
Copy the full SHA e783b0aView commit details -
Don't swallow MODULE_NOT_FOUND error (#24577)
## Bug - [x] Related issues linked using [`fixes #24328`](#24328 (comment)) - [ ] Integration tests added The change in #24328 will swallow any `MODULE_NOT_FOUND` errors triggered in the page. If you for example have a page with a broken import, it will tell you `Error: Failed to load /whatever`. This of course doesn't really tell people what is going on internally (a broken import). I added a check to see if the error actually happened in the page.
Configuration menu - View commit details
-
Copy full SHA for d5de1c5 - Browse repository at this point
Copy the full SHA d5de1c5View commit details -
Fix/link router 24075 take asPath instead of pathName in router (#24199)
Fixes: #24075 ## Bug - [X] Related issues linked using `fixes #number` - [X] Integration tests added ## Documentation / Examples - [x] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 9bbb968 - Browse repository at this point
Copy the full SHA 9bbb968View commit details -
Add experimental blurry placeholder to image component (#24153)
This is the image component implementation of the blurry placeholder as described in #24004. The matching server side implementation is currently planned. ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issue #18858 - [x] Integration tests added (Documentation and telemetry to follow after server side is implemented)
Configuration menu - View commit details
-
Copy full SHA for c76170e - Browse repository at this point
Copy the full SHA c76170eView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 9c47ca2 - Browse repository at this point
Copy the full SHA 9c47ca2View commit details
Commits on May 1, 2021
-
Clarify whether router.pathname includes basePath (#24675)
The docs were vague on this -- `router.asPath` mentions that it doesn't include `basePath` but `router.pathname` didn't say either way. ## Documentation / Examples - [ ] Make sure the linting passes: I haven't checked; I presume you have a CI bot for this.
Configuration menu - View commit details
-
Copy full SHA for a77f384 - Browse repository at this point
Copy the full SHA a77f384View commit details
Commits on May 3, 2021
-
update webpack to 5.36.2, use dependOn (#24656)
* update webpack to 5.36.2 * use dependOn to optimize chunks * disable vendor splitting for main and _app chunks => decreases bundle size in general, gets rid of the 2 extra vendor chunks shared by all pages. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 1d643eb - Browse repository at this point
Copy the full SHA 1d643ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e6ce90 - Browse repository at this point
Copy the full SHA 3e6ce90View commit details
Commits on May 4, 2021
-
Add type checking events (#24595)
Will send events like this: ``` [telemetry] { "eventName": "NEXT_TYPE_CHECK_COMPLETED", "payload": { "durationInSeconds": 2, "typescriptVersion": "3.8.3", "inputFilesCount": 16, "totalFilesCount": 289, "incremental": false } } ``` ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 3a78ccd - Browse repository at this point
Copy the full SHA 3a78ccdView commit details
Commits on May 5, 2021
-
fix(next-storybook): make rules an array in webpack config (#22125)
the `next-storybook` plugin throws an error since version `10.0.6-canary.9`, specifically since #17306: ``` ERR! WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema. ERR! - configuration.module.rules should be an array ``` this PR makes `module.rules` an array again. also see #17306 (comment)
Configuration menu - View commit details
-
Copy full SHA for 3a2cd0e - Browse repository at this point
Copy the full SHA 3a2cd0eView commit details -
fix memory leak in require.cache (#24282)
Previously only the top-level page would be cleared from the require cache, with this change it also clears `module.parent` and `modules.children`.
Configuration menu - View commit details
-
Copy full SHA for 83395c9 - Browse repository at this point
Copy the full SHA 83395c9View commit details -
demo serving storybook static build with serve (#24812)
Unfortunately I couldn't push up changes for that branch as maintainers access was disabled. Closes #18775 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 3a2b88b - Browse repository at this point
Copy the full SHA 3a2b88bView commit details -
Update signin/signup form samples (#24524)
Fix warning: Prop `href` did not match. Server: "signin" Client: "/signin" Fix warning: Prop `href` did not match. Server: "signup" Client: "/signup" ## Documentation / Examples - [] Make sure the linting passes
Lau Wei Lim authoredMay 5, 2021 Configuration menu - View commit details
-
Copy full SHA for fc9b48b - Browse repository at this point
Copy the full SHA fc9b48bView commit details -
Bumps version of supertokens dependencies and updates its README (#24571
Configuration menu - View commit details
-
Copy full SHA for 243472f - Browse repository at this point
Copy the full SHA 243472fView commit details -
react-hook-form example (#21245)
Co-authored-by: Tim Neutkens <timneutkens@me.com>
Configuration menu - View commit details
-
Copy full SHA for 9721aaf - Browse repository at this point
Copy the full SHA 9721aafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 192d42b - Browse repository at this point
Copy the full SHA 192d42bView commit details -
Don't throw 500 error when Content-type is invalid (#24818)
Fixes #24768 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added
Configuration menu - View commit details
-
Copy full SHA for 54ff322 - Browse repository at this point
Copy the full SHA 54ff322View commit details -
docs(next/router): Update router.push api (#24833)
Documentation page: https://nextjs.org/docs/api-reference/next/router#routerpush Add `locale` as supported options in `route.push()` (#17898)
Configuration menu - View commit details
-
Copy full SHA for 2251658 - Browse repository at this point
Copy the full SHA 2251658View commit details -
docs(config intro): Fix github link hash (#24838)
Doc page: https://nextjs.org/docs/api-reference/next.config.js/introduction [`config-sahred.ts`](https://github.com/vercel/next.js/blob/canary/packages/next/next-server/server/config-shared.ts) file has been updated and the link here now is pointing to the random line!
Configuration menu - View commit details
-
Copy full SHA for cc41a19 - Browse repository at this point
Copy the full SHA cc41a19View commit details
Commits on May 6, 2021
-
Land - Font optimizations - Adobe Fonts / Typekit support (#24834)
This updates this initial PR here #18146 to resolve merge conflicts and updates tests since we aren't able to update that PR itself. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. Closes: #18146
Configuration menu - View commit details
-
Copy full SHA for 802af5f - Browse repository at this point
Copy the full SHA 802af5fView commit details -
Add version note for
has
property (#24836)The guides for `next.config.js` never specify that the `has: { }` syntax is only available for v10.1, and not for v10.0. Add a note that indicates these features are only available in the latest version. ## Documentation / Examples - [x] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 73e1fb4 - Browse repository at this point
Copy the full SHA 73e1fb4View commit details -
Remove old docs sections (#24853)
Co-authored-by: Lee Robinson <me@leerob.io>
Configuration menu - View commit details
-
Copy full SHA for 81cc1c5 - Browse repository at this point
Copy the full SHA 81cc1c5View commit details -
Add additional reason for the Prerender Error when running next export (
#24828) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 467ec21 - Browse repository at this point
Copy the full SHA 467ec21View commit details -
Fix rewrite shape in Storybook (#24827)
This fixes a bug in `@next/plugin-storybook` caused by an update in the rewrite structure, solution was provided by @stefanprobst #19345 (comment) Secondary question: it would be awesome if someone at Next could help translating `preset.js` into TypeScript, this would catch those bugs immediately. I've tried in #18367 but failed to build correctly. ## Bug - [X] Related issues linked using `fixes #number` => parent issue is an umbrella of various small issues: #19345 - [X] Integration tests added => reproduction is implemented in https://github.com/lbke/next-plugin-storybook-demo until the package is more stable
Configuration menu - View commit details
-
Copy full SHA for 796c021 - Browse repository at this point
Copy the full SHA 796c021View commit details
Commits on May 7, 2021
-
feat(create-next-app): add
--ts, --typescript
support (#24655)Co-authored-by: Tim Neutkens <timneutkens@me.com>
Configuration menu - View commit details
-
Copy full SHA for 9c77cda - Browse repository at this point
Copy the full SHA 9c77cdaView commit details -
ESLint Plugin: Disallow <title> in Head from next/document (#24868)
Adds lint rule warning to the Next.js ESLint plugin to disallow `<title>` in `Head` imported from `next/document`.
Configuration menu - View commit details
-
Copy full SHA for 656c2ef - Browse repository at this point
Copy the full SHA 656c2efView commit details -
updated zustand example (#24884)
..to use new zustand/context module from zustand 3.5.0. Also fixed code for merging states on client-side navigation. ## Documentation / Examples - [x] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 60d844c - Browse repository at this point
Copy the full SHA 60d844cView commit details -
Update example with-sentry (#24819)
The [official Sentry Next.js SDK](https://docs.sentry.io/platforms/javascript/guides/nextjs/) is now the recommended choice to use with Next.js, instead of the previous workarounds. This PR updates the example, which now uses the SDK.
Configuration menu - View commit details
-
Copy full SHA for 4bc87e4 - Browse repository at this point
Copy the full SHA 4bc87e4View commit details -
Clarify rewrites and other docs cleanup. (#24890)
Based on user feedback, this clarifies the difference between rewrites and redirects, as well as follows the new pattern for showing version history with a collapsible table.
Configuration menu - View commit details
-
Copy full SHA for f6c6094 - Browse repository at this point
Copy the full SHA f6c6094View commit details -
feat(build): Log whether type checking is actually performed (#24440)
Closes #24889 ## Feature Currently `next build` is logging "Checking validity of types" even if `typescript.ignoreBuildErrors` is `true`. It seems like these options still work so `next build` either shouldn't log anything related to type-checking or log that type-checking is skipped. I decided to branch the log message for clarity. Happy to add a test but I'm not sure if you have existing infra considering https://github.com/vercel/next.js/pull/23226/files (which added the message) didn't add or change tests either. CI failures look unrelated to me.
Configuration menu - View commit details
-
Copy full SHA for 7c7e864 - Browse repository at this point
Copy the full SHA 7c7e864View commit details -
webpack 5 externals fixes (#24603)
* fix check in externals that validate if the require is resolve-able for the server * performance improvements Fixes #23130 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 33e09df - Browse repository at this point
Copy the full SHA 33e09dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9506f15 - Browse repository at this point
Copy the full SHA 9506f15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42c4743 - Browse repository at this point
Copy the full SHA 42c4743View commit details -
cache typechecking with incremental compilation (#24559)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4e8fac9 - Browse repository at this point
Copy the full SHA 4e8fac9View commit details -
Ensure next/dynamic transpiles for tests (#24751)
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d25194 - Browse repository at this point
Copy the full SHA 9d25194View commit details -
fix: handle compression for custom-server render calls (#16378) (#18891)
Co-authored-by: Radosław Grochowski <radoslaw.grochowski@grupawp.pl> Co-authored-by: Tim Neutkens <timneutkens@me.com>
Configuration menu - View commit details
-
Copy full SHA for 7f1c8a9 - Browse repository at this point
Copy the full SHA 7f1c8a9View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 8218d5d - Browse repository at this point
Copy the full SHA 8218d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0425763 - Browse repository at this point
Copy the full SHA 0425763View commit details
Commits on May 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 59d50ff - Browse repository at this point
Copy the full SHA 59d50ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8682705 - Browse repository at this point
Copy the full SHA 8682705View commit details -
Fix: Non-writable pages/_app breaks build (#24849)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9e87596 - Browse repository at this point
Copy the full SHA 9e87596View commit details -
Remove outdated/deprecated/unmainted examples (#24945)
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Configuration menu - View commit details
-
Copy full SHA for 802a772 - Browse repository at this point
Copy the full SHA 802a772View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 6b97bcea5ba851740404e8192fc9ebff711e1b83...804971fd9a49dfd009f7339dd8bf4bc32e6eb02c