Fix passing context around #850
Conversation
|
Hi there, sorry if this is not a good place to comment this but was curious if you had a ballpark estimate on when 1.16 will be released. Mostly just need to know if I can wait it out or pivot to a different approach on the issue I'm running into currently. Thanks for your hard work! |
|
Gotcha - it was the nested embeds problem: #708 |
|
@RobLoach if you could take a look at this and then just go ahead and merge and publish v1.16.0 that would be great. It would be great to go ahead and get it released since it has a lot of long standing bugs fixed in it. |
|
@willrowe Thanks for the ping! This is looking really good. Will do some rigorous testing, along with getting the release out later on today 🚀 |
Major improvements: * Fix passing context around by @willrowe in #850 * Add namespace support to `source` function by @willrowe in #823 * Use src/twig.js as package's main script instead of the compiled twig.js by @RobLoach in #829 Minor improvements: * Fix macro changing context in loop by @mihkeleidast in #773 * Imported function PATHS.strip_slash() missing by @murageyun in #770 * Convert non-string values to string before replacing by @kmonahan in #797 * Add GitHub actions test workflow by @willrowe in #817 * Fix date parsing with timezones by @plepe in #765 * Fixed Twig official's URL on README.md by @Geolim4 in #822 * Add tests for whitespace in paths by @willrowe in #824 * Fix multiple includes with embeds by @willrowe in #828 * Update to Mocha 9.x by @RobLoach in #831 * Add test for issue #767 by @willrowe in #837 * Add support for `divisible by` test by @willrowe in #838 * Add support for `with` tag without context or `only` keyword by @willrowe in #839 * Use v3 of `actions/checkout` by @willrowe in #846 * Test on more node versions by @willrowe in #847 * Fix webpack 5 compatibility by @willrowe in #849 * Add test to confirm `renderFile` error handling by @willrowe in #851 * Fix casing of variables in docs by @willrowe in #852 * Bumped dependencies by @dependabot
|
Awesome thanks to you both! |
|
It was all @willrowe!!!! MVP of this release for sure 🚀 |
This fixes #840 by allowing the context to be passed when initially creating an instance of
ParseState. The old way of passing the context when callingparseis still supported to prevent BC breaks, but it no longer used internally.