Fix multiple includes with embeds #828
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Including the `id` triggers `Twig.Templates.save` and adds the instance to `Twig.Templates.registry`. - By omitting the `id` completely, there is no chance that the temporary instance is accidentally reused through a combination of embeds/includes that would load it from the registry.
|
Thanks so much, Will 🚀 |
Merged
RobLoach
added a commit
that referenced
this pull request
Feb 28, 2023
Major improvements: * Fix passing context around by @willrowe in #850 * Add namespace support to `source` function by @willrowe in #823 * Use src/twig.js as package's main script instead of the compiled twig.js by @RobLoach in #829 Minor improvements: * Fix macro changing context in loop by @mihkeleidast in #773 * Imported function PATHS.strip_slash() missing by @murageyun in #770 * Convert non-string values to string before replacing by @kmonahan in #797 * Add GitHub actions test workflow by @willrowe in #817 * Fix date parsing with timezones by @plepe in #765 * Fixed Twig official's URL on README.md by @Geolim4 in #822 * Add tests for whitespace in paths by @willrowe in #824 * Fix multiple includes with embeds by @willrowe in #828 * Update to Mocha 9.x by @RobLoach in #831 * Add test for issue #767 by @willrowe in #837 * Add support for `divisible by` test by @willrowe in #838 * Add support for `with` tag without context or `only` keyword by @willrowe in #839 * Use v3 of `actions/checkout` by @willrowe in #846 * Test on more node versions by @willrowe in #847 * Fix webpack 5 compatibility by @willrowe in #849 * Add test to confirm `renderFile` error handling by @willrowe in #851 * Fix casing of variables in docs by @willrowe in #852 * Bumped dependencies by @dependabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #784. After creating a failing test and debugging the issue, it turns out that the
idshould have never been set on the temporary template instance, since that stored it in the registry and allowed subsequent calls to the loader to return the temporary instance instead of the correct instance set before the embed.Fixes #708