Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: Fix the focus ring on focused checked buttons #39595

Merged
merged 1 commit into from Feb 6, 2024
Merged

CSS: Fix the focus ring on focused checked buttons #39595

merged 1 commit into from Feb 6, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 22, 2024 •
edited by XhmikosR

Description

Changed where the :focus-visible is applied when using .btn-check.

Motivation & Context

The :focus-visible styles weren't applied at all on focused .btn-check with $enable-shadows set to true.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #39569.

@louismaximepiton louismaximepiton requested a review from a team as a code owner January 22, 2024 10:04
mdo
mdo approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@XhmikosR XhmikosR merged commit 5010e8d into main Feb 6, 2024
14 checks passed
@XhmikosR XhmikosR deleted the main-lmp-handle-checked-focus branch February 6, 2024 19:59
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.3
Status: Done
Milestone
No milestone
3 participants
@louismaximepiton @mdo @XhmikosR