refactor css: modal and offcanvas header spacing #39373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkoOleksiyenko
force-pushed
the
header-css
branch
3 times, most recently
from
17075a6
to
9a909bf
Compare
MarkoOleksiyenko
force-pushed
the
header-css
branch
from
9a909bf
to
19b9f6b
Compare
julien-deramond
approved these changes
Nov 15, 2023
|
Thanks for the review @mdo and @julien-deramond ! |
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
|
If you use the dark variant of the "close" button as show here; |
3 tasks
|
@Batman08 you should create a new issue |
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR regarding the discussion https://github.com/orgs/twbs/discussions/39370 about the spacing in the modal (plus offcanvas) header. The space-between is not used anymore as the position of the btn-close is based on the margin now.
Motivation & Context
If the btn-close is removed the content is distributed evenly (space-between behavior), so the wide modals have scattered title if the header is composite (e.g. icon plus text). It is logical to put it to the default setting, which is justify-content: start.
Type of changes
(not sure whether it is breaking change, but might be, please correct me if I am wrong)
Checklist
npm run lint)Live previews
Related GH discussion
https://github.com/orgs/twbs/discussions/39370