Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOrCreateInstance() doc example #39281

Merged
merged 2 commits into from Oct 12, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 8, 2023

Description

Spotted in https://github.com/orgs/twbs/discussions/39280, this PR fixes the doc example showing how to use getOrCreateInstance() with popovers.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A- I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review October 8, 2023 15:20
Copy link

@Git-Harshit Git-Harshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing it in the right place. 😄

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@julien-deramond julien-deramond merged commit 790dc80 into main Oct 12, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-getOrCreateInstance-example-doc branch October 12, 2023 07:31
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants