Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add border-radius sizes to small and large .form-selects #34853

Merged
merged 5 commits into from
Sep 7, 2021
Merged

Add border-radius sizes to small and large .form-selects #34853

merged 5 commits into from
Sep 7, 2021
+5 −1

Conversation

crdo
Copy link
Contributor

@crdo crdo commented Aug 31, 2021 •
edited by ffoodd
Loading

Adds border-radius modifiers for small and large Select to _form-select.scss
Adds corresponding variables to _variables.scss

Fixes #34852

@crdo
Fixes twbs#34852

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tagliala Geremia Taglialatela
GPG key ID: 4A6344430AD4E29F
Expired
Verified
Learn about vigilant mode
9b0950f
@crdo crdo requested a review from a team as a code owner August 31, 2021 12:32
ffoodd
ffoodd reviewed Sep 1, 2021
View reviewed changes
ffoodd
ffoodd requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the 0 fallback, but apart from that it's really good, thanks!

@crdo
Remove fallback

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a072bcb
ffoodd
ffoodd approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@XhmikosR XhmikosR changed the title Fixes #34852 Select does not have border radius modificators for large and small variant Fix select not having border radius modificators for large and small variants Sep 7, 2021
@mdo mdo changed the title Fix select not having border radius modificators for large and small variants Add border-radius sizes to small and large .form-selects Sep 7, 2021
@mdo mdo merged commit dbe0ad4 into twbs:main Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo

@ffoodd ffoodd

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select does not have border radius modificators for large and small variant
4 participants
@crdo @mdo @ffoodd @XhmikosR