Skip to content

Darken dropdown item hover style #32754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

patrickhlauke
Copy link
Member

Closes #23329

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Closes #23329
@patrickhlauke patrickhlauke requested a review from mdo January 10, 2021 17:31
@patrickhlauke patrickhlauke requested a review from a team as a code owner January 10, 2021 17:31
@patrickhlauke
Copy link
Member Author

Not sure if we want to backport this, or if that counts as a breaking visual style...

@patrickhlauke patrickhlauke merged commit 78c5b50 into main Jan 11, 2021
@patrickhlauke patrickhlauke deleted the patrickhlauke-dropdown-hover-darker branch January 11, 2021 01:24
@patrickhlauke
Copy link
Member Author

@mdo thoughts on backporting?

@mdo
Copy link
Member

mdo commented Jan 11, 2021

I'm good with a backport @patrickhlauke. This isn't a breaking change IMO.

patrickhlauke added a commit that referenced this pull request Jan 11, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Backport of #32754
@XhmikosR XhmikosR added the v4 label Jan 11, 2021
XhmikosR pushed a commit that referenced this pull request Jan 11, 2021
XhmikosR pushed a commit that referenced this pull request Jan 13, 2021
XhmikosR pushed a commit that referenced this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V4.beta Dropdown menu focus/hover style constrast too low for accessibility
3 participants