Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: style clipboard button on :focus, not just :hover #32461

Merged
merged 4 commits into from Dec 15, 2020
Merged

Docs: style clipboard button on :focus, not just :hover #32461

merged 4 commits into from Dec 15, 2020

Conversation

patrickhlauke
Copy link
Member

No description provided.

@patrickhlauke patrickhlauke requested a review from a team as a code owner December 14, 2020 00:52
@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-beta2 via automation Dec 14, 2020
@patrickhlauke patrickhlauke added this to Inbox in v4.6.0 via automation Dec 14, 2020
@patrickhlauke
Copy link
Member Author

current look (when focused in Chrome)

current

after this change

after

@XhmikosR XhmikosR requested a review from mdo December 14, 2020 08:39
v5.0.0-beta2 automation moved this from Inbox to Approved Dec 14, 2020
@XhmikosR
Copy link
Member

Please do not merge yet. I want @mdo to have a look.

v5.0.0-beta2 automation moved this from Approved to Review Dec 14, 2020
XhmikosR
XhmikosR previously requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

mdo
mdo approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man I hate Chrome’s focus styling lol. Looks good other than that!

@XhmikosR XhmikosR self-requested a review December 15, 2020 07:02
@XhmikosR XhmikosR moved this from Review to Approved in v5.0.0-beta2 Dec 15, 2020
@XhmikosR XhmikosR merged commit 65f1bf0 into main Dec 15, 2020
v5.0.0-beta2 automation moved this from Approved to Done Dec 15, 2020
@XhmikosR XhmikosR deleted the clipboard-focus branch December 15, 2020 07:43
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked/Manually backported in v4.6.0 Dec 15, 2020
XhmikosR added a commit that referenced this pull request Dec 15, 2020
@patrickhlauke @XhmikosR
Docs: style clipboard button on :focus, not just :hover (#32461)
2b6b42f 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Dec 16, 2020
@patrickhlauke @XhmikosR
Docs: style clipboard button on :focus, not just :hover (#32461)
57a3980 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jan 7, 2021
@patrickhlauke @XhmikosR
Docs: style clipboard button on :focus, not just :hover (#32461)
d2d687b 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jan 8, 2021
@patrickhlauke @XhmikosR
Docs: style clipboard button on :focus, not just :hover (#32461)
56260c3 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Jan 8, 2021
XhmikosR added a commit that referenced this pull request Jan 8, 2021
@patrickhlauke @XhmikosR
Docs: style clipboard button on :focus, not just :hover (#32461)
9fbf50c 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@ffoodd ffoodd ffoodd approved these changes

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
backport-to-v4 docs v5
Projects
No open projects
v4.6.0
Shipped
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrickhlauke @XhmikosR @mdo @ffoodd