Skip to content

Docs: style clipboard button on :focus, not just :hover #32461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Conversation

patrickhlauke
Copy link
Member

No description provided.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@patrickhlauke
Copy link
Member Author

current look (when focused in Chrome)

current

after this change

after

@XhmikosR XhmikosR requested a review from mdo December 14, 2020 08:39

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@XhmikosR
Copy link
Member

Please do not merge yet. I want @mdo to have a look.

Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man I hate Chrome’s focus styling lol. Looks good other than that!

@XhmikosR XhmikosR self-requested a review December 15, 2020 07:02
@XhmikosR XhmikosR dismissed their stale review December 15, 2020 07:43

outdated

@XhmikosR XhmikosR merged commit 65f1bf0 into main Dec 15, 2020
@XhmikosR XhmikosR deleted the clipboard-focus branch December 15, 2020 07:43
XhmikosR added a commit that referenced this pull request Dec 15, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Dec 16, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jan 7, 2021
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jan 8, 2021
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jan 8, 2021
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants