Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hide modal when keyboard is false in modal's config #32220

Merged
merged 1 commit into from Nov 21, 2020
Merged

Don't hide modal when keyboard is false in modal's config #32220

merged 1 commit into from Nov 21, 2020

Conversation

rohit2sharma95
Copy link
Collaborator

Backport #32179

@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner November 20, 2020 15:16
@XhmikosR XhmikosR added this to Inbox in v4.6.0 via automation Nov 20, 2020
@rohit2sharma95 rohit2sharma95 mentioned this pull request Nov 20, 2020
Merged
@XhmikosR XhmikosR merged commit bfb773d into twbs:v4-dev Nov 21, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.6.0 Nov 21, 2020
@rohit2sharma95 rohit2sharma95 deleted the modal-keyboard-v4 branch November 24, 2020 08:22
This was referenced Mar 8, 2021
Closed
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@Johann-S Johann-S Awaiting requested review from Johann-S

Assignees
No one assigned
Labels
js v4
Projects
No open projects
v4.6.0
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit2sharma95 @XhmikosR