v4: switch to Hugo #32077
Merged
v4: switch to Hugo #32077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
15 times, most recently
from
dea84de
to
a436a82
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
3 times, most recently
from
95cc9ee
to
d17f48e
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
2 times, most recently
from
68caca6
to
ea53689
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
from
364ddc8
to
ada4c60
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
2 times, most recently
from
6d0754b
to
bc8613e
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
from
bc8613e
to
58f7214
Compare
|
Updated the gh-pages comparison branch: a0b8dd8?w=1 |
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
2 times, most recently
from
be41f18
to
5762e6d
Compare
|
Concerning border-radius examples, we may simply add No opinion about the team members, I don't know how / when it's updated so I let you (oldest team members) take care of it. Just took a few random pages and I really like it, the generated markup is really better! That's a nice improvement 👍 |
ffoodd
approved these changes
Nov 18, 2020
Comment on lines
-3
to
-12
| /site/.jekyll-cache | ||
| /site/.jekyll-metadata | ||
| /site/docs/**/dist/ | ||
| # Hugo folders | ||
| /resources/ | ||
|
|
||
| # Ignore ruby/bundler files | ||
| /.bundle/ | ||
| /vendor/ | ||
| /.ruby-version |
|
Thanks @ffoodd for the review, it's been really helpful catching some of the issues :) So, basically this leaves us:
|
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
3 times, most recently
from
d19a6d5
to
ff91a9e
Compare
MartijnCuppens
approved these changes
Nov 18, 2020
This was referenced Nov 19, 2020
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
from
ff91a9e
to
7edb919
Compare
This commit includes all the needed workarounds and most changes from the main branch for everything to work, like: * removing empty lines in raw HTML that break output * read .browserslistrc, CSS variables from disk instead of duplicating it * using Hugo mounts * using Hugo for the docs CSS/JS * move ToC Sass code to a separate file while adapting it for Hugo Thus, this patch makes our npm scripts faster since lint runs on one step and there's no separate docs assets processing.
Now, it's safe to do use it since it covers more cases
XhmikosR
force-pushed
the
v4-dev-xmr-hugo
branch
from
7edb919
to
fa6c32e
Compare
This was referenced Nov 25, 2020
This was referenced Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, apart from Hugo being multiple times faster as we already know, I also switched to using Hugo to handle the docs assets (CSS/JS) like we do on main. Which means, it will be equally simple to work on the v4-dev branch as main. 😃
TODO:
fix getting started snippets (also search for
site.)replace the remaining Liquid code
fix jQuery being bundled in the docs JS; not sure how to handle this without hardcoding the files we want to include, since we are using
Resources.match- EDIT: worked around it, not sure if there's a better solutionmake sure we use
docsrefwhen possible like in mainFix migration sidebar link
Read browserslist, fonts, CSS variables etc
Deduplicate npm scripts
Fix duplicate trailing slashes in URLs; also run a full site link checker
Fix ToC CSS - EDIT: added a patch but it seems there are more cases that we need to fix, with nested lists:
Screenshot
EDIT2: it was due to going from an
h2toh4; switched toh3and now it's finego through the layout code one more time; fix discrepancies like social logo, classes etc
Figure out why some classes are missing: EDIT: this is right and previously was wrong
card-imgis missing here https://deploy-preview-32077--twbs-bootstrap.netlify.app/docs/4.5/components/card/#horizontal this seems to affect main toocard-img-topbecomescard-imghere https://deploy-preview-32077--twbs-bootstrap.netlify.app/docs/4.5/components/card/#card-columnsclass="mr-3"is missing here: https://deploy-preview-32077--twbs-bootstrap.netlify.app/docs/4.5/components/media-object/#nestingsee if this bothers us a lot; I can't remove the newline there (although, we apply margin via CSS, so we could probably remove that if it bothers us a lot) https://deploy-preview-32077--twbs-bootstrap.netlify.app/docs/4.5/utilities/borders/#border-radius (it's the same on main too so we probably want to keep it)
Screenshot
see if we are going to go with the homepage patch or if I should drop it- EDIT: moved to homepage: split snippets and show copy buttons #32196Update team members
test all the stuff multiple times
Preview: https://deploy-preview-32077--twbs-bootstrap.netlify.app/