Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list-group.md #31981

Merged
merged 2 commits into from Oct 27, 2020
Merged

Update list-group.md #31981

merged 2 commits into from Oct 27, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 27, 2020

@patrickhlauke this one I meant on Slack; not sure if the div is supposed to be in the snippet or if we should remove it?

This is a regression after #31806

@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha3 via automation Oct 27, 2020
@patrickhlauke
Copy link
Member

yeah the outer div is part of the code, so should be inside the fenced code block

v5.0.0-alpha3 automation moved this from Inbox to Approved Oct 27, 2020
@XhmikosR
Copy link
Member Author

It seems this affects v4 too, I'll manually apply the fix in my v4-dev-xmr branch.

@XhmikosR XhmikosR marked this pull request as ready for review October 27, 2020 09:23
@XhmikosR XhmikosR merged commit 0a61269 into main Oct 27, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Oct 27, 2020
@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch October 27, 2020 09:24
XhmikosR added a commit that referenced this pull request Oct 27, 2020
XhmikosR added a commit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants