Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant visually hidden "(current)" from pagination controls #31892

Merged
merged 2 commits into from Oct 14, 2020
Merged

Remove redundant visually hidden "(current)" from pagination controls #31892

merged 2 commits into from Oct 14, 2020

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Oct 14, 2020 •
edited

additionally, fixes up the markup in two of the visual tests

Closes #31891

@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-alpha3 via automation Oct 14, 2020
v5.0.0-alpha3 automation moved this from Inbox to Approved Oct 14, 2020
@patrickhlauke patrickhlauke merged commit 836a4c0 into main Oct 14, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Oct 14, 2020
@patrickhlauke patrickhlauke deleted the patrickhlauke-31891 branch October 14, 2020 10:59
@XhmikosR XhmikosR added the v4 label Oct 14, 2020
@XhmikosR XhmikosR added this to Inbox in v4.6.0 via automation Oct 14, 2020
@ihorzenich ihorzenich mentioned this pull request Oct 15, 2020
Closed
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.0 Oct 19, 2020
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked/Manually backported in v4.6.0 Oct 26, 2020
XhmikosR pushed a commit that referenced this pull request Oct 26, 2020
@patrickhlauke @XhmikosR
Remove redundant visually hidden "(current)" from pagination controls (…
e5fdb10 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
XhmikosR pushed a commit that referenced this pull request Oct 27, 2020
@patrickhlauke @XhmikosR
Remove redundant visually hidden "(current)" from pagination controls (…
6f8a338 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
XhmikosR pushed a commit that referenced this pull request Oct 27, 2020
@patrickhlauke @XhmikosR
Remove redundant visually hidden "(current)" from pagination controls (…
5f1bc4a 
…#31892)

* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.6.0 Oct 27, 2020
This was referenced Mar 8, 2021
Closed
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
accessibility backport-to-v4 docs v4 v5
Projects
No open projects
v4.6.0
Shipped
v5.0.0-alpha3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Remove redundant visually hidden "(current)" from pagination controls
3 participants
@patrickhlauke @MartijnCuppens @XhmikosR